Re: svn commit: r305177 - head/sys/net

2017-05-18 Thread Sepherosa Ziehau
Oh, my fault. I will revert it. On Thu, May 18, 2017 at 11:11 PM, Hans Petter Selasky wrote: > On 05/18/17 17:00, Oleg Bulyzhin wrote: >> >> On Thu, May 18, 2017 at 04:25:01PM +0200, Hans Petter Selasky wrote: >>> >>> On 05/18/17 16:04, Oleg Bulyzhin wrote: On Thu,

Re: svn commit: r305177 - head/sys/net

2017-05-18 Thread Hans Petter Selasky
On 05/18/17 17:00, Oleg Bulyzhin wrote: On Thu, May 18, 2017 at 04:25:01PM +0200, Hans Petter Selasky wrote: On 05/18/17 16:04, Oleg Bulyzhin wrote: On Thu, Sep 01, 2016 at 06:32:35AM +, Sepherosa Ziehau wrote: Author: sephe Date: Thu Sep 1 06:32:35 2016 New Revision: 305177 URL:

Re: svn commit: r305177 - head/sys/net

2017-05-18 Thread Benjamin Kaduk
On Thu, May 18, 2017 at 10:00 AM, Oleg Bulyzhin wrote: > On Thu, May 18, 2017 at 04:25:01PM +0200, Hans Petter Selasky wrote: > > > > Can you explain a bit more what is wrong? > > > > > If you care about readability it should be: > > > pri) & 7) << 13) | (((cfi) & 1) << 12)

Re: svn commit: r305177 - head/sys/net

2017-05-18 Thread Oleg Bulyzhin
On Thu, May 18, 2017 at 04:25:01PM +0200, Hans Petter Selasky wrote: > On 05/18/17 16:04, Oleg Bulyzhin wrote: > > On Thu, Sep 01, 2016 at 06:32:35AM +, Sepherosa Ziehau wrote: > >> Author: sephe > >> Date: Thu Sep 1 06:32:35 2016 > >> New Revision: 305177 > >> URL:

Re: svn commit: r305177 - head/sys/net

2017-05-18 Thread Hans Petter Selasky
On 05/18/17 16:04, Oleg Bulyzhin wrote: On Thu, Sep 01, 2016 at 06:32:35AM +, Sepherosa Ziehau wrote: Author: sephe Date: Thu Sep 1 06:32:35 2016 New Revision: 305177 URL: https://svnweb.freebsd.org/changeset/base/305177 Log: net/vlan: Shift for pri is 13 (pri mask 0xe000) not 1.

Re: svn commit: r305177 - head/sys/net

2017-05-18 Thread Oleg Bulyzhin
On Thu, Sep 01, 2016 at 06:32:35AM +, Sepherosa Ziehau wrote: > Author: sephe > Date: Thu Sep 1 06:32:35 2016 > New Revision: 305177 > URL: https://svnweb.freebsd.org/changeset/base/305177 > > Log: > net/vlan: Shift for pri is 13 (pri mask 0xe000) not 1. > > Reviewed by: