Re: svn commit: r327058 - head/stand/efi/boot1

[Tomoaki AOKI]

> On Thu, Dec 21, 2017 at 6:21 AM, Michael Zhilin  wrote:
>> Author: mizhka
>> Date: Thu Dec 21 12:21:35 2017
>> New Revision: 327058
>> URL: https://svnweb.freebsd.org/changeset/base/327058
>>
>> Log:
>>   [boot/efi] scan all display modes rather than sequential try-fail way
>>
>>   This patch allows to scan all display modes in boot1 as loader does.
>>
>>   Before system tried to select optimal display mode by sequential scan of
>>   modes and if error then stop scanning. This way is not good, because
>>   if mode N is not present, mode N+1 may exist.
>>
>>   In loader we use conout->Mode->MaxMode to identify maximum number of modes.
>>   This commit is to use same way in boot1 as in loader.
>>
>>   Reported by:  Andrey Pustovetov 
>>   Reviewed by:  tsoome
>>   Differential Revision:https://reviews.freebsd.org/D13541
>>
>
> HI,
>
> Just FYI- we've had several reports of this doing the wrong thing for
> many people, most recently by Allan yesterday (IIRC). I'm going to
> avoid MFC'ing it, I think we should either back this out or figure out
> where it's going wrong sooner rather than later. =(
>
> Thanks,
>
>Kyle Evans

+1.
I've been reporting back to mizhka@ what he wants off-list.
(First report is on-list. [1])
Please wait MFC for this fixed, and, if possible, report below
to mizhka@.

  *Output of "mode" command of loader console.
  *Video of broken boot process or photo of broken screen.
  *CPU model with integrated video.
  *Which mode worked and which isn't if specified by loader command.
  *Result of `got list` by loader command.
  *Result of `uga list` by loader command.

As no one other than me posts negative comment to the commit mail here,
I've not requested him to revert this. (Requested to do so if someone
else reports problem.)

FYI: For me, boot1 and loader screen are OK, but once kernel starts,
 broken screen. So vt (efifb) driver should be fixed to be aware
 of current (actual) screen mode.

[1]
https://lists.freebsd.org/pipermail/svn-src-head/2017-December/107598.html


-- 
Tomoaki AOKI
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r327058 - head/stand/efi/boot1

[Kyle Evans]

On Thu, Dec 21, 2017 at 6:21 AM, Michael Zhilin  wrote:
> Author: mizhka
> Date: Thu Dec 21 12:21:35 2017
> New Revision: 327058
> URL: https://svnweb.freebsd.org/changeset/base/327058
>
> Log:
>   [boot/efi] scan all display modes rather than sequential try-fail way
>
>   This patch allows to scan all display modes in boot1 as loader does.
>
>   Before system tried to select optimal display mode by sequential scan of
>   modes and if error then stop scanning. This way is not good, because
>   if mode N is not present, mode N+1 may exist.
>
>   In loader we use conout->Mode->MaxMode to identify maximum number of modes.
>   This commit is to use same way in boot1 as in loader.
>
>   Reported by:  Andrey Pustovetov 
>   Reviewed by:  tsoome
>   Differential Revision:https://reviews.freebsd.org/D13541
>

HI,

Just FYI- we've had several reports of this doing the wrong thing for
many people, most recently by Allan yesterday (IIRC). I'm going to
avoid MFC'ing it, I think we should either back this out or figure out
where it's going wrong sooner rather than later. =(

Thanks,

Kyle Evans
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r327058 - head/stand/efi/boot1

[Tomoaki AOKI]

This broke screen after kernel starts.
ThinkPad T420 with nvidia NVS 4200M.

boot1 screen and loader screen (beastie menu) shows up smaller (but not
broken) than usual, and small five interlaced kernel outputs (not
actually readable at all) are shown on top of screen.

So screen resolution setting should be different and not re-initialized
in kernel properly.


  *Setting hw.vga.textmode (0 and 1) didn't help.
  *Setting resolution (assuming it wouldn't work, though)
   via kern.vt.fb.default_mode didn't work as expected.
 (the option is for scfb, not for UEFI fb.)
  *Removing nvidia.ko and nvidia-modeset.ko from loader.conf
   didn't help.
  *Last known-to-be-OK revision was r326876 and no other commit
   is done to boot1 codes before this rev.
  *Using known-to-be-OK rev of boot1.efi, all goes fine.

As some commits are done to toolchain codes, I tried rebuilding
known-to-be-OK boot1.efi with current toolchains and confirmed
working OK.


> Author: mizhka
> Date: Thu Dec 21 12:21:35 2017
> New Revision: 327058
> URL: https://svnweb.freebsd.org/changeset/base/327058
> 
> Log:
>   [boot/efi] scan all display modes rather than sequential try-fail way
>   
>   This patch allows to scan all display modes in boot1 as loader does.
>   
>   Before system tried to select optimal display mode by sequential scan
of
>   modes and if error then stop scanning. This way is not good, because
>   if mode N is not present, mode N+1 may exist.
>   
>   In loader we use conout->Mode->MaxMode to identify maximum number of
modes.
>   This commit is to use same way in boot1 as in loader.
  
>   Reported by:Andrey Pustovetov 
>   Reviewed by:tsoome
>   Differential Revision:  https://reviews.freebsd.org/D13541
> 
> Modified:
>   head/stand/efi/boot1/boot1.c
> 
> Modified: head/stand/efi/boot1/boot1.c
> ==
> --- head/stand/efi/boot1/boot1.c  Thu Dec 21 09:21:40 2017
(r327057)
> +++ head/stand/efi/boot1/boot1.c  Thu Dec 21 12:21:35
2017(r327058)
> @@ -430,10 +430,10 @@ efi_main(EFI_HANDLE Ximage,
EFI_SYSTEM_TABLE *Xsystab)
>   conout = ST->ConOut;
>   conout->Reset(conout, TRUE);
>   max_dim = best_mode = 0;
> - for (i = 0; ; i++) {
> + for (i = 0; i < conout->Mode->MaxMode; i++) {
>   status = conout->QueryMode(conout, i, , );
>   if (EFI_ERROR(status))
> - break;
> + continue;
>   if (cols * rows > max_dim) {
>   max_dim = cols * rows;
>   best_mode = i;

-- 
Tomoaki AOKI
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"