Re: svn commit: r329824 - in head: sbin/nvmecontrol sys/cam/nvme sys/conf sys/dev/mpr sys/dev/nvme

2018-02-22 Thread Warner Losh
On Thu, Feb 22, 2018 at 9:49 AM, Wojciech Macek wrote: > Yes, I'm doing that right now. So far it seems everything is there, but > will confirm to be 100% sure. > > Warner, I'm very sorry for not waiting for your comments. The review was > dead for few days and I thought that

Re: svn commit: r329824 - in head: sbin/nvmecontrol sys/cam/nvme sys/conf sys/dev/mpr sys/dev/nvme

2018-02-22 Thread Wojciech Macek
Yes, I'm doing that right now. So far it seems everything is there, but will confirm to be 100% sure. Warner, I'm very sorry for not waiting for your comments. The review was dead for few days and I thought that all was already said, but maybe should have waited a little longer... Let me know

Re: svn commit: r329824 - in head: sbin/nvmecontrol sys/cam/nvme sys/conf sys/dev/mpr sys/dev/nvme

2018-02-22 Thread Warner Losh
I know all about losing things during the rebase I'd be a lot happier if you could confirm that nothing else was lost. It's a large patch, which makes it impossible for others to do it... It seems to build, and seems to be working in the light testing I've done this morning... Warner On

Re: svn commit: r329824 - in head: sbin/nvmecontrol sys/cam/nvme sys/conf sys/dev/mpr sys/dev/nvme

2018-02-22 Thread Wojciech Macek
Thanks and sorry for troubles! These lines must have got lost somewhere during rebase as we run tinderbox with this patch yesterday. Regards, Wojtek wma@ 2018-02-22 17:22 GMT+01:00 Alan Somers : > On Thu, Feb 22, 2018 at 9:20 AM, Kyle Evans wrote: > >>

Re: svn commit: r329824 - in head: sbin/nvmecontrol sys/cam/nvme sys/conf sys/dev/mpr sys/dev/nvme

2018-02-22 Thread Warner Losh
On Thu, Feb 22, 2018 at 9:20 AM, Kyle Evans wrote: > On Thu, Feb 22, 2018 at 10:19 AM, Alan Somers wrote: > > On Thu, Feb 22, 2018 at 6:32 AM, Wojciech Macek wrote: > > > >> Author: wma > >> Date: Thu Feb 22 13:32:31 2018 > >> New

Re: svn commit: r329824 - in head: sbin/nvmecontrol sys/cam/nvme sys/conf sys/dev/mpr sys/dev/nvme

2018-02-22 Thread Alan Somers
On Thu, Feb 22, 2018 at 9:20 AM, Kyle Evans wrote: > On Thu, Feb 22, 2018 at 10:19 AM, Alan Somers wrote: > > On Thu, Feb 22, 2018 at 6:32 AM, Wojciech Macek wrote: > > > >> Author: wma > >> Date: Thu Feb 22 13:32:31 2018 > >> New

Re: svn commit: r329824 - in head: sbin/nvmecontrol sys/cam/nvme sys/conf sys/dev/mpr sys/dev/nvme

2018-02-22 Thread Kyle Evans
On Thu, Feb 22, 2018 at 10:19 AM, Alan Somers wrote: > On Thu, Feb 22, 2018 at 6:32 AM, Wojciech Macek wrote: > >> Author: wma >> Date: Thu Feb 22 13:32:31 2018 >> New Revision: 329824 >> URL: https://svnweb.freebsd.org/changeset/base/329824 >> >> Log: >>

Re: svn commit: r329824 - in head: sbin/nvmecontrol sys/cam/nvme sys/conf sys/dev/mpr sys/dev/nvme

2018-02-22 Thread Alan Somers
On Thu, Feb 22, 2018 at 6:32 AM, Wojciech Macek wrote: > Author: wma > Date: Thu Feb 22 13:32:31 2018 > New Revision: 329824 > URL: https://svnweb.freebsd.org/changeset/base/329824 > > Log: > NVMe: Add big-endian support > > Remove bitfields from defined structures as they