Re: svn commit: r330601 - head/sys/i386/ibcs2
On 07/03/2018 16:19, Brooks Davis wrote: On Wed, Mar 07, 2018 at 01:20:14PM -0500, Pedro Giffuni wrote: FWIW ... ibcs2 is candidate for future removal. It is probably time again to see if actual users exist. ibcs2 has wasted a few hours of my time over the last few months so keeping it does have a non-zero cost. FWIW, I used it long ago on FreeBSD with Unesco's ISIS database software but the software is not developed anymore. We tried to get some vendor interest in it but we failed and given this is very i386-specific it is probably not worth spending huge efforts on it. cloudabi seems to be, for all purposes, a better conceptual replacement. This comment doesn't make much sense. iBCS is the Intel Binary Compatibility Standard, an obsolete ABI for i386 Unixes such as Xenix, SCO, and UnixWare. Cloudabi is, in a sense, taking Capsicum to its logical extreme and totally unrelated. It is also a binary format (ELF-based) that can run on several platforms including Linux and FreeBSD. It clearly targets the cloud market, which makes more sense nowadays than the i386 use space which were common in the early 90s. Pedro. ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Re: svn commit: r330601 - head/sys/i386/ibcs2
On Wed, Mar 07, 2018 at 09:19:55PM +, Brooks Davis wrote: > On Wed, Mar 07, 2018 at 01:20:14PM -0500, Pedro Giffuni wrote: > > FWIW ... > > > > ibcs2 is candidate for future removal. > > It is probably time again to see if actual users exist. ibcs2 has wasted > a few hours of my time over the last few months so keeping it does have > a non-zero cost. There are users of it, I periodically (say two or three times per year) get a report of something appearing broken in it. Note that iBCS2 is disconnected from the build in HEAD in probably in stable/11. It seems that removing it from svn might be a reasonable change after all. > > > We tried to get some vendor interest in it but we failed and given this It was not a 'vendor interest'. It was an unability to get the confirmation that some patch which was written using information from the SCO headers, does not violate the license. > > is very i386-specific it is probably not worth spending huge efforts on it. > > > > cloudabi seems to be, for all purposes, a better conceptual replacement. > > This comment doesn't make much sense. iBCS is the Intel Binary > Compatibility Standard, an obsolete ABI for i386 Unixes such as Xenix, > SCO, and UnixWare. Cloudabi is, in a sense, taking Capsicum to its > logical extreme and totally unrelated. > > -- Brooks ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Re: svn commit: r330601 - head/sys/i386/ibcs2
On Wed, Mar 07, 2018 at 01:20:14PM -0500, Pedro Giffuni wrote: > FWIW ... > > ibcs2 is candidate for future removal. It is probably time again to see if actual users exist. ibcs2 has wasted a few hours of my time over the last few months so keeping it does have a non-zero cost. > We tried to get some vendor interest in it but we failed and given this > is very i386-specific it is probably not worth spending huge efforts on it. > > cloudabi seems to be, for all purposes, a better conceptual replacement. This comment doesn't make much sense. iBCS is the Intel Binary Compatibility Standard, an obsolete ABI for i386 Unixes such as Xenix, SCO, and UnixWare. Cloudabi is, in a sense, taking Capsicum to its logical extreme and totally unrelated. -- Brooks signature.asc Description: PGP signature
Re: svn commit: r330601 - head/sys/i386/ibcs2
FWIW ... ibcs2 is candidate for future removal. We tried to get some vendor interest in it but we failed and given this is very i386-specific it is probably not worth spending huge efforts on it. cloudabi seems to be, for all purposes, a better conceptual replacement. Pedro. On 07/03/2018 09:44, Eitan Adler wrote: Author: eadler Date: Wed Mar 7 14:44:32 2018 New Revision: 330601 URL: https://svnweb.freebsd.org/changeset/base/330601 Log: sys: Fix a few potential infoleaks in cloudabi While there is no immediate leak, if the structure changes underneath us, there might be in the future. Submitted by: Domagoj Stolfa MFC After: 1 month Sponsored by:DARPA/AFRL Modified: head/sys/i386/ibcs2/ibcs2_ipc.c Modified: head/sys/i386/ibcs2/ibcs2_ipc.c == --- head/sys/i386/ibcs2/ibcs2_ipc.c Wed Mar 7 14:41:29 2018 (r330600) +++ head/sys/i386/ibcs2/ibcs2_ipc.c Wed Mar 7 14:44:32 2018 (r330601) @@ -135,6 +135,8 @@ ibcs2_msgctl(struct thread *td, void *v) struct msqid_ds bs; int error; + memset(&is, 0, sizeof(is)); + switch (uap->cmd) { case IBCS2_IPC_STAT: error = kern_msgctl(td, uap->msqid, IPC_STAT, &bs); @@ -317,6 +319,8 @@ ibcs2_semctl(struct thread *td, void *v) union semun semun; register_t rval; int error; + + memset(&is, 0, sizeof(is)); switch(uap->cmd) { case IBCS2_IPC_STAT: ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Re: svn commit: r330601 - head/sys/i386/ibcs2
The message is right if you s/cloudabi/ibcs/ though. Warner On Wed, Mar 7, 2018 at 8:29 AM, Oliver Pinter wrote: > Wrong commit message. IBCS isn't cloudabi. > > On Wednesday, March 7, 2018, Eitan Adler wrote: > >> Author: eadler >> Date: Wed Mar 7 14:44:32 2018 >> New Revision: 330601 >> URL: https://svnweb.freebsd.org/changeset/base/330601 >> >> Log: >> sys: Fix a few potential infoleaks in cloudabi >> >> While there is no immediate leak, if the structure changes underneath >> us, there might be in the future. >> >> Submitted by: Domagoj Stolfa >> MFC After:1 month >> Sponsored by: DARPA/AFRL >> >> Modified: >> head/sys/i386/ibcs2/ibcs2_ipc.c >> >> Modified: head/sys/i386/ibcs2/ibcs2_ipc.c >> >> == >> --- head/sys/i386/ibcs2/ibcs2_ipc.c Wed Mar 7 14:41:29 2018 >> (r330600) >> +++ head/sys/i386/ibcs2/ibcs2_ipc.c Wed Mar 7 14:44:32 2018 >> (r330601) >> @@ -135,6 +135,8 @@ ibcs2_msgctl(struct thread *td, void *v) >> struct msqid_ds bs; >> int error; >> >> + memset(&is, 0, sizeof(is)); >> + >> switch (uap->cmd) { >> case IBCS2_IPC_STAT: >> error = kern_msgctl(td, uap->msqid, IPC_STAT, &bs); >> @@ -317,6 +319,8 @@ ibcs2_semctl(struct thread *td, void *v) >> union semun semun; >> register_t rval; >> int error; >> + >> + memset(&is, 0, sizeof(is)); >> >> switch(uap->cmd) { >> case IBCS2_IPC_STAT: >> ___ >> svn-src-head@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/svn-src-head >> To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org" >> > ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Re: svn commit: r330601 - head/sys/i386/ibcs2
Wrong commit message. IBCS isn't cloudabi. On Wednesday, March 7, 2018, Eitan Adler wrote: > Author: eadler > Date: Wed Mar 7 14:44:32 2018 > New Revision: 330601 > URL: https://svnweb.freebsd.org/changeset/base/330601 > > Log: > sys: Fix a few potential infoleaks in cloudabi > > While there is no immediate leak, if the structure changes underneath > us, there might be in the future. > > Submitted by: Domagoj Stolfa > MFC After:1 month > Sponsored by: DARPA/AFRL > > Modified: > head/sys/i386/ibcs2/ibcs2_ipc.c > > Modified: head/sys/i386/ibcs2/ibcs2_ipc.c > > == > --- head/sys/i386/ibcs2/ibcs2_ipc.c Wed Mar 7 14:41:29 2018 > (r330600) > +++ head/sys/i386/ibcs2/ibcs2_ipc.c Wed Mar 7 14:44:32 2018 > (r330601) > @@ -135,6 +135,8 @@ ibcs2_msgctl(struct thread *td, void *v) > struct msqid_ds bs; > int error; > > + memset(&is, 0, sizeof(is)); > + > switch (uap->cmd) { > case IBCS2_IPC_STAT: > error = kern_msgctl(td, uap->msqid, IPC_STAT, &bs); > @@ -317,6 +319,8 @@ ibcs2_semctl(struct thread *td, void *v) > union semun semun; > register_t rval; > int error; > + > + memset(&is, 0, sizeof(is)); > > switch(uap->cmd) { > case IBCS2_IPC_STAT: > ___ > svn-src-head@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org" > ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"