Re: svn commit: r333765 - head/sys/conf

[Matthew Macy]

It's not breaking the build there, but I'd be fine with removing it
more generally.

-M

On Thu, May 17, 2018 at 2:08 PM, Nathan Whitehorn
 wrote:
>
>
> On 05/17/18 14:04, Matt Macy wrote:
>>
>> Author: mmacy
>> Date: Thu May 17 21:04:19 2018
>> New Revision: 333765
>> URL: https://svnweb.freebsd.org/changeset/base/333765
>>
>> Log:
>>powerpc: fix LINT build
>>   netmap currently doesn't build, take it out of LINT to prevent
>>hiding regressions in universe
>>   Reviewed by:  jhibbits
>>Approved by: sbruno
>>
>> Modified:
>>head/sys/conf/makeLINT.mk
>>
>> Modified: head/sys/conf/makeLINT.mk
>>
>> ==
>> --- head/sys/conf/makeLINT.mk   Thu May 17 21:03:36 2018(r333764)
>> +++ head/sys/conf/makeLINT.mk   Thu May 17 21:04:19 2018(r333765)
>> @@ -53,6 +53,7 @@ LINT: ${NOTES} ${MAKELINT_SED}
>>   .if ${TARGET} == "powerpc"
>> # cat is available, not sure if cp is?
>> cat ${.TARGET} > ${.TARGET}64
>> +   echo "nodevice netmap"  >> ${.TARGET}
>> echo "machine   ${TARGET} powerpc" >> ${.TARGET}
>> echo "machine   ${TARGET} powerpc64" >> ${.TARGET}64
>>   .endif
>>
>
> The build error is that it is broken on all 32-bit architectures because of
> some integer/pointer type confusion, not just (32-bit) PowerPC. So, if we
> aren't fixing it, it at least it should also be removed from ARM, i386,
> mips, etc.
> -Nathan
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r333765 - head/sys/conf

[Nathan Whitehorn]

On 05/17/18 14:04, Matt Macy wrote:

Author: mmacy
Date: Thu May 17 21:04:19 2018
New Revision: 333765
URL: https://svnweb.freebsd.org/changeset/base/333765

Log:
   powerpc: fix LINT build
   
   netmap currently doesn't build, take it out of LINT to prevent

   hiding regressions in universe
   
   Reviewed by:	jhibbits

   Approved by: sbruno

Modified:
   head/sys/conf/makeLINT.mk

Modified: head/sys/conf/makeLINT.mk
==
--- head/sys/conf/makeLINT.mk   Thu May 17 21:03:36 2018(r333764)
+++ head/sys/conf/makeLINT.mk   Thu May 17 21:04:19 2018(r333765)
@@ -53,6 +53,7 @@ LINT: ${NOTES} ${MAKELINT_SED}
  .if ${TARGET} == "powerpc"
# cat is available, not sure if cp is?
cat ${.TARGET} > ${.TARGET}64
+   echo "nodevice netmap">> ${.TARGET}
echo "machine  ${TARGET} powerpc" >> ${.TARGET}
echo "machine  ${TARGET} powerpc64" >> ${.TARGET}64
  .endif



The build error is that it is broken on all 32-bit architectures because 
of some integer/pointer type confusion, not just (32-bit) PowerPC. So, 
if we aren't fixing it, it at least it should also be removed from ARM, 
i386, mips, etc.

-Nathan
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"