Re: svn commit: r305949 - head/usr.bin/soelim

[Warner Losh]

On Sun, Sep 18, 2016 at 11:52 PM, Warner Losh  wrote:
> On Sun, Sep 18, 2016 at 11:44 PM, Warner Losh  wrote:
>> On Sun, Sep 18, 2016 at 6:24 PM, Allan Jude  wrote:
>>> On 2016-09-18 15:16, Baptiste Daroussin wrote:
 Author: bapt
 Date: Sun Sep 18 19:16:48 2016
 New Revision: 305949
 URL: https://svnweb.freebsd.org/changeset/base/305949

 Log:
   Simplify the fix for bootstrap tools

   building head is not supported from prior to stable/10 where 
 sys/capsicum.h was
   named sys/capabilities.h
>>
>> There's still a lot of people building head on 9.x systems. You sure
>> this is a good idea?
>
> MINIMUM_SUPPORTED_OSREL?= 900044
>
> is the currently listed minimum version. Last time I tried it, it worked.

So in case it wasn't clear, I'd like to request a backout of the
elimination of the #ifdef, or at least permission to add them back
when I can show that 9.x systems still can build HEAD. Unlike clang
requiring c++11 to build, this is a trivial thing to maintain
compatibility.

Warner
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r305949 - head/usr.bin/soelim

[Warner Losh]

On Sun, Sep 18, 2016 at 11:44 PM, Warner Losh  wrote:
> On Sun, Sep 18, 2016 at 6:24 PM, Allan Jude  wrote:
>> On 2016-09-18 15:16, Baptiste Daroussin wrote:
>>> Author: bapt
>>> Date: Sun Sep 18 19:16:48 2016
>>> New Revision: 305949
>>> URL: https://svnweb.freebsd.org/changeset/base/305949
>>>
>>> Log:
>>>   Simplify the fix for bootstrap tools
>>>
>>>   building head is not supported from prior to stable/10 where 
>>> sys/capsicum.h was
>>>   named sys/capabilities.h
>
> There's still a lot of people building head on 9.x systems. You sure
> this is a good idea?

MINIMUM_SUPPORTED_OSREL?= 900044

is the currently listed minimum version. Last time I tried it, it worked.

Warner
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r305949 - head/usr.bin/soelim

[Warner Losh]

On Mon, Sep 19, 2016 at 12:41 AM, Baptiste Daroussin  wrote:
> On Mon, Sep 19, 2016 at 12:04:16AM -0600, Warner Losh wrote:
>> On Sun, Sep 18, 2016 at 11:52 PM, Warner Losh  wrote:
>> > On Sun, Sep 18, 2016 at 11:44 PM, Warner Losh  wrote:
>> >> On Sun, Sep 18, 2016 at 6:24 PM, Allan Jude  wrote:
>> >>> On 2016-09-18 15:16, Baptiste Daroussin wrote:
>>  Author: bapt
>>  Date: Sun Sep 18 19:16:48 2016
>>  New Revision: 305949
>>  URL: https://svnweb.freebsd.org/changeset/base/305949
>> 
>>  Log:
>>    Simplify the fix for bootstrap tools
>> 
>>    building head is not supported from prior to stable/10 where 
>>  sys/capsicum.h was
>>    named sys/capabilities.h
>> >>
>> >> There's still a lot of people building head on 9.x systems. You sure
>> >> this is a good idea?
>> >
>> > MINIMUM_SUPPORTED_OSREL?= 900044
>> >
>> > is the currently listed minimum version. Last time I tried it, it worked.
>>
>> So in case it wasn't clear, I'd like to request a backout of the
>> elimination of the #ifdef, or at least permission to add them back
>> when I can show that 9.x systems still can build HEAD. Unlike clang
>> requiring c++11 to build, this is a trivial thing to maintain
>> compatibility.
>>
>
> Agree, I had also other reasons to back out the entire capsicum support. I 
> will
> bring it back later (and make sure it can build on FreeBSD 9

Thanks! I'll be happy to help test or code review if you'd like.

Warner
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r305949 - head/usr.bin/soelim

[Baptiste Daroussin]

On Mon, Sep 19, 2016 at 12:04:16AM -0600, Warner Losh wrote:
> On Sun, Sep 18, 2016 at 11:52 PM, Warner Losh  wrote:
> > On Sun, Sep 18, 2016 at 11:44 PM, Warner Losh  wrote:
> >> On Sun, Sep 18, 2016 at 6:24 PM, Allan Jude  wrote:
> >>> On 2016-09-18 15:16, Baptiste Daroussin wrote:
>  Author: bapt
>  Date: Sun Sep 18 19:16:48 2016
>  New Revision: 305949
>  URL: https://svnweb.freebsd.org/changeset/base/305949
> 
>  Log:
>    Simplify the fix for bootstrap tools
> 
>    building head is not supported from prior to stable/10 where 
>  sys/capsicum.h was
>    named sys/capabilities.h
> >>
> >> There's still a lot of people building head on 9.x systems. You sure
> >> this is a good idea?
> >
> > MINIMUM_SUPPORTED_OSREL?= 900044
> >
> > is the currently listed minimum version. Last time I tried it, it worked.
> 
> So in case it wasn't clear, I'd like to request a backout of the
> elimination of the #ifdef, or at least permission to add them back
> when I can show that 9.x systems still can build HEAD. Unlike clang
> requiring c++11 to build, this is a trivial thing to maintain
> compatibility.
> 

Agree, I had also other reasons to back out the entire capsicum support. I will
bring it back later (and make sure it can build on FreeBSD 9

Best regards,
Bapt


signature.asc
Description: PGP signature

Re: svn commit: r305949 - head/usr.bin/soelim

[Warner Losh]

On Sun, Sep 18, 2016 at 6:24 PM, Allan Jude  wrote:
> On 2016-09-18 15:16, Baptiste Daroussin wrote:
>> Author: bapt
>> Date: Sun Sep 18 19:16:48 2016
>> New Revision: 305949
>> URL: https://svnweb.freebsd.org/changeset/base/305949
>>
>> Log:
>>   Simplify the fix for bootstrap tools
>>
>>   building head is not supported from prior to stable/10 where 
>> sys/capsicum.h was
>>   named sys/capabilities.h

There's still a lot of people building head on 9.x systems. You sure
this is a good idea?

And why does soelim need capsicum anyway in its role as a bootstrap tool?

Warner
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r305949 - head/usr.bin/soelim

[Allan Jude]

On 2016-09-18 15:16, Baptiste Daroussin wrote:
> Author: bapt
> Date: Sun Sep 18 19:16:48 2016
> New Revision: 305949
> URL: https://svnweb.freebsd.org/changeset/base/305949
> 
> Log:
>   Simplify the fix for bootstrap tools
>   
>   building head is not supported from prior to stable/10 where sys/capsicum.h 
> was
>   named sys/capabilities.h
>   
>   Reported by:kib
> 
> Modified:
>   head/usr.bin/soelim/soelim.c
> 
> Modified: head/usr.bin/soelim/soelim.c
> ==
> --- head/usr.bin/soelim/soelim.c  Sun Sep 18 18:49:18 2016
> (r305948)
> +++ head/usr.bin/soelim/soelim.c  Sun Sep 18 19:16:48 2016
> (r305949)
> @@ -30,6 +30,8 @@ __FBSDID("$FreeBSD$");
>  #include 
>  #if __FreeBSD_version > 1001510
>  #include 
> +#else
> +#include 

I am pretty sure this is spelled: sys/capability.h

>  #endif
>  #include 
>  
> @@ -163,10 +165,8 @@ main(int argc, char **argv)
>   int ret = 0;
>   int flags = 0;
>   char cwd[MAXPATHLEN];
> -#if __FreeBSD_version > 1001510
>   unsigned long cmd;
>   cap_rights_t rights;
> -#endif
>  
>   includes = sl_init();
>   if (getcwd(cwd, sizeof(cwd)) != NULL)
> @@ -200,7 +200,6 @@ main(int argc, char **argv)
>   rootfd = open("/", O_DIRECTORY | O_RDONLY);
>   if (rootfd == -1)
>   err(EXIT_FAILURE, "unable to open '/'");
> -#if __FreeBSD_version > 1001510
>   cap_rights_init(, CAP_READ, CAP_FSTAT, CAP_IOCTL);
>   /*
>* EBADF in case stdin is closed by the caller
> @@ -227,7 +226,6 @@ main(int argc, char **argv)
>  
>   if (cap_enter() < 0 && errno != ENOSYS)
>   err(EXIT_FAILURE, "unable to enter capability mode");
> -#endif
>  
>   if (argc == 0)
>   ret = soelim_file(rootfd, stdin, flags);
> 


-- 
Allan Jude
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r305949 - head/usr.bin/soelim

[Baptiste Daroussin]

Author: bapt
Date: Sun Sep 18 19:16:48 2016
New Revision: 305949
URL: https://svnweb.freebsd.org/changeset/base/305949

Log:
  Simplify the fix for bootstrap tools
  
  building head is not supported from prior to stable/10 where sys/capsicum.h 
was
  named sys/capabilities.h
  
  Reported by:  kib

Modified:
  head/usr.bin/soelim/soelim.c

Modified: head/usr.bin/soelim/soelim.c
==
--- head/usr.bin/soelim/soelim.cSun Sep 18 18:49:18 2016
(r305948)
+++ head/usr.bin/soelim/soelim.cSun Sep 18 19:16:48 2016
(r305949)
@@ -30,6 +30,8 @@ __FBSDID("$FreeBSD$");
 #include 
 #if __FreeBSD_version > 1001510
 #include 
+#else
+#include 
 #endif
 #include 
 
@@ -163,10 +165,8 @@ main(int argc, char **argv)
int ret = 0;
int flags = 0;
char cwd[MAXPATHLEN];
-#if __FreeBSD_version > 1001510
unsigned long cmd;
cap_rights_t rights;
-#endif
 
includes = sl_init();
if (getcwd(cwd, sizeof(cwd)) != NULL)
@@ -200,7 +200,6 @@ main(int argc, char **argv)
rootfd = open("/", O_DIRECTORY | O_RDONLY);
if (rootfd == -1)
err(EXIT_FAILURE, "unable to open '/'");
-#if __FreeBSD_version > 1001510
cap_rights_init(, CAP_READ, CAP_FSTAT, CAP_IOCTL);
/*
 * EBADF in case stdin is closed by the caller
@@ -227,7 +226,6 @@ main(int argc, char **argv)
 
if (cap_enter() < 0 && errno != ENOSYS)
err(EXIT_FAILURE, "unable to enter capability mode");
-#endif
 
if (argc == 0)
ret = soelim_file(rootfd, stdin, flags);
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"