Re: svn commit: r329853 - in head: lib/libifconfig share/examples/libifconfig usr.sbin/wlandebug
> On Fri, Feb 23, 2018 at 7:47 AM, Rodney W. Grimes < > free...@pdx.rh.cn85.dnsmgr.net> wrote: > > > > Author: asomers > > > Date: Fri Feb 23 03:11:43 2018 > > > New Revision: 329853 > > > URL: https://svnweb.freebsd.org/changeset/base/329853 > > > > > > Log: > > > libifconfig: multiple feature additions > > > > > > Added the ability to: > > > > > > * Create virtual interfaces > > > * Create vlan interfaces > > > * Get interface fib > > > * Get interface groups > > > * Get interface status > > > * Get nd6 info > > > * Get media status > > > * Get additional ifaddr info in a convenient struct > > > * Get vhids > > > * Get carp info > > > * Get lagg and laggport status > > > * Iterate over all interfaces and ifaddrs > > > > Love that list!!! > > > > > > And add more examples, too. > > > > Remove MIT 1996 Copyright? > > Under what conditions is it that this is being done? > > > > The file's original author removed the extra license block. It probably > shouldn't have been there to begin with. > https://github.com/Savagedlight/libifconfig/commit/92fa671bd2451c11c9f1abf68b56295a05af2c85#diff-d2b1298dd60d9c72a5776c8d57a7fe78 A good commit message summarize ALL changes, sighting the fact that the MIT copyright was being removed, and with the pointer to this external source (probalby should of been listed in an obtained from: line both here in the commit log and in the differential.) > > > Note that this is a backwards-incompatible change. But that's ok, > > because it's > > > a private library. > > > > > > MFC after: 3 weeks > > > Sponsored by: Spectra Logic Corp > > > Differential Revision: https://reviews.freebsd.org/D14463 > > > > With 0 feed back? And a ~30 hour life time? It is not a diffential if > > no one looks at, comments on, or accepts the revision. > > > > > Actually, it's been under review for nearly nine months, but on Github, not > Phabricator. You see, the original author lacks a commit bit, and has > developed this library out-of-tree. It's time we brought it back in, > though. I know the Phabricator review didn't last very long, but I have a > time limitation on my end. Feel free to tear it apart in post-commit > review, if you like. > > https://github.com/Savagedlight/libifconfig/pull/46 You failed to sight this external developer as well, that should always be done in a commit message! A quick easy fix would be simply add some comments to the differential that sight both the 2 external links above, and please appologize to Savageedlight for failing to attribe them in this commit message. The commit references the differential, so that would lead someone down the right road in the future. Thanks, -- Rod Grimes rgri...@freebsd.org ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Re: svn commit: r329853 - in head: lib/libifconfig share/examples/libifconfig usr.sbin/wlandebug
On Fri, Feb 23, 2018 at 7:47 AM, Rodney W. Grimes < free...@pdx.rh.cn85.dnsmgr.net> wrote: > > Author: asomers > > Date: Fri Feb 23 03:11:43 2018 > > New Revision: 329853 > > URL: https://svnweb.freebsd.org/changeset/base/329853 > > > > Log: > > libifconfig: multiple feature additions > > > > Added the ability to: > > > > * Create virtual interfaces > > * Create vlan interfaces > > * Get interface fib > > * Get interface groups > > * Get interface status > > * Get nd6 info > > * Get media status > > * Get additional ifaddr info in a convenient struct > > * Get vhids > > * Get carp info > > * Get lagg and laggport status > > * Iterate over all interfaces and ifaddrs > > Love that list!!! > > > > And add more examples, too. > > Remove MIT 1996 Copyright? > Under what conditions is it that this is being done? > The file's original author removed the extra license block. It probably shouldn't have been there to begin with. https://github.com/Savagedlight/libifconfig/commit/92fa671bd2451c11c9f1abf68b56295a05af2c85#diff-d2b1298dd60d9c72a5776c8d57a7fe78 > > Note that this is a backwards-incompatible change. But that's ok, > because it's > > a private library. > > > > MFC after: 3 weeks > > Sponsored by: Spectra Logic Corp > > Differential Revision: https://reviews.freebsd.org/D14463 > > With 0 feed back? And a ~30 hour life time? It is not a diffential if > no one looks at, comments on, or accepts the revision. > > Actually, it's been under review for nearly nine months, but on Github, not Phabricator. You see, the original author lacks a commit bit, and has developed this library out-of-tree. It's time we brought it back in, though. I know the Phabricator review didn't last very long, but I have a time limitation on my end. Feel free to tear it apart in post-commit review, if you like. https://github.com/Savagedlight/libifconfig/pull/46 -Alan ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Re: svn commit: r329853 - in head: lib/libifconfig share/examples/libifconfig usr.sbin/wlandebug
> Author: asomers
> Date: Fri Feb 23 03:11:43 2018
> New Revision: 329853
> URL: https://svnweb.freebsd.org/changeset/base/329853
>
> Log:
> libifconfig: multiple feature additions
>
> Added the ability to:
>
> * Create virtual interfaces
> * Create vlan interfaces
> * Get interface fib
> * Get interface groups
> * Get interface status
> * Get nd6 info
> * Get media status
> * Get additional ifaddr info in a convenient struct
> * Get vhids
> * Get carp info
> * Get lagg and laggport status
> * Iterate over all interfaces and ifaddrs
Love that list!!!
>
> And add more examples, too.
Remove MIT 1996 Copyright?
Under what conditions is it that this is being done?
> Note that this is a backwards-incompatible change. But that's ok, because
> it's
> a private library.
>
> MFC after: 3 weeks
> Sponsored by: Spectra Logic Corp
> Differential Revision: https://reviews.freebsd.org/D14463
With 0 feed back? And a ~30 hour life time? It is not a diffential if
no one looks at, comments on, or accepts the revision.
> Added:
> head/lib/libifconfig/libifconfig_carp.c (contents, props changed)
> head/lib/libifconfig/libifconfig_inet.c (contents, props changed)
> head/lib/libifconfig/libifconfig_inet6.c (contents, props changed)
> head/lib/libifconfig/libifconfig_lagg.c (contents, props changed)
> head/lib/libifconfig/libifconfig_media.c (contents, props changed)
> head/share/examples/libifconfig/ifchangevlan.c (contents, props changed)
> head/share/examples/libifconfig/ifcreatevlan.c (contents, props changed)
> head/share/examples/libifconfig/status.c (contents, props changed)
> Modified:
> head/lib/libifconfig/Makefile
> head/lib/libifconfig/libifconfig.c
> head/lib/libifconfig/libifconfig.h
> head/lib/libifconfig/libifconfig_internal.c
> head/lib/libifconfig/libifconfig_internal.h
> head/share/examples/libifconfig/Makefile
> head/share/examples/libifconfig/ifcreate.c
> head/share/examples/libifconfig/ifdestroy.c
> head/share/examples/libifconfig/setdescription.c
> head/share/examples/libifconfig/setmtu.c
> head/usr.sbin/wlandebug/wlandebug.c
>
> Modified: head/lib/libifconfig/Makefile
> ==
> --- head/lib/libifconfig/Makefile Fri Feb 23 02:53:50 2018
> (r329852)
> +++ head/lib/libifconfig/Makefile Fri Feb 23 03:11:43 2018
> (r329853)
> @@ -8,7 +8,9 @@ NO_PIC=
>
> SHLIBDIR?= /lib
> SHLIB_MAJOR= 1
> -SRCS=libifconfig.c libifconfig_internal.c
> +SRCS=libifconfig.c libifconfig_carp.c libifconfig_inet.c
> +SRCS+= libifconfig_inet6.c libifconfig_internal.c
> libifconfig_lagg.c
> +SRCS+= libifconfig_media.c
>
> INCSDIR= ${INCLUDEDIR}
> INCS=libifconfig.h
> @@ -16,6 +18,6 @@ INCS= libifconfig.h
> #MAN=libifconfig.3
>
> CFLAGS+= -I${.CURDIR}
> -WARNS?=6
> +NO_WCAST_ALIGN= yes
>
> .include
>
> Modified: head/lib/libifconfig/libifconfig.c
> ==
> --- head/lib/libifconfig/libifconfig.cFri Feb 23 02:53:50 2018
> (r329852)
> +++ head/lib/libifconfig/libifconfig.cFri Feb 23 03:11:43 2018
> (r329853)
> @@ -1,38 +1,7 @@
> /*
> - * Copyright (c) 2016, Marie Helene Kvello-Aune
> - * All rights reserved.
> - *
> - * Redistribution and use in source and binary forms, with or without
> modification,
> - * are permitted provided that the following conditions are met:
> - *
> - * 1. Redistributions of source code must retain the above copyright notice,
> - * thislist of conditions and the following disclaimer.
> - *
> - * 2. Redistributions in binary form must reproduce the above copyright
> notice,
> - * this list of conditions and the following disclaimer in the documentation
> and/or
> - * other materials provided with the distribution.
> - *
> - * 3. Neither the name of the copyright holder nor the names of its
> contributors
> - * may be used to endorse or promote products derived from this software
> without
> - * specific prior written permission.
> - *
> - * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS
> IS"
> - * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
> - * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
> PURPOSE
> - * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
> LIABLE
> - * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
> - * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
> - * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
> - * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
> LIABILITY,
> - * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
svn commit: r329853 - in head: lib/libifconfig share/examples/libifconfig usr.sbin/wlandebug
Author: asomers
Date: Fri Feb 23 03:11:43 2018
New Revision: 329853
URL: https://svnweb.freebsd.org/changeset/base/329853
Log:
libifconfig: multiple feature additions
Added the ability to:
* Create virtual interfaces
* Create vlan interfaces
* Get interface fib
* Get interface groups
* Get interface status
* Get nd6 info
* Get media status
* Get additional ifaddr info in a convenient struct
* Get vhids
* Get carp info
* Get lagg and laggport status
* Iterate over all interfaces and ifaddrs
And add more examples, too.
Note that this is a backwards-incompatible change. But that's ok, because it's
a private library.
MFC after:3 weeks
Sponsored by: Spectra Logic Corp
Differential Revision:https://reviews.freebsd.org/D14463
Added:
head/lib/libifconfig/libifconfig_carp.c (contents, props changed)
head/lib/libifconfig/libifconfig_inet.c (contents, props changed)
head/lib/libifconfig/libifconfig_inet6.c (contents, props changed)
head/lib/libifconfig/libifconfig_lagg.c (contents, props changed)
head/lib/libifconfig/libifconfig_media.c (contents, props changed)
head/share/examples/libifconfig/ifchangevlan.c (contents, props changed)
head/share/examples/libifconfig/ifcreatevlan.c (contents, props changed)
head/share/examples/libifconfig/status.c (contents, props changed)
Modified:
head/lib/libifconfig/Makefile
head/lib/libifconfig/libifconfig.c
head/lib/libifconfig/libifconfig.h
head/lib/libifconfig/libifconfig_internal.c
head/lib/libifconfig/libifconfig_internal.h
head/share/examples/libifconfig/Makefile
head/share/examples/libifconfig/ifcreate.c
head/share/examples/libifconfig/ifdestroy.c
head/share/examples/libifconfig/setdescription.c
head/share/examples/libifconfig/setmtu.c
head/usr.sbin/wlandebug/wlandebug.c
Modified: head/lib/libifconfig/Makefile
==
--- head/lib/libifconfig/Makefile Fri Feb 23 02:53:50 2018
(r329852)
+++ head/lib/libifconfig/Makefile Fri Feb 23 03:11:43 2018
(r329853)
@@ -8,7 +8,9 @@ NO_PIC=
SHLIBDIR?= /lib
SHLIB_MAJOR= 1
-SRCS= libifconfig.c libifconfig_internal.c
+SRCS= libifconfig.c libifconfig_carp.c libifconfig_inet.c
+SRCS+= libifconfig_inet6.c libifconfig_internal.c libifconfig_lagg.c
+SRCS+= libifconfig_media.c
INCSDIR= ${INCLUDEDIR}
INCS= libifconfig.h
@@ -16,6 +18,6 @@ INCS= libifconfig.h
#MAN= libifconfig.3
CFLAGS+= -I${.CURDIR}
-WARNS?=6
+NO_WCAST_ALIGN= yes
.include
Modified: head/lib/libifconfig/libifconfig.c
==
--- head/lib/libifconfig/libifconfig.c Fri Feb 23 02:53:50 2018
(r329852)
+++ head/lib/libifconfig/libifconfig.c Fri Feb 23 03:11:43 2018
(r329853)
@@ -1,38 +1,7 @@
/*
- * Copyright (c) 2016, Marie Helene Kvello-Aune
- * All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
modification,
- * are permitted provided that the following conditions are met:
- *
- * 1. Redistributions of source code must retain the above copyright notice,
- * thislist of conditions and the following disclaimer.
- *
- * 2. Redistributions in binary form must reproduce the above copyright notice,
- * this list of conditions and the following disclaimer in the documentation
and/or
- * other materials provided with the distribution.
- *
- * 3. Neither the name of the copyright holder nor the names of its
contributors
- * may be used to endorse or promote products derived from this software
without
- * specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
- * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
- * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
PURPOSE
- * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
LIABLE
- * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
- * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
- * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
- * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
LIABILITY,
- * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE
USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- *
- * $FreeBSD$
- */
-
-/*
* Copyright (c) 1983, 1993
* The Regents of the University of California. All rights reserved.
+ * Copyright (c) 2016-2017, Marie Helene Kvello-Aune. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -61,65 +30,63 @@
* $FreeBSD$
*/
- /*
- * Copyright 1996 Massachusetts
