Re: svn commit: r332471 - head/sys/dev/ocs_fc

[Ram Kishore Vegesna via svn-src-head]

Thanks Oliver, For pointing the issue. Checked in the change.

-Ram

On Sat, Apr 14, 2018 at 3:32 AM, Oliver Pinter <
oliver.pin...@hardenedbsd.org> wrote:

>
>
> On Friday, April 13, 2018, Ram Kishore Vegesna  wrote:
>
>> Author: ram
>> Date: Fri Apr 13 13:31:20 2018
>> New Revision: 332471
>> URL: https://svnweb.freebsd.org/changeset/base/332471
>>
>> Log:
>>   Check if STACK is defined before using the stack(9).
>>
>>   PR: 227446
>>   Reported by: emaste
>>   Approved by: ken
>>
>> Modified:
>>   head/sys/dev/ocs_fc/ocs_os.c
>>
>> Modified: head/sys/dev/ocs_fc/ocs_os.c
>> 
>> ==
>> --- head/sys/dev/ocs_fc/ocs_os.cFri Apr 13 13:23:31 2018
>> (r332470)
>> +++ head/sys/dev/ocs_fc/ocs_os.cFri Apr 13 13:31:20 2018
>> (r332471)
>> @@ -37,6 +37,7 @@
>>   */
>>
>>  #include "ocs.h"
>> +#include "opt_stack.h"
>
>
> These types of includes - where you includes opts - should go before any
> other includes.
>
>
>
>>  #include 
>>  #include 
>>  #include /* for debug of memory
>> allocations */
>> @@ -855,11 +856,13 @@ void ocs_intr_enable(ocs_os_handle_t os)
>>
>>  void ocs_print_stack(void)
>>  {
>> +#if defined(STACK)
>> struct stack st;
>>
>> stack_zero();
>> stack_save();
>> stack_print();
>> +#endif
>>  }
>>
>>  void ocs_abort(void)
>> ___
>> svn-src-head@freebsd.org mailing list
>> https://lists.freebsd.org/mailman/listinfo/svn-src-head
>> To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
>>
>
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r332471 - head/sys/dev/ocs_fc

[Oliver Pinter]

On Friday, April 13, 2018, Ram Kishore Vegesna  wrote:

> Author: ram
> Date: Fri Apr 13 13:31:20 2018
> New Revision: 332471
> URL: https://svnweb.freebsd.org/changeset/base/332471
>
> Log:
>   Check if STACK is defined before using the stack(9).
>
>   PR: 227446
>   Reported by: emaste
>   Approved by: ken
>
> Modified:
>   head/sys/dev/ocs_fc/ocs_os.c
>
> Modified: head/sys/dev/ocs_fc/ocs_os.c
> 
> ==
> --- head/sys/dev/ocs_fc/ocs_os.cFri Apr 13 13:23:31 2018
> (r332470)
> +++ head/sys/dev/ocs_fc/ocs_os.cFri Apr 13 13:31:20 2018
> (r332471)
> @@ -37,6 +37,7 @@
>   */
>
>  #include "ocs.h"
> +#include "opt_stack.h"


These types of includes - where you includes opts - should go before any
other includes.



>  #include 
>  #include 
>  #include /* for debug of memory allocations
> */
> @@ -855,11 +856,13 @@ void ocs_intr_enable(ocs_os_handle_t os)
>
>  void ocs_print_stack(void)
>  {
> +#if defined(STACK)
> struct stack st;
>
> stack_zero();
> stack_save();
> stack_print();
> +#endif
>  }
>
>  void ocs_abort(void)
> ___
> svn-src-head@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/svn-src-head
> To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
>
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r332471 - head/sys/dev/ocs_fc

[Ram Kishore Vegesna]

Author: ram
Date: Fri Apr 13 13:31:20 2018
New Revision: 332471
URL: https://svnweb.freebsd.org/changeset/base/332471

Log:
  Check if STACK is defined before using the stack(9).
  
  PR: 227446
  Reported by: emaste
  Approved by: ken

Modified:
  head/sys/dev/ocs_fc/ocs_os.c

Modified: head/sys/dev/ocs_fc/ocs_os.c
==
--- head/sys/dev/ocs_fc/ocs_os.cFri Apr 13 13:23:31 2018
(r332470)
+++ head/sys/dev/ocs_fc/ocs_os.cFri Apr 13 13:31:20 2018
(r332471)
@@ -37,6 +37,7 @@
  */
 
 #include "ocs.h"
+#include "opt_stack.h"
 #include 
 #include 
 #include /* for debug of memory allocations */
@@ -855,11 +856,13 @@ void ocs_intr_enable(ocs_os_handle_t os)
 
 void ocs_print_stack(void)
 {
+#if defined(STACK)
struct stack st;
 
stack_zero();
stack_save();
stack_print();
+#endif
 }
 
 void ocs_abort(void)
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"