[Swan-commit] Changes to ref refs/heads/master

2019-08-13 Thread D. Hugh Redelmeier
New commits: commit 50912bf3e95b0981b878b55100b181ef5f27d1fc Author: D. Hugh Redelmeier Date: Tue Aug 13 14:04:04 2019 -0400 library: fix bug in 33da1c2fbb3cf728213137df27ff7fba33bc47f6 In addrinsubnet(), correct one != to be ==. Detected by Cagney

[Swan-commit] Changes to ref refs/heads/master

2019-08-17 Thread D. Hugh Redelmeier
New commits: commit 32b1dd1e80b06983bd681fced8d68a0e94de1270 Author: D. Hugh Redelmeier Date: Sat Aug 17 11:05:05 2019 -0400 initsystems/sysvinit/init.debian.in: fix whitespace ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https

[Swan-commit] Changes to ref refs/heads/master

2019-08-17 Thread D. Hugh Redelmeier
New commits: commit 720e0a22dd8b34fb12dbb9258cae5fbcd2b21672 Author: D. Hugh Redelmeier Date: Sat Aug 17 10:49:27 2019 -0400 testing: fix some whitespace ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org

[Swan-commit] Changes to ref refs/heads/master

2019-08-12 Thread D. Hugh Redelmeier
New commits: commit 33da1c2fbb3cf728213137df27ff7fba33bc47f6 Author: D. Hugh Redelmeier Date: Tue Aug 13 00:03:42 2019 -0400 libswan: modernize and simplify sameaddr.c ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https

[Swan-commit] Changes to ref refs/heads/master

2019-08-12 Thread D. Hugh Redelmeier
New commits: commit 93097b6f4edd20be727c2d7e09b276c6d510c8a1 Author: D. Hugh Redelmeier Date: Tue Aug 13 00:27:30 2019 -0400 pluto: server.c: create_socket(): simplify port handling The previous version overwrote ifp->addr's port, used ifp->addr, and then r

[Swan-commit] Changes to ref refs/heads/master

2019-08-12 Thread D. Hugh Redelmeier
New commits: commit 57bcf6c319bab1998d69559f1c024310cc8f9eb6 Author: D. Hugh Redelmeier Date: Tue Aug 13 00:39:41 2019 -0400 pluto: sprinkle const on struct raw_iface *ifp parameters ___ Swan-commit mailing list Swan-commit@lists.libreswan.org

[Swan-commit] Changes to ref refs/heads/master

2019-08-19 Thread D. Hugh Redelmeier
New commits: commit c58e68f266d05124414bcf24cdbf8799db4600df Author: D. Hugh Redelmeier Date: Mon Aug 19 11:16:32 2019 -0400 libswan: constants.c: enum_match: refactor ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https

[Swan-commit] Changes to ref refs/heads/master

2019-08-17 Thread D. Hugh Redelmeier
New commits: commit 124a8564aa2e2ab7b5fa79c047deae8bd62004de Author: D. Hugh Redelmeier Date: Sat Aug 17 12:45:32 2019 -0400 libswan: enum_search, enum_match: tweak - remove '-' from first column of a comment block (odd, inconsequential) - move declaration of index

[Swan-commit] Changes to ref refs/heads/master

2019-08-17 Thread D. Hugh Redelmeier
New commits: commit 07b1811474f16d3dc0e84c7bc5ea060b7679 Author: D. Hugh Redelmeier Date: Sat Aug 17 22:35:58 2019 -0400 pervasive: fix some whitespace ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org

[Swan-commit] Changes to ref refs/heads/master

2019-08-20 Thread D. Hugh Redelmeier
New commits: commit 25721bed624550d03153d732b57b74a7025b5bf6 Author: D. Hugh Redelmeier Date: Tue Aug 20 20:56:12 2019 -0400 pervasive: eliminate blank lines that precede "}" - these blank lines make to code longer but not more readable - they were often

[Swan-commit] Changes to ref refs/heads/master

2019-09-03 Thread D. Hugh Redelmeier
New commits: commit f69269add8a4793be8c9156fab5721fb9884368f Author: D. Hugh Redelmeier Date: Tue Sep 3 11:26:24 2019 -0400 pervasive: fix calls to idtoa() and dntoa() to use sizeof - "idtoa(a, abuf, IDTOA_BUF)" => "idtoa(a, abuf, sizeof(abuf));"

[Swan-commit] Changes to ref refs/heads/master

2019-09-03 Thread D. Hugh Redelmeier
New commits: commit 60956ab1eb15e13ab69aa8e010187ea653cdf4ef Author: D. Hugh Redelmeier Date: Tue Sep 3 15:32:50 2019 -0400 pervasive: exploit str_id(); shrink scopes of some local variables ___ Swan-commit mailing list Swan-commit

[Swan-commit] Changes to ref refs/heads/master

2019-09-03 Thread D. Hugh Redelmeier
New commits: commit cdc2acd1f621d3375f574b1a4bee24057247654b Author: D. Hugh Redelmeier Date: Tue Sep 3 17:20:56 2019 -0400 pluto/state.c: tweak formatting calls to make code more readable (no change in output) ___ Swan-commit mailing list Swan

[Swan-commit] Changes to ref refs/heads/master

2019-09-04 Thread D. Hugh Redelmeier
New commits: commit 2f1e3f8dc5355266d71bd5a29fd708bc615f673b Author: D. Hugh Redelmeier Date: Wed Sep 4 14:13:54 2019 -0400 ip_address.h: fix grammar in a comment ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https

[Swan-commit] Changes to ref refs/heads/master

2019-09-04 Thread D. Hugh Redelmeier
New commits: commit 5c7cf5c8cd91f095aacbbc64823ef4d28bedcfac Author: D. Hugh Redelmeier Date: Wed Sep 4 12:45:00 2019 -0400 ip_address.h, ip_endpoint.h: improve grammar in comments ___ Swan-commit mailing list Swan-commit@lists.libreswan.org

[Swan-commit] Changes to ref refs/heads/master

2019-09-06 Thread D. Hugh Redelmeier
New commits: commit 3d5516b1c2b004db0685df6c23294a53ceab297b Author: D. Hugh Redelmeier Date: Fri Sep 6 02:26:01 2019 -0400 pluto/ikev2_ipseckey.c: decode IPSECKEY Resource Records more carefully - more validation of fields - more comments to explain the RR and our

[Swan-commit] Changes to ref refs/heads/master

2019-09-16 Thread D. Hugh Redelmeier
New commits: commit 2214c61569f5f25a0def5ae34fbac9e695dc7afd Author: D. Hugh Redelmeier Date: Mon Sep 16 17:46:45 2019 -0400 pluto: v2_decode_certs(): shrink scope of auto "namebuf" ___ Swan-commit mailing list Swan-commit@lists.lib

[Swan-commit] Changes to ref refs/heads/master

2019-09-16 Thread D. Hugh Redelmeier
New commits: commit 64aa80429adf7b154f18b55fff691665c4cd39c5 Author: D. Hugh Redelmeier Date: Mon Sep 16 18:20:12 2019 -0400 doc: improve wording of description of require-id-on-certificate= ___ Swan-commit mailing list Swan-commit

[Swan-commit] Changes to ref refs/heads/master

2019-09-18 Thread D. Hugh Redelmeier
New commits: commit d8529c6157d0cfe1620e7a7530bac1e5f1a1fb2d Author: D. Hugh Redelmeier Date: Wed Sep 18 13:24:15 2019 -0400 pluto: x509.c: simplify match_certs_id() commit 054eee5586b5a0fc8cb5a62e4aba5fde0c1a4e52 Author: D. Hugh Redelmeier Date: Wed Sep 18 13:23:10 2019 -0400

[Swan-commit] Changes to ref refs/heads/master

2019-08-06 Thread D. Hugh Redelmeier
New commits: commit a61b0755e42f3d8c6496deab41913a3b0c1a8931 Author: D. Hugh Redelmeier Date: Tue Aug 6 12:18:54 2019 -0400 libswan: ip_subnet: simplify and clarify mashup() ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https

[Swan-commit] Changes to ref refs/heads/master

2019-08-08 Thread D. Hugh Redelmeier
New commits: commit 0f4cdd099a4522c930fbcf9ea0e268235cf2a70f Author: D. Hugh Redelmeier Date: Thu Aug 8 11:57:45 2019 -0400 eroute, spi, spigrp commands: improve error_s - reduce scopes - declare with correct type (err_t) - rename as "e" since each sc

[Swan-commit] Changes to ref refs/heads/master

2019-08-08 Thread D. Hugh Redelmeier
New commits: commit d3fbb038df53ed46267c93a71fbe00e481be2df5 Author: D. Hugh Redelmeier Date: Thu Aug 8 11:12:26 2019 -0400 pluto: kernel_netlink.c: finish adjusting indentation of a complex test in netlink_acquire() Started in 73bb9e4437ac4d580d2ca1f056bbeaf40c487bd3

[Swan-commit] Changes to ref refs/heads/master

2019-08-09 Thread D. Hugh Redelmeier
New commits: commit 63e235b3c33dcbef2ec5a1615c99f403ae51f542 Author: D. Hugh Redelmeier Date: Fri Aug 9 09:38:14 2019 -0400 ip_address.h: fix spelling in a comment ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https

[Swan-commit] Changes to ref refs/heads/master

2019-07-03 Thread D. Hugh Redelmeier
New commits: commit b1003cb76da681600fe429bea3dd6d4728bef0df Author: D. Hugh Redelmeier Date: Wed Jul 3 23:45:05 2019 -0400 pfkey_v2_build.c: revert to c90 since that seems to be a Kernel Thing Note: this file is in two places in the tree

[Swan-commit] Changes to ref refs/heads/master

2019-07-03 Thread D. Hugh Redelmeier
New commits: commit cd9b2eb60844aae857e14959f15b8278d19af603 Author: D. Hugh Redelmeier Date: Wed Jul 3 23:38:09 2019 -0400 pfkey_v2_build.c: resynchronize the two copies Missed in 226afc3fc06. We really should not have two copies

[Swan-commit] Changes to ref refs/heads/master

2019-07-07 Thread D. Hugh Redelmeier
New commits: commit e4511d6c0e126d08b6580f97e30f2066e6a6ebe6 Author: D. Hugh Redelmeier Date: Sun Jul 7 23:35:24 2019 -0400 whack: sighash_policy can have multiple members commit dbebae24b7a94e121261a0688dd34f83e7e37bf2 Author: D. Hugh Redelmeier Date: Sun Jul 7 23:32:46 2019 -0400

[Swan-commit] Changes to ref refs/heads/master

2019-10-21 Thread D. Hugh Redelmeier
New commits: commit 22973c441c598bce074a5018d81da62907d50a58 Author: D. Hugh Redelmeier Date: Mon Oct 21 12:21:29 2019 -0400 pervasive: bad_case() never returns: don't do anything after a call ___ Swan-commit mailing list Swan-commit

[Swan-commit] Changes to ref refs/heads/master

2019-10-21 Thread D. Hugh Redelmeier
New commits: commit 3ee326cd50f1d88427f0a8238f8423a68075b871 Author: D. Hugh Redelmeier Date: Mon Oct 21 12:36:28 2019 -0400 pluto: ikev2_parent.c: fix grammar ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https

[Swan-commit] Changes to ref refs/heads/master

2019-09-24 Thread D. Hugh Redelmeier
New commits: commit edb6ef007ebf13a6beaa7b3b327b3185258a13ff Author: D. Hugh Redelmeier Date: Tue Sep 24 17:28:56 2019 -0400 pluto: nss_cert_verify.c: cert_VerifySubjectAltName: don't skip missing '@' ___ Swan-commit mailing list Swan-commit

[Swan-commit] Changes to ref refs/heads/master

2019-09-24 Thread D. Hugh Redelmeier
New commits: commit e67c7ea6622d8fb82a67118706a93872bc70f741 Author: D. Hugh Redelmeier Date: Tue Sep 24 17:19:51 2019 -0400 pluto: connections.c: simplify idr_wildmatch (kind of) - (new behaviour) elminate trailing "." characters from consideration (li

[Swan-commit] Changes to ref refs/heads/master

2019-10-09 Thread D. Hugh Redelmeier
New commits: commit 1d583d0dca8ca2c33ffc41262466d410a0e60a10 Author: D. Hugh Redelmeier Date: Wed Oct 9 15:49:54 2019 -0400 lib/libswan/x509dn.c: tiny tidy ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org

[Swan-commit] Changes to ref refs/heads/master

2019-10-09 Thread D. Hugh Redelmeier
New commits: commit 1d22c5a11acfbee75f996c2a750677109c0362ab Author: D. Hugh Redelmeier Date: Wed Oct 9 15:55:26 2019 -0400 testing: check/ip/ipcheck.h fix spelling and grammatical error Note: none of these messages shows up in a test reference log so I guess that the testing

[Swan-commit] Changes to ref refs/heads/master

2019-10-09 Thread D. Hugh Redelmeier
New commits: commit feabbb1290cc796eabcd49f1e4b379d7d565dc83 Author: D. Hugh Redelmeier Date: Wed Oct 9 16:05:21 2019 -0400 pluto: nss_cert_verify.c: don't spell when drunk ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https

[Swan-commit] Changes to ref refs/heads/master

2020-03-02 Thread D. Hugh Redelmeier
New commits: commit 89b5e4662ef473efdcda08ef62068233488fa571 Author: D. Hugh Redelmeier Date: Mon Mar 2 10:18:21 2020 -0500 pluto: ikev2_emit_ts() should not set payload lengths These are set by out_struct for ft_len fields. ___ Swan

[Swan-commit] Changes to ref refs/heads/master

2020-03-02 Thread D. Hugh Redelmeier
New commits: commit 4041884cfef394e1604730a400aae8f71d828a63 Author: D. Hugh Redelmeier Date: Mon Mar 2 10:26:44 2020 -0500 pluto: ikev2_emit_ts should not emit a TS it doesn't understand The default (unhandled) case should fail in some way. Tentatively, I've chosen

[Swan-commit] Changes to ref refs/heads/master

2020-02-16 Thread D. Hugh Redelmeier
New commits: commit 35f8db42466d838e3ade687fa38be2ec70c833e1 Author: D. Hugh Redelmeier Date: Sun Feb 16 19:10:25 2020 -0500 pluto: sprinkle const on many struct fd * parameters also rename show_shunt_count => shunt_count since it doesn't show anyth

[Swan-commit] Changes to ref refs/heads/main

2020-09-03 Thread D. Hugh Redelmeier
New commits: commit 81c2fff97d896e14db2895984100adc088fd718d Author: D. Hugh Redelmeier Date: Thu Sep 3 14:40:10 2020 -0400 pluto: simplify nl_query_small_resp and its callers ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https

[Swan-commit] Changes to ref refs/heads/main

2020-09-01 Thread D. Hugh Redelmeier
New commits: commit e865fa9dcee2ab53f938ccbd459241cba024abfa Author: D. Hugh Redelmeier Date: Wed Sep 2 01:18:10 2020 -0400 pluto/library netlink code: simplify Especially: reduce complexity by eliminating flawed code to handle impossible NULL pointer cases

[Swan-commit] Changes to ref refs/heads/main

2020-09-12 Thread D. Hugh Redelmeier
New commits: commit e5c430b0c50a04dedda0c6d7ec3401898ae78934 Author: D. Hugh Redelmeier Date: Sat Sep 12 18:14:07 2020 -0400 pluto: eliminate two leaks in v2_calculate_sighash() ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https

[Swan-commit] Changes to ref refs/heads/main

2020-09-13 Thread D. Hugh Redelmeier
New commits: commit 7d32338e73448913dd4d63defd264fec4d0dfbee Author: D. Hugh Redelmeier Date: Sun Sep 13 10:39:19 2020 -0400 pluto: eliminate another leak in v2_calculate_sighash() No need to make a copy. Without a copy, there is no need to free

[Swan-commit] Changes to ref refs/heads/main

2020-09-13 Thread D. Hugh Redelmeier
New commits: commit 6c69c513e10d98fbd96c96a5a9710eeebb4fbce5 Author: D. Hugh Redelmeier Date: Sun Sep 13 09:19:30 2020 -0400 pluto: tweak enum perspective ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https://lists.libreswan.org

[Swan-commit] Changes to ref refs/heads/main

2020-09-13 Thread D. Hugh Redelmeier
New commits: commit 7d007c7d5e2f1faf183d12a587584abef3d4825e Author: D. Hugh Redelmeier Date: Sun Sep 13 10:02:54 2020 -0400 libswan: ditch chunk1() because it isn't used. ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https

[Swan-commit] Changes to ref refs/heads/main

2020-09-02 Thread D. Hugh Redelmeier
New commits: commit 71177ead6758f14308db52aee717bf35b4d79204 Author: D. Hugh Redelmeier Date: Wed Sep 2 20:55:04 2020 -0400 pluto: fix bug in kernel_xfrm_interface.c: nl_query_small_resp ___ Swan-commit mailing list Swan-commit

[Swan-commit] Changes to ref refs/heads/main

2020-09-14 Thread D. Hugh Redelmeier
New commits: commit dd1685b3a48e4139daeb7eb1f3084a577f9fc847 Author: D. Hugh Redelmeier Date: Mon Sep 14 02:18:29 2020 -0400 pluto: git rid of a bunch of leaks in ikev2_message.c ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https

[Swan-commit] Changes to ref refs/heads/main

2020-09-14 Thread D. Hugh Redelmeier
New commits: commit fa71e90119478ee22d6a0ef732079225ac4f5b95 Author: D. Hugh Redelmeier Date: Mon Sep 14 02:23:07 2020 -0400 pluto: use htonl for byte-order hack in ikev2_message.c The previous hand-rolled code was tricky and would not work on a big-endian computer

[Swan-commit] Changes to ref refs/heads/main

2020-10-11 Thread D. Hugh Redelmeier
New commits: commit 841d1e7cffc328ba0a7a03148eadecd07978f27d Author: D. Hugh Redelmeier Date: Sun Oct 11 18:08:19 2020 -0400 pluto: packet.c: eliminate pointless last_enum from pbs_in_struct() and pbs_out_struct() commit 1e6ced2921b9d8887c10a3a06edd8ddd9dd7f5c2 Author: D. Hugh Redelmeier

[Swan-commit] Changes to ref refs/heads/main

2020-10-12 Thread D. Hugh Redelmeier
New commits: commit 688d1400c6e5b3e71c2067b733ddc29404e046f4 Author: D. Hugh Redelmeier Date: Tue Oct 13 01:11:23 2020 -0400 pluto: ikev2_message.c: clean up another pair of endian bugs. commit eefc52299a3703a080bfb8ae1084f54e2b447817 Author: D. Hugh Redelmeier Date: Tue Oct 13 01:09

[Swan-commit] Changes to ref refs/heads/main

2020-10-17 Thread D. Hugh Redelmeier
New commits: commit 9b5271ab42816b6887b44b68672e47501d3c31a4 Author: D. Hugh Redelmeier Date: Sat Oct 17 14:19:43 2020 -0400 pluto: rcv_whack.c: clarify and simplify key_add_request() ___ Swan-commit mailing list Swan-commit@lists.libreswan.org

[Swan-commit] Changes to ref refs/heads/main

2020-08-28 Thread D. Hugh Redelmeier
New commits: commit 7b6276b7bc00710af633fccbc80984f644aff58a Author: D. Hugh Redelmeier Date: Fri Aug 28 12:34:42 2020 -0400 pervasive: "cannot" is clearer and more idiomatic thant "can not" ___ Swan-commit mail

[Swan-commit] Changes to ref refs/heads/main

2020-08-28 Thread D. Hugh Redelmeier
New commits: commit 0813b56e289f721a52929d398741ddc15316582c Author: D. Hugh Redelmeier Date: Fri Aug 28 12:20:29 2020 -0400 pluto: netlink/xfrm code improvement - nl_query_small_resp: + Eliminate horrible pointer bug. Parameter rsp was treated as a buffer

[Swan-commit] Changes to ref refs/heads/main

2020-08-30 Thread D. Hugh Redelmeier
New commits: commit 8a6a178b3ed0656a1dcf767ca6a09093fd85a957 Author: D. Hugh Redelmeier Date: Sun Aug 30 18:32:15 2020 -0400 pluto kernel_xfrm_interface.c: nl_query_small_resp remove protocol parameter All calls used NETLINK_ROUTE so hard-wire

[Swan-commit] Changes to ref refs/heads/main

2020-06-26 Thread D. Hugh Redelmeier
New commits: commit 468b1986c7e3dc937758c3976538e96066b029dc Author: D. Hugh Redelmeier Date: Fri Jun 26 23:59:57 2020 -0400 pluto: kernel.c: tidy teardown_half_ipsec_sa - clarify and simplify handling of redirection. Don't hack the connection! - bug fix

[Swan-commit] Changes to ref refs/heads/main

2020-06-28 Thread D. Hugh Redelmeier
New commits: commit cb9dbd32be74e0ab5029b78f06a109e136a3a29f Author: D. Hugh Redelmeier Date: Sun Jun 28 18:31:01 2020 -0400 pluto: kernel: teardown_half_ipsec_sa: resolve a ??? Thanks to Vukasin Karadzic ___ Swan-commit mailing list

[Swan-commit] Changes to ref refs/heads/master

2020-06-19 Thread D. Hugh Redelmeier
New commits: commit a3c30a0a3b4384950761beda752611d81f4177ea Author: D. Hugh Redelmeier Date: Fri Jun 19 13:50:41 2020 -0400 pluto: kernel_xfrm.c: use SA, not Sa, for Security Association ___ Swan-commit mailing list Swan-commit

[Swan-commit] Changes to ref refs/heads/master

2020-06-13 Thread D. Hugh Redelmeier
New commits: commit ed667b061398231444810ee261c8d03a93ce32e3 Author: D. Hugh Redelmeier Date: Sat Jun 13 18:36:30 2020 -0400 library: initsubnet: make second parameter name consistent Function prototype calls it "maskbits" lib/libswan/initsubnet.3.xml agrees.

[Swan-commit] Changes to ref refs/heads/main

2020-08-14 Thread D. Hugh Redelmeier
New commits: commit 4926080ecbb4b5e4cca2a78913d17ab2067b1a94 Merge: b499278 7554a70 Author: D. Hugh Redelmeier Date: Fri Aug 14 11:58:06 2020 -0400 Merge branch 'main' of vault.libreswan.org:/srv/src/libreswan into main commit b4992781a14d48497923c90e5bfeba0c55ad19e4 Author: D. Hugh

[Swan-commit] Changes to ref refs/heads/main

2020-12-29 Thread D. Hugh Redelmeier
New commits: commit 826c11f4f0834abde7812302239f9ca0b71c9834 Author: D. Hugh Redelmeier Date: Tue Dec 29 18:14:37 2020 -0500 libswan: ip_endpoint.c: endpoint_eq(): simplify ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https

[Swan-commit] Changes to ref refs/heads/main

2020-12-29 Thread D. Hugh Redelmeier
New commits: commit 4fb0dc5ff36163a34a284a0b86e7d36520b5d5d7 Author: D. Hugh Redelmeier Date: Tue Dec 29 17:39:12 2020 -0500 libswan: anyaddr.c: isanyaddr(): simplify ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https

[Swan-commit] Changes to ref refs/heads/main

2021-06-16 Thread D. Hugh Redelmeier
New commits: commit 0e67cf45937b7cd8b03c7bee24a3871dbb7618d6 Author: D. Hugh Redelmeier Date: Wed Jun 16 02:47:01 2021 -0400 pluto: get rid of fake_md from aggr_outI1_continue() Stimulus: Coverity flagged a possible null pointer dereference of fake_md->smc I had

[Swan-commit] Changes to ref refs/heads/main

2021-06-14 Thread D. Hugh Redelmeier
New commits: commit 704e36d5e8a738a449b11a90555c7f810a35446b Author: D. Hugh Redelmeier Date: Mon Jun 14 17:37:17 2021 -0400 pluto: initiate.c: fix typo in comment ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https

[Swan-commit] Changes to ref refs/heads/main

2021-06-16 Thread D. Hugh Redelmeier
New commits: commit a8fe696f67534be498e730c45f5337edc153ec1a Author: D. Hugh Redelmeier Date: Wed Jun 16 12:07:33 2021 -0400 pluto: ikev2_ts.c: convert large const by-value parameters to by-ref Coverity complains about pointlessly copying large (1k) parameters. It's right

[Swan-commit] Changes to ref refs/heads/main

2021-06-16 Thread D. Hugh Redelmeier
New commits: commit df58403c72de69d243efed461c17f113f7818e17 Author: D. Hugh Redelmeier Date: Wed Jun 16 14:39:43 2021 -0400 pluto/whack: add const to all struct pickler objects ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https

[Swan-commit] Changes to ref refs/heads/main

2021-06-17 Thread D. Hugh Redelmeier
New commits: commit 85ff55b619f36efedf7baf0f61497d09434133b9 Author: D. Hugh Redelmeier Date: Thu Jun 17 15:05:43 2021 -0400 pluto: define and use enum encapsulation_mode commit bb4b8f5595ba68346a6d2b7619879f97d456c50a Author: D. Hugh Redelmeier Date: Thu Jun 17 15:04:33 2021 -0400

[Swan-commit] Changes to ref refs/heads/main

2021-06-19 Thread D. Hugh Redelmeier
New commits: commit 292ec75828cd9fbb8914e338444301bacbfc3f98 Author: D. Hugh Redelmeier Date: Sat Jun 19 09:55:40 2021 -0400 pluto: kernel_xfrm.c: modest simplifications ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https

[Swan-commit] Changes to ref refs/heads/main

2021-06-23 Thread D. Hugh Redelmeier
New commits: commit 386c3b86d7af497ead3c544634eb8d142e3e96d0 Author: D. Hugh Redelmeier Date: Wed Jun 23 10:11:35 2021 -0400 libreswan.h: make definition of ULTOT_BUF clearer ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https

[Swan-commit] Changes to ref refs/heads/main

2021-06-23 Thread D. Hugh Redelmeier
New commits: commit f74726bdc60113f0fb58a2c10d4c81e6c35123fe Author: D. Hugh Redelmeier Date: Wed Jun 23 10:03:37 2021 -0400 testing: fix type in filename in pluto/TESTLIST ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https

[Swan-commit] Changes to ref refs/heads/main

2021-06-18 Thread D. Hugh Redelmeier
New commits: commit 3aafd213427305959965dfe3a4be066c3e30 Author: D. Hugh Redelmeier Date: Fri Jun 18 11:11:31 2021 -0400 pluto: kernel_xfrm.c: avoid null-dereference discovered by Coverity Null dereferences often indicate a logic error. Any such error remains

[Swan-commit] Changes to ref refs/heads/main

2021-06-18 Thread D. Hugh Redelmeier
New commits: commit 2dfd2fded83c004c53a40e8b27c20c4153c5efae Author: D. Hugh Redelmeier Date: Fri Jun 18 11:20:22 2021 -0400 pluto: kernel.c: remove unreachable RETURN fromtrap_connection ___ Swan-commit mailing list Swan-commit

[Swan-commit] Changes to ref refs/heads/main

2021-05-08 Thread D. Hugh Redelmeier
New commits: commit 79da7aa1fa5f60c0c42ea81ecc8c3d2bb32a3ecd Author: D. Hugh Redelmeier Date: Sun May 9 01:21:35 2021 -0400 pluto: ikev2.c: avoid pointless NULL test of md in v2_dispatch() Coverity pointed out that code would previously have dereferenced md. commit

[Swan-commit] Changes to ref refs/heads/main

2021-05-08 Thread D. Hugh Redelmeier
New commits: commit 726ce81d4d60eb84b4c6caddd8335aa88f919aa6 Author: D. Hugh Redelmeier Date: Sat May 8 23:52:50 2021 -0400 pluto: host_pair.c: avoid a NULL dereference Coverity points out that a NULL pointer could be dereferenced. Avoid that. commit

[Swan-commit] Changes to ref refs/heads/main

2021-05-08 Thread D. Hugh Redelmeier
New commits: commit af815465667ccebc758de5396340b678206c0e25 Author: D. Hugh Redelmeier Date: Sun May 9 00:02:58 2021 -0400 pluto: kernel_xfrm.c: netlink_acquire() eliminate dead variable and code - uctx was only ever assigned once, set to NULL - the only use was a test

[Swan-commit] Changes to ref refs/heads/main

2021-05-07 Thread D. Hugh Redelmeier
New commits: commit 9945236619b17fa13dfd1cfbe60359dcbf3fcd21 Author: D. Hugh Redelmeier Date: Fri May 7 23:58:52 2021 -0400 pluto: packet.c: add consistency check to pbs_in_struct pbs_in_struct now requires that if and only if the structure has a length field then the obj_pbs

[Swan-commit] Changes to ref refs/heads/main

2021-05-06 Thread D. Hugh Redelmeier
New commits: commit 4af9072e62237daad9fea9bb769f6dfbdf2e4ea1 Author: D. Hugh Redelmeier Date: Thu May 6 15:18:02 2021 -0400 libswan/ttoaddress.c: use getaddrinfo(3) instead of gethostbyname2(3) (attempt 2) Modernization. Much simplification. I'm not sure if we lose

[Swan-commit] Changes to ref refs/heads/main

2021-05-28 Thread D. Hugh Redelmeier
New commits: commit 9c4c07ce525a12a113d1cca83c55a2e077c29930 Author: D. Hugh Redelmeier Date: Fri May 28 17:59:28 2021 -0400 libswan: fix bug in constants.c's enum_match It's interesting that this hasn't been detected (it was introduced in February). That probably means

[Swan-commit] Changes to ref refs/heads/main

2021-05-28 Thread D. Hugh Redelmeier
New commits: commit 44bddacf03d513c12a2ddbddf80c53e175a719ef Author: D. Hugh Redelmeier Date: Fri May 28 19:52:53 2021 -0400 pervasive: get rid of more erratic spaces in our code ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https

[Swan-commit] Changes to ref refs/heads/main

2021-05-28 Thread D. Hugh Redelmeier
New commits: commit eae6309fac1d28f9b142913d1ab6e8db32f59350 Author: D. Hugh Redelmeier Date: Fri May 28 19:37:14 2021 -0400 pervasive: get rid of some erratic spaces ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https

[Swan-commit] Changes to ref refs/heads/main

2021-05-28 Thread D. Hugh Redelmeier
New commits: commit 39bfa7ef66f9eb38b975c4c3d0eef02ec65898d7 Author: D. Hugh Redelmeier Date: Fri May 28 16:44:18 2021 -0400 pluto: move has_v2_IKE_AUTH_child_sa_payloads() and make it file-static commit 51a3c1f8583a35d0f97ad9d729e3058b8335df28 Author: D. Hugh Redelmeier Date: Fri May

[Swan-commit] Changes to ref refs/heads/main

2021-05-28 Thread D. Hugh Redelmeier
New commits: commit e3507b731e12b5beec3ca24e5d85ab52935a987c Author: D. Hugh Redelmeier Date: Fri May 28 16:54:32 2021 -0400 pluto: fix typo in comment in ikev2_parent.c ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https

[Swan-commit] Changes to ref refs/heads/main

2021-05-22 Thread D. Hugh Redelmeier
New commits: commit 00bd0a75480d3e1197bf18d9d931e2391130b44f Author: D. Hugh Redelmeier Date: Sat May 22 16:46:26 2021 -0400 pluto: iface.c: simplify find_raw_ifaces4() - Eliminate use of realloc(3). - Logic is otherwise unchanged but code now exploits modern C to reduce

[Swan-commit] Changes to ref refs/heads/main

2021-05-21 Thread D. Hugh Redelmeier
New commits: commit ca8aa7b78b3f357a4e66f915ee617077476e4061 Author: D. Hugh Redelmeier Date: Fri May 21 13:19:55 2021 -0400 pluto: fetch.c: fetch_curl(): add checks to make Coverity happy Results returned by curl_easy_setopt() might indicate errors

[Swan-commit] Changes to ref refs/heads/main

2021-05-29 Thread D. Hugh Redelmeier
New commits: commit 978fae35ee3e8da00fe5a733dfc4a0247a0b3b36 Author: D. Hugh Redelmeier Date: Sat May 29 11:15:58 2021 -0400 pervasive: eliminate a few more erratic spaces in C code ___ Swan-commit mailing list Swan-commit@lists.libreswan.org

[Swan-commit] Changes to ref refs/heads/main

2021-07-01 Thread D. Hugh Redelmeier
New commits: commit 351003c40b5c75291b8539345b0bc0c7158d2838 Author: D. Hugh Redelmeier Date: Fri Jul 2 00:44:21 2021 -0400 pluto: rejig code generating and using textual SAIDs - move SAMIGTOT_BUF from include/ip_said.h to kernel_xfrm.c (only user) - kernel.c: replace

[Swan-commit] Changes to ref refs/heads/main

2021-04-26 Thread D. Hugh Redelmeier
New commits: commit 67422c63b69a31e1af1c3e47cb778bf5249c6286 Author: D. Hugh Redelmeier Date: Mon Apr 26 21:45:50 2021 -0400 pervasive: get rid of trailing whitespace in our C code ___ Swan-commit mailing list Swan-commit@lists.libreswan.org

[Swan-commit] Changes to ref refs/heads/main

2021-04-26 Thread D. Hugh Redelmeier
New commits: commit ba33726a2a9dd44c9e34929c5aac35b40f2f5446 Author: D. Hugh Redelmeier Date: Mon Apr 26 22:07:50 2021 -0400 C code: restore some tabs that had decayed into spaces ___ Swan-commit mailing list Swan-commit@lists.libreswan.org

[Swan-commit] Changes to ref refs/heads/main

2021-04-26 Thread D. Hugh Redelmeier
New commits: commit 71af152cbf2b1570705259e5f1ec31f62df17590 Author: D. Hugh Redelmeier Date: Mon Apr 26 21:31:33 2021 -0400 include: remove unused lsw_select.h ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https

[Swan-commit] Changes to ref refs/heads/main

2021-04-26 Thread D. Hugh Redelmeier
New commits: commit 6c72aad7404f013c9bccd50371fa8079bb424023 Author: D. Hugh Redelmeier Date: Mon Apr 26 22:21:45 2021 -0400 C code: IF and its THEN clause should be on separate lines ___ Swan-commit mailing list Swan-commit@lists.libreswan.org

[Swan-commit] Changes to ref refs/heads/main

2021-04-30 Thread D. Hugh Redelmeier
New commits: commit 8bca5286e698786d0bd766562e76758be98ec022 Author: D. Hugh Redelmeier Date: Fri Apr 30 15:08:09 2021 -0400 refcnt.h: rename O to OBJ (for readability) ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https

[Swan-commit] Changes to ref refs/heads/main

2021-04-30 Thread D. Hugh Redelmeier
New commits: commit c139182fff018ef9609c1e02441aedbd691b8e3a Author: D. Hugh Redelmeier Date: Fri Apr 30 15:16:34 2021 -0400 pluto: virtual_ip.c: clarify struct virtual_ip ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https

[Swan-commit] Changes to ref refs/heads/main

2021-05-02 Thread D. Hugh Redelmeier
New commits: commit cd02dfbf37c0a1c17d63ae126ab290d27580f086 Author: D. Hugh Redelmeier Date: Sun May 2 10:03:01 2021 -0400 libswan, pluto: make sure references to refcnt are atomic C (pre-11) doesn't guarantee that any integral type is atomic. All but one use was protected

[Swan-commit] Changes to ref refs/heads/main

2021-04-30 Thread D. Hugh Redelmeier
New commits: commit 8268aa67302f5d8a8b29a50a9ae301ad2067cbe6 Author: D. Hugh Redelmeier Date: Fri Apr 30 15:49:31 2021 -0400 libswan/ttoaddress.c: update comment in ttoaddress_dns() commit 0b40894dff88e6ff0265cca29582a4f85edea27f Author: D. Hugh Redelmeier Date: Fri Apr 30 15:21:51

[Swan-commit] Changes to ref refs/heads/main

2021-04-30 Thread D. Hugh Redelmeier
New commits: commit f543770846d26127bf310b26f0e834f408609a3f Author: D. Hugh Redelmeier Date: Fri Apr 30 16:05:19 2021 -0400 libswan/ttoaddress.c: clarify tryname() - getting the wrong address family from gethostbyname2 should be impossible. Instead of handling

[Swan-commit] Changes to ref refs/heads/main

2021-05-03 Thread D. Hugh Redelmeier
New commits: commit 379929c054bbe6022abbc456f5c1fd9bd453470d Author: D. Hugh Redelmeier Date: Mon May 3 12:37:40 2021 -0400 libswan/ttoaddress.c: use getaddrinfo(3) instead of gethostbyname2(3) Modernization. Much simplification. I'm not sure if we lose support for hex

[Swan-commit] Changes to ref refs/heads/main

2021-05-03 Thread D. Hugh Redelmeier
New commits: commit 3bfbe401cb372cff53267bd0f3a63884bb3f510a Author: D. Hugh Redelmeier Date: Mon May 3 14:54:03 2021 -0400 pluto/fetch.c: add a bit missing from 131892b682bff4577ea1c72a5e8fa95e2a7afa5b ___ Swan-commit mailing list Swan-commit

[Swan-commit] Changes to ref refs/heads/main

2021-05-03 Thread D. Hugh Redelmeier
New commits: commit 202d1b7c6f3cfd63bcf066e278c30163f1b8752a Author: D. Hugh Redelmeier Date: Tue May 4 00:11:22 2021 -0400 libswan/ttoaddress.c: attempt to fix a crash in ttoaddress_dns Cagney observed a crash in the version of ttoaddress_dns that uses getaddrinfo. It looks

[Swan-commit] Changes to ref refs/heads/main

2021-05-03 Thread D. Hugh Redelmeier
New commits: commit 1dad494d64c1775670ddc4d9d5d11dd10a660977 Author: D. Hugh Redelmeier Date: Tue May 4 00:51:50 2021 -0400 pluto/ikev2_cookie.c: convert pexpect into passert (Coverity complains about unreachable code) We know that the failing case is impossible. Be bold

[Swan-commit] Changes to ref refs/heads/main

2021-05-04 Thread D. Hugh Redelmeier
New commits: commit 06fb615b009ad1b016aeca797a7f8fec7c8d4ae2 Author: D. Hugh Redelmeier Date: Tue May 4 11:53:30 2021 -0400 Revert "libswan/ttoaddress.c: use getaddrinfo(3) instead of gethostbyname2(3)" This reverts commit 379929c054bbe6022abbc456f5c1fd

[Swan-commit] Changes to ref refs/heads/main

2021-05-04 Thread D. Hugh Redelmeier
New commits: commit c2d07de65afa3ee9f46f4c0c8c2b52b4bb4c0426 Author: D. Hugh Redelmeier Date: Tue May 4 10:57:58 2021 -0400 testing/programs/ipcheck/ip_range_check.c: fix typo caught by Coverity Scan ___ Swan-commit mailing list Swan-commit

[Swan-commit] Changes to ref refs/heads/main

2021-03-26 Thread D. Hugh Redelmeier
New commits: commit 3e968bad23671e086f2a1ac9e7098e76c5240e66 Author: D. Hugh Redelmeier Date: Fri Mar 26 11:08:53 2021 -0400 lib: add comments to IP range code ___ Swan-commit mailing list Swan-commit@lists.libreswan.org https

[Swan-commit] Changes to ref refs/heads/main

2021-03-26 Thread D. Hugh Redelmeier
New commits: commit 27219552bfbf02f09c55356cee6563f1bb8bbf6a Author: D. Hugh Redelmeier Date: Fri Mar 26 17:58:40 2021 -0400 lib_swan: ip_bytes.c: bytes_sub(): avoid mixing signed and unsigned Mixing is surprisingly treacherous since it works in most cases and in most

[Swan-commit] Changes to ref refs/heads/main

2021-03-26 Thread D. Hugh Redelmeier
New commits: commit 671c8675dfb1ae938628670376453e46ebc67c9d Author: D. Hugh Redelmeier Date: Fri Mar 26 18:23:58 2021 -0400 pluto: modify 8d1f8aec2ca811954811337008b4aee1a8900286 to make it more declarative This version is clearer because .sec_label isn't ovrewritten

<    2   3   4   5   6   7   8   >