Re: [Swan-dev] [libreswan RFC 2/3] pluto, whack: Add nic-offload 'auto' mode

2017-08-01 Thread Paul Wouters
On Mon, 31 Jul 2017, Ilan Tayari wrote: It's designed to be compatible anywhere ethtool -k works. This was introduced around kernel 2.6.38, circa 2011 We do still have embedded people, and people on 2.4.x kernels. I think it is safe to assume that if these detection routines fail, we go back

Re: [Swan-dev] [libreswan RFC 2/3] pluto, whack: Add nic-offload 'auto' mode

2017-07-31 Thread Ilan Tayari
> -Original Message- > From: Paul Wouters [mailto:p...@nohats.ca] > Subject: RE: [libreswan RFC 2/3] pluto, whack: Add nic-offload 'auto' mode > > On Mon, 31 Jul 2017, Ilan Tayari wrote: > > >> For the second and the third patch here is my suggestion. > >> > >> no|yes|auto is probably

Re: [Swan-dev] [libreswan RFC 2/3] pluto, whack: Add nic-offload 'auto' mode

2017-07-31 Thread Paul Wouters
On Mon, 31 Jul 2017, Ilan Tayari wrote: For the second and the third patch here is my suggestion. no|yes|auto is probably better keywords in the libreswan context. Libreswan do not use first letter capitalizing as you proposed. Sure, no problem, I'll change in v2 I am not sure about

Re: [Swan-dev] [libreswan RFC 2/3] pluto, whack: Add nic-offload 'auto' mode

2017-07-31 Thread Ilan Tayari
> -Original Message- > From: Antony Antony [mailto:ant...@phenome.org] > Subject: Re: [libreswan RFC 2/3] pluto, whack: Add nic-offload 'auto' mode > > Hi Ilan, > Thanks for the patches. > > I reviewed the patches. May be Hugh can clarify the first one. I wonder > the > comment following

Re: [Swan-dev] [libreswan RFC 2/3] pluto, whack: Add nic-offload 'auto' mode

2017-07-24 Thread Antony Antony
Hi Ilan, Thanks for the patches. I reviewed the patches. May be Hugh can clarify the first one. I wonder the comment following that line need to be fix as well. For the second and the third patch here is my suggestion. no|yes|auto is probably better keywords in the libreswan context.