Re: [swift-corelibs-dev] Adding retain to CFCalendar.c - SR2879

2016-10-07 Thread Tony Parker via swift-corelibs-dev
Yes, that was the “skirting of the issue”. =) It’s likely not a huge deal in the end; since CF is an implementation detail of swift-corelibs-foundation, we just need to remember to retain/release constant strings as we would others and we would be ok. However, I suspect there are other places i

Re: [swift-corelibs-dev] Adding retain to CFCalendar.c - SR2879

2016-10-07 Thread Alex Blewitt via swift-corelibs-dev
That's what I was expecting, too, but then I found this: https://github.com/apple/swift-corelibs-foundation/blob/1a76e814212e781a9d50782ee24117760cfe9b48/CoreFoundation/Base.subproj/CFInternal.h#L387-L389

Re: [swift-corelibs-dev] Adding retain to CFCalendar.c - SR2879

2016-10-07 Thread Tony Parker via swift-corelibs-dev
Hi Alex, Thanks for digging into this. This seems like a correct solution for now. I think there is a larger question though, which is why it’s possible to overrelease kCFEmptyString. I think we skirted the issue early in bringup of SCL-Foundation, but constant strings are supposed to be “pinne

[swift-corelibs-dev] Adding retain to CFCalendar.c - SR2879

2016-10-07 Thread Alex Blewitt via swift-corelibs-dev
I'm looking at https://bugs.swift.org/browse/SR-2879 which is exposing itself through an over-release of a constant CF string (in this case, kCFEmptyString). I don't believe it to be a Swift related problem, because Swift doesn't get into the internals of