Re: [swift-corelibs-dev] NSURLSession & libcurl

2016-04-20 Thread Daniel Dunbar via swift-corelibs-dev
ple.com>> >> From: Daniel Eggert mailto:danielegg...@me.com>> >> Date: 04/19/2016 08:21PM >> Cc: Pushkar N Kulkarni/India/IBM@IBMIN, Swift corelibs dev >> mailto:swift-corelibs-dev@swift.org>> >> Subject: Re: [swift-corelibs-dev] NSURLSession & lib

Re: [swift-corelibs-dev] NSURLSession & libcurl

2016-04-20 Thread Daniel Eggert via swift-corelibs-dev
gt; Simplicity is prerequisite for reliability - Edsger W. Dijkstra > > > > -Daniel Eggert wrote: - > To: Tony Parker > From: Daniel Eggert > Date: 04/19/2016 08:21PM > Cc: Pushkar N Kulkarni/India/IBM@IBMIN, Swift corelibs dev > > Subject: Re: [swift-co

Re: [swift-corelibs-dev] NSURLSession & libcurl

2016-04-20 Thread Pushkar N Kulkarni via swift-corelibs-dev
Hi Tony, Daniel, Thanks for your responses. Would it be acceptable if, for now, we check for the availability of Dispatch and conditionally compile calls to it into the current implementation of NSURLSession* (something like the  _HAS_DISPATCH__ macro used in CoreFoundation)? This would make NSURLS

Re: [swift-corelibs-dev] NSURLSession & libcurl

2016-04-19 Thread Daniel Eggert via swift-corelibs-dev
gt; >> Thanks! >> >> Pushkar N Kulkarni, >> IBM Runtimes >> >> Simplicity is prerequisite for reliability - Edsger W. Dijkstra >> >> >> >> -swift-corelibs-dev-boun...@swift.org wrote: - >> To: Swift corelibs dev >> Fr

Re: [swift-corelibs-dev] NSURLSession & libcurl

2016-04-18 Thread Tony Parker via swift-corelibs-dev
org> wrote: - > To: Swift corelibs dev <mailto:swift-corelibs-dev@swift.org>> > From: Daniel Eggert via swift-corelibs-dev > Sent by: swift-corelibs-dev-boun...@swift.org > <mailto:swift-corelibs-dev-boun...@swift.org> > Date: 04/05/2016 12:14AM > Subject

Re: [swift-corelibs-dev] NSURLSession & libcurl

2016-04-18 Thread Pushkar N Kulkarni via swift-corelibs-dev
Thanks for your great work on NSURLSession and friends, Daniel!I was wondering if we are only waiting for dispatch to be available on Linux here. In that case, could we have the failing tests (if any) excluded (only on Linux perhaps) and have this merged please? Some of us at IBM would like to work

Re: [swift-corelibs-dev] NSURLSession & libcurl

2016-04-04 Thread Daniel Eggert via swift-corelibs-dev
I won't be able to put too many more hours into this after next week. https://github.com/apple/swift-corelibs-foundation/pull/299 Feedback is very welcome. The tests show what's working, and there are "TODO:" markers throughout the code where applicable. /Daniel __

Re: [swift-corelibs-dev] NSURLSession & libcurl

2016-03-30 Thread Daniel Eggert via swift-corelibs-dev
Changes since last week: NSURLSessionDataTask (i.e. GET requests) now work with callbacks and with completion handler. Debug output is enabled by environment variables. Handling a few common error scenarios to return the corresponding NSError. /Daniel _

Re: [swift-corelibs-dev] NSURLSession & libcurl

2016-03-23 Thread Daniel Eggert via swift-corelibs-dev
I've created this pull request in an attempt to get more feedback on my approach. I hope this is in line with the contribution guidelines. https://github.com/apple/swift-corelibs-foundation/pull/299 This is will work-in-progress and marked as such. /Daniel _

Re: [swift-corelibs-dev] NSURLSession & libcurl

2016-03-23 Thread Daniel Eggert via swift-corelibs-dev
> On 23 Mar 2016, at 14:44, Philippe Hausler wrote: > > The swift-corelibs-foundation version of CF is a static library that is being > built into the Foundation product dynamic library so the linkage for libxml2 > and anything else should be on that. > > The layout of how linking works for t

Re: [swift-corelibs-dev] NSURLSession & libcurl

2016-03-23 Thread Philippe Hausler via swift-corelibs-dev
The swift-corelibs-foundation version of CF is a static library that is being built into the Foundation product dynamic library so the linkage for libxml2 and anything else should be on that. The layout of how linking works for the Darwin version is different because of how we split the layers.

Re: [swift-corelibs-dev] NSURLSession & libcurl

2016-03-23 Thread Daniel Eggert via swift-corelibs-dev
> On 14 Mar 2016, at 18:29, Robert Stephen Thompson > wrote: > > Just a couple of tips based on my experience wrapping libxml2 for > NSXMLDocument: > 1. You’ll need to actually import and link libcurl with CoreFoundation > instead of trying to make a libcurl module.modulemap and importing it

Re: [swift-corelibs-dev] NSURLSession & libcurl

2016-03-19 Thread Tony Parker via swift-corelibs-dev
Awesome, thanks for taking this on! - Tony > On Mar 17, 2016, at 12:33 PM, Daniel Eggert via swift-corelibs-dev > wrote: > > I’ve made good progress on this. I’ll try to get something that’s merge-able > within the next week. It won’t be 100% complete by any means, but should > hopefully (A)

Re: [swift-corelibs-dev] NSURLSession & libcurl

2016-03-18 Thread Daniel Eggert via swift-corelibs-dev
I’ve made good progress on this. I’ll try to get something that’s merge-able within the next week. It won’t be 100% complete by any means, but should hopefully (A) cover the most common use cases, and (B) be a solid basis for the remaining functionality. /Daniel > On 15 Mar 2016, at 15:12, Ph

Re: [swift-corelibs-dev] NSURLSession & libcurl

2016-03-15 Thread Philippe Hausler via swift-corelibs-dev
That seems pretty reasonable to me, I guess the only thing to watch out for is private vs internal. Sent from my iPhone > On Mar 15, 2016, at 2:44 AM, Daniel Eggert wrote: > > Is it ok for me to split the libcurl specific code inside Foundation into a > separate file, say NSURLSession+curl.sw

Re: [swift-corelibs-dev] NSURLSession & libcurl

2016-03-15 Thread Daniel Eggert via swift-corelibs-dev
Is it ok for me to split the libcurl specific code inside Foundation into a separate file, say NSURLSession+curl.swift ? Or should I try to keep everything inside NSURLSession.swift ? If I go for a separate file, I'd be able to differentiate between internal and private for the helpers. I'll en