[swift-corelibs-dev] More on the memory leak in NSString/String.cString(with:)

2017-03-09 Thread Pushkar N Kulkarni via swift-corelibs-dev
Hello there,  We have been talking about a known memory leak in String.cString(using: encoding) and String.utf8String over a JIRA report and a closed PR where we considered the option of  freeing up the memory allocated by NSString.cString() in String.cString() - this approach isn’t acceptable

Re: [swift-corelibs-dev] URLSession test fest!

2017-03-09 Thread Pushkar N Kulkarni via swift-corelibs-dev
Peter: I agree. A stable testing infrastructure is absolutely necessary.  Tony: I am curious about where the sources for these tests (that use the external httpbin.org) will be placed? Will it makes sense to have them in TestFoundation and have a guard to exclude them during normal test

Re: [swift-corelibs-dev] URLSession test fest!

2017-03-09 Thread Peter Tomaselli via swift-corelibs-dev
Just one outside data point on this: as someone who's been wanting to contribute to the test fest, I agree that being able to test against httpbin.org (or some other pre-existing server — as opposed to the loopback server) would make it much easier to make useful contributions. Not that the

Re: [swift-corelibs-dev] URLSession test fest!

2017-03-09 Thread Tony Parker via swift-corelibs-dev
Hi Pushkar, Another option is to continue to use httpbin.org , but make the tests that use that network service not part of the normal unit tests but runnable on demand by us as we develop. That means we don’t have to reimplement the whole thing but we at least have some

Re: [swift-corelibs-dev] URLSession test fest!

2017-03-09 Thread Pushkar N Kulkarni via swift-corelibs-dev
Hi Tony, PRs 911 and 913 reminded me of this conversation you started. The current unit testing infrastructure for URLSession may prove insufficient for future contributions. I've been looking at these tests written by Mike Ferenduros and they appear quite exhaustive! The only issue is that they