Re: [swift-corelibs-dev] NSTask and try!

2016-05-14 Thread James Lee via swift-corelibs-dev
Cheers for the clarification. I will spend some time working through some of the other failures, should help me get to grips with it all :) James Sent from my iPhone > On 14 May 2016, at 15:02, Bouke Haarsma via swift-corelibs-dev > wrote: > > On 2016-05-14

Re: [swift-corelibs-dev] NSTask and try!

2016-05-14 Thread Bouke Haarsma via swift-corelibs-dev
On 2016-05-14 09:05:08 +, James Lee via swift-corelibs-dev said: Please excuse my ignorance, I have looked into the POSIX calls, but am I right in assuming that the EBADF is due to the test calling to a file that doesn't exist and that is just how OSX handles this case? The problem on

Re: [swift-corelibs-dev] NSTask and try!

2016-05-14 Thread James Lee via swift-corelibs-dev
This does seem to keep more inline with the current Darwin implementation. Please excuse my ignorance, I have looked into the POSIX calls, but am I right in assuming that the EBADF is due to the test calling to a file that doesn't exist and that is just how OSX handles this case? Cheers for

Re: [swift-corelibs-dev] NSTask and try!

2016-05-14 Thread Bouke Haarsma via swift-corelibs-dev
The failing testcase is TestNSTask.test_pipe_stdout_and_stderr_same_pipe. The call to posix_spawn returns an error code 9 (EBADF). In order to avoid code repetition I've wrapped all posix calls with a throwing status code check; private func posix(_ code: Int32) throws { switch code {

Re: [swift-corelibs-dev] NSTask and try!

2016-05-13 Thread Tony Parker via swift-corelibs-dev
> On May 13, 2016, at 1:05 PM, James Lee wrote: > > Cheers for the clarification. I started assuming there may be a reason when > changing the guard let on the launch args to use the InvalidArgumentException. > > Could this be a position where we may need os checking to

Re: [swift-corelibs-dev] NSTask and try!

2016-05-13 Thread James Lee via swift-corelibs-dev
Cheers for the clarification. I started assuming there may be a reason when changing the guard let on the launch args to use the InvalidArgumentException. Could this be a position where we may need os checking to cover the regression for the moment. It seems odd that the test would pass in CI

Re: [swift-corelibs-dev] NSTask and try!

2016-05-13 Thread Tony Parker via swift-corelibs-dev
Hi James, > On May 13, 2016, at 12:25 PM, James Lee via swift-corelibs-dev > wrote: > > Following on from a previous discussion with Tests failing on OSX. I have > been looking into the failures. It seems that one of the earliest failures is > due to an error

[swift-corelibs-dev] NSTask and try!

2016-05-13 Thread James Lee via swift-corelibs-dev
Following on from a previous discussion with Tests failing on OSX. I have been looking into the failures. It seems that one of the earliest failures is due to an error from a try! within NSTask.launch(). This came in with this commit: