Re: [swift-dev] Resilient dynamic dispatch ABI. Notes and mini-proposal.

2017-02-03 Thread John McCall via swift-dev
> On Feb 3, 2017, at 7:06 PM, Andrew Trick wrote: >> On Feb 3, 2017, at 3:12 PM, John McCall > > wrote: >> >> I think we can generalize this discussion a bit by describing some >> mostly-independent axes of variation: > > That's great (sorry I used up the arabic+lette

Re: [swift-dev] Resilient dynamic dispatch ABI. Notes and mini-proposal.

2017-02-03 Thread John McCall via swift-dev
> On Feb 3, 2017, at 7:12 PM, Joe Groff via swift-dev > wrote: > Given that most open-coded resilient method lookup paths require an extra > load dependency to grab the method offset before loading the method address > itself, we might possibly consider indirecting the vtables for each class, s

Re: [swift-dev] Resilient dynamic dispatch ABI. Notes and mini-proposal.

2017-02-03 Thread Joe Groff via swift-dev
Given that most open-coded resilient method lookup paths require an extra load dependency to grab the method offset before loading the method address itself, we might possibly consider indirecting the vtables for each class, so that the top-level vtable contains [address of root class vtable, ad

Re: [swift-dev] Resilient dynamic dispatch ABI. Notes and mini-proposal.

2017-02-03 Thread Andrew Trick via swift-dev
> On Feb 3, 2017, at 3:12 PM, John McCall wrote: > > I think we can generalize this discussion a bit by describing some > mostly-independent axes of variation: That's great (sorry I used up the arabic+letter naming convention earlier in the thread)... > I. A call site: > I1) inlines the loo

Re: [swift-dev] Resilient dynamic dispatch ABI. Notes and mini-proposal.

2017-02-03 Thread John McCall via swift-dev
> On Feb 3, 2017, at 2:55 PM, Andrew Trick wrote: >> On Feb 3, 2017, at 10:58 AM, John McCall wrote: >> >>> On Feb 2, 2017, at 9:57 PM, Andrew Trick via swift-dev >>> wrote: >>> --- >>> #1. (thunk export) The simplest, most flexible way to expose dispatch >>> across resilience boundaries is by

Re: [swift-dev] Resilient dynamic dispatch ABI. Notes and mini-proposal.

2017-02-03 Thread Andrew Trick via swift-dev
> On Feb 3, 2017, at 1:27 PM, John McCall wrote: > >> On Feb 3, 2017, at 4:18 PM, Andrew Trick > > wrote: >>> On Feb 3, 2017, at 11:55 AM, Andrew Trick via swift-dev >>> mailto:swift-dev@swift.org>> wrote: >>> > #3b. (lazy resolution) Offset tables can be completel

Re: [swift-dev] Resilient dynamic dispatch ABI. Notes and mini-proposal.

2017-02-03 Thread John McCall via swift-dev
> On Feb 3, 2017, at 4:18 PM, Andrew Trick wrote: >> On Feb 3, 2017, at 11:55 AM, Andrew Trick via swift-dev > > wrote: >> #3b. (lazy resolution) Offset tables can be completely localized. method_index = immediate { // common per-class method looku

Re: [swift-dev] Resilient dynamic dispatch ABI. Notes and mini-proposal.

2017-02-03 Thread Andrew Trick via swift-dev
> On Feb 3, 2017, at 11:55 AM, Andrew Trick via swift-dev > wrote: > >>> #3b. (lazy resolution) Offset tables can be completely localized. >>> >>> method_index = immediate >>> { // common per-class method lookup >>> isa = load[obj] >>> offset = load[@local_class_method_table + method_index]

Re: [swift-dev] Resilient dynamic dispatch ABI. Notes and mini-proposal.

2017-02-03 Thread Andrew Trick via swift-dev
> On Feb 3, 2017, at 10:58 AM, John McCall wrote: > >> On Feb 2, 2017, at 9:57 PM, Andrew Trick via swift-dev >> wrote: >> --- >> #1. (thunk export) The simplest, most flexible way to expose dispatch >> across resilience boundaries is by exporting a single per-method entry >> point. Future com

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (master) #1699

2017-02-03 Thread Douglas Gregor via swift-dev
> On Feb 3, 2017, at 11:12 AM, Michael Ilseman wrote: > > Is that a missing dependency in CMake then? They’re totally separate projects (swift vs. swift-corelibs-foundation), so it’s an issue with cross-project dependencies. - Doug > >> On Feb 3, 2017, at 10:40 AM, Douglas Gregor >

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (master) #1699

2017-02-03 Thread Michael Ilseman via swift-dev
Is that a missing dependency in CMake then? > On Feb 3, 2017, at 10:40 AM, Douglas Gregor wrote: > >> >> On Feb 3, 2017, at 10:37 AM, Ankit Aggarwal > > wrote: >> >> >>> On 03-Feb-2017, at 11:55 PM, Douglas Gregor >> > wrote: >>> >>>

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (master) #1704

2017-02-03 Thread Douglas Gregor via swift-dev
Ugh, standard library isn’t getting rebuilt. Clearing the workspace… - Doug > On Feb 3, 2017, at 10:57 AM, no-re...@swift.org wrote: > > [FAILURE] oss-swift-incremental-RA-linux-ubuntu-16_10 [#1704] > > Build URL: > https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-16_1

Re: [swift-dev] Resilient dynamic dispatch ABI. Notes and mini-proposal.

2017-02-03 Thread John McCall via swift-dev
> On Feb 2, 2017, at 9:57 PM, Andrew Trick via swift-dev > wrote: > > I'm following up on a resilient dynamic dispatch discussion kicked off by > Slava during a performance team meeting to summarize some key > points on public [swift-dev]. > > It's easy to get sidetracked by the details of dyna

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (master) #1699

2017-02-03 Thread Douglas Gregor via swift-dev
> On Feb 3, 2017, at 10:37 AM, Ankit Aggarwal wrote: > > >> On 03-Feb-2017, at 11:55 PM, Douglas Gregor > > wrote: >> >> >>> On Feb 3, 2017, at 10:24 AM, Michael Ilseman >> > wrote: >>> >>> Doug G, is this this same issue you’re working on

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (master) #1699

2017-02-03 Thread Ankit Aggarwal via swift-dev
> On 03-Feb-2017, at 11:55 PM, Douglas Gregor wrote: > > >> On Feb 3, 2017, at 10:24 AM, Michael Ilseman > > wrote: >> >> Doug G, is this this same issue you’re working on, or a different one? > > Oooh, could be different! Ankit, is this only on Linux? > Looks lik

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (master) #1699

2017-02-03 Thread Douglas Gregor via swift-dev
> On Feb 3, 2017, at 10:24 AM, Michael Ilseman wrote: > > Doug G, is this this same issue you’re working on, or a different one? Oooh, could be different! Ankit, is this only on Linux? - Doug > > >> On Feb 3, 2017, at 5:52 AM, Ankit Aggarwal > > wrot

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (master) #1699

2017-02-03 Thread Michael Ilseman via swift-dev
Doug G, is this this same issue you’re working on, or a different one? > On Feb 3, 2017, at 5:52 AM, Ankit Aggarwal wrote: > > Hm there is a compiler crash is in SwiftPM's Basic module but that wasn't > touched by my commit. > > > Compile Swift Module 'Basic' (23 sources) > swift: > /home/b

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.10 - Long Test (master) #658

2017-02-03 Thread Andrew Trick via swift-dev
I don’t know what this could have to do with the changes in Runtime.swift. Speculatively reverting until it clears up: https://github.com/apple/swift/pull/7227 ArchetypeBuilder.cpp:2461: auto swift::ArchetypeBuilder::getGenericEnvironment(swift::GenericSignature *)::(anonymous class)::operator(

Re: [swift-dev] [Swift CI] Build Still Failing: 1. OSS - Swift (Tools Opt+Assert, Stdlib Opt+DebInfo+Assert, Resilience) - macOS (master) #99

2017-02-03 Thread Jordan Rose via swift-dev
/Users/buildnode/jenkins/workspace/oss-swift_tools-RA_stdlib-RDA_test-macos-resilience/swift/test/Prototypes/TextFormatting.swift:118:3: error: initializer declared in an extension of non-'@_fixed_layout' type 'Integer' must delegate to another initializer init (_ i: N) { ^ Huge blamelist he

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (master) #1693

2017-02-03 Thread Arnold Schwaighofer via swift-dev
Yes. https://bugs.swift.org/browse/SR-1517 https://bugs.swift.org/browse/SR-3621 > On Feb 2, 2017, at 10:18 PM, Douglas Gregor via swift-dev > wrote: > > /home/buildnode/jenkins/workspace/oss-swift-incremental-RA-linux-ubuntu-16_10/buildbot_incremental/foundation-linux-x86_64/TestFoundation/Te

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (master) #1699

2017-02-03 Thread Ankit Aggarwal via swift-dev
Hm there is a compiler crash is in SwiftPM's Basic module but that wasn't touched by my commit. Compile Swift Module 'Basic' (23 sources) swift: /home/buildnode/disk1/workspace/oss-swift-incremental-RA-linux-ubuntu-16_10/swift/lib/AST/ArchetypeBuilder.cpp:2461: auto swift::ArchetypeBuilder::ge

[swift-dev] [Swift CI] Build Still Failing: 1. OSS - Swift (Tools Opt+Assert, Stdlib Opt+DebInfo+Assert, Resilience) - macOS (master) #99

2017-02-03 Thread no-reply--- via swift-dev
New issue found!Title: Report [FAILURE] oss-swift_tools-RA_stdlib-RDA_test-macos-resilience [#99] Build URL:https://ci.swift.org/job/oss-swift_tools-RA_stdlib-RDA_test-macos-resilience/99/ Project:oss-swift_tools-RA_stdlib-RDA_test-macos-resilience Date of build:Fri, 03 Feb 2