Re: [swift-dev] [Swift CI] Build Still Failing: 0. OSS - Swift Incremental RA - OS X (master) #8252

2017-02-06 Thread David Farler via swift-dev
Mishal just kicked a workspace clean on all of the machines to see if this clears things up. > On Feb 6, 2017, at 5:59 PM, no-re...@swift.org wrote: > > New issue found! > > [FAILURE] oss-swift-incremental-RA-osx [#8252] > > Build URL:https://ci.swift.org/job/oss-swift-incremental-RA-osx/8

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - OS X (master) #8242

2017-02-06 Thread David Farler via swift-dev
Also a case of rdar://problem/30381981 . David > On Feb 6, 2017, at 1:44 PM, no-re...@swift.org wrote: > > [FAILURE] oss-swift-incremental-RA-osx [#8242] > > Build URL:https://ci.swift.org/job/oss-swift-incremental-RA-osx/8242/ >

Re: [swift-dev] [Swift CI] Build Still Failing: 0. OSS - Swift Incremental RA - OS X (master) #8247

2017-02-06 Thread David Farler via swift-dev
This looks like it might be isolated to this machine: rdar://problem/30381981 . David > On Feb 6, 2017, at 3:40 PM, no-re...@swift.org wrote: > > New issue found! > > [FAILURE] oss-swift-incremental-RA-osx [#8247] > > Build URL:https://ci.swift.org/job/oss-swift-incremental-RA-osx/8247/

[swift-dev] CI outage tomorrow for upgrade

2017-02-06 Thread Nicole Jacque via swift-dev
Hi All- We will have a CI outage for a couple of hours tomorrow starting at 11 Pacific, in order to upgrade the CI machines to the latest Xcode beta and SDKs, and push back some content in support of the new SDKs. We’ll send out a message when the upgrade is complete. As mentioned in the Swi

Re: [swift-dev] No return functions and program exit

2017-02-06 Thread Michael Gottesman via swift-dev
> On Feb 6, 2017, at 3:41 PM, Erik Eckstein wrote: > > I’m not sure if I understood. > What if there is a call to a function and that conditionally calls a noreturn > function: > > func foo() { > let x = Myclass() > bar(true) > // release x here? > } > > func bar(_ dontReturn: Bool) { >

Re: [swift-dev] No return functions and program exit

2017-02-06 Thread Erik Eckstein via swift-dev
I’m not sure if I understood. What if there is a call to a function and that conditionally calls a noreturn function: func foo() { let x = Myclass() bar(true) // release x here? } func bar(_ dontReturn: Bool) { if (dontReturn) { noreturn_func() } } Is it even possible to “clean up

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (master) #1699

2017-02-06 Thread Erik Eckstein via swift-dev
> On Feb 6, 2017, at 2:17 PM, mishal_shah wrote: > > Hi Erik, > > Please try “@swift-ci Please clean test”. This will clean up the workspace > before building. Thanks! That worked! > > Thanks, > Mishal Shah >> On Feb 6, 2017, at 2:08 PM, Erik Eckstein via swift-dev >

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (master) #1699

2017-02-06 Thread mishal_shah via swift-dev
Hi Erik, Please try “@swift-ci Please clean test”. This will clean up the workspace before building. Thanks, Mishal Shah > On Feb 6, 2017, at 2:08 PM, Erik Eckstein via swift-dev > wrote: > > Is there a workaround? > PR testing is blocked on this. > >> On Feb 3, 2017, at 11:13 AM, Douglas

Re: [swift-dev] Resilient dynamic dispatch ABI. Notes and mini-proposal.

2017-02-06 Thread Dave Abrahams via swift-dev
on Mon Feb 06 2017, John McCall wrote: >> On Feb 4, 2017, at 6:45 PM, Dave Abrahams via swift-dev >> wrote: >> on Fri Feb 03 2017, John McCall wrote: >> On Feb 3, 2017, at 7:12 PM, Joe Groff via swift-dev wrote: Given that most open-coded resilient method lookup paths requir

Re: [swift-dev] Resilient dynamic dispatch ABI. Notes and mini-proposal.

2017-02-06 Thread John McCall via swift-dev
> On Feb 4, 2017, at 5:35 AM, Andrew Trick wrote: > > >> On Feb 3, 2017, at 9:37 PM, John McCall > > wrote: >> IV. The function that performs the lookup: IV1) is parameterized by an isa IV2) is not parameterized by an isa IV1 allows the same fun

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (master) #1699

2017-02-06 Thread Erik Eckstein via swift-dev
Is there a workaround? PR testing is blocked on this. > On Feb 3, 2017, at 11:13 AM, Douglas Gregor via swift-dev > wrote: > > >> On Feb 3, 2017, at 11:12 AM, Michael Ilseman > > wrote: >> >> Is that a missing dependency in CMake then? > > They’re totally separate

Re: [swift-dev] Resilient dynamic dispatch ABI. Notes and mini-proposal.

2017-02-06 Thread John McCall via swift-dev
> On Feb 4, 2017, at 6:45 PM, Dave Abrahams via swift-dev > wrote: > on Fri Feb 03 2017, John McCall wrote: > >>> On Feb 3, 2017, at 7:12 PM, Joe Groff via swift-dev >>> wrote: >>> Given that most open-coded resilient method lookup paths require an >>> extra load dependency to grab the method

Re: [swift-dev] No return functions and program exit

2017-02-06 Thread Michael Gottesman via swift-dev
> On Feb 6, 2017, at 11:44 AM, Jordan Rose wrote: > > >> On Feb 6, 2017, at 11:25, Joe Groff via swift-dev > > wrote: >> >> >>> On Feb 6, 2017, at 11:22 AM, Michael Gottesman >> > wrote: >>> >>> Here is my suggestion: >>> >>> 1. We as

Re: [swift-dev] Resilient dynamic dispatch ABI. Notes and mini-proposal.

2017-02-06 Thread John McCall via swift-dev
> On Feb 6, 2017, at 1:23 PM, Joe Groff wrote: >> On Feb 3, 2017, at 8:47 PM, John McCall > > wrote: >> >>> On Feb 3, 2017, at 7:12 PM, Joe Groff via swift-dev >> > wrote: >>> Given that most open-coded resilient method lookup paths require a

Re: [swift-dev] No return functions and program exit

2017-02-06 Thread Jordan Rose via swift-dev
> On Feb 6, 2017, at 11:25, Joe Groff via swift-dev wrote: > > >> On Feb 6, 2017, at 11:22 AM, Michael Gottesman wrote: >> >> Here is my suggestion: >> >> 1. We assume by default the leaking case. >> 2. We change noreturn functions from C to maybe have a special semantic tag >> on them that

Re: [swift-dev] No return functions and program exit

2017-02-06 Thread John McCall via swift-dev
> On Feb 6, 2017, at 2:25 PM, Joe Groff via swift-dev > wrote: >> On Feb 6, 2017, at 11:22 AM, Michael Gottesman wrote: >> >> Here is my suggestion: >> >> 1. We assume by default the leaking case. >> 2. We change noreturn functions from C to maybe have a special semantic tag >> on them that s

Re: [swift-dev] No return functions and program exit

2017-02-06 Thread Michael Gottesman via swift-dev
SGTM! Michael > On Feb 6, 2017, at 11:25 AM, Joe Groff wrote: > > >> On Feb 6, 2017, at 11:22 AM, Michael Gottesman wrote: >> >> Here is my suggestion: >> >> 1. We assume by default the leaking case. >> 2. We change noreturn functions from C to maybe have a special semantic tag >> on them

Re: [swift-dev] No return functions and program exit

2017-02-06 Thread Michael Gottesman via swift-dev
Here is my suggestion: 1. We assume by default the leaking case. 2. We change noreturn functions from C to maybe have a special semantic tag on them that says that cleanups should occur before them (i.e. UIApplicationMain). How does that sound? Michael > On Feb 6, 2017, at 11:08 AM, Joe Groff

Re: [swift-dev] No return functions and program exit

2017-02-06 Thread Joe Groff via swift-dev
> On Feb 6, 2017, at 11:22 AM, Michael Gottesman wrote: > > Here is my suggestion: > > 1. We assume by default the leaking case. > 2. We change noreturn functions from C to maybe have a special semantic tag > on them that says that cleanups should occur before them (i.e. > UIApplicationMain).

Re: [swift-dev] Resilient dynamic dispatch ABI. Notes and mini-proposal.

2017-02-06 Thread Joe Groff via swift-dev
> On Feb 5, 2017, at 7:45 AM, Karl Wagner via swift-dev > wrote: > > >> On 3 Feb 2017, at 03:57, Andrew Trick via swift-dev > > wrote: >> >> I'm following up on a resilient dynamic dispatch discussion kicked off by >> Slava during a performance team meeting to summ

Re: [swift-dev] No return functions and program exit

2017-02-06 Thread Joe Groff via swift-dev
> On Feb 6, 2017, at 11:04 AM, Michael Gottesman wrote: > >> >> On Feb 6, 2017, at 10:04 AM, Joe Groff wrote: >> >> >>> On Feb 6, 2017, at 9:48 AM, Michael Gottesman via swift-dev >>> wrote: >>> >>> One thing that is an issue that has come up with ownership is that at the >>> SIL level w

Re: [swift-dev] No return functions and program exit

2017-02-06 Thread Michael Gottesman via swift-dev
> On Feb 6, 2017, at 10:04 AM, Joe Groff wrote: > > >> On Feb 6, 2017, at 9:48 AM, Michael Gottesman via swift-dev >> wrote: >> >> One thing that is an issue that has come up with ownership is that at the >> SIL level we do not distinguish in between exceptional noreturn functions >> and e

Re: [swift-dev] Resilient dynamic dispatch ABI. Notes and mini-proposal.

2017-02-06 Thread Andrew Trick via swift-dev
> On Feb 5, 2017, at 7:45 AM, Karl Wagner wrote: > > I have a question about current dispatching behaviour with protocols and > ‘Self’. > > protocol CustomEquatable { > func equal(to: Self) -> Bool > } > > open class Super : CustomEquatable { > func equal(to: Super) -> Bool { print("s

Re: [swift-dev] Resilient dynamic dispatch ABI. Notes and mini-proposal.

2017-02-06 Thread Joe Groff via swift-dev
> On Feb 3, 2017, at 8:47 PM, John McCall wrote: > >> On Feb 3, 2017, at 7:12 PM, Joe Groff via swift-dev > > wrote: >> Given that most open-coded resilient method lookup paths require an extra >> load dependency to grab the method offset before loading the method ad

Re: [swift-dev] No return functions and program exit

2017-02-06 Thread Michael Gottesman via swift-dev
> On Feb 6, 2017, at 10:05 AM, Joe Groff wrote: > > >> On Feb 6, 2017, at 10:02 AM, Jordan Rose via swift-dev >> wrote: >> >> I’ve said this Michael in person, but I’ll put it on the thread for others >> to see: >> >> I don’t think modeling this is worth the increase in complexity. There’s

Re: [swift-dev] No return functions and program exit

2017-02-06 Thread Joe Groff via swift-dev
> On Feb 6, 2017, at 10:02 AM, Jordan Rose via swift-dev > wrote: > > I’ve said this Michael in person, but I’ll put it on the thread for others to > see: > > I don’t think modeling this is worth the increase in complexity. There’s a > partial workaround for anyone who notices this being a p

Re: [swift-dev] No return functions and program exit

2017-02-06 Thread Joe Groff via swift-dev
> On Feb 6, 2017, at 9:48 AM, Michael Gottesman via swift-dev > wrote: > > One thing that is an issue that has come up with ownership is that at the SIL > level we do not distinguish in between exceptional noreturn functions and > exceptional return functions. > > This is important since in

Re: [swift-dev] No return functions and program exit

2017-02-06 Thread Jordan Rose via swift-dev
I’ve said this Michael in person, but I’ll put it on the thread for others to see: I don’t think modeling this is worth the increase in complexity. There’s a partial workaround for anyone who notices this being a problem, which is to put any expensive work in a ‘do’ block. And actually emitting

Re: [swift-dev] Resilient dynamic dispatch ABI. Notes and mini-proposal.

2017-02-06 Thread Andrew Trick via swift-dev
> On Feb 3, 2017, at 4:12 PM, Joe Groff wrote: > > Given that most open-coded resilient method lookup paths require an extra > load dependency to grab the method offset before loading the method address > itself, we might possibly consider indirecting the vtables for each class, so > that the

[swift-dev] No return functions and program exit

2017-02-06 Thread Michael Gottesman via swift-dev
One thing that is an issue that has come up with ownership is that at the SIL level we do not distinguish in between exceptional noreturn functions and exceptional return functions. This is important since in the non-exceptional case, we would like to clean up all of the values used in the curr

Re: [swift-dev] Resilient dynamic dispatch ABI. Notes and mini-proposal.

2017-02-06 Thread Andrew Trick via swift-dev
> On Feb 6, 2017, at 9:02 AM, Greg Parker wrote: > >> >> On Feb 4, 2017, at 2:35 AM, Andrew Trick via swift-dev > > wrote: >> >> >>> On Feb 3, 2017, at 9:37 PM, John McCall >> > wrote: >>> > IV. The function that performs the lookup:

[swift-dev] Compiler/Migration Resources

2017-02-06 Thread Juan Ceasar via swift-dev
Good Morning, I was wondering, can anyone point me towards where the compiler/migration resources are to create the .remap files? I wanted to try a little tweak locally but not quite sure where things are being imported from… Thanks ___ swift-dev ma

Re: [swift-dev] Resilient dynamic dispatch ABI. Notes and mini-proposal.

2017-02-06 Thread Greg Parker via swift-dev
> On Feb 4, 2017, at 2:35 AM, Andrew Trick via swift-dev > wrote: > > >> On Feb 3, 2017, at 9:37 PM, John McCall > > wrote: >> IV. The function that performs the lookup: IV1) is parameterized by an isa IV2) is not parameterized by an isa IV1 al