Re: [swift-dev] Debugging performance regressions?

I think that my change exposed a latent performance bug in the constraint solver. Let’s followup in a bug report: https://bugs.swift.org/browse/SR-5669 > On Aug 9, 2017, at 16:47, Mark Lacey wrote: > > > >> On Aug 9, 2017, at 11:33 AM, Arnold Schwaig

Re: [swift-dev] Debugging performance regressions?

> On Aug 9, 2017, at 11:33 AM, Arnold Schwaighofer > wrote: > > Mark do you have suggestions for Dave? I’d suggest something similar to what Pavel said. My usual first step is to look at the output of -Xfrontend -debug-constraints, which in cases like this tends to be so verbose that you ha

Re: [swift-dev] Debugging performance regressions?

> On Aug 9, 2017, at 11:34 AM, Arnold Schwaighofer via swift-dev > wrote: > > Mark do you have suggestions for Dave? Also, whatever comes from this, can we document in updating the compiler. > >> On Aug 9, 2017, at 11:22 AM, David Zarzycki via swift-dev >> mailto:swift-dev@swift.org>> wrote

Re: [swift-dev] Debugging performance regressions?

Mark do you have suggestions for Dave? > On Aug 9, 2017, at 11:22 AM, David Zarzycki via swift-dev > wrote: > > Any tips on how to debug performance regressions? > > And as aside, if this test is critical enough to cause a revert, why isn’t it > in the public repo? > This is part of a large

Re: [swift-dev] Debugging performance regressions?

Hi David, What I usually do is - lldb with debug build, or debug build REPL with ":constraints debug on" which is going to print what type checker is doing and attach using lldb or Xcode. This example definitely belongs in the repo, I will add it right away. Best Regards, Pavel. On We

[swift-dev] Debugging performance regressions?

Any tips on how to debug performance regressions? And as aside, if this test is critical enough to cause a revert, why isn’t it in the public repo? > On Aug 9, 2017, at 14:04, Arnold Schwaighofer > wrote: > > Hi Dave, > I have reverted this commit because it broke internal bots. > > import

Re: [swift-dev] 107 lines of "dead" code in ConstraintSystem::performMemberLookup?

I think there are docs on this in the main README or in a CONTRIBUTING file. Mishal (+CC) knows for sure. Michael > On Aug 9, 2017, at 5:41 AM, David Zarzycki via swift-dev > wrote: > > Hi Slava, > > Thanks! I appreciate the suggestion to run tests, but what I’ve tried in the > past, @swift

Re: [swift-dev] 107 lines of "dead" code in ConstraintSystem::performMemberLookup?

Hi Slava, Thanks! I appreciate the suggestion to run tests, but what I’ve tried in the past, @swift-ci ignored me. Is there a whitelist for who can request that tests be run? That would make sense from a security perspective. Dave > On Aug 8, 2017, at 23:48, Slava Pestov wrote: > > I see y