[swift-dev] [Swift CI] Build Failure: OSS - Swift Package - OS X (swift 4.0) #59

2017-08-17 Thread no-reply--- via swift-dev
Title: Report [FAILURE] oss-swift-4.0-package-osx [#59] Build URL:https://ci.swift.org/job/oss-swift-4.0-package-osx/59/ Project:oss-swift-4.0-package-osx Date of build:Thu, 17 Aug 2017 17:39:37 -0500 Build duration:55 min Changes No Changes

Re: [swift-dev] Typos while hacking on the constraint system

2017-08-17 Thread Mark Lacey via swift-dev
> On Aug 17, 2017, at 10:28 AM, David Zarzycki via swift-dev > wrote: > > >> On Aug 17, 2017, at 13:03, Robert Widmann wrote: >> >> It’s an unfortunate naming scheme, but I would hesitate to use notions like >> “from” and “to”, especially in

Re: [swift-dev] [Swift CI] Build Failure: OSS - Swift Package - OS X (swift 4.0) #57

2017-08-17 Thread Mishal Shah via swift-dev
Looking into the failure. > On Aug 17, 2017, at 12:08 PM, no-re...@swift.org wrote: > > [FAILURE] oss-swift-4.0-package-osx [#57] > > Build URL:https://ci.swift.org/job/oss-swift-4.0-package-osx/57/ > Project: oss-swift-4.0-package-osx > Date of build:Thu, 17 Aug 2017 11:16:45

[swift-dev] [Swift CI] Build Failure: OSS - Swift Package - OS X (swift 4.0) #57

2017-08-17 Thread no-reply--- via swift-dev
Title: Report [FAILURE] oss-swift-4.0-package-osx [#57] Build URL:https://ci.swift.org/job/oss-swift-4.0-package-osx/57/ Project:oss-swift-4.0-package-osx Date of build:Thu, 17 Aug 2017 11:16:45 -0500 Build duration:2 hr 53 min Changes No

Re: [swift-dev] Typos while hacking on the constraint system

2017-08-17 Thread David Zarzycki via swift-dev
> On Aug 17, 2017, at 13:03, Robert Widmann wrote: > > It’s an unfortunate naming scheme, but I would hesitate to use notions like > “from” and “to”, especially in CSSimplify where different matchers are handed > types in whatever order variance requires. Thanks Robert,

Re: [swift-dev] Typos while hacking on the constraint system

2017-08-17 Thread Robert Widmann via swift-dev
It’s an unfortunate naming scheme, but I would hesitate to use notions like “from” and “to”, especially in CSSimplify where different matchers are handed types in whatever order variance requires. More critical here are the scoping issues. There are a bunch of places, especially in matchTypes

[swift-dev] Typos while hacking on the constraint system

2017-08-17 Thread David Zarzycki via swift-dev
Hello, More than once, I’ve made typos while hacking on the constraint system because the key variables are often named “type1” and “type2”. Beyond sharing 4 out of 5 characters, the ‘1’ and the ‘2’ are right next to each other on the keyboard, and typing the other by accident results in code