Re: [swift-dev] Adding a field to StrongRefCount class

2017-10-12 Thread Jiho Choi via swift-dev
Now I am finally able to build the Swift runtime with an extended object header and run some benchmarks. For future reference, in addition to making changes similar to the commits which Greg pointed to, I needed to change the Foundation library's CFRuntimeBase class which mirrors the Swift's objec

Re: [swift-dev] Adding a field to StrongRefCount class

2017-09-28 Thread Greg Parker via swift-dev
> On Sep 27, 2017, at 10:39 AM, John McCall via swift-dev > wrote: > >> On Sep 27, 2017, at 1:24 PM, Jiho Choi > > wrote: >> >> Thanks for the explanation. I modified those two locations you mentioned >> but the build failed during tests. I've been browsing the sou

Re: [swift-dev] Adding a field to StrongRefCount class

2017-09-27 Thread John McCall via swift-dev
> On Sep 27, 2017, at 1:24 PM, Jiho Choi wrote: > > Thanks for the explanation. I modified those two locations you mentioned but > the build failed during tests. I've been browsing the source code to figure > out other dependences but didn't succeed yet. Could you please give me some > poin

Re: [swift-dev] Adding a field to StrongRefCount class

2017-09-27 Thread Jiho Choi via swift-dev
Thanks for the explanation. I modified those two locations you mentioned but the build failed during tests. I've been browsing the source code to figure out other dependences but didn't succeed yet. Could you please give me some pointers on where to look at? Regards, Jiho On Tue, Sep 26, 2017

Re: [swift-dev] Adding a field to StrongRefCount class

2017-09-25 Thread John McCall via swift-dev
> On Sep 26, 2017, at 12:56 AM, Jiho Choi via swift-dev > wrote: > I want to add a field to StrongRefCount class for some experiment, but the > build fails while building self-hosted 'swift-build'. I am using the version > 3.1.1. > > Does the shape of StrongRefCount class have any implicit de

[swift-dev] Adding a field to StrongRefCount class

2017-09-25 Thread Jiho Choi via swift-dev
Hi, I want to add a field to StrongRefCount class for some experiment, but the build fails while building self-hosted 'swift-build'. I am using the version 3.1.1. Does the shape of StrongRefCount class have any implicit dependence on other parts of the runtime? What is the correct way to add a