Re: [swift-dev] Request for review on Windows CMake changes

2017-12-12 Thread Greg Parker via swift-dev
> On Dec 12, 2017, at 6:06 PM, Saleem Abdulrasool via swift-dev > wrote: > > The problems with the cross-compiling that Im referring to are not inherent > to CMake (although, I am slightly partial to the autotools approach to > cross-compilation), but rather the way that the tool is being use

Re: [swift-dev] Request for review on Windows CMake changes

2017-12-12 Thread Saleem Abdulrasool via swift-dev
On Tue, Dec 12, 2017 at 4:47 PM, Wallacy wrote: > Has anyone considered the Bezel Build for swift? > > https://bazel.build/ > > Seems to address these problems. I'm sorry, but I fail to see how bazel would address any of these issues. The flags are exported from LLVM's CMake infrastructure. Fi

Re: [swift-dev] Request for review on Windows CMake changes

2017-12-12 Thread Wallacy via swift-dev
Has anyone considered the Bezel Build for swift? https://bazel.build/ Seems to address these problems. Em ter, 12 de dez de 2017 às 19:39, Saleem Abdulrasool via swift-dev < swift-dev@swift.org> escreveu: > On Sat, Dec 9, 2017 at 9:21 AM, David Zarzycki via swift-dev < > swift-dev@swift.org> wr

Re: [swift-dev] Request for review on Windows CMake changes

2017-12-12 Thread Saleem Abdulrasool via swift-dev
On Sat, Dec 9, 2017 at 9:21 AM, David Zarzycki via swift-dev < swift-dev@swift.org> wrote: > Can somebody please also speak up to why Windows needs to remove the > "-Wl,-z,defs” from CXX_FLAGS? At the very least, I’d like to see the > project-wide removal of this useful flag limited to just the Wi

Re: [swift-dev] Request for review on Windows CMake changes

2017-12-11 Thread Michael Gottesman via swift-dev
I'll take a look sometime later in the week. If I forget, ping me next Friday. > On Dec 8, 2017, at 5:36 PM, Thomas Roughton via swift-dev > wrote: > > Hi all, > > I've had a PR (https://github.com/apple/swift/pull/13140) that's been open > for about 10 days with a few CMake changes to fix th

Re: [swift-dev] Request for review on Windows CMake changes

2017-12-09 Thread David Zarzycki via swift-dev
Can somebody please also speak up to why Windows needs to remove the "-Wl,-z,defs” from CXX_FLAGS? At the very least, I’d like to see the project-wide removal of this useful flag limited to just the Windows builds. > On Dec 8, 2017, at 20:36, Thomas Roughton via swift-dev > wrote: > > Hi all,