Re: [swift-dev] [Swift CI] Build Failure: OSS - Swift Package - Ubuntu 14.04 (master) #301

2017-02-22 Thread Daniel A. Steffen via swift-dev 
In file included from allocator.c:21:
In file included from ./internal.h:628:
In file included from ./shims.h:171:
./shims/lock.h:92:10: fatal error: 'linux/membarrier.h' file not found

it sounds like that file may not be present on Ubuntu 14 ? I’ve disabled this 
include on intel for now

https://github.com/apple/swift-corelibs-libdispatch/pull/221 


but that may not be the right long term fix (and won’t work on other 
architectures)


> On Feb 22, 2017, at 11:41, no-re...@swift.org wrote:
> 
> [FAILURE] oss-swift-package-linux-ubuntu-14_04 [#301]
> 
> Build URL:
> https://ci.swift.org/job/oss-swift-package-linux-ubuntu-14_04/301/ 
> 
> Project:  oss-swift-package-linux-ubuntu-14_04
> Date of build:Wed, 22 Feb 2017 11:21:38 -0800
> Build duration:   19 min
> 
> Changes
> 
> Commit b213f5603334c166a7919c2444b8bf47e15035b6 by bbuegling:
> Do not process dependencies of cancelled commands
> 
> edit: lib/BuildSystem/BuildExecutionQueue.cpp
> edit: include/llbuild/BuildSystem/ExternalCommand.h
> edit: unittests/BuildSystem/BuildSystemTaskTests.cpp
> edit: lib/BuildSystem/ExternalCommand.cpp
> edit: products/libllbuild/BuildSystem-C-API.cpp
> edit: lib/BuildSystem/SwiftTools.cpp
> edit: include/llbuild/BuildSystem/BuildExecutionQueue.h
> edit: lib/BuildSystem/BuildSystem.cpp
> edit: unittests/BuildSystem/MockBuildSystemDelegate.h
> edit: lib/BuildSystem/LaneBasedExecutionQueue.cpp
> 
> Commit 0c137fa458aa093426d4d8281e1c37d0e34a929c by practicalswift:
> [gardening] Remove unused variables
> 
> edit: lib/IDE/SwiftSourceDocInfo.cpp
> 
> Commit 0d24de788fe596814723a4fb8fe7a18b1dbf67c1 by rlevenstein:
> [sil-combine] Add peephole: alloc_ref/set_deallocating/dealloc_ref ->
> 
> edit: lib/SILOptimizer/SILCombiner/SILCombinerMiscVisitors.cpp
> edit: lib/SILOptimizer/SILCombiner/SILCombiner.h
> edit: test/SILOptimizer/sil_combine.sil
> 
> Commit 4eae3cd756d1a2fb6062e0411dd1230f7f70e5da by dsteffen:
> [SE-0111] Update for removal of argument labels from function types
> 
> edit: src/swift/IO.swift
> edit: src/swift/Wrapper.swift
> edit: src/swift/Data.swift
> 
> Commit 623e47492af6d46f85e59966816d6c306e33f699 by dsteffen:
> Merge pull request #126 from apple/enable-se-0111
> 
> edit: PATCHES
> 
> Commit 58e1a4a00ab83fdcd749df0acccab02b83400cb0 by dsteffen:
> whitespace
> 
> edit: src/swift/Data.swift
> 
> Commit 239b1934ff1d24a12fbd0deabb740406e4814fe9 by dsteffen:
> fix issues preventing overlay from compiling due to SE-0025
> 
> edit: src/swift/Data.swift
> edit: src/swift/Queue.swift
> edit: src/swift/Time.swift
> 
> Commit 3ee02d71b8bdbf948d0e875007c8dc4f0746e348 by dsteffen:
> Merge pull request #124 from jpsim/jp-overlay-fixes
> 
> edit: PATCHES
> 
> Commit 6ba832700a1e4ad1bf64a309a92519352292abdc by dsteffen:
> whitespace
> 
> edit: src/swift/Time.swift
> 
> Commit 2fe547e1ca5a8f1d67c1478bbc13e5b379fe6bdb by dsteffen:
> Update for Unsafe(Mutable)Pointer changes.
> 
> edit: src/swift/Data.swift
> 
> Commit 8fd64e3aacf094b9b6ece13d5972f3cf14815b1f by dsteffen:
> Merge pull request #128 from apple/unsafe-pointer-fixes
> 
> edit: PATCHES
> 
> Commit 6cf609d9e871ce3a2c099c37d74cbf8059de2043 by dsteffen:
> whitespace
> 
> edit: src/swift/Data.swift
> 
> Commit b6451f28a2762f9ed0c28e417c0a22e090da8169 by dsteffen:
> [SE-0101] Migrate sizeof family to MemoryLayout
> 
> edit: src/swift/Data.swift
> 
> Commit 8145a073908af8e41356c0dd94421e71c6d5e92c by dsteffen:
> [SE-0101] .size to .stride
> 
> edit: src/swift/Data.swift
> 
> Commit 24b5b96a7ce1e06d41646189902a2f4dee717a6d by dsteffen:
> Merge pull request #129 from rintaro/SE-0101
> 
> edit: PATCHES
> 
> Commit a60dd233bacb0616ec2b8d52ce4f19143f9b9bc6 by dsteffen:
> [noescape by default] Migration to @noescape by default feature.
> 
> edit: src/swift/Block.swift
> edit: src/swift/IO.swift
> edit: src/swift/Dispatch.swift
> edit: src/swift/Queue.swift
> edit: src/swift/Wrapper.swift
> 
> Commit 4354ce62abeeae969baea18d3562bba95c9a42e9 by dsteffen:
> Add escaping attribute on IO completion handlers.
> 
> edit: src/swift/IO.swift
> 
> Commit 7882efb3c2939b8c2899156c1a26bbac09af8f25 by dsteffen:
> Merge pull request #130 from gonzalolarralde/noescape-migration
> 
> edit: PATCHES
> 
> Commit ec21dea51aaf034b7893cdf34e308d96cee39697 by dsteffen:
> whitespace
> 
> edit: src/swift/Block.swift
> edit: src/swift/Queue.swift
> 
> Commit 11a022bf43af062f3cddc1f62bddebc72981fb1f by dsteffen:
> Update libpwq for fix to race condition in libpwq's test_api
> 
> edit: libpwq
> 
> Commit 386cc1c35b3276f5cce4e2a944cba3b482b4ec10 by dsteffen:
> Merge pull request #134 from seabaylea/pwq_api_test
> 
> edit: PATCHES
> 
> Commit 28974c2304b1b51c21ab3933d234d55684a86576 by dsteffen:
> SR-2309: embed BlocksRuntime in libdispatch to eliminate external
> 
> add: src/BlocksRuntime/data.c
> edit: m4/blocks.m4
> edit: src/Makefile.am
> add:

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.04 (master) #1877

2017-02-22 Thread Daniel A. Steffen via swift-dev 
this only failed on ubuntu 14, I’m guessing that is the relevant difference

https://ci.swift.org/job/oss-swift-package-linux-ubuntu-14_04/301/

in any case I disabled this include on intel for now since it is not actually 
used there

https://github.com/apple/swift-corelibs-libdispatch/pull/221 



> On Feb 22, 2017, at 12:40, Erik Eckstein  wrote:
> 
>> On Feb 22, 2017, at 12:35 PM, Pierre Habouzit > > wrote:
>> 
>> Note that you’ll face another issue that Daniel noticed, which is that we 
>> have a new dependency on the linux kernel headers, usually in the 
>> linux-libc-dev package on Debian and derivatives, and in linux-devel on 
>> redhat derivatives.
>> 
>> We will work around the fact that we need this for now as it is not really 
>> required for Intel, but by abandonning libkqueue (in this merge) and on the 
>> long term libpwq and similar things, libdispatch on linux will start 
>> requiring kernel headers more.
>> 
>> Can you adjust the CI scripts to make sure this dependency is added ?
>> 
> 
> Forwarding this question to Mishal
> 
>> Thanks.
>> 
>> -Pierre
>> 
>>> On Feb 22, 2017, at 10:56 AM, Erik Eckstein via swift-dev 
>>> > wrote:
>>> 
>>> Thanks! I’ll give it a try
>>> 
 On Feb 22, 2017, at 10:55 AM, Daniel A. Steffen > wrote:
 
 
> On Feb 22, 2017, at 10:48, Erik Eckstein via swift-dev 
> > wrote:
> 
>> 
>> On Feb 22, 2017, at 10:47 AM, Daniel A. Steffen > > wrote:
>> 
>> thanks, I don’t think Dave saw that locally in his testing but I believe 
>> he is in the air now
>> 
>> does this block anything ?
> 
> yes, it’s blocking PR testing.
> 
>> I can disable the test temporarily if necessary, but one of the Linux 
>> guys will probably have to debug (we certainly don’t see this on Darwin 
>> internally)
> 
> yes, please
 
 done
 
 https://github.com/apple/swift-corelibs-libdispatch/pull/220 
 
> 
>> 
>>> On Feb 22, 2017, at 10:41, Erik Eckstein via swift-dev 
>>> > wrote:
>>> 
>>> Now there is a fail in the tests:
>>> 
>>> https://ci.swift.org/job/swift-PR-Linux-smoke-test/5128/ 
>>> 
>>> 
>>> FAIL: dispatch_context_for_key
>>> ==
>>> 
>>> 
>>> ==
>>> [TEST] Dispatch Queue Specific
>>> [PID] 40365
>>> ==
>>> 
>>> 
>>> [BEGIN] get context for app
>>> Actual: 0x40409c
>>> Expected: 0x40409c
>>> [PASS] get context for app
>>> 
>>> [BEGIN] get context for key 2
>>> Actual: 0x4040b8
>>> Expected: 0x4040b8
>>> [PASS] get context for key 2
>>> 
>>> [BEGIN] Process exited
>>> Actual: 1
>>> Expected: 0
>>> [FAIL] Process exited (bsdtestharness.c:132)
>>> bsdtestharness.c:132
>>> [PERF]  wall time: 0.66
>>> [PERF]  user time: 0.064000
>>> [PERF]  system time: 0.008000
>>> [PERF]  max resident set size: 18356
>>> [PERF]  page faults: 0
>>> [PERF]  swaps: 0
>>> [PERF]  voluntary context switches: 78
>>> [PERF]  involuntary context switches: 10
>>> FAIL dispatch_context_for_key (exit status: 1)
>>> 
>>> 
>>> Testsuite summary for libdispatch 1.3
>>> 
>>> # TOTAL: 21
>>> # PASS:  20
>>> # SKIP:  0
>>> # XFAIL: 0
>>> # FAIL:  1
>>> # XPASS: 0
>>> # ERROR: 0
>>> 
>>> 
 On Feb 22, 2017, at 10:11 AM, Daniel A. Steffen > wrote:
 
 +Erik
 
 I merged
https://github.com/apple/swift-corelibs-libdispatch/pull/218 
 
 which should fix this
 
 Daniel
 
> On Feb 22, 2017, at 9:59, Daniel A. Steffen via swift-dev 
> > wrote:
> 
> +phausler
> 
>> In file included from CoreFoundation/Collections.subproj/CFTree.c:12:
>> In file included from 
>>

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.04 (master) #1877

2017-02-22 Thread Erik Eckstein via swift-dev 
> On Feb 22, 2017, at 12:35 PM, Pierre Habouzit  wrote:
> 
> Note that you’ll face another issue that Daniel noticed, which is that we 
> have a new dependency on the linux kernel headers, usually in the 
> linux-libc-dev package on Debian and derivatives, and in linux-devel on 
> redhat derivatives.
> 
> We will work around the fact that we need this for now as it is not really 
> required for Intel, but by abandonning libkqueue (in this merge) and on the 
> long term libpwq and similar things, libdispatch on linux will start 
> requiring kernel headers more.
> 
> Can you adjust the CI scripts to make sure this dependency is added ?
> 

Forwarding this question to Mishal

> Thanks.
> 
> -Pierre
> 
>> On Feb 22, 2017, at 10:56 AM, Erik Eckstein via swift-dev 
>> > wrote:
>> 
>> Thanks! I’ll give it a try
>> 
>>> On Feb 22, 2017, at 10:55 AM, Daniel A. Steffen >> > wrote:
>>> 
>>> 
 On Feb 22, 2017, at 10:48, Erik Eckstein via swift-dev 
 > wrote:
 
> 
> On Feb 22, 2017, at 10:47 AM, Daniel A. Steffen  > wrote:
> 
> thanks, I don’t think Dave saw that locally in his testing but I believe 
> he is in the air now
> 
> does this block anything ?
 
 yes, it’s blocking PR testing.
 
> I can disable the test temporarily if necessary, but one of the Linux 
> guys will probably have to debug (we certainly don’t see this on Darwin 
> internally)
 
 yes, please
>>> 
>>> done
>>> 
>>> https://github.com/apple/swift-corelibs-libdispatch/pull/220 
>>> 
 
> 
>> On Feb 22, 2017, at 10:41, Erik Eckstein via swift-dev 
>> > wrote:
>> 
>> Now there is a fail in the tests:
>> 
>> https://ci.swift.org/job/swift-PR-Linux-smoke-test/5128/ 
>> 
>> 
>> FAIL: dispatch_context_for_key
>> ==
>> 
>> 
>> ==
>> [TEST] Dispatch Queue Specific
>> [PID] 40365
>> ==
>> 
>> 
>> [BEGIN] get context for app
>>  Actual: 0x40409c
>>  Expected: 0x40409c
>> [PASS] get context for app
>> 
>> [BEGIN] get context for key 2
>>  Actual: 0x4040b8
>>  Expected: 0x4040b8
>> [PASS] get context for key 2
>> 
>> [BEGIN] Process exited
>>  Actual: 1
>>  Expected: 0
>> [FAIL] Process exited (bsdtestharness.c:132)
>>  bsdtestharness.c:132
>> [PERF]   wall time: 0.66
>> [PERF]   user time: 0.064000
>> [PERF]   system time: 0.008000
>> [PERF]   max resident set size: 18356
>> [PERF]   page faults: 0
>> [PERF]   swaps: 0
>> [PERF]   voluntary context switches: 78
>> [PERF]   involuntary context switches: 10
>> FAIL dispatch_context_for_key (exit status: 1)
>> 
>> 
>> Testsuite summary for libdispatch 1.3
>> 
>> # TOTAL: 21
>> # PASS:  20
>> # SKIP:  0
>> # XFAIL: 0
>> # FAIL:  1
>> # XPASS: 0
>> # ERROR: 0
>> 
>> 
>>> On Feb 22, 2017, at 10:11 AM, Daniel A. Steffen >> > wrote:
>>> 
>>> +Erik
>>> 
>>> I merged
>>> https://github.com/apple/swift-corelibs-libdispatch/pull/218 
>>> 
>>> which should fix this
>>> 
>>> Daniel
>>> 
 On Feb 22, 2017, at 9:59, Daniel A. Steffen via swift-dev 
 > wrote:
 
 +phausler
 
> In file included from CoreFoundation/Collections.subproj/CFTree.c:12:
> In file included from 
> ../buildbot_incremental/foundation-linux-x86_64/Foundation/usr//lib/swift/CoreFoundation/CFInternal.h:838:
> In file included from 
> /home/buildnode/jenkins/workspace/oss-swift-incremental-RA-linux-ubuntu-16_04/buildbot_incremental/libdispatch-linux-x86_64/tests/dispatch/private.h:56:
> 
> /home/buildnode/jenkins/workspace/oss-swift-incremental-RA-linux-ubuntu-16_04/buildbot_incremental/libdispatch-linux-x86_64/tests/dispatch/source_private.h:81:33:
>  error: expected parameter declarator
> 
> API_DEPRECATED_WITH_REPLACEMENT("DISPATCH_SOURCE_TYPE_MEMORYPRESSURE",
> 
 
 Dave, you didn’t see this in your local Linux testing right ?
 
 I would

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.04 (master) #1877

2017-02-22 Thread Erik Eckstein via swift-dev 
Thanks! I’ll give it a try

> On Feb 22, 2017, at 10:55 AM, Daniel A. Steffen  wrote:
> 
> 
>> On Feb 22, 2017, at 10:48, Erik Eckstein via swift-dev > > wrote:
>> 
>>> 
>>> On Feb 22, 2017, at 10:47 AM, Daniel A. Steffen >> > wrote:
>>> 
>>> thanks, I don’t think Dave saw that locally in his testing but I believe he 
>>> is in the air now
>>> 
>>> does this block anything ?
>> 
>> yes, it’s blocking PR testing.
>> 
>>> I can disable the test temporarily if necessary, but one of the Linux guys 
>>> will probably have to debug (we certainly don’t see this on Darwin 
>>> internally)
>> 
>> yes, please
> 
> done
> 
> https://github.com/apple/swift-corelibs-libdispatch/pull/220 
> 
>> 
>>> 
 On Feb 22, 2017, at 10:41, Erik Eckstein via swift-dev 
 > wrote:
 
 Now there is a fail in the tests:
 
 https://ci.swift.org/job/swift-PR-Linux-smoke-test/5128/ 
 
 
 FAIL: dispatch_context_for_key
 ==
 
 
 ==
 [TEST] Dispatch Queue Specific
 [PID] 40365
 ==
 
 
 [BEGIN] get context for app
Actual: 0x40409c
Expected: 0x40409c
 [PASS] get context for app
 
 [BEGIN] get context for key 2
Actual: 0x4040b8
Expected: 0x4040b8
 [PASS] get context for key 2
 
 [BEGIN] Process exited
Actual: 1
Expected: 0
 [FAIL] Process exited (bsdtestharness.c:132)
bsdtestharness.c:132
 [PERF] wall time: 0.66
 [PERF] user time: 0.064000
 [PERF] system time: 0.008000
 [PERF] max resident set size: 18356
 [PERF] page faults: 0
 [PERF] swaps: 0
 [PERF] voluntary context switches: 78
 [PERF] involuntary context switches: 10
 FAIL dispatch_context_for_key (exit status: 1)
 
 
 Testsuite summary for libdispatch 1.3
 
 # TOTAL: 21
 # PASS:  20
 # SKIP:  0
 # XFAIL: 0
 # FAIL:  1
 # XPASS: 0
 # ERROR: 0
 
 
> On Feb 22, 2017, at 10:11 AM, Daniel A. Steffen  > wrote:
> 
> +Erik
> 
> I merged
>   https://github.com/apple/swift-corelibs-libdispatch/pull/218 
> 
> which should fix this
> 
> Daniel
> 
>> On Feb 22, 2017, at 9:59, Daniel A. Steffen via swift-dev 
>> > wrote:
>> 
>> +phausler
>> 
>>> In file included from CoreFoundation/Collections.subproj/CFTree.c:12:
>>> In file included from 
>>> ../buildbot_incremental/foundation-linux-x86_64/Foundation/usr//lib/swift/CoreFoundation/CFInternal.h:838:
>>> In file included from 
>>> /home/buildnode/jenkins/workspace/oss-swift-incremental-RA-linux-ubuntu-16_04/buildbot_incremental/libdispatch-linux-x86_64/tests/dispatch/private.h:56:
>>> 
>>> /home/buildnode/jenkins/workspace/oss-swift-incremental-RA-linux-ubuntu-16_04/buildbot_incremental/libdispatch-linux-x86_64/tests/dispatch/source_private.h:81:33:
>>>  error: expected parameter declarator
>>> 
>>> API_DEPRECATED_WITH_REPLACEMENT("DISPATCH_SOURCE_TYPE_MEMORYPRESSURE",
>>> 
>> 
>> Dave, you didn’t see this in your local Linux testing right ?
>> 
>> I would have expected the following in dispatch/dispatch.h to provide a 
>> definition of API_DEPRECATED_WITH_REPLACEMENT() on Linux, I’m guessing 
>> that maybe that doesn’t trigger for CF because that its own fallback 
>> definition of API_AVAILABLE ? Philippe ?
>> 
>> #ifndef API_AVAILABLE
>> #define API_AVAILABLE(...)
>> #define API_DEPRECATED(...)
>> #define API_UNAVAILABLE(...)
>> #define API_DEPRECATED_WITH_REPLACEMENT(...)
>> #endif // !API_AVAILABLE
>> 
>> Daniel
>> 
>> 
>>> On Feb 22, 2017, at 9:49, no-re...@swift.org 
>>>  wrote:
>>> 
>>> [FAILURE] oss-swift-incremental-RA-linux-ubuntu-16_04 [#1877]
>>> 
>>> Build URL:  
>>> https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-16_04/1877/
>>>  
>>> 
>>> Project:oss-swift-incremental-RA-linux-ubuntu-16_04
>>> Date of build:  Wed, 22 Feb 2017 09:28:46 -0800
>>> Build duration: 20 min
>>> Identified

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.04 (master) #1877

2017-02-22 Thread Daniel A. Steffen via swift-dev 

> On Feb 22, 2017, at 10:48, Erik Eckstein via swift-dev  
> wrote:
> 
>> 
>> On Feb 22, 2017, at 10:47 AM, Daniel A. Steffen > > wrote:
>> 
>> thanks, I don’t think Dave saw that locally in his testing but I believe he 
>> is in the air now
>> 
>> does this block anything ?
> 
> yes, it’s blocking PR testing.
> 
>> I can disable the test temporarily if necessary, but one of the Linux guys 
>> will probably have to debug (we certainly don’t see this on Darwin 
>> internally)
> 
> yes, please

done

https://github.com/apple/swift-corelibs-libdispatch/pull/220 

> 
>> 
>>> On Feb 22, 2017, at 10:41, Erik Eckstein via swift-dev >> > wrote:
>>> 
>>> Now there is a fail in the tests:
>>> 
>>> https://ci.swift.org/job/swift-PR-Linux-smoke-test/5128/ 
>>> 
>>> 
>>> FAIL: dispatch_context_for_key
>>> ==
>>> 
>>> 
>>> ==
>>> [TEST] Dispatch Queue Specific
>>> [PID] 40365
>>> ==
>>> 
>>> 
>>> [BEGIN] get context for app
>>> Actual: 0x40409c
>>> Expected: 0x40409c
>>> [PASS] get context for app
>>> 
>>> [BEGIN] get context for key 2
>>> Actual: 0x4040b8
>>> Expected: 0x4040b8
>>> [PASS] get context for key 2
>>> 
>>> [BEGIN] Process exited
>>> Actual: 1
>>> Expected: 0
>>> [FAIL] Process exited (bsdtestharness.c:132)
>>> bsdtestharness.c:132
>>> [PERF]  wall time: 0.66
>>> [PERF]  user time: 0.064000
>>> [PERF]  system time: 0.008000
>>> [PERF]  max resident set size: 18356
>>> [PERF]  page faults: 0
>>> [PERF]  swaps: 0
>>> [PERF]  voluntary context switches: 78
>>> [PERF]  involuntary context switches: 10
>>> FAIL dispatch_context_for_key (exit status: 1)
>>> 
>>> 
>>> Testsuite summary for libdispatch 1.3
>>> 
>>> # TOTAL: 21
>>> # PASS:  20
>>> # SKIP:  0
>>> # XFAIL: 0
>>> # FAIL:  1
>>> # XPASS: 0
>>> # ERROR: 0
>>> 
>>> 
 On Feb 22, 2017, at 10:11 AM, Daniel A. Steffen > wrote:
 
 +Erik
 
 I merged
https://github.com/apple/swift-corelibs-libdispatch/pull/218 
 
 which should fix this
 
 Daniel
 
> On Feb 22, 2017, at 9:59, Daniel A. Steffen via swift-dev 
> > wrote:
> 
> +phausler
> 
>> In file included from CoreFoundation/Collections.subproj/CFTree.c:12:
>> In file included from 
>> ../buildbot_incremental/foundation-linux-x86_64/Foundation/usr//lib/swift/CoreFoundation/CFInternal.h:838:
>> In file included from 
>> /home/buildnode/jenkins/workspace/oss-swift-incremental-RA-linux-ubuntu-16_04/buildbot_incremental/libdispatch-linux-x86_64/tests/dispatch/private.h:56:
>> 
>> /home/buildnode/jenkins/workspace/oss-swift-incremental-RA-linux-ubuntu-16_04/buildbot_incremental/libdispatch-linux-x86_64/tests/dispatch/source_private.h:81:33:
>>  error: expected parameter declarator
>> 
>> API_DEPRECATED_WITH_REPLACEMENT("DISPATCH_SOURCE_TYPE_MEMORYPRESSURE",
>> 
> 
> Dave, you didn’t see this in your local Linux testing right ?
> 
> I would have expected the following in dispatch/dispatch.h to provide a 
> definition of API_DEPRECATED_WITH_REPLACEMENT() on Linux, I’m guessing 
> that maybe that doesn’t trigger for CF because that its own fallback 
> definition of API_AVAILABLE ? Philippe ?
> 
> #ifndef API_AVAILABLE
> #define API_AVAILABLE(...)
> #define API_DEPRECATED(...)
> #define API_UNAVAILABLE(...)
> #define API_DEPRECATED_WITH_REPLACEMENT(...)
> #endif // !API_AVAILABLE
> 
> Daniel
> 
> 
>> On Feb 22, 2017, at 9:49, no-re...@swift.org  
>> wrote:
>> 
>> [FAILURE] oss-swift-incremental-RA-linux-ubuntu-16_04 [#1877]
>> 
>> Build URL:   
>> https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-16_04/1877/
>>  
>> 
>> Project: oss-swift-incremental-RA-linux-ubuntu-16_04
>> Date of build:   Wed, 22 Feb 2017 09:28:46 -0800
>> Build duration:  20 min
>> Identified problems:
>> 
>> Compile Error: This build failed because of a compile error. Below is a 
>> list of all errors in the build log:
>> Indication 1 
>>

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.04 (master) #1877

2017-02-22 Thread Daniel A. Steffen via swift-dev 
thanks, I don’t think Dave saw that locally in his testing but I believe he is 
in the air now

does this block anything ? I can disable the test temporarily if necessary, but 
one of the Linux guys will probably have to debug (we certainly don’t see this 
on Darwin internally)

> On Feb 22, 2017, at 10:41, Erik Eckstein via swift-dev  
> wrote:
> 
> Now there is a fail in the tests:
> 
> https://ci.swift.org/job/swift-PR-Linux-smoke-test/5128/ 
> 
> 
> FAIL: dispatch_context_for_key
> ==
> 
> 
> ==
> [TEST] Dispatch Queue Specific
> [PID] 40365
> ==
> 
> 
> [BEGIN] get context for app
>   Actual: 0x40409c
>   Expected: 0x40409c
> [PASS] get context for app
> 
> [BEGIN] get context for key 2
>   Actual: 0x4040b8
>   Expected: 0x4040b8
> [PASS] get context for key 2
> 
> [BEGIN] Process exited
>   Actual: 1
>   Expected: 0
> [FAIL] Process exited (bsdtestharness.c:132)
>   bsdtestharness.c:132
> [PERF]wall time: 0.66
> [PERF]user time: 0.064000
> [PERF]system time: 0.008000
> [PERF]max resident set size: 18356
> [PERF]page faults: 0
> [PERF]swaps: 0
> [PERF]voluntary context switches: 78
> [PERF]involuntary context switches: 10
> FAIL dispatch_context_for_key (exit status: 1)
> 
> 
> Testsuite summary for libdispatch 1.3
> 
> # TOTAL: 21
> # PASS:  20
> # SKIP:  0
> # XFAIL: 0
> # FAIL:  1
> # XPASS: 0
> # ERROR: 0
> 
> 
>> On Feb 22, 2017, at 10:11 AM, Daniel A. Steffen > > wrote:
>> 
>> +Erik
>> 
>> I merged
>>  https://github.com/apple/swift-corelibs-libdispatch/pull/218 
>> 
>> which should fix this
>> 
>> Daniel
>> 
>>> On Feb 22, 2017, at 9:59, Daniel A. Steffen via swift-dev 
>>> > wrote:
>>> 
>>> +phausler
>>> 
 In file included from CoreFoundation/Collections.subproj/CFTree.c:12:
 In file included from 
 ../buildbot_incremental/foundation-linux-x86_64/Foundation/usr//lib/swift/CoreFoundation/CFInternal.h:838:
 In file included from 
 /home/buildnode/jenkins/workspace/oss-swift-incremental-RA-linux-ubuntu-16_04/buildbot_incremental/libdispatch-linux-x86_64/tests/dispatch/private.h:56:
 
 /home/buildnode/jenkins/workspace/oss-swift-incremental-RA-linux-ubuntu-16_04/buildbot_incremental/libdispatch-linux-x86_64/tests/dispatch/source_private.h:81:33:
  error: expected parameter declarator
 
 API_DEPRECATED_WITH_REPLACEMENT("DISPATCH_SOURCE_TYPE_MEMORYPRESSURE",
 
>>> 
>>> Dave, you didn’t see this in your local Linux testing right ?
>>> 
>>> I would have expected the following in dispatch/dispatch.h to provide a 
>>> definition of API_DEPRECATED_WITH_REPLACEMENT() on Linux, I’m guessing that 
>>> maybe that doesn’t trigger for CF because that its own fallback definition 
>>> of API_AVAILABLE ? Philippe ?
>>> 
>>> #ifndef API_AVAILABLE
>>> #define API_AVAILABLE(...)
>>> #define API_DEPRECATED(...)
>>> #define API_UNAVAILABLE(...)
>>> #define API_DEPRECATED_WITH_REPLACEMENT(...)
>>> #endif // !API_AVAILABLE
>>> 
>>> Daniel
>>> 
>>> 
 On Feb 22, 2017, at 9:49, no-re...@swift.org  
 wrote:
 
 [FAILURE] oss-swift-incremental-RA-linux-ubuntu-16_04 [#1877]
 
 Build URL: 
 https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-16_04/1877/ 
 
 Project:   oss-swift-incremental-RA-linux-ubuntu-16_04
 Date of build: Wed, 22 Feb 2017 09:28:46 -0800
 Build duration:20 min
 Identified problems:
 
 Compile Error: This build failed because of a compile error. Below is a 
 list of all errors in the build log:
 Indication 1 
 
 Changes
 
 Commit b213f5603334c166a7919c2444b8bf47e15035b6 by bbuegling:
 Do not process dependencies of cancelled commands
 
 edit: lib/BuildSystem/BuildSystem.cpp
 edit: lib/BuildSystem/SwiftTools.cpp
 edit: lib/BuildSystem/ExternalCommand.cpp
 edit: lib/BuildSystem/LaneBasedExecutionQueue.cpp
 edit: products/libllbuild/BuildSystem-C-API.cpp
 edit: unittests/BuildSystem/BuildSystemTaskTests.cpp
 edit: include/llbuild/BuildSystem/ExternalCommand.h
 edit: include/llbuild/BuildSystem/BuildExecutionQueue.h
 edit: lib/BuildSystem/BuildExecutionQueue.cpp
 edit:

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.04 (master) #1877

2017-02-22 Thread Erik Eckstein via swift-dev 
Now there is a fail in the tests:

https://ci.swift.org/job/swift-PR-Linux-smoke-test/5128/ 


FAIL: dispatch_context_for_key
==


==
[TEST] Dispatch Queue Specific
[PID] 40365
==


[BEGIN] get context for app
Actual: 0x40409c
Expected: 0x40409c
[PASS] get context for app

[BEGIN] get context for key 2
Actual: 0x4040b8
Expected: 0x4040b8
[PASS] get context for key 2

[BEGIN] Process exited
Actual: 1
Expected: 0
[FAIL] Process exited (bsdtestharness.c:132)
bsdtestharness.c:132
[PERF]  wall time: 0.66
[PERF]  user time: 0.064000
[PERF]  system time: 0.008000
[PERF]  max resident set size: 18356
[PERF]  page faults: 0
[PERF]  swaps: 0
[PERF]  voluntary context switches: 78
[PERF]  involuntary context switches: 10
FAIL dispatch_context_for_key (exit status: 1)


Testsuite summary for libdispatch 1.3

# TOTAL: 21
# PASS:  20
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0


> On Feb 22, 2017, at 10:11 AM, Daniel A. Steffen  wrote:
> 
> +Erik
> 
> I merged
>   https://github.com/apple/swift-corelibs-libdispatch/pull/218 
> 
> which should fix this
> 
> Daniel
> 
>> On Feb 22, 2017, at 9:59, Daniel A. Steffen via swift-dev 
>> > wrote:
>> 
>> +phausler
>> 
>>> In file included from CoreFoundation/Collections.subproj/CFTree.c:12:
>>> In file included from 
>>> ../buildbot_incremental/foundation-linux-x86_64/Foundation/usr//lib/swift/CoreFoundation/CFInternal.h:838:
>>> In file included from 
>>> /home/buildnode/jenkins/workspace/oss-swift-incremental-RA-linux-ubuntu-16_04/buildbot_incremental/libdispatch-linux-x86_64/tests/dispatch/private.h:56:
>>> 
>>> /home/buildnode/jenkins/workspace/oss-swift-incremental-RA-linux-ubuntu-16_04/buildbot_incremental/libdispatch-linux-x86_64/tests/dispatch/source_private.h:81:33:
>>>  error: expected parameter declarator
>>> 
>>> API_DEPRECATED_WITH_REPLACEMENT("DISPATCH_SOURCE_TYPE_MEMORYPRESSURE",
>>> 
>> 
>> Dave, you didn’t see this in your local Linux testing right ?
>> 
>> I would have expected the following in dispatch/dispatch.h to provide a 
>> definition of API_DEPRECATED_WITH_REPLACEMENT() on Linux, I’m guessing that 
>> maybe that doesn’t trigger for CF because that its own fallback definition 
>> of API_AVAILABLE ? Philippe ?
>> 
>> #ifndef API_AVAILABLE
>> #define API_AVAILABLE(...)
>> #define API_DEPRECATED(...)
>> #define API_UNAVAILABLE(...)
>> #define API_DEPRECATED_WITH_REPLACEMENT(...)
>> #endif // !API_AVAILABLE
>> 
>> Daniel
>> 
>> 
>>> On Feb 22, 2017, at 9:49, no-re...@swift.org  
>>> wrote:
>>> 
>>> [FAILURE] oss-swift-incremental-RA-linux-ubuntu-16_04 [#1877]
>>> 
>>> Build URL:  
>>> https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-16_04/1877/ 
>>> 
>>> Project:oss-swift-incremental-RA-linux-ubuntu-16_04
>>> Date of build:  Wed, 22 Feb 2017 09:28:46 -0800
>>> Build duration: 20 min
>>> Identified problems:
>>> 
>>> Compile Error: This build failed because of a compile error. Below is a 
>>> list of all errors in the build log:
>>> Indication 1 
>>> 
>>> Changes
>>> 
>>> Commit b213f5603334c166a7919c2444b8bf47e15035b6 by bbuegling:
>>> Do not process dependencies of cancelled commands
>>> 
>>> edit: lib/BuildSystem/BuildSystem.cpp
>>> edit: lib/BuildSystem/SwiftTools.cpp
>>> edit: lib/BuildSystem/ExternalCommand.cpp
>>> edit: lib/BuildSystem/LaneBasedExecutionQueue.cpp
>>> edit: products/libllbuild/BuildSystem-C-API.cpp
>>> edit: unittests/BuildSystem/BuildSystemTaskTests.cpp
>>> edit: include/llbuild/BuildSystem/ExternalCommand.h
>>> edit: include/llbuild/BuildSystem/BuildExecutionQueue.h
>>> edit: lib/BuildSystem/BuildExecutionQueue.cpp
>>> edit: unittests/BuildSystem/MockBuildSystemDelegate.h
>>> 
>>> Commit 0d24de788fe596814723a4fb8fe7a18b1dbf67c1 by rlevenstein:
>>> [sil-combine] Add peephole: alloc_ref/set_deallocating/dealloc_ref ->
>>> 
>>> edit: test/SILOptimizer/sil_combine.sil
>>> edit: lib/SILOptimizer/SILCombiner/SILCombiner.h
>>> edit: lib/SILOptimizer/SILCombiner/SILCombinerMiscVisitors.cpp
>>> 
>>> Commit 4eae3cd756d1a2fb6062e0411dd1230f7f70e5da by dsteffen:
>>> [SE-0111] Update for removal of argument labels from function types
>>> 
>>> edit: src/swift/Wrapper.swift
>>> edit: src/swift/Data.swift
>>> edit: src/swift/IO.swift
>>> 
>>> Commit

[swift-dev] linux pr testing is broken

2017-02-22 Thread Erik Eckstein via swift-dev 
Hi Danial,

Looks like your recent merge in libdispatch broke the linux PR bot:

https://ci.swift.org/job/swift-PR-Linux-smoke-test/5126/ 



/home/buildnode/jenkins/workspace/swift-PR-Linux-smoke-test/branch-master/buildbot_linux/libdispatch-linux-x86_64/tests/dispatch/source_private.h:81:33:
 error: expected parameter declarator
API_DEPRECATED_WITH_REPLACEMENT("DISPATCH_SOURCE_TYPE_MEMORYPRESSURE",
^
/home/buildnode/jenkins/workspace/swift-PR-Linux-smoke-test/branch-master/buildbot_linux/libdispatch-linux-x86_64/tests/dispatch/source_private.h:81:33:
 error: expected ')'

Can you please fix or revert?

Thanks,
Erik
___
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.04 (master) #1877

2017-02-22 Thread Daniel A. Steffen via swift-dev 
+phausler

> In file included from CoreFoundation/Collections.subproj/CFTree.c:12:
> In file included from 
> ../buildbot_incremental/foundation-linux-x86_64/Foundation/usr//lib/swift/CoreFoundation/CFInternal.h:838:
> In file included from 
> /home/buildnode/jenkins/workspace/oss-swift-incremental-RA-linux-ubuntu-16_04/buildbot_incremental/libdispatch-linux-x86_64/tests/dispatch/private.h:56:
> 
> /home/buildnode/jenkins/workspace/oss-swift-incremental-RA-linux-ubuntu-16_04/buildbot_incremental/libdispatch-linux-x86_64/tests/dispatch/source_private.h:81:33:
>  error: expected parameter declarator
> 
> API_DEPRECATED_WITH_REPLACEMENT("DISPATCH_SOURCE_TYPE_MEMORYPRESSURE",
> 

Dave, you didn’t see this in your local Linux testing right ?

I would have expected the following in dispatch/dispatch.h to provide a 
definition of API_DEPRECATED_WITH_REPLACEMENT() on Linux, I’m guessing that 
maybe that doesn’t trigger for CF because that its own fallback definition of 
API_AVAILABLE ? Philippe ?

#ifndef API_AVAILABLE
#define API_AVAILABLE(...)
#define API_DEPRECATED(...)
#define API_UNAVAILABLE(...)
#define API_DEPRECATED_WITH_REPLACEMENT(...)
#endif // !API_AVAILABLE

Daniel


> On Feb 22, 2017, at 9:49, no-re...@swift.org wrote:
> 
> [FAILURE] oss-swift-incremental-RA-linux-ubuntu-16_04 [#1877]
> 
> Build URL:
> https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-16_04/1877/ 
> 
> Project:  oss-swift-incremental-RA-linux-ubuntu-16_04
> Date of build:Wed, 22 Feb 2017 09:28:46 -0800
> Build duration:   20 min
> Identified problems:
> 
> Compile Error: This build failed because of a compile error. Below is a list 
> of all errors in the build log:
> Indication 1 
> 
> Changes
> 
> Commit b213f5603334c166a7919c2444b8bf47e15035b6 by bbuegling:
> Do not process dependencies of cancelled commands
> 
> edit: lib/BuildSystem/BuildSystem.cpp
> edit: lib/BuildSystem/SwiftTools.cpp
> edit: lib/BuildSystem/ExternalCommand.cpp
> edit: lib/BuildSystem/LaneBasedExecutionQueue.cpp
> edit: products/libllbuild/BuildSystem-C-API.cpp
> edit: unittests/BuildSystem/BuildSystemTaskTests.cpp
> edit: include/llbuild/BuildSystem/ExternalCommand.h
> edit: include/llbuild/BuildSystem/BuildExecutionQueue.h
> edit: lib/BuildSystem/BuildExecutionQueue.cpp
> edit: unittests/BuildSystem/MockBuildSystemDelegate.h
> 
> Commit 0d24de788fe596814723a4fb8fe7a18b1dbf67c1 by rlevenstein:
> [sil-combine] Add peephole: alloc_ref/set_deallocating/dealloc_ref ->
> 
> edit: test/SILOptimizer/sil_combine.sil
> edit: lib/SILOptimizer/SILCombiner/SILCombiner.h
> edit: lib/SILOptimizer/SILCombiner/SILCombinerMiscVisitors.cpp
> 
> Commit 4eae3cd756d1a2fb6062e0411dd1230f7f70e5da by dsteffen:
> [SE-0111] Update for removal of argument labels from function types
> 
> edit: src/swift/Wrapper.swift
> edit: src/swift/Data.swift
> edit: src/swift/IO.swift
> 
> Commit 623e47492af6d46f85e59966816d6c306e33f699 by dsteffen:
> Merge pull request #126 from apple/enable-se-0111
> 
> edit: PATCHES
> 
> Commit 58e1a4a00ab83fdcd749df0acccab02b83400cb0 by dsteffen:
> whitespace
> 
> edit: src/swift/Data.swift
> 
> Commit 239b1934ff1d24a12fbd0deabb740406e4814fe9 by dsteffen:
> fix issues preventing overlay from compiling due to SE-0025
> 
> edit: src/swift/Queue.swift
> edit: src/swift/Data.swift
> edit: src/swift/Time.swift
> 
> Commit 3ee02d71b8bdbf948d0e875007c8dc4f0746e348 by dsteffen:
> Merge pull request #124 from jpsim/jp-overlay-fixes
> 
> edit: PATCHES
> 
> Commit 6ba832700a1e4ad1bf64a309a92519352292abdc by dsteffen:
> whitespace
> 
> edit: src/swift/Time.swift
> 
> Commit 2fe547e1ca5a8f1d67c1478bbc13e5b379fe6bdb by dsteffen:
> Update for Unsafe(Mutable)Pointer changes.
> 
> edit: src/swift/Data.swift
> 
> Commit 8fd64e3aacf094b9b6ece13d5972f3cf14815b1f by dsteffen:
> Merge pull request #128 from apple/unsafe-pointer-fixes
> 
> edit: PATCHES
> 
> Commit 6cf609d9e871ce3a2c099c37d74cbf8059de2043 by dsteffen:
> whitespace
> 
> edit: src/swift/Data.swift
> 
> Commit b6451f28a2762f9ed0c28e417c0a22e090da8169 by dsteffen:
> [SE-0101] Migrate sizeof family to MemoryLayout
> 
> edit: src/swift/Data.swift
> 
> Commit 8145a073908af8e41356c0dd94421e71c6d5e92c by dsteffen:
> [SE-0101] .size to .stride
> 
> edit: src/swift/Data.swift
> 
> Commit 24b5b96a7ce1e06d41646189902a2f4dee717a6d by dsteffen:
> Merge pull request #129 from rintaro/SE-0101
> 
> edit: PATCHES
> 
> Commit a60dd233bacb0616ec2b8d52ce4f19143f9b9bc6 by dsteffen:
> [noescape by default] Migration to @noescape by default feature.
> 
> edit: src/swift/Queue.swift
> edit: src/swift/Dispatch.swift
> edit: src/swift/Wrapper.swift
> edit: src/swift/Block.swift
> edit: src/swift/IO.swift
> 
> Commit 4354ce62abeeae969baea18d3562bba95c9a42e9 by dsteffen:
> Add escaping attribute on IO