Re: [swift-dev] [Swift CI] Build Still Failing: 0. OSS - LLDB Incremental - OS X (master-llvm-swift5-transition) #61

2018-01-17 Thread Vedant Kumar via swift-dev 
This didn't send to the list because the quoted section of the email was too 
long. Once again;

I cherry-picked Slava's fix for the failures listed here:

a5243443d (HEAD -> llvm-swift5-transition, origin/llvm-swift5-transition) Merge 
pull request #275 from slavapestov/fix-inout-reconstruction-4.1

vedant
___
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

Re: [swift-dev] DebugScope Verification Error

2018-01-16 Thread Vedant Kumar via swift-dev 
+ Adrian and Davide, since they work in this area.

Hi Raj,

> On Jan 15, 2018, at 4:48 PM, Raj Barik via swift-dev  
> wrote:
> 
> Thanks Mark. You are right, the following assertion fails
> 
> require(!DS || DS->getParentFunction() == I->getFunction(),
> "debug scope of instruction belongs to a different function");
> 
> I am not sure if we need such a check.

This check exists to ensure that the debug info generated for a program is 
helpful. For example, a function with the wrong debug scope attached might make 
for confusing backtraces.

vedant

>   
> 
> On Mon, Jan 15, 2018 at 4:16 PM, Mark Lacey  > wrote:
> 
> 
>> On Jan 15, 2018, at 12:54 PM, Raj Barik > > wrote:
>> 
>> Mark,
>> 
>> Thanks a lot for quick reply.
>>  
>> Is there any reason this interface in SILInstruction should be private?
>> void setDebugScope(SILBuilder , const SILDebugScope *DS);
>> 
>> In my case, I am splicing the old F into the new function NF. While splicing 
>> retains the debug scope, the new instruction (InitRef) that I am adding to 
>> NF is being created in some random scope (not F) even though I explicitly 
>> make Builder's debug scope point to F's. 
> 
> The assert you originally hit appears to indicate that the parentFunction of 
> the debug scope for an instruction should be the same as the function the 
> instruction is in. I am not very familiar with the requirements of our debug 
> information and debug scopes, but this seems like a reasonable expectation.
> 
> I suggested looking at SILCloner because it is the primary way by which we 
> clone functions, and clearly has to deal with debug scopes when it does so.
> 
> I’m not sure how much more help I can be on this matter, but perhaps someone 
> more knowledgable can chime in.
> 
> Mark
> 
> 
> 
> 
>> 
>> Best,
>> Raj
>> 
>> 
>> 
>> On Mon, Jan 15, 2018 at 9:52 AM, Mark Lacey > > wrote:
>> I’d suggest looking at SILCloner.h as well as ScopeCloner in 
>> SILBasicBlock.cpp to see how they are dealing with debug scopes.
>> 
>> Mark
>> 
>> > On Jan 15, 2018, at 9:24 AM, Raj Barik via swift-dev > > > wrote:
>> >
>> > Hi,
>> >
>> > I am running into a debug scope SIL Verifier error when creating a new 
>> > function (NF) from an existing one (F). Can someone point me where I am 
>> > going wrong?
>> >
>> > NF = M.createFunction(, F->getDebugScope());
>> > SILBasicBlock *NFBody = NF->createBasicBlock();
>> > SILBuilder NFBuilder(NFBody);
>> > SILOpenedArchetypesTracker OpenedArchetypesTrackerNF(NF);
>> > NFBuilder.setOpenedArchetypesTracker();
>> > NFBuilder.setCurrentDebugScope(NFBody->getParent()->getDebugScope());
>> > ...
>> > for (auto  : params) { /* Assume all are generic types */
>> >   auto GenericsSILType = 
>> >   auto NewArg = NFBody->createFunctionArgument(GenericSILType);
>> >   auto Conformances = Mod->lookupConformance(...);
>> >   auto *InitRef = NFBuilder.createInitExistentialRef( Loc, 
>> > ArgDesc.Arg->getType(), 
>> > NewArg->getType().getSwiftRValueType()->getCanonicalType(), NewArg, 
>> > Conformances);
>> >   ...
>> > }
>> >
>> > The InitRef instruction created above runs into SIL verifier error:
>> >
>> > SIL verification failed: debug scope of instruction belongs to a different 
>> > function: !DS || DS->getParentFunction() == I->getFunction()
>> > Verifying instruction:
>> >%0 = argument of bb0 : $τ_0_0 // user: %1
>> > ->   %1 = init_existential_ref %0 : $τ_0_0 : $τ_0_0, $SomeProtocol // 
>> > user: %2
>> >
>> > The SIL looks correct to me though.
>> >
>> > --Raj
>> > ___
>> > swift-dev mailing list
>> > swift-dev@swift.org 
>> > https://lists.swift.org/mailman/listinfo/swift-dev 
>> > 
>> 
>> 
> 
> 
> ___
> swift-dev mailing list
> swift-dev@swift.org
> https://lists.swift.org/mailman/listinfo/swift-dev

___
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

Re: [swift-dev] [Swift CI] Build Still Failing: 0. OSS - LLDB Incremental - OS X (master-llvm-swift5-transition) #15

2018-01-12 Thread Vedant Kumar via swift-dev 
I'm looking into the lldb failures.

vedant

> On Jan 11, 2018, at 11:09 PM, swift...@swift.org wrote:
> 
> New issue found!
> 
> [FAILURE] oss-lldb-swift-master-llvm-swift5-transition-incremental-osx [#15]
> 
> Build URL:
> https://ci.swift.org/job/oss-lldb-swift-master-llvm-swift5-transition-incremental-osx/15/
>  
> 
> Project:  oss-lldb-swift-master-llvm-swift5-transition-incremental-osx
> Date of build:Fri, 12 Jan 2018 00:22:59 -0600
> Build duration:   46 min
___
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

Re: [swift-dev] [Swift CI] Build Failure: OSS - Swift Package - OS X (master) #1021

2018-01-11 Thread Vedant Kumar via swift-dev 
Sorry for the noise, I see that you'd already taken care of this with 
d104a7aec405177384a4cf92a101b99297183fed.

vedant

> On Jan 11, 2018, at 5:36 PM, Vedant Kumar  wrote:
> 
> Hi Slava,
> 
> I think there might be a separate compilation breakage related to: IRGen: 
> Remove FieldAccess::NonConstantIndirect.
> 
> /Users/buildnode/jenkins/workspace/oss-lldb-swift-master-llvm-swift5-transition-incremental-osx/lldb/source/Symbol/SwiftASTContext.cpp:6891:38:
>  error: no member named 'mangleFieldOffsetFull' in 
> 'swift::irgen::IRGenMangler'
> 
>std::string buffer = mangler.mangleFieldOffsetFull(the_value_decl, 
> false);
> 
> Mind taking a look?
> 
> thanks,
> vedant
> 
> 
>> On Jan 11, 2018, at 2:52 PM, Slava Pestov via swift-dev 
>>  wrote:
>> 
>> That test failure is my fault. Sorry about that, I’ll fix it shortly. In the 
>> mean time you can do a smoke test instead of a full test and it won’t run 
>> i386 tests.
>> 
>> Slava
>> 
>>> On Jan 11, 2018, at 2:51 PM, Itai Ferber  wrote:
>>> 
>>> Hi Doug, Slava,
>>> 
>>> Looks like this is still an issue — just hit this on 
>>> https://github.com/apple/swift/pull/13879
>>> Does this failure look familiar to either of you?
>>> 
>>> — Itai
>>> 
>>> On 11 Jan 2018, at 7:12, swift-ci--- via swift-dev wrote:
>>> 
>>> [FAILURE] oss-swift-package-osx [#1021]
>>> 
>>> Build URL:  https://ci.swift.org/job/oss-swift-package-osx/1021/
>>> Project:oss-swift-package-osx
>>> Date of build:  Thu, 11 Jan 2018 06:39:53 -0600
>>> Build duration: 2 hr 32 min
>>> Identified problems:
>>> 
>>> • Regression test failed: This build failed because a regression test 
>>> in the test suite FAILed. Below is a list of all errors:
>>> • Indication 1
>>> • Compile Error: This build failed because of a compile error. Below is 
>>> a list of all errors in the build log:
>>> • Indication 1
>>> 
>>> Changes
>>> 
>>> • Commit 005267f2b087f1db34688670b5e273015dcdd2f2 by spestov:
>>> SIL: Remove obsolete comments from FormalLinkage.h
>>> 
>>> • edit: include/swift/SIL/FormalLinkage.h
>>> 
>>> • Commit 3dae007465eca11d6d202ed411579ffc86826f2a by spestov:
>>> IRGen: Remove FieldAccess::NonConstantIndirect
>>> 
>>> • edit: lib/IRGen/GenClass.cpp
>>> • edit: lib/IRGen/GenDecl.cpp
>>> • edit: lib/IRGen/GenMeta.cpp
>>> • edit: lib/TBDGen/TBDGen.cpp
>>> • edit: lib/IRGen/IRGenModule.h
>>> • edit: lib/IRGen/IRGenMangler.h
>>> • edit: lib/IRGen/Linking.cpp
>>> • edit: include/swift/IRGen/Linking.h
>>> • edit: lib/IRGen/StructLayout.h
>>> • edit: lib/IRGen/GenKeyPath.cpp
>>> 
>>> • Commit d134529e5491cce10b3af76e98356952e2c472f9 by spestov:
>>> IRGen: Field offset symbols of resilient classes have hidden linkage
>>> 
>>> • edit: test/IRGen/class_resilience.swift
>>> • edit: lib/IRGen/GenDecl.cpp
>>> 
>>> • Commit 065d18921f57d8e18637a6b9dd6d152806e5ed55 by spestov:
>>> IRGen: Test protocol dispatch thunk for a throwing method requirement
>>> 
>>> • edit: test/IRGen/protocol_resilience_thunks.swift
>>> 
>>> • Commit df10c8659b19ea0bf6ff34d95c87db4e3b4b480a by spestov:
>>> SILOptimizer: Fix mandatory inlining bug with resilience
>>> 
>>> • edit: lib/SILOptimizer/Mandatory/MandatoryInlining.cpp
>>> • add: test/SILOptimizer/mandatory_inlining_resilience.sil
>>> 
>>> • Commit 992da7494ba8a0086f34e09b9dbd61ca6fb46d5f by spestov:
>>> SIL: Remove some uses of LValueType
>>> 
>>> • edit: lib/SIL/TypeLowering.cpp
>>> 
>>> • Commit 43aebc832e0a9c596d89a77c65b894b8ac570c95 by github:
>>> Revert "IUO: Add support for non-subscript dynamic lookup."
>>> 
>>> • edit: lib/Sema/ConstraintLocator.h
>>> • edit: lib/Sema/ConstraintSystem.cpp
>>> • edit: lib/Sema/CSApply.cpp
>>> • edit: lib/Sema/ConstraintSystem.h
>>> • edit: lib/Sema/ConstraintLocator.cpp
>>> 
>>> • Commit 2c86f918def205b9414d89ee7967360ef56fc88f by dgregor:
>>> [Runtime] Add tests for demanling never-before-seen types to metadata.
>>> 
>>> • edit: test/Runtime/demangleToMetadata.swift
>>> 
>>> • Commit 35268902332dd3ac0b746f863c9517bc2a96c1cb by spestov:
>>> TypeReconstruction: Fix reconstruction of InOutType
>>> 
>>> • edit: test/IDE/reconstruct_type_from_mangled_name.swift
>>> • edit: lib/IDE/TypeReconstruction.cpp
>>> 
>>> • Commit 759f4c3a2cb1531958465058849fabdb4e09e628 by dgregor:
>>> [Runtime] Skip Objective-C type records when looking for types.
>>> 
>>> • edit: test/Runtime/demangleToMetadataObjC.swift
>>> • edit: stdlib/public/runtime/ProtocolConformance.cpp
>>> • edit: stdlib/public/runtime/MetadataLookup.cpp
>>> 
>>> • Commit d104a7aec405177384a4cf92a101b99297183fed

Re: [swift-dev] [Swift CI] Build Failure: OSS - Swift Package - OS X (master) #1021

2018-01-11 Thread Vedant Kumar via swift-dev 
Hi Slava,

I think there might be a separate compilation breakage related to: IRGen: 
Remove FieldAccess::NonConstantIndirect.

/Users/buildnode/jenkins/workspace/oss-lldb-swift-master-llvm-swift5-transition-incremental-osx/lldb/source/Symbol/SwiftASTContext.cpp:6891:38:
 error: no member named 'mangleFieldOffsetFull' in 'swift::irgen::IRGenMangler'

std::string buffer = mangler.mangleFieldOffsetFull(the_value_decl, 
false);

Mind taking a look?

thanks,
vedant


> On Jan 11, 2018, at 2:52 PM, Slava Pestov via swift-dev  
> wrote:
> 
> That test failure is my fault. Sorry about that, I’ll fix it shortly. In the 
> mean time you can do a smoke test instead of a full test and it won’t run 
> i386 tests.
> 
> Slava
> 
>> On Jan 11, 2018, at 2:51 PM, Itai Ferber  wrote:
>> 
>> Hi Doug, Slava,
>> 
>> Looks like this is still an issue — just hit this on 
>> https://github.com/apple/swift/pull/13879
>> Does this failure look familiar to either of you?
>> 
>> — Itai
>> 
>> On 11 Jan 2018, at 7:12, swift-ci--- via swift-dev wrote:
>> 
>> [FAILURE] oss-swift-package-osx [#1021]
>> 
>> Build URL:   https://ci.swift.org/job/oss-swift-package-osx/1021/
>> Project: oss-swift-package-osx
>> Date of build:   Thu, 11 Jan 2018 06:39:53 -0600
>> Build duration:  2 hr 32 min
>> Identified problems:
>> 
>>  • Regression test failed: This build failed because a regression test 
>> in the test suite FAILed. Below is a list of all errors:
>>  • Indication 1
>>  • Compile Error: This build failed because of a compile error. Below is 
>> a list of all errors in the build log:
>>  • Indication 1
>> 
>> Changes
>> 
>>  • Commit 005267f2b087f1db34688670b5e273015dcdd2f2 by spestov:
>> SIL: Remove obsolete comments from FormalLinkage.h
>> 
>>  • edit: include/swift/SIL/FormalLinkage.h
>> 
>>  • Commit 3dae007465eca11d6d202ed411579ffc86826f2a by spestov:
>> IRGen: Remove FieldAccess::NonConstantIndirect
>> 
>>  • edit: lib/IRGen/GenClass.cpp
>>  • edit: lib/IRGen/GenDecl.cpp
>>  • edit: lib/IRGen/GenMeta.cpp
>>  • edit: lib/TBDGen/TBDGen.cpp
>>  • edit: lib/IRGen/IRGenModule.h
>>  • edit: lib/IRGen/IRGenMangler.h
>>  • edit: lib/IRGen/Linking.cpp
>>  • edit: include/swift/IRGen/Linking.h
>>  • edit: lib/IRGen/StructLayout.h
>>  • edit: lib/IRGen/GenKeyPath.cpp
>> 
>>  • Commit d134529e5491cce10b3af76e98356952e2c472f9 by spestov:
>> IRGen: Field offset symbols of resilient classes have hidden linkage
>> 
>>  • edit: test/IRGen/class_resilience.swift
>>  • edit: lib/IRGen/GenDecl.cpp
>> 
>>  • Commit 065d18921f57d8e18637a6b9dd6d152806e5ed55 by spestov:
>> IRGen: Test protocol dispatch thunk for a throwing method requirement
>> 
>>  • edit: test/IRGen/protocol_resilience_thunks.swift
>> 
>>  • Commit df10c8659b19ea0bf6ff34d95c87db4e3b4b480a by spestov:
>> SILOptimizer: Fix mandatory inlining bug with resilience
>> 
>>  • edit: lib/SILOptimizer/Mandatory/MandatoryInlining.cpp
>>  • add: test/SILOptimizer/mandatory_inlining_resilience.sil
>> 
>>  • Commit 992da7494ba8a0086f34e09b9dbd61ca6fb46d5f by spestov:
>> SIL: Remove some uses of LValueType
>> 
>>  • edit: lib/SIL/TypeLowering.cpp
>> 
>>  • Commit 43aebc832e0a9c596d89a77c65b894b8ac570c95 by github:
>> Revert "IUO: Add support for non-subscript dynamic lookup."
>> 
>>  • edit: lib/Sema/ConstraintLocator.h
>>  • edit: lib/Sema/ConstraintSystem.cpp
>>  • edit: lib/Sema/CSApply.cpp
>>  • edit: lib/Sema/ConstraintSystem.h
>>  • edit: lib/Sema/ConstraintLocator.cpp
>> 
>>  • Commit 2c86f918def205b9414d89ee7967360ef56fc88f by dgregor:
>> [Runtime] Add tests for demanling never-before-seen types to metadata.
>> 
>>  • edit: test/Runtime/demangleToMetadata.swift
>> 
>>  • Commit 35268902332dd3ac0b746f863c9517bc2a96c1cb by spestov:
>> TypeReconstruction: Fix reconstruction of InOutType
>> 
>>  • edit: test/IDE/reconstruct_type_from_mangled_name.swift
>>  • edit: lib/IDE/TypeReconstruction.cpp
>> 
>>  • Commit 759f4c3a2cb1531958465058849fabdb4e09e628 by dgregor:
>> [Runtime] Skip Objective-C type records when looking for types.
>> 
>>  • edit: test/Runtime/demangleToMetadataObjC.swift
>>  • edit: stdlib/public/runtime/ProtocolConformance.cpp
>>  • edit: stdlib/public/runtime/MetadataLookup.cpp
>> 
>>  • Commit d104a7aec405177384a4cf92a101b99297183fed by spestov:
>> [Swift] Update for mangler API change
>> 
>>  • edit: source/Symbol/SwiftASTContext.cpp
>> 
>> ___
>> swift-dev mailing list
>> swift-dev@swift.org
>> https://lists.swift.org/mailman/listinfo/swift-dev
>> 
> 
>

Re: [swift-dev] [Swift CI] Build Failure: 2. Swift Source Compatibility Suite (master) #1014

2018-01-03 Thread Vedant Kumar via swift-dev 

> On Jan 3, 2018, at 7:46 PM, Slava Pestov  wrote:
> 
> 
> 
>> On Jan 3, 2018, at 7:36 PM, Vedant Kumar > > wrote:
>> 
>>> 
>>> On Jan 3, 2018, at 7:34 PM, Mark Lacey >> > wrote:
>>> 
>>> 
>>> 
 On Jan 3, 2018, at 7:31 PM, Vedant Kumar > wrote:
 
> 
> On Jan 3, 2018, at 7:23 PM, Mark Lacey  > wrote:
> 
> 
> 
>> On Jan 3, 2018, at 7:18 PM, Vedant Kumar > > wrote:
>> 
>> This is a bit surprising, since I wouldn't expect this suite of tests to 
>> stress the code coverage logic.
>> 
>> How were you able to determine that the #13597 caused the break? 
> 
> I’m seeing this in the failing builds:
> 
> Assertion failed: (std::all_of(Mappings.begin(), Mappings.end(), [](const 
> SILCoverageMap ) { return M.hasSymtabEntry(); }) && "Missing symtab 
> entry for coverage mapping"), function emitCoverageMapping, file 
> /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/swift/lib/IRGen/GenCoverage.cpp,
>  line 53.
 
 I added this assert as a debugging tool, with plans on making it a 
 defensive measure. I.e, we'd use the check to avoid emitting broken 
 coverage mapping data. Instead of reverting, it might be easier to finish 
 that up. Wdyt?
>>> 
>>> Is that something you can do quickly?
>> 
>> I think so, I should have it done tonight. If it's looking unlikely, I can 
>> finish up the revert of #13597. Is that ok?
>> 
>> vedant
> 
> Why don’t you just temporarily disable the assertion?

I thought it'd be simpler to finish up the planned work. I've got the patch 
ready: https://github.com/apple/swift/pull/13711 
. If it'd be better to have a 
smaller change, I'm open to disable the assert.

vedant



> 
> Slava
> 
>> 
>>> 
>>> It’s blocking PR testing for source compatibility, which means we get no 
>>> coverage for people that want to run those tests until this is fixed or 
>>> reverted.
>>> 
>>> Mark
>>> 
 
 
> 
>> I'm having a hard time understanding what the logs mean. For example, I 
>> see this failure, but I'm not sure how my change relates to it:
> 
> It’s non-obvious, but the easiest thing to do is download the build 
> artifacts via a couple clicks from 
> https://ci.swift.org/job/swift-master-source-compat-suite/1014/ 
> , and 
> then look at the logs named FAIL_*.
 
 Thanks, I see the failures now.
 
 
> 
>> 
>> FAIL: JSQDataSourcesKit, 3.0, b764e3, JSQDataSourcesKit-iOS, 
>> generic/platform=iOS, ExecuteCommandFailure(command="sandbox-exec -f 
>> /Users/buildnode/jenkins/workspace-private/swift-source-compat-suite-sandbox/sandbox_xcodebuild.sb
>>  xcodebuild clean build -project 
>> /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/JSQDataSourcesKit/JSQDataSourcesKit.xcodeproj
>>  -target JSQDataSourcesKit-iOS -destination generic/platform=iOS 
>> SYMROOT=/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/JSQDataSourcesKit/build
>>  -sdk 
>> /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS11.2.sdk
>>  CODE_SIGN_IDENTITY= CODE_SIGNING_REQUIRED=NO ENABLE_BITCODE=NO 
>> INDEX_ENABLE_DATA_STORE=NO GCC_TREAT_WARNINGS_AS_ERRORS=NO 
>> SWIFT_TREAT_WARNINGS_AS_ERRORS=NO 
>> 'OTHER_SWIFT_FLAGS=$(OTHER_SWIFT_FLAGS) -swift-version 3' -configuration 
>> Release 
>> SWIFT_EXEC=/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/build/compat_macos/install/toolchain/usr/bin/swiftc
>>  SWIFT_VERSION=3", returncode=65)
>> Can I reproduce the issue with `build-script -t`?
> 
> You should be able to reproduce by building and then following the 
> instructions here to run a single project build: 
> https://github.com/apple/swift-source-compat-suite/blob/master/README.md 
> 
 Thanks.
 
 vedant
 
> 
> Mark
> 
> 
>> 
>> thanks,
>> vedant
>> 
>>> On Jan 3, 2018, at 7:10 PM, Mark Lacey >> > wrote:
>>> 
>>> Vedant, this appears to be a result of your changes.
>>> 
>>> I’ve opened https://github.com/apple/swift/pull/13709 
>>>  to revert the later 
>>> clean-up change which appears to be required before it will be possible 
>>> to revert the change below.
>>> 
>>> Mark
>>>

Re: [swift-dev] [Swift CI] Build Failure: 2. Swift Source Compatibility Suite (master) #1014

2018-01-03 Thread Vedant Kumar via swift-dev 

> On Jan 3, 2018, at 7:34 PM, Mark Lacey  wrote:
> 
> 
> 
>> On Jan 3, 2018, at 7:31 PM, Vedant Kumar > > wrote:
>> 
>>> 
>>> On Jan 3, 2018, at 7:23 PM, Mark Lacey >> > wrote:
>>> 
>>> 
>>> 
 On Jan 3, 2018, at 7:18 PM, Vedant Kumar > wrote:
 
 This is a bit surprising, since I wouldn't expect this suite of tests to 
 stress the code coverage logic.
 
 How were you able to determine that the #13597 caused the break? 
>>> 
>>> I’m seeing this in the failing builds:
>>> 
>>> Assertion failed: (std::all_of(Mappings.begin(), Mappings.end(), [](const 
>>> SILCoverageMap ) { return M.hasSymtabEntry(); }) && "Missing symtab entry 
>>> for coverage mapping"), function emitCoverageMapping, file 
>>> /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/swift/lib/IRGen/GenCoverage.cpp,
>>>  line 53.
>> 
>> I added this assert as a debugging tool, with plans on making it a defensive 
>> measure. I.e, we'd use the check to avoid emitting broken coverage mapping 
>> data. Instead of reverting, it might be easier to finish that up. Wdyt?
> 
> Is that something you can do quickly?

I think so, I should have it done tonight. If it's looking unlikely, I can 
finish up the revert of #13597. Is that ok?

vedant

> 
> It’s blocking PR testing for source compatibility, which means we get no 
> coverage for people that want to run those tests until this is fixed or 
> reverted.
> 
> Mark
> 
>> 
>> 
>>> 
 I'm having a hard time understanding what the logs mean. For example, I 
 see this failure, but I'm not sure how my change relates to it:
>>> 
>>> It’s non-obvious, but the easiest thing to do is download the build 
>>> artifacts via a couple clicks from 
>>> https://ci.swift.org/job/swift-master-source-compat-suite/1014/ 
>>> , and then 
>>> look at the logs named FAIL_*.
>> 
>> Thanks, I see the failures now.
>> 
>> 
>>> 
 
 FAIL: JSQDataSourcesKit, 3.0, b764e3, JSQDataSourcesKit-iOS, 
 generic/platform=iOS, ExecuteCommandFailure(command="sandbox-exec -f 
 /Users/buildnode/jenkins/workspace-private/swift-source-compat-suite-sandbox/sandbox_xcodebuild.sb
  xcodebuild clean build -project 
 /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/JSQDataSourcesKit/JSQDataSourcesKit.xcodeproj
  -target JSQDataSourcesKit-iOS -destination generic/platform=iOS 
 SYMROOT=/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/JSQDataSourcesKit/build
  -sdk 
 /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS11.2.sdk
  CODE_SIGN_IDENTITY= CODE_SIGNING_REQUIRED=NO ENABLE_BITCODE=NO 
 INDEX_ENABLE_DATA_STORE=NO GCC_TREAT_WARNINGS_AS_ERRORS=NO 
 SWIFT_TREAT_WARNINGS_AS_ERRORS=NO 'OTHER_SWIFT_FLAGS=$(OTHER_SWIFT_FLAGS) 
 -swift-version 3' -configuration Release 
 SWIFT_EXEC=/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/build/compat_macos/install/toolchain/usr/bin/swiftc
  SWIFT_VERSION=3", returncode=65)
 Can I reproduce the issue with `build-script -t`?
>>> 
>>> You should be able to reproduce by building and then following the 
>>> instructions here to run a single project build: 
>>> https://github.com/apple/swift-source-compat-suite/blob/master/README.md 
>>> 
>> Thanks.
>> 
>> vedant
>> 
>>> 
>>> Mark
>>> 
>>> 
 
 thanks,
 vedant
 
> On Jan 3, 2018, at 7:10 PM, Mark Lacey  > wrote:
> 
> Vedant, this appears to be a result of your changes.
> 
> I’ve opened https://github.com/apple/swift/pull/13709 
>  to revert the later clean-up 
> change which appears to be required before it will be possible to revert 
> the change below.
> 
> Mark
> 
>> On Jan 3, 2018, at 6:06 PM, swift...@swift.org 
>>  wrote:
>> 
>> [FAILURE] swift-master-source-compat-suite [#1014]
>> 
>> Build URL:   
>> https://ci.swift.org/job/swift-master-source-compat-suite/1014/ 
>> 
>> Project: swift-master-source-compat-suite
>> Date of build:   Wed, 03 Jan 2018 16:40:37 -0600
>> Build duration:  3 hr 26 min
>> 
>> Changes
>> 
>> Commit 5307f5d2ecdbcab62ae203ef21d2e1b95e2723f7 by dgregor:
>> [Runtime] Add "reserved" protocol conformance kind and ignore it.
>> 
>> edit: stdlib/public/runtime/ProtocolConformance.cpp
>> edit: include/swift/Runtime/Metadata.h
>> edit:

Re: [swift-dev] [Swift CI] Build Failure: 2. Swift Source Compatibility Suite (master) #1014

2018-01-03 Thread Vedant Kumar via swift-dev 

> On Jan 3, 2018, at 7:23 PM, Mark Lacey  wrote:
> 
> 
> 
>> On Jan 3, 2018, at 7:18 PM, Vedant Kumar > > wrote:
>> 
>> This is a bit surprising, since I wouldn't expect this suite of tests to 
>> stress the code coverage logic.
>> 
>> How were you able to determine that the #13597 caused the break?
> 
> I’m seeing this in the failing builds:
> 
> Assertion failed: (std::all_of(Mappings.begin(), Mappings.end(), [](const 
> SILCoverageMap ) { return M.hasSymtabEntry(); }) && "Missing symtab entry 
> for coverage mapping"), function emitCoverageMapping, file 
> /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/swift/lib/IRGen/GenCoverage.cpp,
>  line 53.

I added this assert as a debugging tool, with plans on making it a defensive 
measure. I.e, we'd use the check to avoid emitting broken coverage mapping 
data. Instead of reverting, it might be easier to finish that up. Wdyt?


> 
>> I'm having a hard time understanding what the logs mean. For example, I see 
>> this failure, but I'm not sure how my change relates to it:
> 
> It’s non-obvious, but the easiest thing to do is download the build artifacts 
> via a couple clicks from 
> https://ci.swift.org/job/swift-master-source-compat-suite/1014/ 
> , and then 
> look at the logs named FAIL_*.

Thanks, I see the failures now.


> 
>> 
>> FAIL: JSQDataSourcesKit, 3.0, b764e3, JSQDataSourcesKit-iOS, 
>> generic/platform=iOS, ExecuteCommandFailure(command="sandbox-exec -f 
>> /Users/buildnode/jenkins/workspace-private/swift-source-compat-suite-sandbox/sandbox_xcodebuild.sb
>>  xcodebuild clean build -project 
>> /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/JSQDataSourcesKit/JSQDataSourcesKit.xcodeproj
>>  -target JSQDataSourcesKit-iOS -destination generic/platform=iOS 
>> SYMROOT=/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/JSQDataSourcesKit/build
>>  -sdk 
>> /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS11.2.sdk
>>  CODE_SIGN_IDENTITY= CODE_SIGNING_REQUIRED=NO ENABLE_BITCODE=NO 
>> INDEX_ENABLE_DATA_STORE=NO GCC_TREAT_WARNINGS_AS_ERRORS=NO 
>> SWIFT_TREAT_WARNINGS_AS_ERRORS=NO 'OTHER_SWIFT_FLAGS=$(OTHER_SWIFT_FLAGS) 
>> -swift-version 3' -configuration Release 
>> SWIFT_EXEC=/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/build/compat_macos/install/toolchain/usr/bin/swiftc
>>  SWIFT_VERSION=3", returncode=65)
>> Can I reproduce the issue with `build-script -t`?
> 
> You should be able to reproduce by building and then following the 
> instructions here to run a single project build: 
> https://github.com/apple/swift-source-compat-suite/blob/master/README.md 
> 
Thanks.

vedant

> 
> Mark
> 
> 
>> 
>> thanks,
>> vedant
>> 
>>> On Jan 3, 2018, at 7:10 PM, Mark Lacey >> > wrote:
>>> 
>>> Vedant, this appears to be a result of your changes.
>>> 
>>> I’ve opened https://github.com/apple/swift/pull/13709 
>>>  to revert the later clean-up 
>>> change which appears to be required before it will be possible to revert 
>>> the change below.
>>> 
>>> Mark
>>> 
 On Jan 3, 2018, at 6:06 PM, swift...@swift.org  
 wrote:
 
 [FAILURE] swift-master-source-compat-suite [#1014]
 
 Build URL: https://ci.swift.org/job/swift-master-source-compat-suite/1014/ 
 
 Project:   swift-master-source-compat-suite
 Date of build: Wed, 03 Jan 2018 16:40:37 -0600
 Build duration:3 hr 26 min
 
 Changes
 
 Commit 5307f5d2ecdbcab62ae203ef21d2e1b95e2723f7 by dgregor:
 [Runtime] Add "reserved" protocol conformance kind and ignore it.
 
 edit: stdlib/public/runtime/ProtocolConformance.cpp
 edit: include/swift/Runtime/Metadata.h
 edit: include/swift/ABI/MetadataValues.h
 
 Commit 8c668ba524969856496f2b96f6efca188a36c2f6 by dgregor:
 [Runtime] Rename the segment for protocol conformance records.
 
 edit: stdlib/public/runtime/ImageInspectionCOFF.cpp
 edit: stdlib/public/runtime/ImageInspectionELF.h
 edit: stdlib/public/runtime/ImageInspectionELF.cpp
 edit: stdlib/public/runtime/ImageInspectionCOFF.h
 edit: stdlib/public/runtime/ImageInspectionMachO.cpp
 edit: stdlib/public/runtime/SwiftRT-ELF.cpp
 edit: lib/IRGen/GenDecl.cpp
 
 Commit 314d705f417b357d03c99e9153cf819d13df595e by mark.lacey:
 Sema: Look through inout when mapping IUOs to Optionals.
 
 edit: lib/AST/Decl.cpp
 edit: test/decl/overload.swift
 
 Commit 7e6f52308d4db11ef6e560f63235e5cfa4346c6d by dgregor:

Re: [swift-dev] [Swift CI] Build Failure: 2. Swift Source Compatibility Suite (master) #1014

2018-01-03 Thread Vedant Kumar via swift-dev 
This is a bit surprising, since I wouldn't expect this suite of tests to stress 
the code coverage logic.

How were you able to determine that the #13597 caused the break? I'm having a 
hard time understanding what the logs mean. For example, I see this failure, 
but I'm not sure how my change relates to it:

FAIL: JSQDataSourcesKit, 3.0, b764e3, JSQDataSourcesKit-iOS, 
generic/platform=iOS, ExecuteCommandFailure(command="sandbox-exec -f 
/Users/buildnode/jenkins/workspace-private/swift-source-compat-suite-sandbox/sandbox_xcodebuild.sb
 xcodebuild clean build -project 
/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/JSQDataSourcesKit/JSQDataSourcesKit.xcodeproj
 -target JSQDataSourcesKit-iOS -destination generic/platform=iOS 
SYMROOT=/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/JSQDataSourcesKit/build
 -sdk 
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS11.2.sdk
 CODE_SIGN_IDENTITY= CODE_SIGNING_REQUIRED=NO ENABLE_BITCODE=NO 
INDEX_ENABLE_DATA_STORE=NO GCC_TREAT_WARNINGS_AS_ERRORS=NO 
SWIFT_TREAT_WARNINGS_AS_ERRORS=NO 'OTHER_SWIFT_FLAGS=$(OTHER_SWIFT_FLAGS) 
-swift-version 3' -configuration Release 
SWIFT_EXEC=/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/build/compat_macos/install/toolchain/usr/bin/swiftc
 SWIFT_VERSION=3", returncode=65)
Can I reproduce the issue with `build-script -t`?

thanks,
vedant

> On Jan 3, 2018, at 7:10 PM, Mark Lacey  wrote:
> 
> Vedant, this appears to be a result of your changes.
> 
> I’ve opened https://github.com/apple/swift/pull/13709 
>  to revert the later clean-up 
> change which appears to be required before it will be possible to revert the 
> change below.
> 
> Mark
> 
>> On Jan 3, 2018, at 6:06 PM, swift...@swift.org  
>> wrote:
>> 
>> [FAILURE] swift-master-source-compat-suite [#1014]
>> 
>> Build URL:   https://ci.swift.org/job/swift-master-source-compat-suite/1014/ 
>> 
>> Project: swift-master-source-compat-suite
>> Date of build:   Wed, 03 Jan 2018 16:40:37 -0600
>> Build duration:  3 hr 26 min
>> 
>> Changes
>> 
>> Commit 5307f5d2ecdbcab62ae203ef21d2e1b95e2723f7 by dgregor:
>> [Runtime] Add "reserved" protocol conformance kind and ignore it.
>> 
>> edit: stdlib/public/runtime/ProtocolConformance.cpp
>> edit: include/swift/Runtime/Metadata.h
>> edit: include/swift/ABI/MetadataValues.h
>> 
>> Commit 8c668ba524969856496f2b96f6efca188a36c2f6 by dgregor:
>> [Runtime] Rename the segment for protocol conformance records.
>> 
>> edit: stdlib/public/runtime/ImageInspectionCOFF.cpp
>> edit: stdlib/public/runtime/ImageInspectionELF.h
>> edit: stdlib/public/runtime/ImageInspectionELF.cpp
>> edit: stdlib/public/runtime/ImageInspectionCOFF.h
>> edit: stdlib/public/runtime/ImageInspectionMachO.cpp
>> edit: stdlib/public/runtime/SwiftRT-ELF.cpp
>> edit: lib/IRGen/GenDecl.cpp
>> 
>> Commit 314d705f417b357d03c99e9153cf819d13df595e by mark.lacey:
>> Sema: Look through inout when mapping IUOs to Optionals.
>> 
>> edit: lib/AST/Decl.cpp
>> edit: test/decl/overload.swift
>> 
>> Commit 7e6f52308d4db11ef6e560f63235e5cfa4346c6d by dgregor:
>> [Runtime] Move conformance kind into low bits of witness table
>> 
>> edit: include/swift/Basic/RelativePointer.h
>> edit: docs/ABI/TypeMetadata.rst
>> edit: test/IRGen/protocol_conformance_records.swift
>> edit: include/swift/ABI/MetadataValues.h
>> edit: include/swift/Runtime/Metadata.h
>> edit: lib/IRGen/GenDecl.cpp
>> 
>> Commit 32ab89b0cc149a86cde206cca67bfeb27bd42521 by dgregor:
>> [Runtime] Reference ObjC class objects indirectly in conformance
>> 
>> edit: test/IRGen/protocol_conformance_records_objc.swift
>> edit: lib/IRGen/GenDecl.cpp
>> edit: include/swift/Runtime/Metadata.h
>> edit: test/IRGen/objc_bridged_generic_conformance.swift
>> 
>> Commit e3d6a2b9a2b3bbc80a1ccf5079a76751ff6a05ec by spestov:
>> IRGen: Correctly set class metadata base offset variable
>> 
>> edit: test/IRGen/class_resilience.swift
>> edit: lib/IRGen/GenMeta.cpp
>> edit: lib/IRGen/MetadataLayout.cpp
>> edit: lib/IRGen/MetadataLayout.h
>> 
>> Commit 22f08f7f472dee57ffb1e7d9678411bcd87fc4a8 by spestov:
>> Runtime: Set metadata size when allocating runtime-sized class metadata
>> 
>> edit: stdlib/public/runtime/Metadata.cpp
>> 
>> Commit c1782d8cc01e5b7e5da6643c946c2c618575ec1b by dgregor:
>> [Runtime] Eliminate the UniqueDirectClass metadata record kind.
>> 
>> edit: stdlib/public/runtime/MetadataLookup.cpp
>> edit: include/swift/ABI/MetadataValues.h
>> edit: stdlib/public/runtime/ProtocolConformance.cpp
>> edit: lib/IRGen/GenDecl.cpp
>> edit: test/IRGen/protocol_conformance_records.swift
>> edit: include/swift/Runtime/Metadata.h
>> 
>> Commit fea92a0214aaf7f61a676d6dd3b9efdf695ed848 by spestov:
>> Runtime: Add support for resilient

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.04 - Long Test (swift 4.1) #126

2017-11-08 Thread Vedant Kumar via swift-dev 
Does anyone know what's up with 
swift-corelibs-libdispatch/dispatch/module.modulemap?

[2/25] Generating swiftDispatch.o, swift/Dispatch.swiftmodule, 
swift/Dispatch.swiftdoc
FAILED: src/swiftDispatch.o src/swift/Dispatch.swiftmodule 
src/swift/Dispatch.swiftdoc 
cd 
/home/buildnode/jenkins/workspace/oss-swift-4.1-incremental-RA-linux-ubuntu-16_04-long-test/buildbot_incremental/libdispatch-linux-x86_64/src
 && /usr/bin/cmake -E make_directory 
/home/buildnode/jenkins/workspace/oss-swift-4.1-incremental-RA-linux-ubuntu-16_04-long-test/buildbot_incremental/libdispatch-linux-x86_64/src/swift
 && 
/home/buildnode/jenkins/workspace/oss-swift-4.1-incremental-RA-linux-ubuntu-16_04-long-test/buildbot_incremental/swift-linux-x86_64/bin/swiftc
 -emit-library -module-name Dispatch -module-link-name dispatch 
-emit-module-path 
/home/buildnode/jenkins/workspace/oss-swift-4.1-incremental-RA-linux-ubuntu-16_04-long-test/buildbot_incremental/libdispatch-linux-x86_64/src/swift/Dispatch.swiftmodule
 -I 
/home/buildnode/jenkins/workspace/oss-swift-4.1-incremental-RA-linux-ubuntu-16_04-long-test/swift-corelibs-libdispatch
 -O -Xcc -fblocks -Xcc 
-fmodule-map-file=/home/buildnode/jenkins/workspace/oss-swift-4.1-incremental-RA-linux-ubuntu-16_04-long-test/swift-corelibs-libdispatch/dispatch/module.modulemap
 -force-single-frontend-invocation -c 
/home/buildnode/jenkins/workspace/oss-swift-4.1-incremental-RA-linux-ubuntu-16_04-long-test/swift-corelibs-libdispatch/src/swift/Block.swift
 
/home/buildnode/jenkins/workspace/oss-swift-4.1-incremental-RA-linux-ubuntu-16_04-long-test/swift-corelibs-libdispatch/src/swift/Data.swift
 
/home/buildnode/jenkins/workspace/oss-swift-4.1-incremental-RA-linux-ubuntu-16_04-long-test/swift-corelibs-libdispatch/src/swift/Dispatch.swift
 
/home/buildnode/jenkins/workspace/oss-swift-4.1-incremental-RA-linux-ubuntu-16_04-long-test/swift-corelibs-libdispatch/src/swift/IO.swift
 
/home/buildnode/jenkins/workspace/oss-swift-4.1-incremental-RA-linux-ubuntu-16_04-long-test/swift-corelibs-libdispatch/src/swift/Private.swift
 
/home/buildnode/jenkins/workspace/oss-swift-4.1-incremental-RA-linux-ubuntu-16_04-long-test/swift-corelibs-libdispatch/src/swift/Queue.swift
 
/home/buildnode/jenkins/workspace/oss-swift-4.1-incremental-RA-linux-ubuntu-16_04-long-test/swift-corelibs-libdispatch/src/swift/Source.swift
 
/home/buildnode/jenkins/workspace/oss-swift-4.1-incremental-RA-linux-ubuntu-16_04-long-test/swift-corelibs-libdispatch/src/swift/Time.swift
 
/home/buildnode/jenkins/workspace/oss-swift-4.1-incremental-RA-linux-ubuntu-16_04-long-test/swift-corelibs-libdispatch/src/swift/Wrapper.swift
 -o 
/home/buildnode/jenkins/workspace/oss-swift-4.1-incremental-RA-linux-ubuntu-16_04-long-test/buildbot_incremental/libdispatch-linux-x86_64/src/swiftDispatch.o
 <>:0: error: module map file 
'/home/buildnode/jenkins/workspace/oss-swift-4.1-incremental-RA-linux-ubuntu-16_04-long-test/swift-corelibs-libdispatch/dispatch/module.modulemap'
 not found
 <>:0: error: module map file 
'/home/buildnode/jenkins/workspace/oss-swift-4.1-incremental-RA-linux-ubuntu-16_04-long-test/swift-corelibs-libdispatch/dispatch/module.modulemap'
 not found
:0: error: missing required module 'SwiftShims'
ninja: build stopped: subcommand failed.


vedant

> On Nov 8, 2017, at 7:40 PM, no-re...@swift.org wrote:
> 
> [FAILURE] oss-swift-4.1-incremental-RA-linux-ubuntu-16_04-long-test [#126]
> 
> Build URL:
> https://ci.swift.org/job/oss-swift-4.1-incremental-RA-linux-ubuntu-16_04-long-test/126/
>  
> 
> Project:  oss-swift-4.1-incremental-RA-linux-ubuntu-16_04-long-test
> Date of build:Wed, 08 Nov 2017 21:11:13 -0600
> Build duration:   29 min
> Identified problems:
> 
> Compile Error: This build failed because of a compile error. Below is a list 
> of all errors in the build log:
> Indication 1 
> 
> Tests:
> 
> Name: Swift(linux-x86_64)
> Failed: 0 test(s), Passed: 10008 test(s), Total: 10008 test(s)
> Name: Swift-Unit
> Failed: 0 test(s), Passed: 497 test(s), Total: 497 test(s)
> 
> Changes
> 
> Commit 0cd96b26abb5adc937bebd714c5239f5a69adf00 by enderby:
> Fix a crash in llvm-nm for a bad Mach-O file that has an N_SECT type
> 
> add: test/tools/llvm-nm/X86/macho-bad-zero-nsect-for-N_SECT.test
> edit: tools/llvm-nm/llvm-nm.cpp
> add: test/tools/llvm-nm/X86/Inputs/macho-bad-zero-nsect-for-N_SECT
> 
> Commit b2a89068d01c236b39e9af1e9db41a8be93ba1e5 by enderby:
> Fix a bug in llvm-objdump when disassembling using the wrong default CPU
> 
> edit: tools/llvm-objdump/MachODump.cpp
> add: test/tools/llvm-objdump/AArch64/Inputs/fat.macho-armv7s-arm64
> add: test/tools/llvm-objdump/AArch64/macho-fat-arm-disasm.test
> 
> Commit 8bfb0faf66f5e8f8cea18b2239270fd1a9d899a4 by vsk:
> [Coverage] Use the

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - LLDB Incremental - OS X (swift 4.1) #48

2017-11-08 Thread Vedant Kumar via swift-dev 
Seems unrelated to my coverage cherry picks:

+ 
/Users/buildnode/jenkins/workspace/oss-lldb-swift-4.1-incremental-osx/Ninja-ReleaseAssert/lldb-macosx-x86_64/CustomSwift-Release/lldb-gtest
 
--gtest_output=xml:/Users/buildnode/jenkins/workspace/oss-lldb-swift-4.1-incremental-osx/Ninja-ReleaseAssert/lldb-macosx-x86_64/gtest-results.xml

[--] 7 tests from PythonExceptionStateTest
[ RUN  ] PythonExceptionStateTest.TestExceptionStateChecking
0  lldb-gtest   0x00010c23ca88 
llvm::sys::PrintStackTrace(llvm::raw_ostream&) + 40
1  lldb-gtest   0x00010c23d146 SignalHandler(int) + 470
2  libsystem_platform.dylib 0x7fffa1539b3a _sigtramp + 26
3  Python   0x00010f9d5bed PyDict_SetItem + 181
4  Python   0x000112961c1e PyDict_SetItem + 49856742
5  Python   0x00011295d4aa PyDict_SetItem + 49838450
6  Python   0x00011295c524 PyDict_SetItem + 49834476
7  Python   0x00011295c5b9 PyDict_SetItem + 49834625
8  Python   0x0001129517cd PyDict_SetItem + 49790101
9  Python   0x0001129593ec PyDict_SetItem + 49821876
10 libdyld.dylib0x7fffa1327832 dlopen + 59
11 Python   0x00010fa50f02 _PyImport_GetDynLoadFunc + 309
12 Python   0x00010fa3c104 _PyImport_LoadDynamicModule + 96
13 Python   0x00010fa3bbc7 PyImport_AppendInittab + 5344

vedant


> On Nov 8, 2017, at 7:16 PM, no-re...@swift.org wrote:
> 
> [FAILURE] oss-lldb-swift-4.1-incremental-osx [#48]
> 
> Build URL:https://ci.swift.org/job/oss-lldb-swift-4.1-incremental-osx/48/ 
> 
> Project:  oss-lldb-swift-4.1-incremental-osx
> Date of build:Wed, 08 Nov 2017 21:04:13 -0600
> Build duration:   12 min
> 
> Changes
> 
> Commit 376b507883962ea548e0cbf721d058163664b2de by vsk:
> [Coverage] Emit a gap area after if conditions
> 
> edit: test/CoverageMapping/casts.c
> edit: test/CoverageMapping/switch.cpp
> edit: test/CoverageMapping/includehell.cpp
> edit: test/CoverageMapping/moremacros.c
> edit: test/CoverageMapping/objc.m
> edit: test/CoverageMapping/switchmacro.c
> edit: test/CoverageMapping/label.cpp
> edit: test/CoverageMapping/test.c
> edit: test/CoverageMapping/trycatch.cpp
> edit: test/CoverageMapping/macro-expressions.cpp
> edit: test/CoverageMapping/macroscopes.cpp
> edit: test/CoverageMapping/return.c
> edit: test/CoverageMapping/preprocessor.c
> edit: test/CoverageMapping/macro-expansion.c
> edit: test/CoverageMapping/break.c
> edit: test/CoverageMapping/continue.c
> edit: lib/CodeGen/CoverageMappingGen.cpp
> edit: test/CoverageMapping/if.cpp
> 
> Commit 436936d1f7568a0a5c023fba3a340b1ffe0f1e75 by vsk:
> [Coverage] Complete top-level deferred regions before labels
> 
> edit: lib/CodeGen/CoverageMappingGen.cpp
> edit: test/CoverageMapping/label.cpp
> edit: test/CoverageMapping/switchmacro.c
> 
> Commit 654db48c18d5cc295dfa4c0329976796276f2f8c by vsk:
> [Coverage] Emit deferred regions in headers
> 
> edit: test/CoverageMapping/deferred-region.cpp
> add: test/CoverageMapping/Inputs/deferred-region-helper.h
> edit: lib/CodeGen/CoverageMappingGen.cpp
> 
> Commit 8bfb0faf66f5e8f8cea18b2239270fd1a9d899a4 by vsk:
> [Coverage] Use the wrapped segment when a line has entry segments
> 
> edit: test/tools/llvm-cov/showHighlightedRanges.cpp
> edit: test/tools/llvm-cov/Inputs/regionMarkers.covmapping
> edit: lib/ProfileData/Coverage/CoverageMapping.cpp
> edit: unittests/ProfileData/CoverageMappingTest.cpp
> edit: test/tools/llvm-cov/Inputs/instrprof-comdat.h
> edit: test/tools/llvm-cov/report.cpp
> edit: test/tools/llvm-cov/prefer_used_to_unused.h
> edit: test/tools/llvm-cov/hideUnexecutedSubviews.test
> edit: tools/llvm-cov/SourceCoverageViewHTML.cpp
> edit: test/tools/llvm-cov/Inputs/prefer_used_to_unused.covmapping
> edit: test/tools/llvm-cov/Inputs/report.covmapping
> edit: tools/llvm-cov/SourceCoverageViewText.cpp
> edit: test/tools/llvm-cov/Inputs/deferred-regions.covmapping
> edit: test/tools/llvm-cov/Inputs/templateInstantiations.covmapping
> edit: test/tools/llvm-cov/load-multiple-objects.test
> edit: test/tools/llvm-cov/Inputs/lineExecutionCounts.covmapping
> edit: test/tools/llvm-cov/Inputs/highlightedRanges.covmapping
> edit: test/tools/llvm-cov/Inputs/highlightedRanges.json
> edit: test/tools/llvm-cov/deferred-region.cpp
> edit: test/tools/llvm-cov/showTemplateInstantiations.cpp
> edit: test/tools/llvm-cov/Inputs/regionMarkers.json
> 
> Commit 91ab84fbbd5c88730c01b23a6e273f1803480e88 by vsk:
> [llvm-cov] Don't render empty region marker lines
> 
> edit: tools/llvm-cov/SourceCoverageView.cpp
> edit: tools/llvm-cov/SourceCoverageView.h
> edit: test/tools/llvm-cov/deferred-region.cpp
> edit: tools/llvm-cov/SourceCoverageViewHTML.cpp
> 
> Commit 64af33b0078e85cff3b509500d18ec6a395749a9 by vsk:
> [llvm-cov] Fix a -path-equivalence bug

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (master) #1001

2017-10-11 Thread Vedant Kumar via swift-dev 
Should be a transient issue. The bots just haven't picked up the paired llvm 
change.

vedant

> On Oct 11, 2017, at 12:49 PM, no-re...@swift.org wrote:
> 
> [FAILURE] oss-swift-incremental-RA-linux-ubuntu-16_10 [#1001]
> 
> Build URL:
> https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-16_10/1001/ 
> 
> Project:  oss-swift-incremental-RA-linux-ubuntu-16_10
> Date of build:Wed, 11 Oct 2017 14:50:15 -0500
> Build duration:   26 sec
> Identified problems:
> 
> Compile Error: This build failed because of a compile error. Below is a list 
> of all errors in the build log:
> Indication 1 
> 
> Tests:
> 
> Name: Swift(linux-x86_64)
> Failed: 0 test(s), Passed: 9985 test(s), Total: 9985 test(s)
> Name: Swift-Unit
> Failed: 0 test(s), Passed: 483 test(s), Total: 483 test(s)
> 
> Changes
> 
> Commit bb540eca76f2a5bef3f49fff41b96393a88fdedf by vsk:
> [Driver] Disable static C++ library support on Fuchsia
> 
> edit: test/Driver/fuchsia.cpp
> edit: cmake/caches/Fuchsia-stage2.cmake
> edit: lib/Driver/ToolChains/Fuchsia.cpp
> 
> Commit 2482b3c1235a58514eac22d773fa9ee3f466084d by vsk:
> Enable AddressSanitizer for Fuchsia targets
> 
> edit: cmake/caches/Fuchsia-stage2.cmake
> edit: lib/Driver/SanitizerArgs.cpp
> edit: lib/Driver/ToolChains/Fuchsia.cpp
> edit: test/Driver/fuchsia.c
> 
> Commit a71837e63f534f437ca0976e02d335a10962004c by vsk:
> [Driver][Fuchsia] Pass --hash-style=gnu to the linker
> 
> edit: lib/Driver/ToolChains/Fuchsia.cpp
> edit: test/Driver/fuchsia.c
> 
> Commit f8de77f400831aa9b2a5709bef3013542b42d808 by vsk:
> Cleanup and generalize -shared-libasan.
> 
> edit: lib/Driver/ToolChains/Fuchsia.cpp
> edit: lib/Driver/ToolChains/CommonArgs.cpp
> edit: test/Driver/sanitizer-ld.c
> edit: include/clang/Driver/SanitizerArgs.h
> edit: lib/Driver/SanitizerArgs.cpp
> edit: include/clang/Driver/Options.td
> edit: lib/Driver/ToolChains/MSVC.cpp
> 
> Commit 5772d165302cf00f041a71f33b1d2835b3347d32 by vsk:
> [Driver] Fix -static-libsan / -shared-libsan on Darwin
> 
> edit: lib/Driver/SanitizerArgs.cpp
> edit: lib/Driver/ToolChains/Darwin.cpp
> edit: test/Driver/sanitizer-ld.c
> 
> Commit 7e57318605d9cadc41aa971af6646797872a907d by vsk:
> Allow specifying sanitizers in blacklists
> 
> add: test/CodeGen/sanitizer-special-case-list.c
> add: test/CodeGen/Inputs/sanitizer-special-case-list.unsanitized4.txt
> add: include/clang/Basic/SanitizerSpecialCaseList.h
> add: test/CodeGen/Inputs/sanitizer-special-case-list.unsanitized3.txt
> add: test/CodeGen/Inputs/sanitizer-special-case-list.sanitized.txt
> add: test/CodeGen/Inputs/sanitizer-special-case-list.unsanitized1.txt
> edit: lib/Basic/XRayLists.cpp
> edit: include/clang/Basic/SanitizerBlacklist.h
> edit: lib/Basic/SanitizerBlacklist.cpp
> add: lib/Basic/SanitizerSpecialCaseList.cpp
> edit: docs/SanitizerSpecialCaseList.rst
> edit: lib/CodeGen/CGExpr.cpp
> edit: lib/CodeGen/CGClass.cpp
> edit: docs/ControlFlowIntegrity.rst
> add: test/CodeGen/Inputs/sanitizer-special-case-list.unsanitized2.txt
> edit: lib/Basic/CMakeLists.txt
> edit: test/CodeGenCXX/cfi-blacklist.cpp
> edit: lib/CodeGen/CodeGenFunction.cpp
> edit: lib/AST/Decl.cpp
> edit: lib/CodeGen/CGDeclCXX.cpp
> edit: lib/CodeGen/CodeGenModule.cpp
> edit: lib/CodeGen/CodeGenModule.h
> 
> Commit a47a033749c0d3c9a376f2ead7ae154925d436d7 by vsk:
> [Preprocessor] Preserve #pragma clang assume_nonnull in preprocessed
> 
> edit: lib/Lex/Pragma.cpp
> edit: lib/Frontend/PrintPreprocessedOutput.cpp
> add: test/Preprocessor/pragma_assume_nonnull.c
> edit: include/clang/Lex/PPCallbacks.h
> 
> Commit 2c0a0e90b7706f5eb6d43200b9babcc756a05722 by vsk:
> Fix templated type alias completion when using global completion cache
> 
> edit: lib/Frontend/ASTUnit.cpp
> edit: test/Index/code-completion.cpp
> edit: lib/Parse/ParseTemplate.cpp
> 
> Commit c3ee9f507de5523bcc473c6724f1d3da7702699e by vsk:
> Use EmitPointerWithAlignment to get alignment information of the pointer
> 
> add: test/CodeGenCXX/atomic-align.cpp
> edit: lib/CodeGen/CGAtomic.cpp

___
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

Re: [swift-dev] [Swift CI] Build Still Failing: 0. OSS - Swift Incremental RA - Ubuntu 14.04 - Long Test (master) #799

2017-09-25 Thread Vedant Kumar via swift-dev 
I don't think this is related to my commit -- I've just touched docs and 
llvm-cov.

vedant

> On Sep 25, 2017, at 5:51 PM, no-re...@swift.org wrote:
> 
> New issue found!
> 
> [FAILURE] oss-swift-incremental-RA-linux-ubuntu-14_04-long-test [#799]
> 
> Build URL:
> https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-14_04-long-test/799/
>  
> 
> Project:  oss-swift-incremental-RA-linux-ubuntu-14_04-long-test
> Date of build:Mon, 25 Sep 2017 19:08:39 -0500
> Build duration:   43 min
> Identified problems:
> 
> Regression test failed: This build failed because a regression test in the 
> test suite FAILed. Below is a list of all errors:
> Indication 1 
> 
> Changes
> 
> Commit 03ad44c0fa1d3e047f6c300ad9da12c92e90a5be by vsk:
> [llvm-cov] Warn if -show-functions is used without query files
> 
> edit: test/tools/llvm-cov/report.cpp
> edit: tools/llvm-cov/CodeCoverage.cpp
> 
> Commit 315d77d79f1df44e5ac72b873dce822b3db6d7b7 by vsk:
> [docs] llvm-cov: Document -show-instantiation-summary
> 
> edit: docs/CommandGuide/llvm-cov.rst
> 
> Commit 068eca3dd566249379f5c855337e713cea30851f by vsk:
> [docs] llvm-cov: Make docs for boolean options more consistent
> 
> edit: docs/CommandGuide/llvm-cov.rst

___
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

Re: [swift-dev] [Swift CI] Build Still Failing: 0. OSS - Swift Incremental RA - Ubuntu 16.04 (master) #596

2017-09-18 Thread Vedant Kumar via swift-dev 
I don't think I have changed this or control it:
--install-destdir is required to install products.
/home/buildnode/jenkins/workspace/oss-swift-incremental-RA-linux-ubuntu-16_04/swift/utils/build-script:
 fatal error: command terminated with a non-zero exit status 1, aborting
/home/buildnode/jenkins/workspace/oss-swift-incremental-RA-linux-ubuntu-16_04/swift/utils/build-script:
 fatal error: command terminated with a non-zero exit status 1, aborting

vedant

> On Sep 18, 2017, at 6:32 PM, no-re...@swift.org wrote:
> 
> New issue found!
> 
> [FAILURE] oss-swift-incremental-RA-linux-ubuntu-16_04 [#596]
> 
> Build URL:
> https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-16_04/596/ 
> 
> Project:  oss-swift-incremental-RA-linux-ubuntu-16_04
> Date of build:Mon, 18 Sep 2017 19:25:52 -0500
> Build duration:   1 hr 7 min
> Tests:
> 
> Name: Swift(linux-x86_64)
> Failed: 0 test(s), Passed: 9899 test(s), Total: 9899 test(s)
> Name: Swift-Unit
> Failed: 0 test(s), Passed: 461 test(s), Total: 461 test(s)
> 
> Changes
> 
> Commit 7e0311ad2cf4f688518aed84a665b6c8a50eaefc by vsk:
> [Coverage] Use gap regions to select better line exec counts
> 
> edit: include/llvm/ProfileData/InstrProfData.inc
> edit: tools/llvm-cov/SourceCoverageViewText.cpp
> edit: lib/ProfileData/Coverage/CoverageMappingReader.cpp
> edit: lib/ProfileData/Coverage/CoverageMapping.cpp
> edit: docs/CoverageMappingFormat.rst
> edit: tools/llvm-cov/SourceCoverageViewHTML.cpp
> edit: tools/llvm-cov/SourceCoverageView.cpp
> edit: include/llvm/ProfileData/Coverage/CoverageMapping.h
> edit: test/tools/llvm-cov/deferred-region.cpp
> edit: lib/ProfileData/Coverage/CoverageMappingWriter.cpp
> edit: test/tools/llvm-cov/Inputs/deferred-regions.covmapping
> 
> Commit 9a8caaf5b6cd207d61e0867ea46650d45a3e5adf by vsk:
> [profile] Update InstrProfData.inc
> 
> edit: lib/profile/InstrProfData.inc
> 
> Commit 223e2eacb73b51efd6284bfb15ac1ef9b596a2e6 by vsk:
> [cmake] Make it possible to build and test profile without sanitizers
> 
> edit: lib/CMakeLists.txt
> edit: test/CMakeLists.txt

___
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

Re: [swift-dev] [Swift CI] Build Still Failing: 0. OSS - Swift Incremental RA - Ubuntu 16.04 (master) #595

2017-09-18 Thread Vedant Kumar via swift-dev 
The sync'd llvm change did not make it into this build.

vedant

> On Sep 18, 2017, at 5:24 PM, no-re...@swift.org wrote:
> 
> New issue found!
> 
> [FAILURE] oss-swift-incremental-RA-linux-ubuntu-16_04 [#595]
> 
> Build URL:
> https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-16_04/595/ 
> 
> Project:  oss-swift-incremental-RA-linux-ubuntu-16_04
> Date of build:Mon, 18 Sep 2017 19:08:14 -0500
> Build duration:   17 min
> Identified problems:
> 
> Compile Error: This build failed because of a compile error. Below is a list 
> of all errors in the build log:
> Indication 1 
> 
> Changes
> 
> Commit ec1e051a3670dcf83f25f6dd027480fbf290146e by rlevenstein:
> Add runtime library support for tracking the invocations of runtime
> 
> add: stdlib/public/runtime/RuntimeInvocationsTracking.cpp
> edit: stdlib/public/runtime/CMakeLists.txt
> edit: stdlib/public/runtime/HeapObject.cpp
> add: stdlib/public/runtime/RuntimeInvocationsTracking.h
> 
> Commit a590e4902e20b44ce8733b4ee5ec8f2e0c3cfa39 by rlevenstein:
> Add experimental Swift standard library support for tracking the
> 
> edit: stdlib/public/core/GroupInfo.json
> add: stdlib/public/core/RuntimeFunctionCounters.swift
> edit: stdlib/public/core/CMakeLists.txt
> 
> Commit 4b2c6c017e1554deb25ea715873dcebd26a7a3aa by rlevenstein:
> Add a test for testing the runtime function counters functionality
> 
> add: test/stdlib/test_runtime_function_counters.swift
> 
> Commit a4d5cad3a5da40b4b697e90d2dcd5cc7f14fe42a by rlevenstein:
> Fix creation of UnsafeRawPointer for found references
> 
> edit: stdlib/public/core/RuntimeFunctionCounters.swift
> 
> Commit 3392b765ea9f74b562d72eac0cffa238a65e78be by rlevenstein:
> Provide runtime function counters for object allocation, deallocation
> 
> edit: test/stdlib/test_runtime_function_counters.swift
> edit: stdlib/public/runtime/RuntimeInvocationsTracking.h
> edit: stdlib/public/runtime/HeapObject.cpp
> 
> Commit 045dc3495566980040215dd581101cad6d9bf628 by rlevenstein:
> Address review comments related to the Swift standard library part of
> 
> edit: stdlib/public/core/RuntimeFunctionCounters.swift
> edit: test/stdlib/test_runtime_function_counters.swift
> 
> Commit 1996d5fb645797691685f44b863a6f99fdacab2b by rlevenstein:
> Address review comments.
> 
> edit: stdlib/public/runtime/RuntimeInvocationsTracking.cpp
> add: stdlib/public/runtime/RuntimeInvocationsTracking.def
> edit: stdlib/public/runtime/RuntimeInvocationsTracking.h
> 
> Commit 2012451eb1edd1f02e1a16661e9f4ac0d31dbc58 by rlevenstein:
> Fix a macro-definition
> 
> edit: stdlib/public/runtime/RuntimeInvocationsTracking.h
> 
> Commit 8027fa2b0a1bc4574151b6487234ac553eaf3be8 by rlevenstein:
> The test needs the standard library (the runtime library part of it)
> 
> edit: test/stdlib/test_runtime_function_counters.swift
> 
> Commit 460de35b824c3ee26e868b51e8d8aacbd07de41f by rlevenstein:
> Expose runtime APIs for runtime function counters in such a way that
> 
> edit: stdlib/public/runtime/RuntimeInvocationsTracking.h
> 
> Commit 7aa8d6f2b6e5e228f96daba42db1d6d50d68aec5 by rlevenstein:
> Warn if FUNCTION_TO_TRACK is not defined
> 
> edit: stdlib/public/runtime/RuntimeInvocationsTracking.def
> 
> Commit d8c5238449b45f69598c9cc5406310c757194ce9 by rlevenstein:
> Move FUNCTION_TO_TRACK definitions closer to the includes of
> 
> edit: stdlib/public/runtime/RuntimeInvocationsTracking.cpp
> 
> Commit acf94f94eca4ef0383e461548ddb55e945c3332d by lance_parker:
> Add -Onone to all the _Debug tests
> 
> edit: test/stdlib/StringTraps.swift
> edit: test/stdlib/RangeTraps.swift
> edit: validation-test/stdlib/FloatingPointConversion.swift.gyb
> edit: test/stdlib/DictionaryTraps.swift
> edit: validation-test/stdlib/ArrayTraps.swift.gyb
> edit: validation-test/stdlib/FixedPointConversion.swift.gyb
> edit: validation-test/stdlib/ArrayTrapsObjC.swift.gyb
> edit: test/stdlib/IntervalTraps.swift
> edit: validation-test/stdlib/DictionaryTrapsObjC.swift
> edit: test/stdlib/SetTrapsObjC.swift
> edit: test/stdlib/CharacterTraps.swift
> edit: test/stdlib/SetTraps.swift
> edit: validation-test/stdlib/FixedPointArithmeticTraps.swift.gyb
> edit: validation-test/stdlib/Assert.swift
> 
> Commit 51bb830763190c70bc1316d9a0b60614550b8afb by rlevenstein:
> #include should be on the next line after #define
> 
> edit: stdlib/public/runtime/RuntimeInvocationsTracking.h
> edit: stdlib/public/runtime/RuntimeInvocationsTracking.cpp
> 
> Commit acff3212b5ccca477c223b2256f0dc321486cf38 by rlevenstein:
> Add a comment explaining why the file needs to be compiled even in
> 
> edit: stdlib/public/runtime/RuntimeInvocationsTracking.cpp
> 
> Commit 8dfdcd9a617ed07c2c79a1995c872dd5175143ac by rlevenstein:
> Check that the runtime counters APIs are available even in no-asserts
> 
>

Re: [swift-dev] [Swift CI] Build Still Failing: 0. OSS - Swift Incremental RA - Ubuntu 16.04 (master) #2891

2017-05-01 Thread Vedant Kumar via swift-dev 
SwiftPMPackageTests.xctest: 
/home/buildnode/jenkins/workspace/oss-swift-incremental-RA-linux-ubuntu-16_04/swift/include/swift/Runtime/../../../stdlib/public/SwiftShims/RefCount.h:399:
 bool swift::RefCountBitsT::

doDecrementStrongExtraRefCount(uint32_t) [refcountIsInline = 
swift::RefCountInlinedness::RefCountIsInline, clearPinnedFlag = 
swift::ClearPinnedFlag::DontClearPinnedFlag]: Assertion 
`getStrongExtraRefCount() >= dec && "releasing reference whose refcount is 
already zero"' failed

.--- bootstrap: error: tests failed with exit status 1


vedant

> On May 1, 2017, at 4:25 PM, no-re...@swift.org wrote:
> 
> New issue found!
> 
> [FAILURE] oss-swift-incremental-RA-linux-ubuntu-16_04 [#2891]
> 
> Build URL:
> https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-16_04/2891/
> Project:  oss-swift-incremental-RA-linux-ubuntu-16_04
> Date of build:Mon, 01 May 2017 15:38:07 -0700
> Build duration:   47 min
> Identified problems:
> 
>   • Compile Error: This build failed because of a compile error. Below is 
> a list of all errors in the build log:
>   • Indication 1
> Tests:
> 
> Name: Swift(linux-x86_64)
> Failed: 0 test(s), Passed: 9319 test(s), Total: 9319 test(s)
> Name: Swift-Unit
> Failed: 0 test(s), Passed: 417 test(s), Total: 417 test(s)
> 
> Changes
> 
>   • Commit 95e6506682e87e620319d84d1dbd66924ac44e87 by David Farler:
> [Migrator] Don't pick up missing argument type placeholder fix-its
> 
>   • add: test/Migrator/Inputs/ignore_type_placeholder.swift
>   • add: test/Migrator/ignore_type_placeholder.swift
>   • edit: include/swift/Migrator/FixitFilter.h
> 
>   • Commit 905b6b1710589f1c7401f22a5af21427abdecd3a by Doug Gregor:
> [Serialization] Ignore parsed declarations when resolving x-refs.
> 
>   • edit: lib/Serialization/Deserialization.cpp
> 
>   • Commit f7bccb0e688c06158ae461b1dc1fe56a17bfa65d by Doug Gregor:
> [Type checker] Downgrade some "redundant conformance" errors to
> 
>   • edit: 
> test/Sema/enum_post_hoc_raw_representable_with_raw_type.swift
>   • edit: lib/Sema/TypeCheckProtocol.cpp
>   • add: 
> test/decl/protocol/conforms/Inputs/redundant_conformance_A.swift
>   • add: test/Compatibility/string_collection.swift
>   • add: 
> test/decl/protocol/conforms/Inputs/redundant_conformance_B.swift
>   • edit: include/swift/AST/DiagnosticsSema.def
>   • edit: test/decl/protocol/conforms/placement.swift
>   • add: test/decl/protocol/conforms/redundant_conformance.swift
> 
>   • Commit 16e90f7b2cd913b96187632b19e0c00e41f54298 by Vedant Kumar:
> [ubsan] Fall back to the fast unwinder when print_stacktrace=1
> 
>   • edit: lib/ubsan/ubsan_diag.cc
>   • edit: test/ubsan/TestCases/Misc/missing_return.cpp
>   • edit: test/ubsan/TestCases/TypeCheck/misaligned.cpp

___
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.04 (swift 3.1) #473

2017-04-11 Thread Vedant Kumar via swift-dev 
I see an "Unknown IO error", which looks unrelated to my change:

---
Test Case 'TestNSXMLDocument.test_validation_success' started at 19:42:05.659
error : Unknown IO error
I/O warning : failed to load external entity "
http://www.apple.com/DTDs/PropertyList-1.0.dtd
"

TestFoundation/TestNSXMLDocument.swift:309: error: 
TestNSXMLDocument.test_validation_success : failed - ["NSLocalizedDescription": 
"Could not load the external subset 
\"http://www.apple.com/DTDs/PropertyList-1.0.dtd\"\n;]
---

Has anyone seen this before?

vedant


> On Apr 11, 2017, at 12:43 PM, no-re...@swift.org wrote:
> 
> [FAILURE] oss-swift-3.1-incremental-RA-linux-ubuntu-16_04 [#473]
> 
> Build URL:
> https://ci.swift.org/job/oss-swift-3.1-incremental-RA-linux-ubuntu-16_04/473/
> Project:  oss-swift-3.1-incremental-RA-linux-ubuntu-16_04
> Date of build:Tue, 11 Apr 2017 11:51:28 -0700
> Build duration:   51 min
> Identified problems:
> 
>   • Compile Error: This build failed because of a compile error. Below is 
> a list of all errors in the build log:
>   • Indication 1
> Tests: 
> 
> Name: Swift(linux-x86_64)
> Failed: 0 test(s), Passed: 8903 test(s), Total: 8903 test(s)
> Name: Swift-Unit
> Failed: 0 test(s), Passed: 239 test(s), Total: 239 test(s)
> 
> Changes
> 
>   • Commit ccc36ed762f2246d6c22694f46c5019e7b927a30 by Vedant Kumar:
> [Coverage] Audit uses of getCurrentCounter() (SR-4453)
> 
>   • edit: lib/SILGen/SILGenProfiling.cpp
>   • edit: test/SILGen/coverage_toplevel.swift
> 
>   • Commit 2c41a06f784c2044496516a5fb028266ee5a5146 by Vedant Kumar:
> [Coverage] Simplify a check (NFC)
> 
>   • edit: lib/SILGen/SILGenProfiling.cpp

___
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - OS X (swift 4.0) #71

2017-04-03 Thread Vedant Kumar via swift-dev 
This doesn't look related to my changes.

+ Hugh, since he's at least touched the file.

vedant

> On Apr 3, 2017, at 4:29 PM, no-re...@swift.org wrote:
> 
> [FAILURE] oss-swift-4.0-incremental-RA-osx [#71]
> 
> Build URL:https://ci.swift.org/job/oss-swift-4.0-incremental-RA-osx/71/
> Project:  oss-swift-4.0-incremental-RA-osx
> Date of build:Mon, 03 Apr 2017 15:39:24 -0700
> Build duration:   49 min
> Identified problems:
> 
>   • Regression test failed: This build failed because a regression test 
> in the test suite FAILed. Below is a list of all errors:
>   • Indication 1
> Tests:
> 
> Name: Swift(macosx-x86_64)
> Failed: 1 test(s), Passed: 9103 test(s), Total: 9104 test(s)
>   • Failed: Swift(macosx-x86_64).Python.gyb.swift
> Name: Swift-Unit
> Failed: 0 test(s), Passed: 476 test(s), Total: 476 test(s)
> 
> Changes
> 
>   • Commit f683c24ef812b985e0e93c0aaa962062677b0af4 by Vedant Kumar:
> Revert "[InlineCost] Fix codesize issue caused by r286814"
> 
>   • edit: test/Transforms/Inline/inline-fast-math-flags.ll
>   • edit: 
> test/Transforms/Inline/optimization-remarks-passed-yaml.ll
>   • edit: test/Transforms/Inline/inline-cold.ll
>   • edit: test/Transforms/Inline/inline-hot-callee.ll
>   • edit: lib/Analysis/InlineCost.cpp
>   • edit: test/Transforms/Inline/inline-cold-callee.ll
>   • edit: test/Transforms/Inline/inline-optsize.ll
>   • edit: test/Transforms/Inline/alloca-bonus.ll
>   • edit: test/Transforms/Inline/ptr-diff.ll
>   • edit: test/Transforms/Inline/inline-hot-callsite.ll
>   • edit: test/Transforms/Inline/inline_unreachable-2.ll
> 
>   • Commit 57278f9a2b853e79b47aaff61b25a952aade98f8 by Vedant Kumar:
> Revert "[Inliner] Tweak inline threshold for code size regression"
> 
>   • edit: test/Transforms/Inline/ptr-diff.ll
> 
>   • Commit e3511601a3c036006fab2becb4802b8f27055f02 by Vedant Kumar:
> Revert "[InlineCost] Remove skew when calculating call costs"
> 
>   • edit: test/Transforms/Inline/inline_unreachable-2.ll
>   • edit: test/Transforms/Inline/ptr-diff.ll
>   • edit: 
> test/Transforms/Inline/optimization-remarks-passed-yaml.ll
>   • edit: test/Transforms/Inline/inline-hot-callsite.ll
>   • edit: test/Transforms/Inline/inline-optsize.ll
>   • edit: test/Transforms/Inline/inline-cold.ll
>   • edit: test/Transforms/Inline/alloca-bonus.ll
>   • edit: lib/Analysis/InlineCost.cpp
>   • edit: test/Transforms/Inline/inline-cold-callee.ll
>   • edit: test/Transforms/Inline/inline-hot-callee.ll
> 
>   • Commit 022afe34b9c86521a7d17bcd75811b6f1c39daba by Vedant Kumar:
> Revert "[InlineCost] Reduce inline thresholds to compensate for cost
> 
>   • edit: test/Transforms/Inline/inline-fp.ll
>   • edit: include/llvm/Analysis/InlineCost.h
>   • edit: test/Transforms/Inline/ephemeral.ll

___
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (master) #1907

2017-02-14 Thread Vedant Kumar via swift-dev 
Yes, I did.

> On Feb 14, 2017, at 5:07 PM, Jordan Rose  wrote:
> 
> Did you revert yet? This is blocking PR testing for us.
> 
>> On Feb 14, 2017, at 16:07, Vedant Kumar  wrote:
>> 
>> I think I'm just going to revert, because it's taking me a while to get 
>> swift to build.
>> 
>> vedant
>> 
>>> On Feb 14, 2017, at 4:07 PM, no-re...@swift.org wrote:
>>> 
>>> [FAILURE] oss-swift-incremental-RA-linux-ubuntu-16_10 [#1907]
>>> 
>>> Build URL:  
>>> https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-16_10/1907/
>>> Project:oss-swift-incremental-RA-linux-ubuntu-16_10
>>> Date of build:  Tue, 14 Feb 2017 15:57:13 -0800
>>> Build duration: 9 min 52 sec
>>> Identified problems:
>>> 
>>> • Regression test failed: This build failed because a regression test 
>>> in the test suite FAILed. Below is a list of all errors:
>>> • Indication 1
>>> Tests: 
>>> 
>>> Name: Swift(linux-x86_64)
>>> Failed: 1 test(s), Passed: 8974 test(s), Total: 8975 test(s)
>>> • Failed: Swift(linux-x86_64).IRGen.coverage.swift
>>> Name: Swift-Unit
>>> Failed: 0 test(s), Passed: 310 test(s), Total: 310 test(s)
>>> 
>>> Changes
>>> 
>>> • Commit 39fa2f0228e3fd9c221f97639a802b92d1f5eecb by aschwaighofer:
>>> Use the swift calling convention for swift functions
>>> 
>>> • edit: test/IRGen/indirect_return.swift
>>> • edit: test/DebugInfo/generic_enum_closure.swift
>>> • edit: 
>>> test/IRGen/sil_witness_tables_inherited_conformance.swift
>>> • edit: test/IRGen/witness_table_objc_associated_type.swift
>>> • edit: test/IRGen/abitypes.swift
>>> • edit: test/IRGen/dynamic_cast.sil
>>> • edit: lib/IRGen/GenHeap.cpp
>>> • edit: test/IRGen/unowned_objc.sil
>>> • edit: test/IRGen/generic_structs.sil
>>> • edit: test/IRGen/fixed_size_buffer_peepholes.sil
>>> • edit: test/IRGen/generic_class_anyobject.swift
>>> • edit: test/DebugInfo/inout.swift
>>> • edit: test/IRGen/objc_bridge.swift
>>> • edit: test/IRGen/same_type_constraints.swift
>>> • edit: test/IRGen/builtin_word.sil
>>> • edit: stdlib/public/runtime/ErrorObject.h
>>> • edit: test/IRGen/witness_method_phi.sil
>>> • edit: unittests/runtime/LongTests/LongRefcounting.cpp
>>> • edit: test/IRGen/abi_v7k.swift
>>> • edit: test/IRGen/newtype.swift
>>> • edit: test/IRGen/objc_generic_protocol_conformance.swift
>>> • edit: test/IRGen/witness_method.sil
>>> • edit: lib/IRGen/ScalarTypeInfo.h
>>> • edit: test/IRGen/objc_subclass.swift
>>> • edit: test/IRGen/enum_derived.swift
>>> • edit: stdlib/public/SDK/Foundation/Hashing.m
>>> • edit: test/IRGen/method_linkage.swift
>>> • add: test/stdlib/SIMDParameterPassing.swift.gyb
>>> • edit: test/DebugInfo/closure-args.swift
>>> • edit: test/IRGen/readonly.sil
>>> • edit: test/IRGen/objc_errors.sil
>>> • edit: test/IRGen/c_functions.swift
>>> • edit: test/IRGen/ordering_x86.sil
>>> • edit: test/IRGen/enum_32_bit.sil
>>> • edit: test/IRGen/objc_simd.sil
>>> • edit: test/IRGen/dynamic_self_metadata.swift
>>> • edit: test/IRGen/ordering_aarch64.sil
>>> • edit: test/SILOptimizer/eager_specialize.sil
>>> • edit: test/IRGen/enum_function.sil
>>> • edit: test/IRGen/nondominant.sil
>>> • edit: test/IRGen/objc_generic_class_convention.sil
>>> • edit: test/IRGen/undef.sil
>>> • edit: test/IRGen/class_bounded_generics.swift
>>> • edit: test/IRGen/closure.swift
>>> • edit: stdlib/public/runtime/MetadataLookup.cpp
>>> • edit: test/IRGen/asmname.swift
>>> • edit: test/IRGen/boxed_existential.sil
>>> • edit: test/IRGen/enum_value_semantics.sil
>>> • edit: test/IRGen/objc_runtime_visible.sil
>>> • edit: test/SILOptimizer/inline_thunk.swift
>>> • edit: stdlib/public/runtime/ErrorObjectNative.cpp
>>> • edit: test/IRGen/sil_generic_witness_methods_objc.swift
>>> • edit: test/IRGen/generic_ternary.swift
>>> • edit: test/IRGen/class_resilience.swift
>>> • edit: test/IRGen/indexing.sil
>>> • edit: test/IRGen/generic_tuples.swift
>>> • edit: test/IRGen/objc_protocol_conversion.sil
>>> • edit: test/IRGen/objc_block_storage.sil
>>> • edit: test/IRGen/autorelease.sil
>>> • edit: test/SILOptimizer/prespecialization_with_definition.sil
>>> • edit: test/IRGen/dllimport.swift
>>> • edit: test/IRGen/generic_casts.swift
>>> • edit: test/IRGen/casts.sil
>>> •

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - OS X (master) #7598

2016-12-14 Thread Vedant Kumar via swift-dev 
Looks like it was a transient issue :(. #7599 is blue.

vedant

> On Dec 14, 2016, at 5:40 PM, Slava Pestov  wrote:
> 
> Does anyone know what happened here? It doesn’t look like any of the patches 
> in the blame log could have caused this:
> 
> /Users/buildnode/jenkins/workspace/oss-swift-incremental-RA-osx/swift/stdlib/public/SDK/XPC/XPC.swift:14:8:
>  error: no such module '_SwiftXPCOverlayShims'
> 
> import _SwiftXPCOverlayShims
> 
> 
>> On Dec 14, 2016, at 4:00 PM, no-re...@swift.org wrote:
>> 
>> [FAILURE] oss-swift-incremental-RA-osx [#7598]
>> 
>> Build URL:   https://ci.swift.org/job/oss-swift-incremental-RA-osx/7598/
>> Project: oss-swift-incremental-RA-osx
>> Date of build:   Wed, 14 Dec 2016 15:43:10 -0800
>> Build duration:  17 min
>> Identified problems:
>> 
>>  • Compile Error: This build failed because of a compile error. Below is 
>> a list of all errors in the build log:
>>  • Indication 1
>> 
>> Changes
>> 
>>  • Commit 3ba23ac3d2f5947bb2c70c1f96675bc951cf77a9 by mren:
>> PR28438: Update the information on an identifier with local definitions
>> 
>>  • add: test/Modules/Inputs/PR28438/module.modulemap
>>  • add: test/Modules/Inputs/PR28438/a.h
>>  • add: test/Modules/Inputs/PR28438/b1.h
>>  • edit: lib/Lex/Preprocessor.cpp
>>  • add: test/Modules/pr28438.cpp
>>  • edit: include/clang/Lex/Preprocessor.h
>>  • add: test/Modules/Inputs/PR28438/b2.h
>> 
>>  • Commit 6ba447b5b0cfd93f8bfd414357216513f30a9382 by mren:
>> Remove debugging aids from this test and fix its expectations.
>> 
>>  • edit: test/Modules/pr28438.cpp
>> 
>>  • Commit 05e5ddd52f8ada6638b7eed1a99b2d7eba04c9a0 by vsk:
>> [cmake] Check if SANITIZER_MIN_OSX_VERSION is defined before using it
>> 
>>  • edit: CMakeLists.txt
>> 
>>  • Commit b6823b930b19b6db71f6e0cd37842e5bff98118a by jgroff:
>> SIL: Change SILType::subst to be SubstitutionMap-based.
>> 
>>  • edit: include/swift/AST/SubstitutionMap.h
>>  • edit: lib/SILGen/SILGenFunction.cpp
>>  • edit: lib/SILGen/SILGenDestructor.cpp
>>  • edit: include/swift/SIL/SILType.h
>>  • edit: include/swift/SIL/SILCloner.h
>>  • edit: lib/SILOptimizer/Transforms/AllocBoxToStack.cpp
>>  • edit: lib/SILOptimizer/Transforms/SimplifyCFG.cpp
>>  • edit: lib/SILGen/SILGenApply.cpp
>>  • edit: lib/SIL/SILVerifier.cpp
>>  • edit: lib/SIL/SILBuilder.cpp
>>  • edit: lib/SILGen/SILGenExpr.cpp
>>  • edit: lib/SILOptimizer/Transforms/ReleaseDevirtualizer.cpp
>>  • edit: lib/SILOptimizer/Utils/Devirtualize.cpp
>>  • edit: lib/SIL/SILFunctionType.cpp
>>  • edit: lib/SIL/SILType.cpp
>>  • edit: include/swift/AST/Types.h
>>  • edit: lib/Parse/ParseSIL.cpp
>>  • edit: lib/SILGen/SILGenBridging.cpp
>>  • edit: lib/Serialization/DeserializeSIL.cpp
>>  • edit: lib/SILOptimizer/Transforms/CSE.cpp
>>  • edit: lib/SILOptimizer/Utils/Generics.cpp
>>  • edit: include/swift/SIL/TypeSubstCloner.h
>>  • edit: lib/SILGen/SILGenPoly.cpp
>>  • edit: lib/SILOptimizer/IPO/CapturePromotion.cpp
>>  • edit: 
>> lib/SILOptimizer/SILCombiner/SILCombinerApplyVisitors.cpp
>>  • edit: lib/SILGen/SILGenLValue.cpp
>> 
>>  • Commit ef011690e31c35fed7b5b415fe89277d93d1c3d3 by eeckstein:
>> Revert "[docs] DebuggingTheCompiler.rst => DebuggingTheCompiler.md."
>> 
>>  • delete: docs/DebuggingTheCompiler.md
>>  • add: docs/DebuggingTheCompiler.rst
>> 
>>  • Commit 361d026080a35c3f05f634fe2445a99049b92749 by gparker-github:
>> [runtime] Use memory_order_consume hack on 32-bit arm architectures.
>> 
>>  • edit: include/swift/Runtime/Metadata.h
> 

___
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

Re: [swift-dev] Advice on adding PGO support

2016-09-08 Thread Vedant Kumar via swift-dev 
Hi Erik,

Thanks for your advice!

> On Sep 7, 2016, at 12:53 PM, Erik Eckstein <eeckst...@apple.com> wrote:
> 
> Hi Vedant,
> 
> nice work!
> 
>> On Sep 6, 2016, at 12:36 PM, Vedant Kumar via swift-dev 
>> <swift-dev@swift.org> wrote:
>> 
>> Hi swift-dev,
>> 
>> I've been working on some patches which add basic support for PGO to swift 
>> [1].
>> What I have so far is just a proof-of-concept. I'd like to get some feedback 
>> on
>> the approach I've taken.
>> 
>> I've added support for loading profile data, matching up execution counts to
>> the right parts of the AST, and attaching those execution counts to 
>> conditional
>> branches. I added two fields to CondBranchInst (in SIL):
>> 
>> /// The number of times the True branch was executed.
>> Optional TrueBBCount;
>> 
>> /// The number of times the False branch was executed.
>> Optional FalseBBCount;
>> 
>> I fixed up the SILCloner and a few other sites where conditional branches are
>> created to propagate the branch taken counts. I have a patch to propagate
>> branch taken counts through the SILOptimizer, but I didn't include it in [1]
>> because I don't know how to write tests for it.
>> 
>> In IRGen, I added some logic to scale execution counts and create llvm
>> branch_weight metadata.
>> 
>> Some questions:
>> 
>> 1. Is it acceptable to make some SIL objects larger in order to store
>>execution counts (e.g CondBranchInst)?
> 
> Yes, I don’t see a problem with that.
> But for saving some space, you might want to store the counts as a plain 
> uint64_t instead of an Optional and use a special value (e.g. ~0) for the 
> none-case.

Right, this makes sense. Reserving that value should be fine, since it looks
like llvm expects weights to be scaled below UINT32_MAX.


>> If not, what's the best way to make
>>this information visible to SILOptimizer and IRGen?
>> 
>> 2. Is it better to associate counts with SIL instructions, or with
>>SILSuccessor?
> 
> I think storing the counts in SILSuccessor makes sense, because counts are 
> needed for all kind of terminator instructions (like switch_enum), except for 
> the unconditional br, but IMO we can live with wasting some bytes for this 
> instructions.

Storing counts in SILSuccessor has pros and cons, like you mentioned. It may
lead to wasted space in some cases, but would require fewer invasive API
changes to implement.


> Another thing to consider is that the count information should be 
> printed/parsed/serialized when writing and reading SIL.

Yes! I jotted these down as "TODO's" in my commit messages.


>> 3. Does anyone have tips on modifying swift/benchmark? I'd like to add a
>>benchmark driver which generates profile data, and another driver which
>>uses that data to turn on PGO.

I still need to work out how to configure swift/benchmark.

At any rate, I'm going to start gradually cleaning up these patches and
submitting PR's. I expect swift to support frontend-based PGO in the future,
but if it doesn't, some of these patches will still be useful. I'd rather have
them in-tree than let them bitrot.

Here's the first one:

https://github.com/apple/swift/pull/4675

Reviews appreciated :).

best,
vedant


>> 
>> thanks,
>> vedant
>> 
>> [1] https://github.com/vedantk/swift/tree/profile_use
>> ___
>> swift-dev mailing list
>> swift-dev@swift.org
>> https://lists.swift.org/mailman/listinfo/swift-dev
> 

___
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

[swift-dev] Advice on adding PGO support

2016-09-06 Thread Vedant Kumar via swift-dev 
Hi swift-dev,

I've been working on some patches which add basic support for PGO to swift [1].
What I have so far is just a proof-of-concept. I'd like to get some feedback on
the approach I've taken.

I've added support for loading profile data, matching up execution counts to
the right parts of the AST, and attaching those execution counts to conditional
branches. I added two fields to CondBranchInst (in SIL):

  /// The number of times the True branch was executed.
  Optional TrueBBCount;

  /// The number of times the False branch was executed.
  Optional FalseBBCount;

I fixed up the SILCloner and a few other sites where conditional branches are
created to propagate the branch taken counts. I have a patch to propagate
branch taken counts through the SILOptimizer, but I didn't include it in [1]
because I don't know how to write tests for it.

In IRGen, I added some logic to scale execution counts and create llvm
branch_weight metadata.

Some questions:

  1. Is it acceptable to make some SIL objects larger in order to store
 execution counts (e.g CondBranchInst)? If not, what's the best way to make
 this information visible to SILOptimizer and IRGen?

  2. Is it better to associate counts with SIL instructions, or with
 SILSuccessor?

  3. Does anyone have tips on modifying swift/benchmark? I'd like to add a
 benchmark driver which generates profile data, and another driver which
 uses that data to turn on PGO.

thanks,
vedant

[1] https://github.com/vedantk/swift/tree/profile_use
___
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

[swift-dev] Adding a singleton to swift

2016-09-01 Thread Vedant Kumar via swift-dev 
Hi all,

I'm experimenting with swift and would like to add a singleton to the compiler
in a way that's visible to SILGen. It seemed that CompilerInstance would be the
right place to store it, but I don't see a way to access the CI from SILGen. My
first question is: what's the best place to put this singleton?

While I was looking at CompilerInstance, I noticed that we're doing something
strange in its setup() method:

  // FrontendTool.cpp
  if (Instance.setup(Invocation)) { ... }
  ...
  Invocation.getDiagnosticOptions();

This code is copying a CompilerInvocation into a CompilerInstance, modifying it
within CompilerInstance::setup(), and then using the original (unmodified)
CompilerInvocation. I don't think this is causing any bugs, but it is a bit
confusing. My second question is: which invocation is the "right" one: the
unmodifed one, the modified one, or both? It seems like the CompilerInstance
should either own an invocation or just have a reference to one.

thanks!
vedant
___
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

Re: [swift-dev] Fixing some build issues on master-next

2016-06-27 Thread Vedant Kumar via swift-dev 
All done :).

8dd7d14 [stable-merge] [swift-llvm-opt] Pass RelocModel as an Optional
06756d2 [stable-merge] [IRGen] Fix what appears to be a typo
2111897 [stable-merge] [driver] Adopt new Error/Expected API
1409a44 [stable-merge] Adopt new setUnnamedAddr API
4a7ba9c [stable-merge] [IRGen] Adopt new coverage encoding API

vedant

> On Jun 27, 2016, at 10:17 AM, Vedant Kumar via swift-dev 
> <swift-dev@swift.org> wrote:
> 
> Hi all,
> 
> Just as a heads-up, I've got most of the build errors on master-next sorted 
> out locally.
> 
> If you need to push something to the branch, please wait a bit so we don't 
> end up duplicating work. I'll ping this thread when the branch is ready.
> 
> thanks,
> vedant
> ___
> swift-dev mailing list
> swift-dev@swift.org
> https://lists.swift.org/mailman/listinfo/swift-dev

___
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

[swift-dev] Fixing some build issues on master-next

2016-06-27 Thread Vedant Kumar via swift-dev 
Hi all,

Just as a heads-up, I've got most of the build errors on master-next sorted out 
locally.

If you need to push something to the branch, please wait a bit so we don't end 
up duplicating work. I'll ping this thread when the branch is ready.

thanks,
vedant
___
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev