Re: [swift-dev] [Swift CI] Build Failure: 2. Swift Source Compatibility Suite (master) #1014

> On Jan 4, 2018, at 11:14 AM, Vedant Kumar wrote: > > To follow up on this thread, I reverted #13597 (the profiling refactor) > because I couldn't get a clean run of the source compat suite. > > It looks like there's an issue unrelated to #13597 causing a few failures: >

Re: [swift-dev] [Swift CI] Build Failure: 2. Swift Source Compatibility Suite (master) #1014

> On Jan 3, 2018, at 7:46 PM, Slava Pestov wrote: > > > >> On Jan 3, 2018, at 7:36 PM, Vedant Kumar > > wrote: >> >>> >>> On Jan 3, 2018, at 7:34 PM, Mark Lacey >> > wrote: >>>

Re: [swift-dev] [Swift CI] Build Failure: 2. Swift Source Compatibility Suite (master) #1014

> On Jan 3, 2018, at 7:36 PM, Vedant Kumar wrote: > >> >> On Jan 3, 2018, at 7:34 PM, Mark Lacey > > wrote: >> >> >> >>> On Jan 3, 2018, at 7:31 PM, Vedant Kumar >> > wrote: >>>

Re: [swift-dev] [Swift CI] Build Failure: 2. Swift Source Compatibility Suite (master) #1014

> On Jan 3, 2018, at 7:34 PM, Mark Lacey wrote: > > > >> On Jan 3, 2018, at 7:31 PM, Vedant Kumar > > wrote: >> >>> >>> On Jan 3, 2018, at 7:23 PM, Mark Lacey >> > wrote: >>>

Re: [swift-dev] [Swift CI] Build Failure: 2. Swift Source Compatibility Suite (master) #1014

> On Jan 3, 2018, at 7:31 PM, Vedant Kumar wrote: > >> >> On Jan 3, 2018, at 7:23 PM, Mark Lacey > > wrote: >> >> >> >>> On Jan 3, 2018, at 7:18 PM, Vedant Kumar >> > wrote: >>>

Re: [swift-dev] [Swift CI] Build Failure: 2. Swift Source Compatibility Suite (master) #1014

> On Jan 3, 2018, at 7:23 PM, Mark Lacey wrote: > > > >> On Jan 3, 2018, at 7:18 PM, Vedant Kumar > > wrote: >> >> This is a bit surprising, since I wouldn't expect this suite of tests to >> stress the code coverage logic. >>

Re: [swift-dev] [Swift CI] Build Failure: 2. Swift Source Compatibility Suite (master) #1014

> On Jan 3, 2018, at 7:18 PM, Vedant Kumar wrote: > > This is a bit surprising, since I wouldn't expect this suite of tests to > stress the code coverage logic. > > How were you able to determine that the #13597 caused the break? I’m seeing this in the failing builds:

Re: [swift-dev] [Swift CI] Build Failure: 2. Swift Source Compatibility Suite (master) #1014

This is a bit surprising, since I wouldn't expect this suite of tests to stress the code coverage logic. How were you able to determine that the #13597 caused the break? I'm having a hard time understanding what the logs mean. For example, I see this failure, but I'm not sure how my change

Re: [swift-dev] [Swift CI] Build Failure: 2. Swift Source Compatibility Suite (master) #1014

Vedant, this appears to be a result of your changes. I’ve opened https://github.com/apple/swift/pull/13709 to revert the later clean-up change which appears to be required before it will be possible to revert the change below. Mark > On Jan 3,