Re: [swift-dev] Merge-commit noise?

Note that recording the original contributor is exactly what happens when you do `git rebase`: the rebaser will become the Committer, but the Author remains the same. On Sat, Dec 5, 2015 at 1:25 PM, Alex Blewitt via swift-dev < swift-dev@swift.org> wrote: > > > > On 5 Dec 2015, at 19:46, Jordan R

Re: [swift-dev] Continuous Integration on Swift.org projects

I submitted a PR last night to fix the crasher and recursion.swift. On Mon, Dec 7, 2015 at 12:52 PM Dmitri Gribenko via swift-dev < swift-dev@swift.org> wrote: > On Mon, Dec 7, 2015 at 12:49 PM, Brad Erickson via swift-dev < > swift-dev@swift.org> wrote: > >> I'm hoping to get an ETA or learn the

Re: [swift-dev] Continuous Integration on Swift.org projects

It's https://github.com/apple/swift/pull/296 Jacob Bandes-Storch On Mon, Dec 7, 2015 at 1:20 PM, Nadav Rotem wrote: > After reverting "Fixes [SR-78] swift compiler seg fault”” the only failing > test is: > > ./test/decl/protocol/req/recursion.swift > > Jacob, can you send a link to your pull re

Re: [swift-dev] Starter project: API to upgrade AnySequence to Any*Collection

What do you mean by "without copying the underlying collection"? Is this specifically for the case where the AnySequence is wrapping a collection (which is not always the case)? On Mon, Dec 7, 2015 at 2:18 PM, Dmitri Gribenko via swift-dev < swift-dev@swift.org> wrote: > It would require a propos

Re: [swift-dev] Allowing extensions of bound generic types

Email is hard...last sentence should say "in the case of extensions". Jacob ___ swift-dev mailing list swift-dev@swift.org https://lists.swift.org/mailman/listinfo/swift-dev

Re: [swift-dev] Allowing extensions of bound generic types

Hi Doug, thanks for the response! There’s a path through TypeChecker::handleSILGenericParams() that you need > to consider, which is triggered when parsing SIL. It’s an odd case because > you get all of the generic parameter lists up front. I suspect you would > just always allow type parameters t

Re: [swift-dev] Pointers vs. References?

e.g. IRGenModule, TypeChecker). > > The biggest grey area is for those parts of the language representation > that are either globally or contextually singleton, e.g. ASTContext and > SILFunction; these are almost always stored as references. > > John. > > > Michael > &

Re: [swift-dev] What do to when stdlib guidelines conflict with proposal?

+1 from the proposal author, although since it went through community review that doesn't make me an authority ;) On Wed, May 11, 2016 at 2:53 PM Russ Bishop via swift-dev < swift-dev@swift.org> wrote: > I’m implementing SE-0017 but based on the standard library guidelines I > think Unmanaged shou

Re: [swift-dev] build-script -x freezing?

I've experienced this multiple times in the past, and I'm seeing it today. Does anyone have thoughts on how this might be root-caused/fixed? On Fri, May 20, 2016 at 7:12 PM, Jordan Rose via swift-dev < swift-dev@swift.org> wrote: > Hypotheses: > - There are several executables that get linked ar

Re: [swift-dev] build-script -x freezing?

Actually, I think this was a Python problem for me. I had installed Python via Homebrew — running "brew unlink python" before a build-script invocation made it work fine. Jacob On Wed, May 25, 2016 at 7:59 PM, Jacob Bandes-Storch wrote: > I've experienced this multiple times in the past, and I'

Re: [swift-dev] build-script -x freezing?

I've filed https://bugs.swift.org/browse/SR-1629 with an account of my experience (and some logs). On Thu, May 26, 2016 at 10:56 AM, Daniel Dunbar wrote: > Can someone who can reproduce this issue please file a bug on > bugs.swift.org with as much information as possible about what exactly is >

Re: [swift-dev] Error running build-script -R?

I believe there was a note sent out earlier this week saying Xcode 8 is now required to build from source. On Wed, Jun 15, 2016 at 8:10 AM Austin Zheng via swift-dev < swift-dev@swift.org> wrote: > Hi, > > I've running into an issue where I can't build Swift successfully. Right > before it errors

[swift-dev] CI trigger request

Could someone kindly trigger CI again for me? https://github.com/apple/swift/pull/3637 Jacob ___ swift-dev mailing list swift-dev@swift.org https://lists.swift.org/mailman/listinfo/swift-dev

Re: [swift-dev] CI trigger request

fixed this in https://github.com/apple/swift-package-manager/pull/515 Jacob On Thu, Jul 21, 2016 at 1:15 PM, Tony Parker wrote: > I kicked it off. > > - Tony > > On Jul 21, 2016, at 1:08 PM, Jacob Bandes-Storch via swift-dev < > swift-dev@swift.org> wrote: > > Could s

Re: [swift-dev] CI trigger request

15 PM, Tony Parker > wrote: > >> I kicked it off. >> >> - Tony >> >> On Jul 21, 2016, at 1:08 PM, Jacob Bandes-Storch via swift-dev < >> swift-dev@swift.org> wrote: >> >> Could someone kindly trigger CI again for me? >> https://github.com/

Re: [swift-dev] CI trigger request

rror it had the first >> time: https://ci.swift.org/job/swift-PR-osx/2642/console But I already >> fixed this in https://github.com/apple/swift-package-manager/pull/515 >> >> Jacob >> >> On Thu, Jul 21, 2016 at 1:15 PM, Tony Parker >> wrote: >> >>>

Re: [swift-dev] CI trigger request

gt; >>> Jacob >>> >>> On Thu, Jul 21, 2016 at 1:15 PM, Tony Parker >>> wrote: >>> >>>> I kicked it off. >>>> >>>> - Tony >>>> >>>> On Jul 21, 2016, at 1:08 PM, Jacob Bandes-Storch via

Re: [swift-dev] [swift-evolution] End of source-breaking changes for Swift 3

> > >- SE-0089 - Renaming String.init(_: T) > > > > Has anyone worked on this? I have some time in the next couple of days and might be able to come up with an implementation in time.

[swift-dev] [Swift 4] Organizing source stability

Chris writes: > - *Source stability features: *These should be relatively small, but > important. For example, we need a “-std=swift3” sort of compiler flag. We > may also add a way to conditionally enable larger efforts that are under > development but not yet stable - in order to make it easie

Re: [swift-dev] [swift-evolution] [Swift 4] Organizing source stability

Here are a few thoughts: - -swift=4 - -swift-version=4 - -language-version=4 - a top-of-file "shebang"-style comment indicating the version, something like //#swift(4), mirroring the "#if swift" syntax On Fri, Jul 29, 2016 at 5:27 PM, Chris Lattner wrote: > > On Jul 29, 2016, at

Re: [swift-dev] clang: warning: argument unused during compilation: '-MMD'

-MMDWrite a depfile containing user headers On Fri, Jul 29, 2016 at 6:14 PM, Ted kremenek via swift-dev < swift-dev@swift.org> wrote: > -Wno-unused-variable would drop warnings about variables in *code* that > are not used. This is about a driver option that is not being u

Re: [swift-dev] [swift-evolution] [Swift 4] Organizing source stability

Importing the right version of a module (such as the standard library) when more than one are available is just a search-paths problem. Supporting multiple versions of the language's syntax and ABI, though, as far as I can tell, requires the switch to be deeply baked into the compiler. So I don't

[swift-dev] Code coverage?

Has there been any thought put into generating code coverage reports for the compiler? Or, are there some known steps community members could take to help out (such as adding a flag to build-script which enables -fprofile-arcs -ftest-coverage)? I think it'd be really interesting to see what's cove

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 14.04 (swift 3.0) #177

Not really sure what's going on here. The only failure I see is this, but I don't know what actually failed: make[3]: *** [test-suite.log] Error 1 make[3]: Leaving directory `/home/buildnode/jenkins/workspace/oss-swift-3.0-incremental-RA-linux-ubuntu-14_04/buildbot_incremental/libdispatch-linux-x8

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 15.10 (swift 3.0) #154

This and the LLDB failure seem to be unrelated, but I'm not sure since I can't really see logs besides the "FAIL" result. On Fri, Sep 2, 2016 at 12:16 PM, wrote: > [FAILURE] oss-swift-3.0-incremental-RA-linux-ubuntu-15_10 [#154] > Build URL: https://ci.swift.org/job/oss-swift-3.0-incremental-RA-

Re: [swift-dev] [swift-evolution] [Swift 4] Organizing source stability

I've filed https://bugs.swift.org/browse/SR-2582 for this. On Tue, Sep 6, 2016 at 10:37 AM, Jordan Rose wrote: > > On Jul 29, 2016, at 21:13, Chris Lattner via swift-dev < > swift-dev@swift.org> wrote: > > > On Jul 29, 2016, at 5:55 PM, Jacob Bandes-Storch > wrote: > > Here are a few thoughts:

Re: [swift-dev] [swift-users] Swift 3.0 released!

Congratulations!! On Tue, Sep 13, 2016 at 5:23 PM Ted kremenek via swift-users < swift-us...@swift.org> wrote: > Hi everyone, > > Swift 3.0 has been officially released: > > https://swift.org/blog/swift-3-0-released/ > > This moment marks an incredible achievement for the Swift open source >

Re: [swift-dev] Separating ./docs into several folders

Can we get swift.org hosted on GitHub Pages, and then make these documents part of the main site? :-) On Thu, Sep 22, 2016 at 2:59 PM Michael Gottesman via swift-dev < swift-dev@swift.org> wrote: > Over time as the project grows, we are going to need more documentation > around CI/policy. Right no

[swift-dev] Linux full-test CI broken?

My "test Linux" build (from https://github.com/apple/swift/pull/5871) seems to be consistently failing in CI. It could be my fault, but it looks like a bunch of other recent builds have failed too: https://ci.swift.org/job/swift-PR-Linux/ Anyone know what's going on? _

Re: [swift-dev] undefining macros after including Tokens.def

I am not the authority here, but based on what I've seen this sounds good to me. I was once discouraged from adding an #undef in client code because Tokens.def does it already. Mentioning that behavior in the comments certainly can't hurt. On Wed, Dec 28, 2016 at 2:37 PM, Micah Hainline via swift

Re: [swift-dev] undefining macros after including Tokens.def

Probably because expansion happens when an argument appears in the macro body, for instance: #define FOO(x) tok_##x // FOO(__FILE__) expands to tok___FILE__ #define BAR(x) FOO(x) // BAR(__FILE__) is invalid; tries to expand tok_"/path/to/the/file" On Thu, Dec 29, 2016 at 9:29 AM, Micah Hainline

[swift-dev] SubstitutionMap questions

Happy holidays :-) I started looking at this bug to see if I could figure out how to fix it: https://bugs.swift.org/browse/SR-3500 As the bug author points out, there is a TODO in GenericSignature::getSubstitutionMap, saying it needs to handle same-type requirements: https://github.com/apple/swif

[swift-dev] CSGen/LinkedExprAnalyzer questions

This is a pretty great bug: https://bugs.swift.org/browse/SR-3483 let x: Double? = 1 // error: ambiguous reference to member '+' let sum = x! + x! + x! // error: value of optional type 'Double?' not unwrapped; did you mean to use '!' or '?'? let sum: Double = x! + x! + x! I

Re: [swift-dev] CSGen/LinkedExprAnalyzer questions

his seems to get it - didn’t check whether this regresses things, but > this seems to be the right fix at a high level. > > ~Robert Widmann > > > On Dec 31, 2016, at 11:22 AM, Mark Lacey via swift-dev < > swift-dev@swift.org> wrote: > > > On Dec 30, 2016, at 2:07

Re: [swift-dev] CSGen/LinkedExprAnalyzer questions

On Sat, Dec 31, 2016 at 1:55 PM, Robert Widmann wrote: > > As for why this works with non-chained binops no simplification occurs in > that case because, well, there’s no chain here. The solver walks each part > in turn instead. > What do you mean by this? The LinkedExprAnalyzer is still used i

Re: [swift-dev] String Processing in Swift

Moving to swift-users. (swift-dev to BCC; swift-dev is for compiler development.) It's also important to know about the methods available on NSString, which are exposed on the String type when you import Foundation: https://developer.apple.com/reference/foundation/nsstring You might also be inter

Re: [swift-dev] Nightly builds?

I suppose you probably found this already, but the Snapshots section here has a build from Jan 5: https://swift.org/download/#snapshots On Tue, Jan 10, 2017 at 10:48 AM, Erica Sadun via swift-dev < swift-dev@swift.org> wrote: > Are there still nightly builds that are easy to pull and install? I

[swift-dev] Why doesn't CaptureListExpr hold a ClosureExpr?

I just learned about CaptureListExpr when working on some diagnostics. Is there a particular reason that its member "closureBody" is an Expr* and not a ClosureExpr*? There seems to be only one place it's built

Re: [swift-dev] Why doesn't CaptureListExpr hold a ClosureExpr?

PR'd: https://github.com/apple/swift/pull/7326 Although I would also ask: why is CaptureListExpr a *parent* of ClosureExpr and not a child? Jacob On Tue, Feb 7, 2017 at 7:56 PM, Slava Pestov wrote: > > On Feb 7, 2017, at 7:30 PM, Jacob Bandes-Storch via swift-dev < > sw

Re: [swift-dev] Why doesn't CaptureListExpr hold a ClosureExpr?

I think right now it’s just a property of how > the parser works, the capture list comes first, before the closure body? > > Slava > > > Jacob > > On Tue, Feb 7, 2017 at 7:56 PM, Slava Pestov wrote: > >> >> On Feb 7, 2017, at 7:30 PM, Jacob Bandes-Storch via

Re: [swift-dev] Why doesn't CaptureListExpr hold a ClosureExpr?

fore and would've just assumed it was part of ClosureExpr. But it looks like the change was pretty intentional. (Maybe someone can share what rdar://19146761 was?) On Tue, Feb 7, 2017 at 9:27 PM, John McCall wrote: > On Feb 8, 2017, at 12:18 AM, Jacob Bandes-Storch via swift-dev < > swif

[swift-dev] Summary of outstanding compiler crashers

This may or may not be practically useful to anyone, but I've collected a summary of the currently outstanding compiler crashers, somewhat categorized: https://gist.github.com/jtbandes/95ebf031d0ae4890d4dc3dc79e2bb4fa Slava has additionally offered, on Twitter, > 28482 root cause is a name look

Re: [swift-dev] [swift-users] Anyone else having trouble getting swift to build?

No, just having the command-line tools set to the beta should be fine. Also, moving this to swift-dev. On Sun, Mar 5, 2017 at 3:12 PM, David Sweeris wrote: > Yep. Do I need to uninstall 8.2, though? I hadn't thought to try that > until just now. > > Sent from my iPhone > > On Mar 5, 2017, at 15:

Re: [swift-dev] Pathway to becoming an effective contributor

Hi, I’ve thought about this issue in the past too, and would be happy to help write some content or at least proofread / contribute tidbits to a guide for new developers. As pointed out in this thread, a lot of Swift infrastructure and paradigms comes from the LLVM community, but spelling that out

[swift-dev] Re-pitch: Deriving collections of enum cases

Over a year ago, we discussed adding a magic "allValues"/"allCases" static property on enums with a compiler-derived implementation. The original proposal PR has been reopened for Swift 5 after languishing for a while, and I'd like to revisit it a

Re: [swift-dev] [swift-evolution] Re-pitch: Deriving collections of enum cases

Jacob Bandes-Storch On Tue, Nov 14, 2017 at 9:06 PM, Brent Royal-Gordon wrote: > On Nov 14, 2017, at 5:21 PM, Xiaodi Wu wrote: > > 1. It must be possible to easily access the count of values, and to access >> any particular value using contiguous `Int` indices. This could be achieved >> either