Re: [swift-dev] Shouldn't the optimizer make this manual loop-unrolling unnecessary?

2015-12-11 Thread Mark Lacey via swift-dev
> On Dec 11, 2015, at 6:05 AM, Jens Persson via swift-dev > wrote: > > Correction: The test I'm running is actually using V4. > Manually unrolling the loop makes adding V4 as fast as adding SIMD > float4x4. > Using the (un-unrolled) for loop will be about 4 times

Re: [swift-dev] Policy on the use of clang-format

2016-04-05 Thread Mark Lacey via swift-dev
> On Apr 4, 2016, at 7:18 PM, Omeed Safaee-Rad via swift-dev > wrote: > > Hello Swift! :) Hi Omeed, > > First off, thank you for the wonderful project! > > I noticed that a number of C++ files in the Swift compiler could use a pass > of clang-format. What is the

Re: [swift-dev] Could not find a package configuration file provided by "Clang"

2016-07-22 Thread Mark Lacey via swift-dev
> On Jul 22, 2016, at 12:35 PM, Erica Sadun via swift-dev > wrote: > > So where do I find the "starter bugs for the humanities" how-to section? Is > there a checklist that goes beyond fix this code and explains tests, > comments, etc? I think this is what you’re looking

Re: [swift-dev] 1_stdlib/NSSetAPI.swift fails verifying open archetypes

2016-07-16 Thread Mark Lacey via swift-dev
FYI, I hit this yesterday on the master-next merge and have disabled the test on that branch. I hadn’t realized that it was already failing on master. Mark > On Jul 16, 2016, at 12:13 PM, Andrew Trick via swift-dev > wrote: > > Roman, > > This has been failing since

Re: [swift-dev] compiler-rt...Wait wat?

2016-08-17 Thread Mark Lacey via swift-dev
> On Aug 17, 2016, at 5:48 AM, Ryan Lovelett via swift-dev > wrote: > > I just noticed that if you do `utils/update-checkout --clone` it pulls > down `compiler-rt`. I have been building Swift from source on Linux for > awhile now. I've never once checked out compiler-rt.

Re: [swift-dev] Reporting/Debugging Slow Swift Compile Time

2016-10-05 Thread Mark Lacey via swift-dev
> On Oct 5, 2016, at 3:37 PM, Ben Asher wrote: > > I just tried with both Xcode 8.1 beta 2 and Xcode 8.0, and 8.1b2 seems maybe > 15s faster (to build our main huge target): 7m28s compared to 7m43s. It's > some improvement, but I'm not exactly sure what kind of

Re: [swift-dev] Reporting/Debugging Slow Swift Compile Time

2016-10-05 Thread Mark Lacey via swift-dev
> On Oct 4, 2016, at 2:38 PM, Ben Asher via swift-dev > wrote: > > Hello! I work with a large project (~900 .swift files and more .m files). We > have a nightly job that compiles the app and calls out function bodies (using > -debug-time-function-bodies) that are slower

Re: [swift-dev] Reporting/Debugging Slow Swift Compile Time

2016-10-08 Thread Mark Lacey via swift-dev
> On Oct 7, 2016, at 2:35 PM, Ben Asher wrote: > > Hello again! I wanted to follow up with some more numbers and feedback. I > wasn't able to easily compile a single file from our project from the CLI. I > started putting together a command with all of the necessary

Re: [swift-dev] Needs better error msg?

2016-09-20 Thread Mark Lacey via swift-dev
> On Sep 20, 2016, at 2:05 PM, Joe Groff via swift-dev > wrote: > >> >> On Sep 20, 2016, at 1:45 PM, Kevin Choi via swift-dev >> wrote: >> >> b.sw: >> func findIndex(array: [T], _ valueToFind: T) -> Int? { >>for (index, value) in

Re: [swift-dev] Major SwiftPM compile time regression

2016-09-25 Thread Mark Lacey via swift-dev
> On Sep 24, 2016, at 11:20 PM, Daniel Dunbar wrote: > > Thanks! I guess this showed up as a result of the most recent LLVM sync then? Yes, that seems like the most likely explanation. Mark > > - Daniel > >> On Sep 24, 2016, at 11:17 PM, Mark Lacey

Re: [swift-dev] [Swift CI] [FAILURE] oss-swift_tools-RA_stdlib-RDA_test-macos-resilience [#5]

2016-11-07 Thread Mark Lacey via swift-dev
> On Nov 7, 2016, at 5:00 PM, mishal_shah via swift-dev > wrote: > > SIL verification failed: function_ref inside fragile function cannot > reference a private or hidden symbol: (SingleFunction && > RefF->isExternalDeclaration()) || RefF->hasValidLinkageForFragileRef() >

Re: [swift-dev] Associated type inference fun with RandomAccessCollection

2016-11-07 Thread Mark Lacey via swift-dev
> On Nov 7, 2016, at 6:16 PM, Douglas Gregor via swift-dev > wrote: > > Hi all, > > While working on the type checker, I came across an interesting case for > associated type inference with the ‘Indices’ type of RandomAccessCollection. > At issue is a simple model of

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - OS X (master) #7135

2016-11-10 Thread Mark Lacey via swift-dev
Hi Sean, There appears to be a dependency issue in the clang build that is causing this. It (and another similar assert related to diagnostics) started showing up after we pulled in a diagnostics change this morning. You can ignore the failure. Hopefully we can get this fixed quickly. Mark

Re: [swift-dev] Swiftc and -parse-sil?

2016-10-18 Thread Mark Lacey via swift-dev
> On Oct 18, 2016, at 3:43 AM, Alex Blewitt via swift-dev > wrote: > > The swift compiler has an option '-parse-sil' which could previously be used > to parse SIL code. However, it looks like the swift compiler is assuming it's > still Swift code: I just opened a PR

Re: [swift-dev] Cleaning up stale branches?

2016-10-21 Thread Mark Lacey via swift-dev
> On Oct 21, 2016, at 9:14 AM, Daniel Dunbar via swift-dev > wrote: > > While on this topic... > > GitHub's support for doing cross-repo pull requests is excellent. Anyone can > easily fork the main repo, and push to their side repo (for example, with: > `git push

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 14.04 (master) #240

2016-12-12 Thread Mark Lacey via swift-dev
It appears a crasher isn’t crashing every time, so I’ll disable until we can investigate it: https://github.com/apple/swift/pull/6252 Mark > On Dec 12, 2016, at 11:46 PM, no-re...@swift.org wrote: > > [FAILURE]

Re: [swift-dev] Performance issues in automatic reference counting (ARC)?

2016-12-17 Thread Mark Lacey via swift-dev
> On Dec 17, 2016, at 11:13 AM, Brian Gesiak via swift-dev > wrote: > > Hello all! > > I really enjoyed Chris Lattner's slides from his talk at IBM >

Re: [swift-dev] -whole-module-optimization with -Onone

2016-12-01 Thread Mark Lacey via swift-dev
> On Dec 1, 2016, at 3:13 PM, Ben Asher via swift-dev > wrote: > > Just running a quick trial before and after I made this change in our > project, we were previously seeing builds of our main target that took just > under 13min. With this hack, a clean debug build takes

Re: [swift-dev] -whole-module-optimization with -Onone

2016-12-01 Thread Mark Lacey via swift-dev
> On Dec 1, 2016, at 5:48 PM, Ben Asher via swift-dev > wrote: > > The build failed compiling 3 files in our project. Our app is crashing that > snapshot; here is some output from the failures: It would be awesome if you could come up with small reproducers for these and

Re: [swift-dev] Clang 3.9.0

2016-11-29 Thread Mark Lacey via swift-dev
> On Nov 29, 2016, at 8:48 AM, Ryan Lovelett via swift-dev > wrote: > > Is it known/expected that Swift will not build with Clang 3.9.0? My > personal build-bot recently updated its upstream dependency from Clang > 3.8.1 to Clang 3.9.0 and since then it will not build the

Re: [swift-dev] CSGen/LinkedExprAnalyzer questions

2016-12-31 Thread Mark Lacey via swift-dev
> On Dec 30, 2016, at 2:07 PM, Jacob Bandes-Storch via swift-dev > wrote: > > This is a pretty great bug: https://bugs.swift.org/browse/SR-3483 > > > let x: Double? = 1 > > // error: ambiguous reference to member '+' >

Re: [swift-dev] Compiling Swift macOS 10.12.4 Xcode 9 beta 4

2017-08-10 Thread Mark Lacey via swift-dev
> On Aug 10, 2017, at 8:28 AM, Trevör ANNE DENISE via swift-dev > wrote: > > Hello everyone, > > > I followed the instructions on the Swift GitHub for installing and building > Swift on my Mac but there is an error that I don't know how to fix (I am > using the

Re: [swift-dev] Debugging performance regressions?

2017-08-09 Thread Mark Lacey via swift-dev
> On Aug 9, 2017, at 11:33 AM, Arnold Schwaighofer > wrote: > > Mark do you have suggestions for Dave? I’d suggest something similar to what Pavel said. My usual first step is to look at the output of -Xfrontend -debug-constraints, which in cases like this tends to

Re: [swift-dev] Typos while hacking on the constraint system

2017-08-18 Thread Mark Lacey via swift-dev
> On Aug 18, 2017, at 5:35 AM, David Zarzycki wrote: > > > >> On Aug 17, 2017, at 15:28, Mark Lacey > > wrote: >> >> >> >>> On Aug 17, 2017, at 10:28 AM, David Zarzycki via swift-dev >>>

Re: [swift-dev] [Swift CI] Build Failure: OSS - Swift Package - OS X (master) #3603

2017-06-23 Thread Mark Lacey via swift-dev
Joe, this failure looks like it is likely related to your commit below. Mark > On Jun 23, 2017, at 7:26 PM, no-reply--- via swift-dev > wrote: > > [FAILURE] oss-swift-package-osx [#3603] > > Build URL:https://ci.swift.org/job/oss-swift-package-osx/3603/ >

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (master) #3821

2017-05-22 Thread Mark Lacey via swift-dev
This went back to blue on the next run (which makes sense because these two changes shouldn’t be able to cause a failure like this), so it looks like this is a spurious failure. Mark > On May 22, 2017, at 4:21 PM, Mishal Shah wrote: > > Hi, > > Test Case

Re: [swift-dev] [Swift CI] Build Still Failing: 1. OSS - Swift (Tools Opt+Assert, Stdlib Opt+DebInfo+Assert, Resilience) - macOS (master) #185

2017-04-30 Thread Mark Lacey via swift-dev
Ben / Robert, I bisected the failures here and it looks like they are due to these two changes: Robert, The XFAILed FP test that is now passing (and thus…failing) is due to: commit 42c59554a0e980ab83f52eda41140c4b2c465834 Author: Robert Widmann Date: Tue Apr 4

Re: [swift-dev] Fuzzer tests failing?

2017-10-05 Thread Mark Lacey via swift-dev
Are you building with Xcode 9.0? Did you try reconfiguring, e.g. build-script all-your-options -- --reconfigure ? If those do not resolve the issue, I would suggest removing the swift-macosx-x86_64 directory in your build destination, and see if that helps. Mark > On Oct 5, 2017, at 7:51

Re: [swift-dev] Fuzzer tests failing?

2017-10-05 Thread Mark Lacey via swift-dev
and building everything (including compiler-rt)? I’m not sure I can be of much more help here but perhaps someone more familiar with this functionality and these tests can. Mark > > Dave > > > >> On Oct 5, 2017, at 12:55, Mark Lacey via swift-dev <swift-dev@swift.org>

Re: [swift-dev] Typos while hacking on the constraint system

2017-08-17 Thread Mark Lacey via swift-dev
> On Aug 17, 2017, at 10:28 AM, David Zarzycki via swift-dev > wrote: > > >> On Aug 17, 2017, at 13:03, Robert Widmann wrote: >> >> It’s an unfortunate naming scheme, but I would hesitate to use notions like >> “from” and “to”, especially in

Re: [swift-dev] Potential contributions to compilation time reporting?

2017-11-28 Thread Mark Lacey via swift-dev
> On Nov 19, 2017, at 9:02 PM, Brian Gesiak via swift-dev > wrote: > > Thanks for the reply, Graydon, and for your other email on the topic > ! > > I need to take more time to look into some

[swift-dev] Bots have all turned red

2017-11-09 Thread Mark Lacey via swift-dev
It looks like everything is broken at the moment as a result of an LLVM commit that we need to adjust for. The git hash is 42a3c53004c2529fbfcb6e4bbe8391880aa6667a. Mark ___ swift-dev mailing list swift-dev@swift.org

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (master) #2175

2018-01-04 Thread Mark Lacey via swift-dev
This should be fixed by https://github.com/apple/swift/pull/13733 Mark > On Jan 4, 2018, at 12:29 PM, swift...@swift.org wrote: > > [FAILURE] oss-swift-incremental-RA-linux-ubuntu-16_10 [#2175] > > Build URL: >

Re: [swift-dev] DebugScope Verification Error

2018-01-15 Thread Mark Lacey via swift-dev
I’d suggest looking at SILCloner.h as well as ScopeCloner in SILBasicBlock.cpp to see how they are dealing with debug scopes. Mark > On Jan 15, 2018, at 9:24 AM, Raj Barik via swift-dev > wrote: > > Hi, > > I am running into a debug scope SIL Verifier error when

Re: [swift-dev] DebugScope Verification Error

2018-01-15 Thread Mark Lacey via swift-dev
> On Jan 15, 2018, at 12:54 PM, Raj Barik wrote: > > Mark, > > Thanks a lot for quick reply. > > Is there any reason this interface in SILInstruction should be private? > void setDebugScope(SILBuilder , const SILDebugScope *DS); > > In my case, I am splicing the old F

Re: [swift-dev] [Swift CI] Build Failure: 2. Swift Source Compatibility Suite (master) #1014

2018-01-03 Thread Mark Lacey via swift-dev
> On Jan 3, 2018, at 7:31 PM, Vedant Kumar wrote: > >> >> On Jan 3, 2018, at 7:23 PM, Mark Lacey > > wrote: >> >> >> >>> On Jan 3, 2018, at 7:18 PM, Vedant Kumar >> > wrote: >>>

Re: [swift-dev] [Swift CI] Build Failure: 2. Swift Source Compatibility Suite (master) #1014

2018-01-03 Thread Mark Lacey via swift-dev
> On Jan 3, 2018, at 7:18 PM, Vedant Kumar wrote: > > This is a bit surprising, since I wouldn't expect this suite of tests to > stress the code coverage logic. > > How were you able to determine that the #13597 caused the break? I’m seeing this in the failing builds:

Re: [swift-dev] [Swift CI] Build Failure: 2. Swift Source Compatibility Suite (master) #1014

2018-01-03 Thread Mark Lacey via swift-dev
Vedant, this appears to be a result of your changes. I’ve opened https://github.com/apple/swift/pull/13709 to revert the later clean-up change which appears to be required before it will be possible to revert the change below. Mark > On Jan 3,