Re: [swift-dev] -whole-module-optimization with -Onone

2016-12-05 Thread Ben Asher via swift-dev
I've also come up with a small repro case that shows the duplicated bridging header work: https://bugs.swift.org/browse/SR-3338. Thanks! Ben On Fri, Dec 2, 2016 at 3:28 PM, Ben Asher wrote: > Filed the issues I ran into with repro cases here: > >

Re: [swift-dev] -whole-module-optimization with -Onone

2016-12-02 Thread Ben Asher via swift-dev
Filed the issues I ran into with repro cases here: https://bugs.swift.org/browse/SR-3319 https://bugs.swift.org/browse/SR-3321 SR-3321 covers the SIL verification failure. The assertion failure was in the same file as the one that repro'd the SIL verification failure, but I'm not seeing it

Re: [swift-dev] -whole-module-optimization with -Onone

2016-12-01 Thread Ben Asher via swift-dev
Sure thing! I’ll see if I can put small reproducers together tomorrow. Ben On Thu, Dec 1, 2016 at 7:08 PM, Mark Lacey wrote: > > On Dec 1, 2016, at 5:48 PM, Ben Asher via swift-dev > wrote: > > The build failed compiling 3 files in our project. Our

Re: [swift-dev] -whole-module-optimization with -Onone

2016-12-01 Thread Mark Lacey via swift-dev
> On Dec 1, 2016, at 5:48 PM, Ben Asher via swift-dev > wrote: > > The build failed compiling 3 files in our project. Our app is crashing that > snapshot; here is some output from the failures: It would be awesome if you could come up with small reproducers for these and

Re: [swift-dev] -whole-module-optimization with -Onone

2016-12-01 Thread Ben Asher via swift-dev
The build failed compiling 3 files in our project. Our app is crashing that snapshot; here is some output from the failures: - Assertion failed: (newType == type || (isa(newType) && cast(newType)->getNumElements() == 1 && cast(newType).getElementType(0) == type)), function rewriteType, file

Re: [swift-dev] -whole-module-optimization with -Onone

2016-12-01 Thread Ben Asher via swift-dev
Sure! Thanks for reminding me. I'll follow up on that, test, and get back to you. Ben On Thu, Dec 1, 2016 at 2:48 PM, Mark Lacey wrote: > > On Dec 1, 2016, at 3:13 PM, Ben Asher via swift-dev > wrote: > > Just running a quick trial before and after I

Re: [swift-dev] -whole-module-optimization with -Onone

2016-12-01 Thread Mark Lacey via swift-dev
> On Dec 1, 2016, at 3:13 PM, Ben Asher via swift-dev > wrote: > > Just running a quick trial before and after I made this change in our > project, we were previously seeing builds of our main target that took just > under 13min. With this hack, a clean debug build takes

Re: [swift-dev] -whole-module-optimization with -Onone

2016-12-01 Thread Ben Asher via swift-dev
Just running a quick trial before and after I made this change in our project, we were previously seeing builds of our main target that took just under 13min. With this hack, a clean debug build takes about 4.5min. Ben On Thu, Dec 1, 2016 at 1:33 PM, Ben Asher wrote: >

Re: [swift-dev] -whole-module-optimization with -Onone

2016-12-01 Thread Jordan Rose via swift-dev
Xcode needs to know that you're building in WMO mode, so rather than putting -whole-module-optimization in your "Other Swift Flags", put -Onone there. It's an ugly hack but it should work in the near term. We do want to work to make this drastic speed difference go away, so if you're able we