Re: [swift-dev] Having 64-bit swift_retain/release ignore all negative pointer values

2016-10-17 Thread Michael Gottesman via swift-dev
> On Oct 17, 2016, at 12:01 PM, Michael Gottesman wrote: > > >> On Oct 17, 2016, at 11:53 AM, Michael Gottesman via swift-dev >> mailto:swift-dev@swift.org>> wrote: >> >> >>> On Oct 17, 2016, at 10:00 AM, Joe Groff >> > wrote: >>> >>> On Oct 17, 2016, at 9:57

Re: [swift-dev] Having 64-bit swift_retain/release ignore all negative pointer values

2016-10-17 Thread Michael Gottesman via swift-dev
> On Oct 17, 2016, at 11:53 AM, Michael Gottesman via swift-dev > wrote: > > >> On Oct 17, 2016, at 10:00 AM, Joe Groff > > wrote: >> >> >>> On Oct 17, 2016, at 9:57 AM, Michael Gottesman >> > wrote: >>> >>> On Oct 17, 2016, at 9:4

Re: [swift-dev] Having 64-bit swift_retain/release ignore all negative pointer values

2016-10-17 Thread Michael Gottesman via swift-dev
> On Oct 17, 2016, at 10:00 AM, Joe Groff wrote: > > >> On Oct 17, 2016, at 9:57 AM, Michael Gottesman wrote: >> >> >>> On Oct 17, 2016, at 9:42 AM, Joe Groff via swift-dev >>> wrote: >>> >>> On Oct 16, 2016, at 1:10 PM, Dave Abrahams via swift-dev wrote: on

Re: [swift-dev] Having 64-bit swift_retain/release ignore all negative pointer values

2016-10-17 Thread Joe Groff via swift-dev
> On Oct 17, 2016, at 10:54 AM, Dave Abrahams wrote: > > > on Mon Oct 17 2016, Joe Groff wrote: > >>> On Oct 16, 2016, at 1:10 PM, Dave Abrahams via swift-dev >>> wrote: >>> >>> >>> on Thu Oct 13 2016, Joe Groff wrote: >>> >> > On Oct 13, 2016, at 1:18 PM, Greg Parker wrote: >

Re: [swift-dev] Having 64-bit swift_retain/release ignore all negative pointer values

2016-10-17 Thread Dave Abrahams via swift-dev
on Mon Oct 17 2016, Joe Groff wrote: >> On Oct 16, 2016, at 1:10 PM, Dave Abrahams via swift-dev >> wrote: >> >> >> on Thu Oct 13 2016, Joe Groff wrote: >> > On Oct 13, 2016, at 1:18 PM, Greg Parker wrote: > On Oct 13, 2016, at 10:46 AM, John McCall via swift-dev >>>

Re: [swift-dev] Having 64-bit swift_retain/release ignore all negative pointer values

2016-10-17 Thread Joe Groff via swift-dev
> On Oct 17, 2016, at 9:57 AM, Michael Gottesman wrote: > > >> On Oct 17, 2016, at 9:42 AM, Joe Groff via swift-dev >> wrote: >> >> >>> On Oct 16, 2016, at 1:10 PM, Dave Abrahams via swift-dev >>> wrote: >>> >>> >>> on Thu Oct 13 2016, Joe Groff wrote: >>> > On Oct 13, 2016, at 1:

Re: [swift-dev] Having 64-bit swift_retain/release ignore all negative pointer values

2016-10-17 Thread Michael Gottesman via swift-dev
> On Oct 17, 2016, at 9:42 AM, Joe Groff via swift-dev > wrote: > > >> On Oct 16, 2016, at 1:10 PM, Dave Abrahams via swift-dev >> wrote: >> >> >> on Thu Oct 13 2016, Joe Groff wrote: >> On Oct 13, 2016, at 1:18 PM, Greg Parker wrote: > On Oct 13, 2016, at 10:46 AM,

Re: [swift-dev] Having 64-bit swift_retain/release ignore all negative pointer values

2016-10-17 Thread Joe Groff via swift-dev
> On Oct 16, 2016, at 1:10 PM, Dave Abrahams via swift-dev > wrote: > > > on Thu Oct 13 2016, Joe Groff wrote: > >>> On Oct 13, 2016, at 1:18 PM, Greg Parker wrote: >>> >>> On Oct 13, 2016, at 10:46 AM, John McCall via swift-dev wrote: >> > On Oct 13, 2016, at 9:04

Re: [swift-dev] Having 64-bit swift_retain/release ignore all negative pointer values

2016-10-16 Thread Dave Abrahams via swift-dev
on Thu Oct 13 2016, Joe Groff wrote: >> On Oct 13, 2016, at 1:18 PM, Greg Parker wrote: >> >> >>> On Oct 13, 2016, at 10:46 AM, John McCall via swift-dev >>> wrote: >>> > On Oct 13, 2016, at 9:04 AM, Joe Groff via swift-dev wrote: > On Mar 1, 2016, at 1:33 PM, Joe Gro

Re: [swift-dev] Having 64-bit swift_retain/release ignore all negative pointer values

2016-10-13 Thread Alexis via swift-dev
> On Oct 13, 2016, at 5:14 PM, Joe Groff wrote: > > >> On Oct 13, 2016, at 2:04 PM, Alexis wrote: >> >> Correct me if I’m wrong, but aren’t all kernel addresses negative on x64 and >> AArch64? Would this then mean any attempt to use Swift in kernel-space >> requires a distinct ABI? > > Th

Re: [swift-dev] Having 64-bit swift_retain/release ignore all negative pointer values

2016-10-13 Thread John McCall via swift-dev
> On Oct 13, 2016, at 2:14 PM, Joe Groff via swift-dev > wrote: > > >> On Oct 13, 2016, at 2:04 PM, Alexis wrote: >> >> Correct me if I’m wrong, but aren’t all kernel addresses negative on x64 and >> AArch64? Would this then mean any attempt to use Swift in kernel-space >> requires a disti

Re: [swift-dev] Having 64-bit swift_retain/release ignore all negative pointer values

2016-10-13 Thread Joe Groff via swift-dev
> On Oct 13, 2016, at 2:04 PM, Alexis wrote: > > Correct me if I’m wrong, but aren’t all kernel addresses negative on x64 and > AArch64? Would this then mean any attempt to use Swift in kernel-space > requires a distinct ABI? That's correct, but we'd likely already have to have a separate "ke

Re: [swift-dev] Having 64-bit swift_retain/release ignore all negative pointer values

2016-10-13 Thread Alexis via swift-dev
Correct me if I’m wrong, but aren’t all kernel addresses negative on x64 and AArch64? Would this then mean any attempt to use Swift in kernel-space requires a distinct ABI? > On Oct 13, 2016, at 12:04 PM, Joe Groff via swift-dev > wrote: > > >> On Mar 1, 2016, at 1:33 PM, Joe Groff via swift

Re: [swift-dev] Having 64-bit swift_retain/release ignore all negative pointer values

2016-10-13 Thread Joe Groff via swift-dev
> On Oct 13, 2016, at 1:18 PM, Greg Parker wrote: > > >> On Oct 13, 2016, at 10:46 AM, John McCall via swift-dev >> wrote: >> >>> On Oct 13, 2016, at 9:04 AM, Joe Groff via swift-dev >>> wrote: >>> On Mar 1, 2016, at 1:33 PM, Joe Groff via swift-dev wrote: In swift_

Re: [swift-dev] Having 64-bit swift_retain/release ignore all negative pointer values

2016-10-13 Thread Greg Parker via swift-dev
> On Oct 13, 2016, at 10:46 AM, John McCall via swift-dev > wrote: > >> On Oct 13, 2016, at 9:04 AM, Joe Groff via swift-dev > > wrote: >> >>> On Mar 1, 2016, at 1:33 PM, Joe Groff via swift-dev >> > wrote: >>> >>> In swift_retain/releas

Re: [swift-dev] Having 64-bit swift_retain/release ignore all negative pointer values

2016-10-13 Thread John McCall via swift-dev
> On Oct 13, 2016, at 9:04 AM, Joe Groff via swift-dev > wrote: > > >> On Mar 1, 2016, at 1:33 PM, Joe Groff via swift-dev > > wrote: >> >> In swift_retain/release, we have an early-exit check to pass through a nil >> pointer. Since we're already burning branch, I

Re: [swift-dev] Having 64-bit swift_retain/release ignore all negative pointer values

2016-10-13 Thread Joe Groff via swift-dev
> On Mar 1, 2016, at 1:33 PM, Joe Groff via swift-dev > wrote: > > In swift_retain/release, we have an early-exit check to pass through a nil > pointer. Since we're already burning branch, I'm thinking we could pass > through not only zero but negative pointer values too on 64-bit systems, >