Re: [swift-evolution] [Review] SE-0073: Marking closures as executing exactly once

* What is your evaluation of the proposal? +1 I agree with others that there are opportunities to generalise this proposal. It would be pretty magical if it could be applied to escaping closures, less magical if that's just adding a runtime assertion. It would also be much more flexible if it

Re: [swift-evolution] [Review] SE-0073: Marking closures as executing exactly once

Replies inline: On Sat, May 7, 2016 at 12:37 PM, Dave Abrahams via swift-evolution < swift-evolution@swift.org> wrote: > > on Fri May 06 2016, Andrew Bennett wrote: > > > Hi Dave, > > > > Sorry, Dave, sending a second time as I forgot to Reply-All. > > > > I agree,

Re: [swift-evolution] [Review] SE-0073: Marking closures as executing exactly once

on Fri May 06 2016, Andrew Bennett wrote: > Hi Dave, > > Sorry, Dave, sending a second time as I forgot to Reply-All. > > I agree, this proposal doesn't allow multiple closures where only one of them > should be run, and it should only be run once. I personally don't

Re: [swift-evolution] [Review] SE-0073: Marking closures as executing exactly once

Hi Dave, Sorry, Dave, sending a second time as I forgot to Reply-All. I agree, this proposal doesn't allow multiple closures where only one of them should be run, and it should only be run once. I personally don't think lacking that functionality is worth blocking this proposal for, another

Re: [swift-evolution] [Review] SE-0073: Marking closures as executing exactly once

Agreed. I think you bring up points that articulate well my issues with this proposal. > On 7 May 2016, at 10:31 AM, Greg Parker via swift-evolution > wrote: > > >> On May 3, 2016, at 8:53 PM, Chris Lattner via swift-evolution >> wrote:

Re: [swift-evolution] [Review] SE-0073: Marking closures as executing exactly once

> On May 3, 2016, at 8:53 PM, Chris Lattner via swift-evolution > wrote: > > Hello Swift community, > > The review of "SE-0073: Marking closures as executing exactly once" begins > now and runs through May 9. The proposal is available here: > > >

Re: [swift-evolution] [Review] SE-0073: Marking closures as executing exactly once

* What is your evaluation of the proposal? +1 * Is the problem being addressed significant enough to warrant a change to Swift? I believe so. * Does this proposal fit well with the feel and direction of Swift? Yes * If you have used other languages or libraries with a

Re: [swift-evolution] [Review] SE-0073: Marking closures as executing exactly once

on Tue May 03 2016, Chris Lattner wrote: > Hello Swift community, > > The review of "SE-0073: Marking closures as executing exactly once" > begins now and runs through May 9. The proposal is available here: > > >

Re: [swift-evolution] [Review] SE-0073: Marking closures as executing exactly once

> * What is your evaluation of the proposal? +1. I like semantic guarantees provided by the compiler. > * Is the problem being addressed significant enough to warrant a change > to Swift? Yes. > * Does this proposal fit well with the feel and direction of Swift? Yes. > *

Re: [swift-evolution] [Review] SE-0073: Marking closures as executing exactly once

> Le 5 mai 2016 à 18:16, Dmitri Gribenko a écrit : > > On Thu, May 5, 2016 at 3:27 AM, Gwendal Roué wrote: I quite expect being able to throw out of a @noescape(once) block. Maybe the sentence "it must not be executed on any path that

Re: [swift-evolution] [Review] SE-0073: Marking closures as executing exactly once

On Thu, May 5, 2016 at 3:27 AM, Gwendal Roué wrote: >>> I quite expect being able to throw out of a @noescape(once) block. Maybe >>> the sentence "it must not be executed on any path that throws" should be >>> removed from the proposal, should it have the implications

Re: [swift-evolution] [Review] SE-0073: Marking closures as executing exactly once

> Le 4 mai 2016 à 14:49, Nicola Salmoria via swift-evolution > a écrit : > >> * What is your evaluation of the proposal? > > -1. The proposed change seems to require a somewhat complex implementation > in the compiler, and I fail to see clear benefits in the change.

Re: [swift-evolution] [Review] SE-0073: Marking closures as executing exactly once

>> I quite expect being able to throw out of a @noescape(once) block. Maybe the >> sentence "it must not be executed on any path that throws" should be removed >> from the proposal, should it have the implications you describe. >> >> Here is below what I expect this proposal to allow. So you

Re: [swift-evolution] [Review] SE-0073: Marking closures as executing exactly once

> Le 4 mai 2016 à 11:55, Pyry Jahkola a écrit : > > Hi Gwendal, > > Nice writeup. So I see that you recognise how this extra specification will > complicate (while also facilitate) things. And I also see that you're a > co-author of the proposal. So I'm more than happy

Re: [swift-evolution] [Review] SE-0073: Marking closures as executing exactly once

On Wed, May 4, 2016 at 2:24 AM, Gwendal Roué wrote: > >> Le 4 mai 2016 à 08:28, Pyry Jahkola via swift-evolution >> a écrit : >> >> Here's my review of "SE-0073: Marking closures as executing exactly once". >> >>> What is your evaluation of

Re: [swift-evolution] [Review] SE-0073: Marking closures as executing exactly once

> * What is your evaluation of the proposal? -1. The proposed change seems to require a somewhat complex implementation in the compiler, and I fail to see clear benefits in the change. > * Is the problem being addressed significant enough to warrant a change to Swift? Frankly, I don't think the

Re: [swift-evolution] [Review] SE-0073: Marking closures as executing exactly once

Hi Gwendal, Nice writeup. So I see that you recognise how this extra specification will complicate (while also facilitate) things. And I also see that you're a co-author of the proposal. So I'm more than happy if you can squeeze this extra into it. However reading your example code, I had to

Re: [swift-evolution] [Review] SE-0073: Marking closures as executing exactly once

> Le 4 mai 2016 à 08:28, Pyry Jahkola via swift-evolution > a écrit : > > Here's my review of "SE-0073: Marking closures as executing exactly once". > >> What is your evaluation of the proposal? > > +1. I think this is a good idea and should be accepted (without

Re: [swift-evolution] [Review] SE-0073: Marking closures as executing exactly once

>* What is your evaluation of the proposal? I like the proposal and I think it's a good idea, but I'm really not sure it is important enough to fix. Looking at the proposals already accepted, half of them are still waiting for an implementation. Several will probably never make it in time

Re: [swift-evolution] [Review] SE-0073: Marking closures as executing exactly once

Here's my review of "SE-0073 : Marking closures as executing exactly once". > What is your evaluation of the proposal? +1. I think this is a good idea and should be accepted (without extending the proposed

[swift-evolution] [Review] SE-0073: Marking closures as executing exactly once

Hello Swift community, The review of "SE-0073: Marking closures as executing exactly once" begins now and runs through May 9. The proposal is available here: https://github.com/apple/swift-evolution/blob/master/proposals/0073-noescape-once.md Reviews are an important part of the Swift