Re: [swift-evolution] [Review] SE-0078: Implement a rotate algorithm, equivalent to std::rotate() in C++

2016-05-06 Thread Dave Abrahams via swift-evolution
on Fri May 06 2016, Nate Cook wrote: >> On May 6, 2016, at 4:20 PM, Dave Abrahams via swift-evolution >> wrote: >> >>> on Fri May 06 2016, Nate Cook wrote: >>> >>>How can you reverse a variable-length collection with a fixed number of >>>iterations? Are you talking about loop unroll

Re: [swift-evolution] [Review] SE-0078: Implement a rotate algorithm, equivalent to std::rotate() in C++

2016-05-06 Thread Nate Cook via swift-evolution
> On May 6, 2016, at 4:20 PM, Dave Abrahams via swift-evolution > wrote: > >> on Fri May 06 2016, Nate Cook wrote: >> >>How can you reverse a variable-length collection with a fixed number of >>iterations? Are you talking about loop unrolling in the library? >> >> I mean looping coun

Re: [swift-evolution] [Review] SE-0078: Implement a rotate algorithm, equivalent to std::rotate() in C++

2016-05-06 Thread Dave Abrahams via swift-evolution
on Fri May 06 2016, Nate Cook wrote: > How can you reverse a variable-length collection with a fixed number of > iterations? Are you talking about loop unrolling in the library? > > I mean looping count / 2 times instead of looping while lowIndex < > highIndex, Why do you think that wil

Re: [swift-evolution] [Review] SE-0078: Implement a rotate algorithm, equivalent to std::rotate() in C++

2016-05-06 Thread Nate Cook via swift-evolution
> On May 6, 2016, at 3:18 PM, Dave Abrahams via swift-evolution > wrote: > > on Thu May 05 2016, Nate Cook > wrote: > >> Thanks for the feedback, Dmitri &co, this all looks excellent! I'll work on >> updating the proposal. >> >>> On May 5, 2016, at 6:13 PM,

Re: [swift-evolution] [Review] SE-0078: Implement a rotate algorithm, equivalent to std::rotate() in C++

2016-05-06 Thread Dave Abrahams via swift-evolution
on Thu May 05 2016, Nate Cook wrote: > Thanks for the feedback, Dmitri &co, this all looks excellent! I'll work on > updating the proposal. > >> On May 5, 2016, at 6:13 PM, Dmitri Gribenko wrote: >> >> On Tue, May 3, 2016 at 8:57 PM, Chris Lattner via swift-evolution >> wrote: >>> Hello Swif

Re: [swift-evolution] [Review] SE-0078: Implement a rotate algorithm, equivalent to std::rotate() in C++

2016-05-06 Thread Dmitri Gribenko via swift-evolution
On Fri, May 6, 2016 at 12:53 AM, Nate Cook wrote: > That brings up the question of which protocol to add the requirement to? > Without a MutableBidirectionalProtocol (which we don't want, right?), we'd > need to add it to MutableCollection. While a mutating reverse() is possible > for a forward co

Re: [swift-evolution] [Review] SE-0078: Implement a rotate algorithm, equivalent to std::rotate() in C++

2016-05-06 Thread Nate Cook via swift-evolution
> On May 6, 2016, at 12:35 AM, Dmitri Gribenko wrote: > > On Thu, May 5, 2016 at 5:11 PM, Nate Cook > wrote: >> Thanks for the feedback, Dmitri &co, this all looks excellent! I'll work on >> updating the proposal. >> >>> On May 5, 2016, at 6:13 PM, Dmitri Gribenko

Re: [swift-evolution] [Review] SE-0078: Implement a rotate algorithm, equivalent to std::rotate() in C++

2016-05-05 Thread Dmitri Gribenko via swift-evolution
On Thu, May 5, 2016 at 5:11 PM, Nate Cook wrote: > Thanks for the feedback, Dmitri &co, this all looks excellent! I'll work on > updating the proposal. > >> On May 5, 2016, at 6:13 PM, Dmitri Gribenko wrote: >> >> On Tue, May 3, 2016 at 8:57 PM, Chris Lattner via swift-evolution >> wrote: >>> H

Re: [swift-evolution] [Review] SE-0078: Implement a rotate algorithm, equivalent to std::rotate() in C++

2016-05-05 Thread Nate Cook via swift-evolution
Thanks for the feedback, Dmitri &co, this all looks excellent! I'll work on updating the proposal. > On May 5, 2016, at 6:13 PM, Dmitri Gribenko wrote: > > On Tue, May 3, 2016 at 8:57 PM, Chris Lattner via swift-evolution > wrote: >> Hello Swift community, >> >> The review of "SE-0078: Implem

Re: [swift-evolution] [Review] SE-0078: Implement a rotate algorithm, equivalent to std::rotate() in C++

2016-05-05 Thread Dmitri Gribenko via swift-evolution
On Tue, May 3, 2016 at 8:57 PM, Chris Lattner via swift-evolution wrote: > Hello Swift community, > > The review of "SE-0078: Implement a rotate algorithm, equivalent to > std::rotate() in C++" begins now and runs through May 9. Hi, I'm posting this feedback on behalf of Dave Abrahams, Max Mois

Re: [swift-evolution] [Review] SE-0078: Implement a rotate algorithm, equivalent to std::rotate() in C++

2016-05-03 Thread Nate Cook via swift-evolution
> On May 3, 2016, at 11:51 PM, Xiaodi Wu via swift-evolution > wrote: > >> * What is your evaluation of the proposal? > > +1. A very useful function to have on collections. > > In FORTRAN and in languages that take inspiration from it, the same function > is called a "circular shift"

Re: [swift-evolution] [Review] SE-0078: Implement a rotate algorithm, equivalent to std::rotate() in C++

2016-05-03 Thread Xiaodi Wu via swift-evolution
> * What is your evaluation of the proposal? > +1. A very useful function to have on collections. In FORTRAN and in languages that take inspiration from it, the same function is called a "circular shift"--IMO, it's a clearer name both by its associations with other uses of the term "shift

[swift-evolution] [Review] SE-0078: Implement a rotate algorithm, equivalent to std::rotate() in C++

2016-05-03 Thread Chris Lattner via swift-evolution
Hello Swift community, The review of "SE-0078: Implement a rotate algorithm, equivalent to std::rotate() in C++" begins now and runs through May 9. The proposal is available here: https://github.com/apple/swift-evolution/blob/master/proposals/0078-rotate-algorithm.md Reviews are an im