Re: [swift-evolution] [Review] SE-0119: Remove access modifiers from extensions

2016-07-17 Thread Xiaodi Wu via swift-evolution
On Sun, Jul 17, 2016 at 1:42 PM, Jose Cheyo Jimenez wrote: > > > On Jul 16, 2016, at 11:16 PM, Xiaodi Wu via swift-evolution < > swift-evolution@swift.org> wrote: > > On Sun, Jul 17, 2016 at 1:07 AM, Adrian Zubarev via swift-evolution < > swift-evolution@swift.org> wrote: >

Re: [swift-evolution] [Review] SE-0119: Remove access modifiers from extensions

2016-07-17 Thread Jose Cheyo Jimenez via swift-evolution
> On Jul 16, 2016, at 11:16 PM, Xiaodi Wu via swift-evolution > wrote: > >> On Sun, Jul 17, 2016 at 1:07 AM, Adrian Zubarev via swift-evolution >> wrote: >> My first draft had some mistakes related access modifier on extension but >>

Re: [swift-evolution] [Review] SE-0119: Remove access modifiers from extensions

2016-07-17 Thread Adrian Zubarev via swift-evolution
That’s what this mailing list is for. To discuss everything with the community and the core team behind Swift. If you don’t try, you won’t get anything. If everyone would be afraid to tackle something that might go really wrong during review, nothing will happen at all. We’ll end up with a

Re: [swift-evolution] [Review] SE-0119: Remove access modifiers from extensions

2016-07-17 Thread Adrian Zubarev via swift-evolution
Because extensions are not types. They are still bound to the type you extend. IMHO they should obey the access rules types follow, but we don’t want to debate this anymore. It won’t ever happen. I don’t think that attacking people for their whining and laziness is very constructive. Please

Re: [swift-evolution] [Review] SE-0119: Remove access modifiers from extensions

2016-07-17 Thread Xiaodi Wu via swift-evolution
On Sun, Jul 17, 2016 at 1:07 AM, Adrian Zubarev via swift-evolution < swift-evolution@swift.org> wrote: > My first draft had some mistakes related access modifier on extension but > the final proposal does fully understands how they work and aims to > eliminate default access modifier behavior. >

Re: [swift-evolution] [Review] SE-0119: Remove access modifiers from extensions

2016-07-17 Thread Adrian Zubarev via swift-evolution
My first draft had some mistakes related access modifier on extension but the final proposal does fully understands how they work and aims to eliminate default access modifier behavior. There is no default access modifier on other types like classes etc. So why should there be any on

Re: [swift-evolution] [Review] SE-0119: Remove access modifiers from extensions

2016-07-16 Thread Xiaodi Wu via swift-evolution
Can you elaborate? What understanding of extensions is lacking in this proposal? On Sat, Jul 16, 2016 at 22:30 L. Mihalkovic via swift-evolution < swift-evolution@swift.org> wrote: > > Regards > (From mobile) > > On Jul 16, 2016, at 9:35 PM, Adrian Zubarev via swift-evolution < >

Re: [swift-evolution] [Review] SE-0119: Remove access modifiers from extensions

2016-07-16 Thread L. Mihalkovic via swift-evolution
Regards (From mobile) > On Jul 16, 2016, at 9:35 PM, Adrian Zubarev via swift-evolution > wrote: > > Wrong thread ;) If you think it’s ill-prepared than provide some feedback > instead of just watching and waiting to throw negative feedback during review >

Re: [swift-evolution] [Review] SE-0119: Remove access modifiers from extensions

2016-07-16 Thread Adrian Zubarev via swift-evolution
Wrong thread ;) If you think it’s ill-prepared than provide some feedback instead of just watching and waiting to throw negative feedback during review process. There is a lot done, but it’s not visible to the public thread yet. Will be soon (by tomorrow I’d guess). Thanks. --  Adrian

Re: [swift-evolution] [Review] SE-0119: Remove access modifiers from extensions

2016-07-16 Thread L. Mihalkovic via swift-evolution
To me this is reminicent of what is happening with the T.Type / Type story, where there seems to be a rush to throw a proposal under the cut-off date even if it is ill-prepared, or based on misunderstandinds. Regards (From mobile) > On Jul 16, 2016, at 7:15 PM, Adrian Zubarev via

Re: [swift-evolution] [Review] SE-0119: Remove access modifiers from extensions

2016-07-16 Thread Adrian Zubarev via swift-evolution
I tried to tackle the ability to write extensions where everyone would be forced to write access modifier on member level. That’s what I had in my mind all the time. But the respond on this was, as you can see purely negative. :D Making all extensions public when there is protocol conformance

Re: [swift-evolution] [Review] SE-0119: Remove access modifiers from extensions

2016-07-16 Thread Paul Cantrell via swift-evolution
Like others, I do find the details of this proposal hard to follow. It doesn’t seem like a simpler mental model for developers. However, I also find the current rules around extension access modifiers hard to follow. It’s confusing that “public extension” changes the default for members, when

Re: [swift-evolution] [Review] SE-0119: Remove access modifiers from extensions

2016-07-16 Thread Adrian Zubarev via swift-evolution
If it’s possible I’d like to withdraw this proposal. I’m convinced by the feedback from the community. Feel free to reject it. ;) --  Adrian Zubarev Sent with Airmail Am 13. Juli 2016 um 19:33:00, John McCall via swift-evolution (swift-evolution@swift.org) schrieb: On Jul 13, 2016, at 10:26

Re: [swift-evolution] [Review] SE-0119: Remove access modifiers from extensions

2016-07-13 Thread John McCall via swift-evolution
> On Jul 13, 2016, at 10:26 AM, Xiaodi Wu via swift-evolution > wrote: > As Jordan mentioned, I don't (and I think other people don't) think of > extensions as their own entities, as they can't be referred to and have no > runtime representation. In that mental

Re: [swift-evolution] [Review] SE-0119: Remove access modifiers from extensions

2016-07-13 Thread Xiaodi Wu via swift-evolution
As Jordan mentioned, I don't (and I think other people don't) think of extensions as their own entities, as they can't be referred to and have no runtime representation. In that mental model, there isn't such a thing as "an extension being public." Instead, the access modifier is just a shorthand

Re: [swift-evolution] [Review] SE-0119: Remove access modifiers from extensions

2016-07-13 Thread Jose Cheyo Jimenez via swift-evolution
> On Jul 13, 2016, at 8:46 AM, Xiaodi Wu via swift-evolution > wrote: > > > >> On Wed, Jul 13, 2016 at 4:04 AM, Rod Brown via swift-evolution >> wrote: >> Proposal link: >>

Re: [swift-evolution] [Review] SE-0119: Remove access modifiers from extensions

2016-07-13 Thread Xiaodi Wu via swift-evolution
On Wed, Jul 13, 2016 at 4:04 AM, Rod Brown via swift-evolution < swift-evolution@swift.org> wrote: > Proposal link: > https://github.com/apple/swift-evolution/blob/master/proposals/0119-extensions-access-modifiers.md > > * What is your evaluation of the proposal? > > -1. Extensions appear to me

Re: [swift-evolution] [Review] SE-0119: Remove access modifiers from extensions

2016-07-13 Thread Xiaodi Wu via swift-evolution
> > * What is your evaluation of the proposal? > -1. I think the proposal has great technical merit; if implemented, it would improve the developer experience and pave the way for other improvements in expressivity in the future. However, the proposal doesn't do what it says on the tin

Re: [swift-evolution] [Review] SE-0119: Remove access modifiers from extensions

2016-07-13 Thread Rod Brown via swift-evolution
Proposal link: https://github.com/apple/swift-evolution/blob/master/proposals/0119-extensions-access-modifiers.md > * What is your evaluation of the proposal? -1. Extensions appear to me

Re: [swift-evolution] [Review] SE-0119: Remove access modifiers from extensions

2016-07-13 Thread David Hart via swift-evolution
>* What is your evaluation of the proposal? -1. I'd like to split my review of this proposal in its two features: The loss of extensions as an access modifier grouping construct is what I really dislike. IMHO, extensions are a natural way to express that, and I wouldn't want to have

Re: [swift-evolution] [Review] SE-0119: Remove access modifiers from extensions

2016-07-12 Thread Jose Cheyo Jimenez via swift-evolution
> * What is your evaluation of the proposal? -1 Strong. This proposal should go back to the drawing board because it is incoherent. This proposal claims to try to remove access modifiers but then also is trying to add them for: > 2.Allow access modifier when

[swift-evolution] [Review] SE-0119: Remove access modifiers from extensions

2016-07-12 Thread Chris Lattner via swift-evolution
Hello Swift community, The review of "SE-0119: Remove access modifiers from extensions" begins now and runs through July 19. The proposal is available here: https://github.com/apple/swift-evolution/blob/master/proposals/0119-extensions-access-modifiers.md Reviews are an important part