Re: [swift-evolution] [swift-build-dev] [Draft] Package Manager Custom Targets Layout

2017-03-29 Thread David Sweeris via swift-evolution
> On Mar 29, 2017, at 10:56, Ankit Aggarwal wrote: > > We discussed variadic overloads during the manifest redesign proposal but > ultimately rejected it. We could add an overload for a singular source file > (instead of variadic) but I think its simpler to just have

Re: [swift-evolution] [swift-build-dev] [Draft] Package Manager Custom Targets Layout

2017-03-29 Thread Ankit Aggarwal via swift-evolution
We discussed variadic overloads during the manifest redesign proposal but ultimately rejected it. We could add an overload for a singular source file (instead

Re: [swift-evolution] [swift-build-dev] [Draft] Package Manager Custom Targets Layout

2017-03-29 Thread David Sweeris via swift-evolution
On Mar 29, 2017, at 10:19, Ankit Aggarwal via swift-build-dev wrote: > The proposal is updated with this change. What do we think about adding convenience inits that take a single parameter in place of the []s, for when we're only passing one value? The down side

Re: [swift-evolution] [swift-build-dev] [Draft] Package Manager Custom Targets Layout

2017-03-29 Thread Ankit Aggarwal via swift-evolution
Oops, I had pressed reply instead reply all. The proposal is updated with this change. On Mon, Mar 27, 2017 at 12:32 PM, Ankit Aggarwal

Re: [swift-evolution] [swift-build-dev] [Draft] Package Manager Custom Targets Layout

2017-03-28 Thread Jens Nerup via swift-evolution
+1 > On 27 Mar 2017, at 07.27, Brent Royal-Gordon via swift-build-dev > wrote: > >> On Mar 24, 2017, at 1:26 PM, Ankit Aggarwal via swift-evolution >> > wrote: >> >> sources: This property defines the

Re: [swift-evolution] [swift-build-dev] [Draft] Package Manager Custom Targets Layout

2017-03-27 Thread David Sweeris via swift-evolution
Agreed Sent from my iPhone > On Mar 26, 2017, at 22:27, Brent Royal-Gordon via swift-build-dev > wrote: > >> On Mar 24, 2017, at 1:26 PM, Ankit Aggarwal via swift-evolution >> wrote: >> >> sources: This property defines the source files

Re: [swift-evolution] [swift-build-dev] [Draft] Package Manager Custom Targets Layout

2017-03-27 Thread Ankit Aggarwal via swift-evolution
Hi Joesph, Thank you for the feedback! > For the C target classes, I'd like to also see linker flags defined for > those packages, as currently that has to be included in additional flags > and maintained entirely outside the package structure with scripting, > Makefiles, or the like. That may

Re: [swift-evolution] [swift-build-dev] [Draft] Package Manager Custom Targets Layout

2017-03-27 Thread Ankit Aggarwal via swift-evolution
Hi Karl, Thank you for the feedback, comments inline. > 1) I’m not sure about listing all of the test targets together with the > product targets. I feel it may be better to have them as separate Arrays. > They both are similar entity so they stay together. Another example is products, which

Re: [swift-evolution] [swift-build-dev] [Draft] Package Manager Custom Targets Layout

2017-03-26 Thread Joseph Heck via swift-evolution
I like the explicitness and flexibility that providing these inputs via declaration in the package manager format. For the C target classes, I'd like to also see linker flags defined for those packages, as currently that has to be included in additional flags and maintained entirely outside