Re: [swift-evolution] Pitch: Renaming CharacterSet to UnicodeScalarSet

2016-09-30 Thread Dave Abrahams via swift-evolution
on Wed Sep 28 2016, Erica Sadun wrote: > Chris: "Also, it is worth saying that any source breaking change still has to > have an > ultra-compelling reason to be worth considering. Despite having a framework > to > support some source breaking changes, we still

Re: [swift-evolution] Pitch: Renaming CharacterSet to UnicodeScalarSet

2016-09-29 Thread David Sweeris via swift-evolution
IIUC, Jay wasn't arguing for renaming CharacterSet, but replacing it with Swift's existing Set mechanism. If/when generics get to the point that we can say 'extension Set {...}', I think the transition could simply be putting 'typealias CharacterSet = Set' somewhere in the framework (although

Re: [swift-evolution] Pitch: Renaming CharacterSet to UnicodeScalarSet

2016-09-28 Thread Jay Abbott via swift-evolution
Yes - this is totally confusing. CharacterSet and Set are completely different things with different semantics. I don't know the history, but is CharacterSet simply to have a Swift equivalent of NSCharacterSet? That seems to be what it is, but since Swift redefined characters in a better way,

Re: [swift-evolution] Pitch: Renaming CharacterSet to UnicodeScalarSet

2016-09-28 Thread Xiaodi Wu via swift-evolution
On Wed, Sep 28, 2016 at 10:34 PM, Xiaodi Wu wrote: > On Wed, Sep 28, 2016 at 10:23 PM, Charles Srstka via swift-evolution < > swift-evolution@swift.org> wrote: > >> On Sep 28, 2016, at 9:57 PM, Erica Sadun via swift-evolution < >> swift-evolution@swift.org> wrote: >> >> >>

Re: [swift-evolution] Pitch: Renaming CharacterSet to UnicodeScalarSet

2016-09-28 Thread Xiaodi Wu via swift-evolution
On Wed, Sep 28, 2016 at 10:23 PM, Charles Srstka via swift-evolution < swift-evolution@swift.org> wrote: > On Sep 28, 2016, at 9:57 PM, Erica Sadun via swift-evolution < > swift-evolution@swift.org> wrote: > > > D'erp. I missed that. And that's an unambiguous answer. > > So let me move on to part

Re: [swift-evolution] Pitch: Renaming CharacterSet to UnicodeScalarSet

2016-09-28 Thread Charles Srstka via swift-evolution
> On Sep 28, 2016, at 9:57 PM, Erica Sadun via swift-evolution > wrote: > > D'erp. I missed that. And that's an unambiguous answer. > > So let me move on to part B of the pitch: I think CharacterSets are broken. > >> Xiaodi Wu: "isn't the problem you're presenting

Re: [swift-evolution] Pitch: Renaming CharacterSet to UnicodeScalarSet

2016-09-28 Thread Erica Sadun via swift-evolution
On Sep 28, 2016, at 6:14 PM, Ben Rimmington wrote: > > >> On 28 Sep 2016, at 22:27, Erica Sadun wrote: >> >> Why not rename `CharacterSet` to `UnicodeScalarSe`t, and update the >> initializers >> to reflect they're being initialized from the unicode scalars in strings

Re: [swift-evolution] Pitch: Renaming CharacterSet to UnicodeScalarSet

2016-09-28 Thread Ben Rimmington via swift-evolution
> On 28 Sep 2016, at 22:27, Erica Sadun wrote: > > Why not rename `CharacterSet` to `UnicodeScalarSe`t, and update the > initializers > to reflect they're being initialized from the unicode scalars in strings and > ranges? I agree, but `UnicodeScalarSet` was rejected during the SE-0069

Re: [swift-evolution] Pitch: Renaming CharacterSet to UnicodeScalarSet

2016-09-28 Thread Xiaodi Wu via swift-evolution
Afaik, every Unicode scalar can be its own character, so IMO it's not bothersome that there are overloads that take Unicode scalar arguments. However, since the stated purpose of the type is to be a set of characters, isn't the problem you're presenting really an argument that the type should be

Re: [swift-evolution] Pitch: Renaming CharacterSet to UnicodeScalarSet

2016-09-28 Thread Erica Sadun via swift-evolution
On Sep 28, 2016, at 3:58 PM, Xiaodi Wu wrote: > > Is this really correct? Character and UnicodeScalar are not synonyms. The > Character type represents a character made up of one or more Unicode scalars > (i.e. an extended grapheme cluster). Is a CharacterSet a set of >

Re: [swift-evolution] Pitch: Renaming CharacterSet to UnicodeScalarSet

2016-09-28 Thread Xiaodi Wu via swift-evolution
Is this really correct? Character and UnicodeScalar are not synonyms. The Character type represents a character made up of one or more Unicode scalars (i.e. an extended grapheme cluster). Is a CharacterSet a set of Unicode-compliant characters that happens to be restricted to those characters each

[swift-evolution] Pitch: Renaming CharacterSet to UnicodeScalarSet

2016-09-28 Thread Erica Sadun via swift-evolution
Chris: "Also, it is worth saying that any source breaking change still has to have an ultra-compelling reason to be worth considering. Despite having a framework to support some source breaking changes, we still want to minimize them where ever possible." Since it seems to be open season on