Re: [swift-evolution] [Review] SE-0019 Swift Testing (Package Manager)

2016-01-05 Thread Paul Cantrell via swift-evolution
A few requests for clarification from the proposal authors: 1. The proposal talks in several places about “test modules” (for example, “test-module is created per subdirectory of Tests”). How do these test modules interact with Package.swift? Does each of them have a separate target? If so,

Re: [swift-evolution] [Review] SE-0019 Swift Testing (Package Manager)

2016-01-05 Thread John Joyce via swift-evolution
> On Jan 6, 2016, at 4:06 AM, Rick Ballard via swift-evolution > wrote: > > * What is your evaluation of the proposal? Overall this is great direction, but needs more deliberation and sifting about the details. This kind of infrastructure will live a while, or

Re: [swift-evolution] [Review] SE-0019 Swift Testing (Package Manager)

2016-01-05 Thread Max Howell via swift-evolution
>> Yes, and indeed, this isn’t really acceptable, but I think any changes to >> how this work would involve a discussion on the swift-build-dev mailing >> list. Really how targets depend on each other and external dependencies in >> the Package.swift manifest needs some work in general. > >

Re: [swift-evolution] [Review] SE-0019 Swift Testing (Package Manager)

2016-01-05 Thread Max Howell via swift-evolution
> On Jan 5, 2016, at 12:21 PM, Paul Cantrell wrote: > > Thanks for the clarifications. This helps me understand much better how the > proposal plays out. > >> On Jan 5, 2016, at 2:14 PM, Max Howell wrote: >> >>> 1. The proposal talks in several

Re: [swift-evolution] [Review] SE-0019 Swift Testing (Package Manager)

2016-01-05 Thread Paul Cantrell via swift-evolution
> On Jan 5, 2016, at 2:32 PM, Max Howell wrote: > >> On Jan 5, 2016, at 12:21 PM, Paul Cantrell wrote: >> >>> On Jan 5, 2016, at 2:14 PM, Max Howell wrote: >>> 1. The proposal talks in several places about “test modules”

Re: [swift-evolution] [Review] SE-0019 Swift Testing (Package Manager)

2016-01-05 Thread David Owens II via swift-evolution
Overall, I think the feature is important to have, but I don’t understand some of the aspects of the proposal. I also don’t think there is a real focus for clarity on the types of testing that are being supported here. The implication is that unit tests are what this is being targeted, but is

Re: [swift-evolution] [Review] SE-0019 Swift Testing (Package Manager)

2016-01-05 Thread Paul Cantrell via swift-evolution
> On Jan 5, 2016, at 4:48 PM, Max Howell wrote: > >>> Yes, and indeed, this isn’t really acceptable, but I think any changes to >>> how this work would involve a discussion on the swift-build-dev mailing >>> list. Really how targets depend on each other and external