Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning (Revised)

2016-12-05 Thread Daniel Dunbar via swift-evolution
> On Dec 5, 2016, at 8:09 PM, Paul Cantrell wrote: > > >> On Dec 2, 2016, at 11:11 AM, Daniel Dunbar > > wrote: >> >> >>> On Nov 28, 2016, at 8:25 PM, Paul Cantrell via swift-evolution >>>

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning (Revised)

2016-12-05 Thread Paul Cantrell via swift-evolution
> On Dec 2, 2016, at 11:11 AM, Daniel Dunbar wrote: > > >> On Nov 28, 2016, at 8:25 PM, Paul Cantrell via swift-evolution >> > wrote: >> >> This version of the proposal seems acceptable to me, though I have

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning (Revised)

2016-12-02 Thread Daniel Dunbar via swift-evolution
> On Nov 28, 2016, at 8:25 PM, Paul Cantrell via swift-evolution > wrote: > > Just a quick mini-review here; sorry, time pressure. > > This version of the proposal seems acceptable to me, though I have a nagging > feel that it’s more complex than it needs to be. I

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning (Revised)

2016-11-28 Thread Paul Cantrell via swift-evolution
Just a quick mini-review here; sorry, time pressure. This version of the proposal seems acceptable to me, though I have a nagging feel that it’s more complex than it needs to be. In particular, the two modes (autopin enabled / disabled) plus the --repin option seem to me to have a high

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning (Revised)

2016-11-28 Thread Daniel Dunbar via swift-evolution
> On Nov 23, 2016, at 3:03 PM, Martin Waitz via swift-evolution > wrote: > >> The review of "SE-0145: Package Manager Version Pinning" begins again after >> revisions, starting now and running through November 28th. The proposal is >> available here: >> >>

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning (Revised)

2016-11-28 Thread Adrian Kashivskyy via swift-evolution
> What is your evaluation of the proposal? +1. I think > Is the problem being addressed significant enough to warrant a change to > Swift? Yes, version pinning is a must-have feature for collaboration in larger scale. > Does this proposal fit well with the feel and direction of Swift? Yes,

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning (Revised)

2016-11-24 Thread Martin Waitz via swift-evolution
Hello, Am 2016-11-24 13:54, schrieb Alex Blewitt via swift-evolution: At the moment, the proposal suggests having a secondary 'pins' file, which exists to allow explicit dependencies to be checked in to version control. This can be done at the moment, using a Version(1,2,3) or range

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning (Revised)

2016-11-24 Thread Alex Blewitt via swift-evolution
> On 20 Nov 2016, at 05:48, Anders Bertelrud via swift-evolution > wrote: > > * What is your evaluation of the proposal? A way of building against a specific set of dependencies, rather than a variable set (or master), is needed in Swift. The current build

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning (Revised)

2016-11-23 Thread rintaro ishizaki via swift-evolution
2016-11-20 14:48 GMT+09:00 Anders Bertelrud via swift-evolution < swift-evolution@swift.org>: > Hello Swift community, > > The review of "SE-0145: Package Manager Version Pinning" begins again > after revisions, starting now and running through November 28th. The > proposal is available here: >

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning (Revised)

2016-11-23 Thread Martin Waitz via swift-evolution
> The review of "SE-0145: Package Manager Version Pinning" begins again after > revisions, starting now and running through November 28th. The proposal is > available here: > > > https://github.com/apple/swift-evolution/blob/master/proposals/0145-package-manager-version-pinning.md > >

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning (Revised)

2016-11-23 Thread Bouke Haarsma via swift-evolution
On 2016-11-20 05:48:48 +, Anders Bertelrud via swift-build-dev said: * What is your evaluation of the proposal? Good. The revision is a good improvement over the original proposal. Build reproducability is great improvement to the ecosystem. * Is the problem being addressed

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning (Revised)

2016-11-20 Thread Jay Abbott via swift-evolution
> What is your evaluation of the proposal? It seems like a sensible step on the way to more advanced workflow, stats, testing, checking upgrades, and reporting features - without closing any doors. > If you have used other languages or libraries with a similar feature, how do you feel that this

[swift-evolution] [Review] SE-0145: Package Manager Version Pinning (Revised)

2016-11-19 Thread Anders Bertelrud via swift-evolution
Hello Swift community, The review of "SE-0145: Package Manager Version Pinning" begins again after revisions, starting now and running through November 28th. The proposal is available here: