Re: [swift-evolution] [Draft] Test-Only Package Dependencies and Targets

2017-01-31 Thread Rick Ballard via swift-evolution
+ swift-build-dev To take a step back here, there are two problems I see in this space: 1) Building unnecessary test-only stuff. Say you have a package A which depends on a package B. B might declare a library, a test module, and some auxiliary target that's only needed by the tests. Today,

Re: [swift-evolution] [Draft] Test-Only Package Dependencies and Targets

2017-01-30 Thread Robert Widmann via swift-evolution
> On Jan 30, 2017, at 2:38 PM, Ankit Agarwal wrote: > > > Not in practice (with respect to package manifests). In fact, it seems that, > given there are separate commands (swift build and swift test), separate > directories (Sources and Tests), and separate products, that

Re: [swift-evolution] [Draft] Test-Only Package Dependencies and Targets

2017-01-30 Thread Ankit Agarwal via swift-evolution
> Not in practice (with respect to package manifests). In fact, it seems > that, given there are separate commands (swift build and swift test), > separate directories (Sources and Tests), and separate products, that > there's a hole to be filled here by separate handling for test suites in >

Re: [swift-evolution] [Draft] Test-Only Package Dependencies and Targets

2017-01-30 Thread Robert Widmann via swift-evolution
~Robert Widmann 2017/01/26 4:11、Ankit Agarwal のメッセージ: > > >> On Thu, Jan 26, 2017 at 1:55 PM, Robert Widmann via swift-evolution >> wrote: >> Three parts for three points: >> >> 1) Thanks! >> >> 2) I'm not sure generalizing this is particularly

Re: [swift-evolution] [Draft] Test-Only Package Dependencies and Targets

2017-01-26 Thread Ankit Agarwal via swift-evolution
On Thu, Jan 26, 2017 at 1:55 PM, Robert Widmann via swift-evolution < swift-evolution@swift.org> wrote: > Three parts for three points: > > 1) Thanks! > > 2) I'm not sure generalizing this is particularly useful post-products. > The larger point is not to have non-exported/local target

Re: [swift-evolution] [Draft] Test-Only Package Dependencies and Targets

2017-01-26 Thread Robert Widmann via swift-evolution
Three parts for three points: 1) Thanks! 2) I'm not sure generalizing this is particularly useful post-products. The larger point is not to have non-exported/local target dependencies but to make clear the divide between a package and its test suite in the manifest as well as on disk. Local

Re: [swift-evolution] [Draft] Test-Only Package Dependencies and Targets

2017-01-25 Thread Ankit Agarwal via swift-evolution
We don't have support for inlining package dependencies in targets (see the comment in above manifest example). I suggested that we turn this proposal into adding that feature. On Thu, 26 Jan 2017 at 1:04 PM, David Hart wrote: > I'm confused. I've followed this from afar as I

Re: [swift-evolution] [Draft] Test-Only Package Dependencies and Targets

2017-01-25 Thread David Hart via swift-evolution
I'm confused. I've followed this from afar as I don't have much SwiftPM experience, but if that is true, what's the point of the proposal? > On 26 Jan 2017, at 08:12, Ankit Agarwal via swift-evolution > wrote: > > The test targets are *not* compiled when you run

Re: [swift-evolution] [Draft] Test-Only Package Dependencies and Targets

2017-01-25 Thread Ankit Agarwal via swift-evolution
On Thu, Jan 26, 2017 at 6:37 AM, thislooksfun via swift-evolution < swift-evolution@swift.org> wrote: > I still much prefer 'testDependencies/Targets'. You seem to be confusing > this proposal with the (already accepted) Package Manager Product > Definitions >

Re: [swift-evolution] [Draft] Test-Only Package Dependencies and Targets

2017-01-25 Thread thislooksfun via swift-evolution
I still much prefer 'testDependencies/Targets'. You seem to be confusing this proposal with the (already accepted) Package Manager Product Definitions proposal. This proposal is strictly

Re: [swift-evolution] [Draft] Test-Only Package Dependencies and Targets

2017-01-25 Thread Ankit Aggarwal via swift-evolution
> On 25-Jan-2017, at 4:02 AM, Robert Widmann via swift-evolution > wrote: > > Hello Swift Community, > > Harlan Haskins and I have been working on libraries > to make interacting with LLVM and Clang’s > APIs more elegant with native

Re: [swift-evolution] [Draft] Test-Only Package Dependencies and Targets

2017-01-24 Thread Robert Widmann via swift-evolution
Excellent. I've added your name to the authors list on the gist. That is the version I'll be submitting to evolution soon. ~Robert Widmann 2017/01/25 0:58、thislooksfun のメッセージ: > No problem, it's been inactive for a couple weeks since I've been really > busy. And

Re: [swift-evolution] [Draft] Test-Only Package Dependencies and Targets

2017-01-24 Thread thislooksfun via swift-evolution
No problem, it's been inactive for a couple weeks since I've been really busy. And yeah, yours is more thorough. I didn't even consider adding a `testTargets` section. That alone is worth merging. -thislooksfun (tlf) > On Jan 24, 2017, at 11:55 PM, Robert Widmann

Re: [swift-evolution] [Draft] Test-Only Package Dependencies and Targets

2017-01-24 Thread Russ Bishop via swift-evolution
I never agreed with removing it so this gets a bit fat +1 from me. Russ > On Jan 24, 2017, at 2:32 PM, Robert Widmann via swift-evolution > wrote: > > Hello Swift Community, > > Harlan Haskins and I have been working on libraries >

Re: [swift-evolution] [Draft] Test-Only Package Dependencies and Targets

2017-01-24 Thread Robert Widmann via swift-evolution
Oh, I'm sorry. I didn't know there was existing work in this space. Considering this proposal looks like it expands on your earlier work, would you like to sign on to this and merge the two efforts? ~Robert Widmann 2017/01/25 0:47、thislooksfun のメッセージ: > As the

Re: [swift-evolution] [Draft] Test-Only Package Dependencies and Targets

2017-01-24 Thread thislooksfun via swift-evolution
As the author of the Add support for test-only dependencies thread, and the accompanying draft , this gets a big +1 from me.