Swing Dev [9] Review request for 6219960 null reference in ToolTipManager

2014-07-28 Thread Alexander Scherbatiy
Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-6219960 webrev: http://cr.openjdk.java.net/~alexsch/6219960/webrev.00 The NPE is fixed. Thanks, Alexandr.

Re: Swing Dev [9] Review request for 6219960 null reference in ToolTipManager

2014-07-28 Thread Petr Pchelko
Hello, Alexander. The fix looks fine. With best regards. Petr. On 28 июля 2014 г., at 18:20, Alexander Scherbatiy alexandr.scherba...@oracle.com wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-6219960 webrev:

Re: Swing Dev [9] Review request for 6219960 null reference in ToolTipManager

2014-07-28 Thread Sergey Bylokhov
Hi, Alexander. What about the test? I see that it was added to the bug comment. On 7/28/14 6:20 PM, Alexander Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-6219960 webrev: http://cr.openjdk.java.net/~alexsch/6219960/webrev.00 The NPE

Swing Dev Review request for JDK-8050924 fix doclint missing tags in a few javax.swing.plaf.basic classes

2014-07-28 Thread Steve Sides
Hello, Could you please review the fix for the following bug: https://bugs.openjdk.java.net/browse/JDK-8050924 Webrev corresponding: http://cr.openjdk.java.net/~ssides/8050924/8050924.00/ This addresses a few doclint missing tag and comment issues. thanks, -steve

Re: Swing Dev Review request for JDK-8050924 fix doclint missing tags in a few javax.swing.plaf.basic classes

2014-07-28 Thread Phil Race
http://cr.openjdk.java.net/~ssides/8050924/8050924.00/src/share/classes/javax/swing/plaf/basic/BasicInternalFrameUI.java.sdiff.html new empty line 187 seems superfluous. Please delete before pushing Otherwise seems fine. -phil. On 07/28/2014 01:14 PM, Steve Sides wrote: Hello, Could you