Hello.
Please review a small fix for jdk 9.
Incorrect description in JComponent.set/getAlignmentX/Y were aligned
with Component.getAlignmentX/Y.
Bug: https://bugs.openjdk.java.net/browse/JDK-8068374
Webrev can be found at: http://cr.openjdk.java.net/~serb/8068374/webrev.00
--
Best regards,
Hi, Joe.
The fix looks good.
On 10.01.2015 3:23, Joseph D. Darcy wrote:
Hello,
The previously proposed fix for
JDK-8055059: JDK9b22 public API exposes package private classes
was rejected during code review:
http://mail.openjdk.java.net/pipermail/swing-dev/2014-August/003829.html
The fix looks good to me.
Thanks,
Alexandr.
On 1/12/2015 11:44 AM, Sergey Bylokhov wrote:
Hello.
Please review a small fix for jdk 9.
Incorrect description in JComponent.set/getAlignmentX/Y were aligned
with Component.getAlignmentX/Y.
Bug:
Hello,
Could you review the fix:
bug: https://bugs.openjdk.java.net/browse/JDK-8068040
webrev: http://cr.openjdk.java.net/~alexsch/8068040/webrev.00
BasicComboBoxUI has a special workaround to forward the enter pressed
event
on the editable combo box to the default button. The
The fix looks good to me.
Could you formate the code to have a space between type cast
(UndoPosRef) and the positions variable?
780 UndoPosRef ref =
(UndoPosRef)positions.elementAt(counter);
Thanks,
Alexandr.
On 1/10/2015 3:23 AM, Joseph D. Darcy wrote:
Hello,
Hello.
Please review a fix for jdk 9.
Description:
The problem is that we consider the string which contains a combining
diaeresis as string which needs TextLayout. In such case
SwingUtilities2.clipString will use LineBreakMeasurer to calculate the
characters inside some advance. But by
Hello,
Can you confirm that the test still fails before the fix for 4177735 was
integrated, using both LF?
On 12.01.2015 18:45, shobhit gupta wrote:
|Hi,|
|Please review a fix ||for| |the issue:|
8068301 : [TEST_BUG] Test javax/swing/JColorChooser/Test4177735.java
fails with
Hi Sergey,
Before the fix for 4177735 was integrated, test failed with the
GTKLookAndFeel but passed with the MetalLookAndFeel.
On 12-Jan-15 9:25 PM, Sergey Bylokhov wrote:
Hello,
Can you confirm that the test still fails before the fix for 4177735
was integrated, using both LF?
On
Hello.
Please review a small fix for jdk 9. Unnecessary link was removed.
Bug: https://bugs.openjdk.java.net/browse/JDK-6338077
Webrev can be found at: http://cr.openjdk.java.net/~serb/6338077/webrev.00
--
Best regards, Sergey.
|Hi,|
|Please review a fix ||for| |the issue:|
8068301 : [TEST_BUG] Test javax/swing/JColorChooser/Test4177735.java
fails with ArrayIndexOutOfBoundsException with GTKLF
|Test bug fix.|
|https://bugs.openjdk.java.net/browse/JDK-8068301|||
|The webrev is:
These String literals may be replaced by equivalent character literals[1],
gaining some performance enhancement.
Webrev:
https://dl.dropboxusercontent.com/u/16109193/open_jdk/jdk/index_of_character/index.html
[1]
@State(Scope.Thread)
@OutputTimeUnit(TimeUnit.SECONDS)
public class
Hello.
Please review a fix for jdk 9.
When we paint some image on component we use this component as an
observer, which will be called when the image should be repainted(in
case of animated gif for example). But our code in the
AbstractButton.imageUpdate() will replace correct Icon to null if
Hello.
Please review a fix for jdk 9.
Most of the problems, which were found by the test, were fixed already,
but one issue was found in Aqua.
Bug: https://bugs.openjdk.java.net/browse/JDK-6459800
Webrev can be found at: http://cr.openjdk.java.net/~serb/6459800/webrev.00
--
Best regards,
+1
-phil.
On 1/12/2015 1:13 AM, Sergey Bylokhov wrote:
Hi, Joe.
The fix looks good.
On 10.01.2015 3:23, Joseph D. Darcy wrote:
Hello,
The previously proposed fix for
JDK-8055059: JDK9b22 public API exposes package private classes
was rejected during code review:
14 matches
Mail list logo