Re: Review request for 8013566: Failure of GroupLayout in combination of addPreferredGap and addGroup's

2015-03-11 Thread Semyon Sadetsky
Hi Sergey, I couldn't find this 6494656 in jdk and jck test repositories. How can I find it? Thanks, --Semyon On 3/11/2015 8:05 PM, Sergey Bylokhov wrote: Hi, Semyon. Please confirm that the test for 6494656 completed successfully also. 11.03.15 4:01, Semyon Sadetsky wrote: JCK run is OK: M

[9] Review Request for 8040328: JSlider has wrong preferred size with Synth LAF

2015-03-11 Thread Semyon Sadetsky
Hello, please review fix for jdk9 webrev: http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/8040328/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8040328 Thanks, --Semyon

Re: [OpenJDK 2D-Dev] [9] Review Request: 8074668 [macosx] Mac 10.10: Application run with splash screen has focus issues

2015-03-11 Thread Phil Race
+1 .. I was pondering the exact same approach so I am OK with this as it leaves the useful code in place and disables the problematic part. There was a test added for the hi-res splash. Perhaps you should add an @ignore for now ? -phil. On 3/11/15 6:46 PM, Sergey Bylokhov wrote: 11.03.15 18:40,

Re: [9] Review Request: 8074668 [macosx] Mac 10.10: Application run with splash screen has focus issues

2015-03-11 Thread Sergey Bylokhov
11.03.15 18:40, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 8/9. Lots of issues(hangs or focus lost) occurred after we call NSScreen.backingScaleFactor on a Appkit Thread in time of splash screen initialization. This is a regression of two fixes: https://bugs.openjdk.java.net/b

[9] Review Request: 8074668 [macosx] Mac 10.10: Application run with splash screen has focus issues

2015-03-11 Thread Sergey Bylokhov
Hello. Please review the fix for jdk 8/9. Lots of issues(hangs or focus lost) occurred after we call NSScreen.backingScaleFactor on a Appkit Thread in time of splash screen initialization. This is a regression of two fixes: https://bugs.openjdk.java.net/browse/JDK-8043869 https://bugs.openjdk.j

Re: Review request for 8013566: Failure of GroupLayout in combination of addPreferredGap and addGroup's

2015-03-11 Thread Sergey Bylokhov
Hi, Semyon. Please confirm that the test for 6494656 completed successfully also. 11.03.15 4:01, Semyon Sadetsky wrote: JCK run is OK: Mar 11, 2015 1:58:55 PM Finished executing all tests, wait for cleanup... Mar 11, 2015 1:58:55 PM Harness done with cleanup from test run. Total time = 33s Setu

Re: Review request for 8013566: Failure of GroupLayout in combination of addPreferredGap and addGroup's

2015-03-11 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 3/11/2015 2:01 PM, Semyon Sadetsky wrote: JCK run is OK: Mar 11, 2015 1:58:55 PM Finished executing all tests, wait for cleanup... Mar 11, 2015 1:58:55 PM Harness done with cleanup from test run. Total time = 33s Setup time = 0s Cleanup tim

Re: Review request for 8013566: Failure of GroupLayout in combination of addPreferredGap and addGroup's

2015-03-11 Thread Semyon Sadetsky
JCK run is OK: Mar 11, 2015 1:58:55 PM Finished executing all tests, wait for cleanup... Mar 11, 2015 1:58:55 PM Harness done with cleanup from test run. Total time = 33s Setup time = 0s Cleanup time = 0s Test results: passed: 8 Hi Alexander, your remarks are taken into account : http://cr.op