Re: [9] Review Request for 6921687: Mnemonic disappears after repeated attempts to open menu items using mnemonics

On 3/23/2015 5:36 PM, Alexander Scherbatiy wrote: On 3/23/2015 2:22 PM, Semyon Sadetsky wrote: Hello, Please review JDK9 fix. webrev: http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/6921687/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-6921687 - What was the reason that

Re: [9] Review Request for 6866751: J2SE_Swing_Reg: the caret disappears when moving to the end of the line.

Hi Sergey, On 3/23/2015 5:41 PM, Sergey Bylokhov wrote: Hi, Semyon. It seems that "Caret.width" is platform specific property, right? (looks like it is initialized on windows only). It can be set on any platform. If it is not set we take 1px which is the default cursor width. What happens i

Re: RfR JDK-8055831 Open Source Java Access Bridge

I posted this to awt-dev and build-dev Friday and it was suggested that I also post it to swing-dev. On 3/20/15 11:33 PM, Pete Brunet wrote: > Please review the following patch which will add the code of the Java > Access Bridge (JAB) and related Java Accessibility Utilities to OpenJDK. > > This c

Re: [9] Review request for 8033000 No Horizontal Mouse Wheel Support In BasicScrollPaneUI

Hello Alexandr, the fix looks good to me, but I think that it should be documented somewhere. Users probably should know about this convenient behavior. Thanks, Alexander. On 03/23/2015 05:46 PM, Alexander Scherbatiy wrote: On 3/23/2015 5:44 PM, Sergey Bylokhov wrote: Hi, Alexander. Will yo

Re: [9] Review request for 8033000 No Horizontal Mouse Wheel Support In BasicScrollPaneUI

On 3/23/2015 5:44 PM, Sergey Bylokhov wrote: Hi, Alexander. Will you plan to backport it to jdk8? I remember that we have similar RFE in jkd9 where public API for horizontal scrolling was requested. Yes. Thanks, Alexandr. 23.03.15 17:08, Alexander Scherbatiy wrote: Hello, Could yo

Re: [9] Review request for 8033000 No Horizontal Mouse Wheel Support In BasicScrollPaneUI

Hi, Alexander. Will you plan to backport it to jdk8? I remember that we have similar RFE in jkd9 where public API for horizontal scrolling was requested. 23.03.15 17:08, Alexander Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8033000 webr

Re: [9] Review Request for 6866751: J2SE_Swing_Reg: the caret disappears when moving to the end of the line.

Hi, Semyon. It seems that "Caret.width" is platform specific property, right? (looks like it is initialized on windows only). What happens if the user will set the size/aspect of the caret via "putClientProperty" after the fix? It seems that correct width of the caret can be obtained via Defau

Re: [9] Review Request for 6921687: Mnemonic disappears after repeated attempts to open menu items using mnemonics

On 3/23/2015 2:22 PM, Semyon Sadetsky wrote: Hello, Please review JDK9 fix. webrev: http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/6921687/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-6921687 - What was the reason that mnemonics were hidden between alt press and releas

Re: [9] Review Request for 8075314: All the InternalFrames will be maximized after maximizing only one of the InternalFrame with the special options "-client -Xmixed -Dswing.defaultlaf=com

The fix looks good to me. Thanks, Alexandr. On 3/23/2015 1:58 PM, Semyon Sadetsky wrote: Hello, please review JDK9 fix webrev: http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/8075314/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8075314 Thanks! --Semyon

[9] Review request for 8033000 No Horizontal Mouse Wheel Support In BasicScrollPaneUI

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8033000 webrev: http://cr.openjdk.java.net/~alexsch/8033000/webrev.00 Shift modifier is added to for the horizontal scrolling detection. Thanks, Alexandr.

Re: [9] Review Request for 6866751: J2SE_Swing_Reg: the caret disappears when moving to the end of the line.

+description Cursor size is added to any text control preferred width. On 3/23/2015 2:33 PM, Semyon Sadetsky wrote: Hello, Please review JDK9 fix. webrev: http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/6866751/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-6866751 Thanks! --S

Re: [9] Review Request for 8075314: All the InternalFrames will be maximized after maximizing only one of the InternalFrame with the special options "-client -Xmixed -Dswing.defaultlaf=com

+description A check for the closed state of the previous topmost window is added for the top window selection procedure. On 3/23/2015 1:58 PM, Semyon Sadetsky wrote: Hello, please review JDK9 fix webrev: http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/8075314/webrev.00/ bug: https://bu

Re: [9] Review Request for 6921687: Mnemonic disappears after repeated attempts to open menu items using mnemonics

+description When ALT PRESSED event comes for the second time it can be the case to clear menu focus and srokes or the case when ALT+key combination is about to be pressed. The last one was missed in the ALT key handler. On 3/23/2015 2:22 PM, Semyon Sadetsky wrote: Hello, Please review JDK9

[9] Review Request for 6866751: J2SE_Swing_Reg: the caret disappears when moving to the end of the line.

Hello, Please review JDK9 fix. webrev: http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/6866751/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-6866751 Thanks! --Semyon

[9] Review Request for 6921687: Mnemonic disappears after repeated attempts to open menu items using mnemonics

Hello, Please review JDK9 fix. webrev: http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/6921687/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-6921687 Thanks! --Semyon

[9] Review Request for 8075314: All the InternalFrames will be maximized after maximizing only one of the InternalFrame with the special options "-client -Xmixed -Dswing.defaultlaf=com.sun

Hello, please review JDK9 fix webrev: http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/8075314/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8075314 Thanks! --Semyon