Re: Swing Dev AWT Dev RfR JDK-8055831 Open Source Java Access Bridge

2015-03-25 Thread Erik Joelsson
Hello Peter, The new source layout and Lib-jdk.accessibility.gmk look much better. Thanks! Regarding the .def files, I was mistaken and missed that they were referenced in the LDFLAGS, they were indeed used in the build so no reason to remove them. /Erik On 2015-03-24 22:36, Pete Brunet

Re: Swing Dev [9] Review Request for 8041642: Incorrect paint of JProgressBar in Nimbus LF

2015-03-25 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 3/16/2015 1:23 PM, Semyon Sadetsky wrote: Hello, please review JDK9 fix: webrev: http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/8041642/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8041642 Nimbus uses hard-coded images

Re: Swing Dev AWT Dev RfR JDK-8055831 Open Source Java Access Bridge

2015-03-25 Thread Pete Brunet
On 3/25/15 3:01 AM, Erik Joelsson wrote: Hello Peter, The new source layout and Lib-jdk.accessibility.gmk look much better. Thanks! Regarding the .def files, I was mistaken and missed that they were referenced in the LDFLAGS, they were indeed used in the build so no reason to remove

Re: Swing Dev AWT Dev RfR JDK-8055831 Open Source Java Access Bridge

2015-03-25 Thread Pete Brunet
Hi Sergey, Which methods are you referring to? -Pete On 3/25/15 10:16 AM, Sergey Bylokhov wrote: The fix looks fine. But it is interesting, do we have an option to remove all deprecated methods during this opening? or can we do it later? or we cannot? 25.03.15 17:44, Pete Brunet wrote: On

Re: Swing Dev AWT Dev RfR JDK-8055831 Open Source Java Access Bridge

2015-03-25 Thread Mandy Chung
On 3/24/2015 2:36 PM, Pete Brunet wrote: Here's the latest patch: http://cr.openjdk.java.net/~ptbrunet/JDK-8055831/webrev.01/ The modules.xml change looks fine. Mandy

Re: Swing Dev AWT Dev RfR JDK-8055831 Open Source Java Access Bridge

2015-03-25 Thread Sergey Bylokhov
The fix looks fine. But it is interesting, do we have an option to remove all deprecated methods during this opening? or can we do it later? or we cannot? 25.03.15 17:44, Pete Brunet wrote: On 3/25/15 3:01 AM, Erik Joelsson wrote: Hello Peter, The new source layout and

Re: Swing Dev AWT Dev RfR JDK-8055831 Open Source Java Access Bridge

2015-03-25 Thread Phil Race
AWTEventMonitor.java has a bunch of deprecated methods. If you don't have time now (I expect you don't) then it can be revisited later. Open sourcing is different than binary compatibility. The change jdk/make/copy/Copy-java.gmk suggests that accessbridge is the only reason the closed version of

Re: Swing Dev AWT Dev RfR JDK-8055831 Open Source Java Access Bridge

2015-03-25 Thread Pete Brunet
Thanks Phil, On 3/25/15 11:26 AM, Phil Race wrote: AWTEventMonitor.java has a bunch of deprecated methods. If you don't have time now (I expect you don't) then it can be revisited later. Open sourcing is different than binary compatibility. These were deprecated via CCC 8007499. The change

Re: Swing Dev AWT Dev RfR JDK-8055831 Open Source Java Access Bridge

2015-03-25 Thread Phil Race
On 3/25/2015 10:58 AM, Pete Brunet wrote: Thanks Phil, On 3/25/15 11:26 AM, Phil Race wrote: AWTEventMonitor.java has a bunch of deprecated methods. If you don't have time now (I expect you don't) then it can be revisited later. Open sourcing is different than binary compatibility. These were

Re: Swing Dev Review request for 6894632: Removing rows from a DefaultTableModel with a RowSorter deselectes last row

2015-03-25 Thread Sergey Bylokhov
Hi, Semyon. There is a problem which we discussed offline already. This change fix the problem described in the bug report, but it contradicts the specification of this method, which state that tableChanged should clears the selection if any. So the specification should be updated also via