Re: [9] Review request for 8051548 JColorChooser should have a way to disable transparency controls

2015-04-16 Thread Phil Race
210 211 void setColorTransparencySelectionEnabled(boolean b) { 212 spinners[model.getCount() - 1].setVisible(b); 213 colorChanged(); 214 } do you want to check if there's a state change here before firing the events ? Other than that it looks OK to me. -phil. On

Re: [9] Review Request for 7072653: JComboBox popup mispositioned if its height exceeds the screen height

2015-04-16 Thread Semyon Sadetsky
Subject corrected. On 4/16/2015 3:55 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-7072653 webrev: http://cr.openjdk.java.net/~ssadetsky/7072653/webrev.00/ *THE ROOT CAUSE Incorrect bounds calculation of heavy weight popup window i

Re: [9] Review request for 8074956: ArrayIndexOutOfBoundsException in javax.swing.text.html.parser.ContentModel.first()

2015-04-16 Thread Alexander Potochkin
Hello Alexey Looks good! Thanks alexp On 4/13/2015 4:34 PM, Alexey Ivanov wrote: Hello Swing team, Could you please review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8074956 webrev: http://cr.openjdk.java.net/~aivanov/8074956/jdk9/webrev.00/ Description: Implementation of

[9] Review Request for 6866751:

2015-04-16 Thread Semyon Sadetsky
Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-7072653 webrev: http://cr.openjdk.java.net/~ssadetsky/7072653/webrev.00/ *THE ROOT CAUSE Incorrect bounds calculation of heavy weight popup window in the BasicComboPopup when the requested popup menu height exceed

Re: JDK 9 RFR of JDK-8075082: Fix missing doclint warnings in the javax.swing package

2015-04-16 Thread Anton V. Tarasov
Hi Joe, On 15.04.2015 20:02, joe darcy wrote: Hi Anton, On 4/15/2015 8:14 AM, Anton V. Tarasov wrote: Hi Joe, (Looking into DefaultFocusManager.java) Formally, the @return description is not good here: +/** + * Compare the components. + * @param a the first component + * @par

Re: [9] Review request for 8051548 JColorChooser should have a way to disable transparency controls

2015-04-16 Thread Alexandr Scherbatiy
15.04.2015 22:22, Sergey Bylokhov пишет: HI, Alexander. What is the status of this fix? The fix requires at least two reviewers. Thanks, Alexandr. On 25.07.14 16:45, Alexander Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8051548 webrev:

new kind of exception raised since publication of latest Java releases

2015-04-16 Thread Holger Brands
Hello, sorry if this post is off-topic, but perhaps you can forward this message to the responsible people at Oracle. In any case, desktop applications distributed with Java Webstart seem to be affected. Since yesterday we get a lot of the following exceptions: java.lang.SecurityException: Sicher