On 5/21/2015 5:34 PM, Semyon Sadetsky wrote:
Hello,
I have decided to remake the fix.
The reason for that is sun.swing.FilePane class. One of its inner
classes extends DefaultRowSorter and relays on lazy initialization of
the DefaultRowSorter in unsorted state. After removing the lazy init
https://bugs.openjdk.java.net/browse/JDK-8081231
ShellFolder2 only gets a definition of DASSERT if DEBUG is defined.
Proposed fix :-
diff --git
a/src/java.desktop/windows/native/libawt/windows/ShellFolder2.cpp
b/src/java.desktop/windows/native/libawt/windows/ShellFolder2.cpp
---
Looks fine
--
Thanks,
Alexander.
On 26.05.2015 21:48, Phil Race wrote:
https://bugs.openjdk.java.net/browse/JDK-8081231
ShellFolder2 only gets a definition of DASSERT if DEBUG is defined.
Proposed fix :-
diff --git
a/src/java.desktop/windows/native/libawt/windows/ShellFolder2.cpp
Actually no it wasn't :-) I'd overlooked the line escapes.
So I'll try the following approach :- (but I am waiting for my build to
complete) :-
diff --git
a/src/java.desktop/windows/native/libawt/windows/ShellFolder2.cpp
b/src/java.desktop/windows/native/libawt/windows/ShellFolder2.cpp
---
Oh, I see :)
+1
--
Thanks,
Alexander.
On 26.05.2015 23:41, Phil Race wrote:
Actually no it wasn't :-) I'd overlooked the line escapes.
So I'll try the following approach :- (but I am waiting for my build
to complete) :-
diff --git
The fix looks good to me.
Thanks,
Alexandr.
On 5/26/2015 4:54 PM, Alexey Ivanov wrote:
Hello Swing team,
Could you please review the fix for JDK 8:
bug: https://bugs.openjdk.java.net/browse/JDK-8080628
webrev: http://cr.openjdk.java.net/~aivanov/8080628/jdk8/webrev.00/
JDK9
Hello Swing team,
Could you please review the fix for JDK 8:
bug: https://bugs.openjdk.java.net/browse/JDK-8080628
webrev: http://cr.openjdk.java.net/~aivanov/8080628/jdk8/webrev.00/
JDK9 code review:
http://mail.openjdk.java.net/pipermail/swing-dev/2015-May/004547.html
The changes
