[9-dev] Review request for bug 8079253 : [TESTBUG] Test javax/swing/SwingUtilities/TestBadBreak/TestBadBreak.java fails

2015-06-02 Thread shobhit gupta
Hi, Please review a fix for the issue: 8079253 : [TESTBUG] Test javax/swing/SwingUtilities/TestBadBreak/TestBadBreak.java fails Bug : https://bugs.openjdk.java.net/browse/JDK-8079253 Webrev : http://cr.openjdk.java.net/~sgupta/8079253/webrev.00/ Thanks and Regards, Shobhit Gupta

Re: internal API usage: sun.awt.AppContext

2015-06-02 Thread Alan Snyder
Got it. Thank you. Alan > On Jun 2, 2015, at 12:10 PM, Phil Race wrote: > > Alan, > > AppContext was devised to support applets running in browsers > where the JDK internal classes were shared so were in need of > a way to provide a key that was unique to each running applet. > Note that th

Re: internal API usage: sun.awt.AppContext

2015-06-02 Thread Phil Race
Alan, AppContext was devised to support applets running in browsers where the JDK internal classes were shared so were in need of a way to provide a key that was unique to each running applet. Note that the 'advertisement' is comments on the internal source code. Unless your L&F is installed on t

Re: internal API usage: sun.awt.AppContext

2015-06-02 Thread Alan Snyder
Is this the proper forum for asking this question? I have not seen any reply. > On May 28, 2015, at 7:13 PM, Alan Snyder wrote: > > I am using code — a custom Swing look and feel — that uses the > getAppContext(), get(), put(), and remove() methods of sun.awt.AppContext to > store configur

RFR [9] 8081313: MultipleDocumentHandling.java: tidy warnings

2015-06-02 Thread alexander stepanov
Sorry; was sent to wrong mailing list initially. On 29.05.2015 14:58, alexander stepanov wrote: Hello, Could you please review fix http://cr.openjdk.java.net/~avstepan/8081313/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8081313 Just a minor fix of docs; other code is not affected.

Re: RFR: JDK-8076468: Add @modules to jtreg jdk_desktop tests to take into account the new modular architecture

2015-06-02 Thread Yuri Nesterenko
Hi Alexander(s), I have some problems not with this change but with the routine itself. As I understand, this change is automatically generated. The generator script is imperfect. For instance, it cannot catch dependencies in places like javax/swing/RepaintManager/6608456/bug6608456.java where t

RFR: JDK-8076468: Add @modules to jtreg jdk_desktop tests to take into account the new modular architecture

2015-06-02 Thread Alexander Kulyakhtin
Hi, Could you, please, review the following tests-only changes to the test files from the jdk9/client repository http://cr.openjdk.java.net/~akulyakh/8076468/webrev.02/index.html The changes add @modules to the tests to make it possible to run the tests with jake. Best regards, Alexander