Re: RFR: JDK-8076468 Add @modules to tests in jdk_desktop test group

2015-06-22 Thread Alan Bateman
On 22/06/2015 16:44, Alexander Kulyakhtin wrote: Hi, Could you, please, review the test-only changes for the JDK-8076468 CR: JDK-8076468 "Add @modules to the tests in jdk_desktop test group" Webrev: http://cr.openjdk.java.net/~akulyakh/8076468/webrev.05/ @modules keywords have been added to th

Re: [OpenJDK 2D-Dev] RFR: JDK-8076468 Add @modules to tests in jdk_desktop test group

2015-06-22 Thread Phil Race
I guess I was expecting to see only tests that use internal API updated but we do have some that do not being updated. grep "@modules" jdk.patch | grep -v sun | more | wc 119 4553341 + * @modules java.datatransfer + * @modules java.compiler + * @modules java.desktop And this simple

Re: RFR: JDK-8076468 Add @modules to tests in jdk_desktop test group

2015-06-22 Thread Yuri Nesterenko
Hi Alexander, the fix looks OK to me. Thanks, -yan On 06/22/2015 06:44 PM, Alexander Kulyakhtin wrote: Hi, Could you, please, review the test-only changes for the JDK-8076468 CR: JDK-8076468 "Add @modules to the tests in jdk_desktop test group" Webrev: http://cr.openjdk.java.net/~akulyakh/80

RFR: JDK-8076468 Add @modules to tests in jdk_desktop test group

2015-06-22 Thread Alexander Kulyakhtin
Hi, Could you, please, review the test-only changes for the JDK-8076468 CR: JDK-8076468 "Add @modules to the tests in jdk_desktop test group" Webrev: http://cr.openjdk.java.net/~akulyakh/8076468/webrev.05/ @modules keywords have been added to the jtreg tests so that the tests can be selected as