Re: [9] Review Request for 8081722: Provide public API for file hierarchy provided by sun.awt.shell.ShellFolder

2016-02-15 Thread Semyon Sadetsky
Please look at the updated webrev: http://cr.openjdk.java.net/~ssadetsky/8081722/webrev.05/ Changes was made According to off-line discussion wit Sergey: - IAE -> NPE for file == null - FNFE is corrected for getLinkLocation() --Semyon On 1/22/2016 9:34 AM, Semyon Sadetsky wrote: On

Re: [9] Review fix for JDK-8020039 : SynthTableHeaderUI refers to possibly null parameter in cell renderer

2016-02-15 Thread Rajeev Chamyal
Hello Ajit, Can you please if similar fix is required for other LAF windows ,Aqua etc. Please add a regression test case also. Regards, Rajeev Chamyal From: Ajit Ghaisas Sent: 15 February 2016 17:30 To: Rajeev Chamyal; Sergey Bylokhov; Alexander Scherbatiy;

[9] Review fix for JDK-8020039 : SynthTableHeaderUI refers to possibly null parameter in cell renderer

2016-02-15 Thread Ajit Ghaisas
Hi, Please review the fix for jdk9, Bug: https://bugs.openjdk.java.net/browse/JDK-8020039 Webrev: http://cr.openjdk.java.net/~arapte/ajit/8020039/webrev.00/ Issue : If null is passed as 'table' parameter to SynthTableHeaderUI::getTableCellRendererComponent()

Re: Review Request for 7126823 : JInternalFrame.getNormalBounds() returns bad value after iconify/deiconify

2016-02-15 Thread Rajeev Chamyal
Looks good to me. Regards, Rajeev Chamyal From: Prem Balakrishnan Sent: 15 February 2016 14:22 To: Rajeev Chamyal; Alexander Scherbatiy Cc: Sergey Bylokhov; Semyon Sadetsky; Ambarish Rapte; swing-dev@openjdk.java.net Subject: RE: Review Request for 7126823 :

Re: Review Request for 7126823 : JInternalFrame.getNormalBounds() returns bad value after iconify/deiconify

2016-02-15 Thread Prem Balakrishnan
Hi Rajeev, Test updated as per your comments. Webrev: http://cr.openjdk.java.net/~arapte/prem/7126823/webrev.02/ Regards, Prem From: Rajeev Chamyal Sent: Monday, February 15, 2016 12:00 PM To: Prem Balakrishnan Cc: Sergey Bylokhov; Semyon Sadetsky; Alexander Scherbatiy; Ambarish