Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

2016-03-23 Thread Avik Niyogi
Hi All, Please review my code changes below as per the inputs received. http://cr.openjdk.java.net/~aniyogi/8137169/webrev.02/ As SCROLL_TAB_LAYOUT is the default layout for Aqua LAF, with implementation within the derived AquaTruncatedT

Re: [9] Review request for 8132119 Provide public API for text related methods in SwingUtilities2

2016-03-23 Thread Semyon Sadetsky
Hi Alexander, Could you answer one question: Why did you choose default interface methods to implement TextUIDrawing and not implement them in DefaultTextUIDrawing having declarations only in the interface? AFAIK the common point of view is default methods should be used rarely because they ma

Re: Review Request for 6439354 : Win L&F: TitledBorder colors are not from desktop

2016-03-23 Thread Semyon Sadetsky
Looks good. --Semyon On 3/22/2016 11:56 AM, Prem Balakrishnan wrote: Hi Sergey, Updated test as per the review comments. Webrev: http://cr.openjdk.java.net/~arapte/prem/6439354/webrev.01/ Regards, Prem -Original Message- From: Sergey Bylokhov Sent: Monday, March 21, 2016 7:31 PM To

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

2016-03-23 Thread Alexander Scherbatiy
On 23/03/16 14:07, Avik Niyogi wrote: On 23-Mar-2016, at 3:31 pm, Alexander Scherbatiy > wrote: On 21/03/16 09:19, Avik Niyogi wrote: Hi Alexander, I agree with what you said regarding the look and feel looking different. But this bug arrises due to se

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

2016-03-23 Thread Avik Niyogi
> On 23-Mar-2016, at 3:31 pm, Alexander Scherbatiy > wrote: > > On 21/03/16 09:19, Avik Niyogi wrote: >> Hi Alexander, >> I agree with what you said regarding the look and feel looking different. >> But this bug arrises due to setting of TabbedPaneScrollLayout only. If >> Scroll Layout is not

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

2016-03-23 Thread Alexander Scherbatiy
On 21/03/16 09:19, Avik Niyogi wrote: Hi Alexander, I agree with what you said regarding the look and feel looking different. But this bug arrises due to setting of TabbedPaneScrollLayout only. If Scroll Layout is not meant for Aqua look and feel should not the setting of this parameter instea

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

2016-03-23 Thread Avik Niyogi
Hi Alexander, With inputs (code) provided, it is not possible to accommodate the right methods for tabPlacement parameter. Also, since AquaTabbedPane is copied from BasicUI.java, this implementation if moved to TabbedPaneLayout, does not accommodate Awua related changes and hence, the redundant

Re: [9] Review request for JDK-8150225 api/javax_swing/text/AbstractWriter/index_indent failed

2016-03-23 Thread Rajeev Chamyal
Hello Sergey, I had found below link about pre tag which states A P tag is strictly not permitted inside PRE, but if a browser encounters one, it should treat it as two newlines. http://www.htmlhelp.com/reference/wilbur/block/pre.html Regards, Rajeev Chamyal -Original Message- From: S