Re: RfR JDK-8153149, Uninitialised memory in WinAccessBridge.cpp:1128

2016-04-01 Thread Phil Race
You say its a simple fix but I need you to confirm if i have it right What I see is that pkg is a pointer to part of "buffer" but the contents of that buffer are not initialised so the field rVMID is garbage. So you should not use it. So far so good. But then a reader must ask himself 1) where d

RFR: 8147544: Remove sun.misc.ManagedLocalsThread from java.desktop

2016-04-01 Thread Phil Race
Bug: https://bugs.openjdk.java.net/browse/JDK-8147544 Fix: http://cr.openjdk.java.net/~prr/8147544/ ManagedLocalThreads is now superseded by a standard constructor on java.lang.Thread :- http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/f90cd2c011bc The various places in JDK that use the internal API

RfR: JDK-8153153, Format string argument mismatch in jaccesswalker.cpp:545

2016-04-01 Thread Pete Brunet
Please review this simple fix: https://bugs.openjdk.java.net/browse/JDK-8153153 http://cr.openjdk.java.net/~ptbrunet/JDK-8153153/webrev.00/

RfR JDK-8153149, Uninitialised memory in WinAccessBridge.cpp:1128

2016-04-01 Thread Pete Brunet
Please review this simple fix: https://bugs.openjdk.java.net/browse/JDK-8153149 http://cr.openjdk.java.net/~ptbrunet/JDK-8153149/webrev.00/

Re: [9] Review request for 8136366 Add a public API to create a L&F without installation

2016-04-01 Thread Alexander Scherbatiy
Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8136366/webrev.01 The UnsupportedLookAndFeelException is thrown from the UIManager.createLookAndFeel(className) method for unsupported L&Fs. Thanks, Alexandr. On 01/04/16 18:14, Sergey Bylokhov wrote:

Re: [9] Review request for 8136366 Add a public API to create a L&F without installation

2016-04-01 Thread Sergey Bylokhov
On 01.04.16 16:02, Alexander Scherbatiy wrote: I see the point that creating non installed system L&F may not have many sense. I guess we should thinking about supported/unsupported instead of installed/non-installed. One more use case that should be considered is using the createL

Re: [9] Review request for 8136366 Add a public API to create a L&F without installation

2016-04-01 Thread Alexander Scherbatiy
On 01/04/16 16:12, Mario Torre wrote: On Fri, Apr 1, 2016 at 1:49 PM, Alexander Scherbatiy wrote: May be someone wants to get fonts or colors from Windows L&F on Linux for its own custom L&F? It would be useful to allow it. I don't think this would make any sense, the colours would still depen

Re: [9] Review request for 8136366 Add a public API to create a L&F without installation

2016-04-01 Thread Mario Torre
On Fri, Apr 1, 2016 at 1:49 PM, Alexander Scherbatiy wrote: > May be someone wants to get > fonts or colors from Windows L&F on Linux for its own custom L&F? It would > be useful to allow it. I don't think this would make any sense, the colours would still depend on a specific version of the OS,

Re: [9] Review request for 8136366 Add a public API to create a L&F without installation

2016-04-01 Thread Alexander Scherbatiy
On 01/04/16 04:32, Philip Race wrote: > I recall that it was possible to initialize the windows l&f on linux Do you mean it was "impossible" ? There was a test that directly overrode isSupportedLookAndFeel() method to true for Windows L&F and set it on all platforms including Linux. We had

Re: Review Request JDK-6897701 : In Nimbus Disabled Menus and Menu Items don't look disabled

2016-04-01 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 01/04/16 14:18, Semyon Sadetsky wrote: Looks good. --Semyon On 4/1/2016 11:18 AM, Prem Balakrishnan wrote: Hi Alexander, Please review the updated patch as per review comments. http://cr.openjdk.java.net/~arajkumar/prem/6897701/webrev.02/ R

Re: Review Request JDK-6897701 : In Nimbus Disabled Menus and Menu Items don't look disabled

2016-04-01 Thread Semyon Sadetsky
Looks good. --Semyon On 4/1/2016 11:18 AM, Prem Balakrishnan wrote: Hi Alexander, Please review the updated patch as per review comments. http://cr.openjdk.java.net/~arajkumar/prem/6897701/webrev.02/ Regards, Prem *From:*A

Re: Review Request JDK-6897701 : In Nimbus Disabled Menus and Menu Items don't look disabled

2016-04-01 Thread Prem Balakrishnan
Hi Alexander, Please review the updated patch as per review comments. http://cr.openjdk.java.net/~arajkumar/prem/6897701/webrev.02/ Regards, Prem From: Alexander Scherbatiy Sent: Thursday, March 31, 2016 10:45 PM To: Prem Balakrishnan; Semyon Sadetsky; Sergey Bylokhov; Rajeev Chamyal; s