There is the same code which is repeated in three methods. Is it
possible to add a private method which takes button, button mask, and
event as parameters and returns true if the mouse event specifies the
given button? It would be possible to reuse it in public methods.
Thanks,
Alexandr.
Hello,
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8132791/webrev.01/
- reset() method is removed form the SynthContext class
- unused checks to null are removed from
On 13/04/16 02:40, Sergey Bylokhov wrote:
Hi, Alexander.
Can you please run the same
Perhaps better but given the minimal use here can't we just
replace it with
System.getProperty("os.name").toLowerCase().contains("windows") ?
Then you neither need jtreg to run it, nor internal API.
-phil.
On 4/13/16, 11:44 AM, Sergey Bylokhov wrote:
+1
On 13.04.16 17:17, Yuri Nesterenko
+1
On 13.04.16 17:17, Yuri Nesterenko wrote:
Looks good to me.
-yan
On 04/13/2016 05:07 PM, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8153276
webrev: http://cr.openjdk.java.net/~ssadetsky/8153276/webrev.00/
Internal API usage
You need to add
@run main for latest jtreg to run. Have you run against latest jtreg?
Regards
Prasanta
On 4/13/2016 6:10 PM, Muneer Kolarkunnu wrote:
Hi All,
Please review the fix for test bug 8025430,
Webrev:
Looks good to me.
-yan
On 04/13/2016 05:07 PM, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8153276
webrev: http://cr.openjdk.java.net/~ssadetsky/8153276/webrev.00/
Internal API usage sun.awt.OSInfo was replaced by
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8153276
webrev: http://cr.openjdk.java.net/~ssadetsky/8153276/webrev.00/
Internal API usage sun.awt.OSInfo was replaced by jdk.testlibrary.OSInfo.
--Semyon
Hi,
Thanks for the review.
Your questioning lead me to think about correcting the SwingUtilities
isXXXMouseButton() methods.
It is possible to identify under which mouse state these methods are
invoked using the MouseEvent parameter.
Please review the updated webrev.
Hi All,
Please review the fix for test bug 8025430,
Webrev:
http://cr.openjdk.java.net/~ntv/muneer/8025430/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8025430
Issue:
It is a test bug, API checkSystemClipboardAccess() is