Re: [9] JDK-8049069 : JButton incorrect behaviour on button release

2016-04-13 Thread Alexander Scherbatiy
There is the same code which is repeated in three methods. Is it possible to add a private method which takes button, button mask, and event as parameters and returns true if the mouse event specifies the given button? It would be possible to reuse it in public methods. Thanks, Alexandr.

Re: [9] Review request for 8132791 No access to SynthContext.getContext()

2016-04-13 Thread Alexander Scherbatiy
Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8132791/webrev.01/ - reset() method is removed form the SynthContext class - unused checks to null are removed from On 13/04/16 02:40, Sergey Bylokhov wrote: Hi, Alexander. Can you please run the same

Re: [9] Review request for 8153276: [TEST_BUG] javax/swing/JFileChooser/ShellFolderQueries/ShellFolderQueriesTest.java

2016-04-13 Thread Philip Race
Perhaps better but given the minimal use here can't we just replace it with System.getProperty("os.name").toLowerCase().contains("windows") ? Then you neither need jtreg to run it, nor internal API. -phil. On 4/13/16, 11:44 AM, Sergey Bylokhov wrote: +1 On 13.04.16 17:17, Yuri Nesterenko

Re: [9] Review request for 8153276: [TEST_BUG] javax/swing/JFileChooser/ShellFolderQueries/ShellFolderQueriesTest.java

2016-04-13 Thread Sergey Bylokhov
+1 On 13.04.16 17:17, Yuri Nesterenko wrote: Looks good to me. -yan On 04/13/2016 05:07 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8153276 webrev: http://cr.openjdk.java.net/~ssadetsky/8153276/webrev.00/ Internal API usage

Re: Review request for 8025430: [TEST_BUG] javax/swing/JEditorPane/5076514/bug5076514.java failed since jdk8b108

2016-04-13 Thread prasanta sadhukhan
You need to add @run main for latest jtreg to run. Have you run against latest jtreg? Regards Prasanta On 4/13/2016 6:10 PM, Muneer Kolarkunnu wrote: Hi All, Please review the fix for test bug 8025430, Webrev:

Re: [9] Review request for 8153276: [TEST_BUG] javax/swing/JFileChooser/ShellFolderQueries/ShellFolderQueriesTest.java

2016-04-13 Thread Yuri Nesterenko
Looks good to me. -yan On 04/13/2016 05:07 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8153276 webrev: http://cr.openjdk.java.net/~ssadetsky/8153276/webrev.00/ Internal API usage sun.awt.OSInfo was replaced by

[9] Review request for 8153276: [TEST_BUG] javax/swing/JFileChooser/ShellFolderQueries/ShellFolderQueriesTest.java

2016-04-13 Thread Semyon Sadetsky
Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8153276 webrev: http://cr.openjdk.java.net/~ssadetsky/8153276/webrev.00/ Internal API usage sun.awt.OSInfo was replaced by jdk.testlibrary.OSInfo. --Semyon

Re: [9] JDK-8049069 : JButton incorrect behaviour on button release

2016-04-13 Thread Ajit Ghaisas
Hi, Thanks for the review. Your questioning lead me to think about correcting the SwingUtilities isXXXMouseButton() methods. It is possible to identify under which mouse state these methods are invoked using the MouseEvent parameter. Please review the updated webrev.

Review request for 8025430: [TEST_BUG] javax/swing/JEditorPane/5076514/bug5076514.java failed since jdk8b108

2016-04-13 Thread Muneer Kolarkunnu
Hi All, Please review the fix for test bug 8025430, Webrev: http://cr.openjdk.java.net/~ntv/muneer/8025430/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8025430 Issue: It is a test bug, API checkSystemClipboardAccess() is