+1
On 14.04.16 11:53, Alexander Scherbatiy wrote:
The fix looks good to me.
Thanks,
Alexandr.
On 14/04/16 10:44, Ajit Ghaisas wrote:
Thanks Alex for the good suggestion to have a private method to avoid
code repetition.
I have modified the code accordingly. Please review the updated
On 14.04.16 19:04, Phil Race wrote:
In particular
1) Is the java.sun.com -> oracle.com redirect considered to be something
we can rely on for ever ? Given the number of references to the former
it may need to be.
2) But on the other hand, is there a policy of updating the links as
time permits
Hello,
Please review the fix for jdk9.
The bunch of links in client code were updated to point to the new
location on oracle.com site.
During the fix I realized that not all of data stored on java.sun.com
were moved to the oracle.com. For example:
The article "Using Timers in Swing
On 14.04.16 14:17, Alexander Scherbatiy wrote:
The tests with -Xmx5m options have the similar results too:
http://cr.openjdk.java.net/~alexsch/8132791/profiling/results-xmx5m_3-5/
Thanks, looks fine.
On 12.04.16 22:02, Alexander Scherbatiy wrote:
Hello,
Could you review the fix:
The fix looks good to me.
Thanks,
Alexandr.
On 14/04/16 11:41, Yuri Nesterenko wrote:
Ok, +1, simplest working device is better, definitely in the tests.
-yan
On 04/14/2016 10:05 AM, Semyon Sadetsky wrote:
On 4/13/2016 9:57 PM, Philip Race wrote:
Perhaps better but given the minimal use
Looks good.
--Semyon
On 4/13/2016 10:14 PM, Alexander Scherbatiy wrote:
Hello,
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8132791/webrev.01/
- reset() method is removed form the SynthContext class
- unused checks to null are removed from
On 13/04/16
On 13/04/16 23:44, Sergey Bylokhov wrote:
On 13.04.16 22:14, Alexander Scherbatiy wrote:
The tests immediately fail with OOME using -Xmx2m option, fail on the
same steps with 3 and 4 mb and pass with 5 mb.
And there is no difference in SwingMark results before and after the fix?
The
I added the @run tag and updated the review:
http://cr.openjdk.java.net/~ntv/muneer/8025430/webrev.01/
I tested with latest jtreg with and without @run tag, both are working.
But there is a difference in the logs in the following line:
Without @run flag:
command: main bug5076514
Ok, +1, simplest working device is better, definitely in the tests.
-yan
On 04/14/2016 10:05 AM, Semyon Sadetsky wrote:
On 4/13/2016 9:57 PM, Philip Race wrote:
Perhaps better but given the minimal use here can't we just
replace it with
On 4/13/2016 9:57 PM, Philip Race wrote:
Perhaps better but given the minimal use here can't we just
replace it with
System.getProperty("os.name").toLowerCase().contains("windows") ?
Then you neither need jtreg to run it, nor internal API.
I agree. See the updated webrev:
Thanks Alex for the good suggestion to have a private method to avoid code
repetition.
I have modified the code accordingly. Please review the updated webrev.
http://cr.openjdk.java.net/~aghaisas/8049069/webrev.02/
Regards,
Ajit
-Original Message-
From: Alexander Scherbatiy
Sent:
11 matches
Mail list logo
