Re: RfR JDK-8076554, [macosx] Custom Swing text components need to allow standard accessibility

2016-04-20 Thread Pete Brunet
Hi Sergey, I already pushed the fix but ... On 4/20/16 10:20 AM, Sergey Bylokhov wrote: > Hi, Pete. > Just a small notes: > - It seems that AXTextChangeNotifier() should be created only if "c > is Accessible". That's true. I added a comment to 8154507/8 and will fix that with one of those patche

Re: RfR JDK-8076554, [macosx] Custom Swing text components need to allow standard accessibility

2016-04-20 Thread Sergey Bylokhov
Hi, Pete. Just a small notes: - It seems that AXTextChangeNotifier() should be created only if "c is Accessible". - I am not sure, but when we clear these listeners(which were added to AccessibilityEventMonitor), or it is not necessary? - Is it possible that "AccessibleContext.ACCESSIBLE_TEXT

Re: RfR JDK-8076554, [macosx] Custom Swing text components need to allow standard accessibility

2016-04-20 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 20/04/16 01:52, Pete Brunet wrote: p.s. JPRT ran OK. Still need one more +1. On 4/19/16 2:16 PM, Phil Race wrote: +1 -phil. On 04/19/2016 12:05 PM, Pete Brunet wrote: New patch: http://cr.openjdk.java.net/~ptbrunet/JDK-8076554/webrev.03/ Ch

Re: [9] Review request for 8154431: Allow source and target based validation for the focus transfer between two JComponents.

2016-04-20 Thread Semyon Sadetsky
On 4/19/2016 10:41 PM, Phil Race wrote: On 04/19/2016 11:05 AM, Semyon Sadetsky wrote: On 4/19/2016 7:47 PM, Phil Race wrote: Hi, You are deprecating shouldYieldFocus(JComponent) and yet this class directly uses it. Is this deprecation really the right thing to do ? Why is this not correct?

Re: [9] Review request for 8154431: Allow source and target based validation for the focus transfer between two JComponents.

2016-04-20 Thread Phil Race
On 04/19/2016 11:05 AM, Semyon Sadetsky wrote: On 4/19/2016 7:47 PM, Phil Race wrote: Hi, You are deprecating shouldYieldFocus(JComponent) and yet this class directly uses it. Is this deprecation really the right thing to do ? Why is this not correct? There are plenty examples in JDK: Compon